aboutsummaryrefslogtreecommitdiffstats
path: root/ms/neng
AgeCommit message (Collapse)AuthorFilesLines
2019-01-04Add Sonar Kotlin supportAlexis de Talhouët1-0/+1
Rework parent pom so configuration can be inherited for all modules from root ccsdk-apps/pom.xml. Also updated some pom description so it is better presented within Sonar. These commands can be used locally to publish report to Sonar: mvn clean install -e -Dsonar mvn sonar:sonar -e -Dsonar -Dsonar.host.url=https://sonar.onap.org Note: kotlin code coverage is not fully functional due to https://github.com/jacoco/jacoco/issues/763 That issue has been fixed in jacoco master branch, but hasn't been released. Once released, in version 0.8.3, we can override version of jacoco plugin for ccsdk-apps. Change-Id: Ic382a4d0df9d14a82536993d2dfa55d7f105f951 Issue-ID: CCSDK-725 Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
2018-12-26Fixed sonar issue in ExternalKeyValidatorezhil1-1/+3
Fixed major sonar issue Issue-ID: CCSDK-690 Change-Id: I17abdb751f1a384bd0c63e5b336186eaad945783 Signed-off-by: ezhil <ezhrajam@in.ibm.com>
2018-12-17Merge "Fixed sonar issue i PolicyFinderServiceImpl.java"Dan Timoney1-3/+3
2018-12-17Merge "Fixed sonar issue in NameGenResponse.java"Dan Timoney1-1/+1
2018-12-17Merge "Fixed sonar issues in NamegenRequest.java"Dan Timoney1-2/+3
2018-12-17Merge "Fixed sonar issues in PropertyOperator.java"Dan Timoney1-1/+4
2018-12-13Fixed sonar issue i PolicyFinderServiceImpl.javaezhil1-3/+3
Fixed major sonar issues Issue-ID: CCSDK-819 Change-Id: I2347aa5f234b33231b7782e6a51d0ba5a1b60dfd Signed-off-by: ezhil <ezhrajam@in.ibm.com>
2018-12-12Fixed sonar issue in NameGenResponse.javaezhil1-1/+1
Fixed sonar issue Issue-ID: CCSDK-826 Change-Id: If105b57d779f2ce25212c9a872aa1b379082b14a Signed-off-by: ezhil <ezhrajam@in.ibm.com>
2018-12-12Fixed sonar issues in NamegenRequest.javaezhil1-2/+3
Fixed sonar issues Issue-ID: CCSDK-825 Change-Id: If085726631b98d5c070feae39e1a7ba8f65067e9 Signed-off-by: ezhil <ezhrajam@in.ibm.com>
2018-12-12Fixed sonar issues in PropertyOperator.javaezhil1-1/+4
Logged exception Issue-ID: CCSDK-817 Change-Id: I902428f3a7fcf043c29db630783ab9c08d9cc6f2 Signed-off-by: ezhil <ezhrajam@in.ibm.com>
2018-12-12Fixed sonar issues in SpringServiceImpl.javaezhil1-2/+3
Logged exceptions Issue-ID: CCSDK-818 Change-Id: I90fc2d9c8d7e2627fc2c1f80628a9f4a0e7531da Signed-off-by: ezhil <ezhrajam@in.ibm.com>
2018-12-11Merge "fixed sonar issues in PropertyOperator.java"Dan Timoney1-1/+0
2018-12-11Merge "fixed sonar issues in RestServiceImpl.java"Dan Timoney1-4/+6
2018-12-11Merge "Fixed major sonar issue in Application.java"Dan Timoney1-1/+1
2018-12-11Merge "Fixed sonar issue in PolicySequence"Dan Timoney1-5/+11
2018-12-11fixed sonar issues in PropertyOperator.javaSandeep J1-1/+0
fixed sonar issues Issue-ID: CCSDK-552 Change-Id: I1104b8e2b7caf511b0b50bc28093ff8c38e35c29 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-12-11fixed sonar issues in RestServiceImpl.javaSandeep J1-4/+6
fixed sonar issues Issue-ID: CCSDK-552 Change-Id: I675eaf2314981d1d93b539b07df1568dcf51efcd Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-12-04Fixed major sonar issue in Application.javaezhil1-1/+1
Removed Sysout from Application Issue-ID: CCSDK-786 Change-Id: I9806e98d4a30145f33da757b109cb781f3f1dccd Signed-off-by: ezhil <ezhrajam@in.ibm.com>
2018-12-04Fixed sonar issue in PolicySequenceezhil1-5/+11
Fixed sonar issues in PolicySequence Issue-ID: CCSDK-768 Change-Id: Ifc4558d2c970d80d157c825891948fbc57a7bde1 Signed-off-by: ezhil <ezhrajam@in.ibm.com>
2018-12-04Sonar Fix: NamePersister.javaArundathi Patil1-1/+1
Fixed sonar issues/code smells across this file Issue-ID: CCSDK-785 Change-Id: Ibfe8a9d8024e60385163df1402ca6a902836aae0 Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
2018-12-03Merge "fixed sonar issue in PolicyFinderServiceImpl.java"Dan Timoney1-1/+3
2018-12-03Merge "fixed sonar issues in RestServiceImpl.java"Dan Timoney1-6/+8
2018-12-03Merge "fixed sonar issues in SpringServiceImpl.java"Dan Timoney1-1/+2
2018-12-03fixed sonar issue in PolicyFinderServiceImpl.javaSandeep J1-1/+3
fixed sonar issue Issue-ID: CCSDK-525 Change-Id: I2074cff32ab26db5ba94bea9d08f0d60bdd9b189 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-12-03fixed sonar issues in RestServiceImpl.javaSandeep J1-6/+8
fixed sonar issues Issue-ID: CCSDK-525 Change-Id: I2f37d883df71b48daa0f0daf8b57d3c609889a52 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-12-03fixed sonar issues in SpringServiceImpl.javaSandeep J1-1/+2
fixed sonar issues Issue-ID: CCSDK-525 Change-Id: Id14d83d0b8c38feec837f3135dfd61458f10e77d Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-12-03fixed sonar issues in PolicyReader.javaSandeep J1-6/+5
fixed sonar issues Issue-ID: CCSDK-525 Change-Id: Ieeb51a0c2671c07687ddc189564aa5b44237ec38 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-11-30Merge "Fixed sonar issues in ApplicationConfig"Dan Timoney1-2/+9
2018-11-28Merge "Fix a typo in property name"Dan Timoney1-1/+1
2018-11-28Merge "Fixed Sonar issue in Application.java"Dan Timoney1-4/+5
2018-11-28Merge "Fixed sonar issues in GetConfigResponse"Dan Timoney1-1/+1
2018-11-28Fix a typo in property nameAlexis de Talhouët1-1/+1
Change-Id: I573a7706212dd411a284ec7b57c9373d7d6ff376 Issue-ID: CCSDK-650 Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
2018-11-27Fixed Sonar issue in Application.javaezhil1-4/+5
Renamed the log variable Issue-ID: CCSDK-756 Change-Id: Ibb71e2cc363619bdf2593f67fabada2e55ff8287 Signed-off-by: ezhil <ezhrajam@in.ibm.com>
2018-11-21Fixed sonar issues in GetConfigResponseezhil1-1/+1
Made variable as private Issue-ID: CCSDK-739 Change-Id: Ieb17ea85f91f6f6ba8f3596b55362a403d573b6a Signed-off-by: ezhil <ezhrajam@in.ibm.com>
2018-11-21Fixed sonar issue in GetConfigRequestezhil1-4/+4
Changed variables private to the class Issue-ID: CCSDK-738 Change-Id: Iff3d084b4f26579021412a27372892e0a2dd427b Signed-off-by: ezhil <ezhrajam@in.ibm.com>
2018-11-20Fixed sonar issues in ApplicationConfigezhil1-2/+9
Replace logger for Sysout Issue-ID: CCSDK-731 Change-Id: Iaa6b7c93332a051134b4507d5b814ed20085980a Signed-off-by: ezhil <ezhrajam@in.ibm.com>
2018-11-19Merge "Fixed sonar issue in NameGenResponse"Dan Timoney1-1/+3
2018-11-19Merge "Fixed Sonar issue in RecipeParser"Dan Timoney1-0/+3
2018-11-19Merge "added test file to test ExternalkeyValidator.java"Dan Timoney1-0/+44
2018-11-19Merge "Sonar fix: Application.java"Dan Timoney1-4/+10
2018-11-19Fixed sonar issue in NameGenResponseezhil1-1/+3
Made variable private for the class Issue-ID: CCSDK-732 Change-Id: Idc7e8cceab09a8f01516a0b5d0953a7f113a3145 Signed-off-by: ezhil <ezhrajam@in.ibm.com>
2018-11-19Fixed Sonar issue in RecipeParserezhil1-0/+3
Declared private constructor Issue-ID: CCSDK-689 Change-Id: Ib4f491b4579c8eb0091af0144d250c397fb44b3f Signed-off-by: ezhil <ezhrajam@in.ibm.com>
2018-11-16added test file to test ExternalkeyValidator.javaSandeep J1-0/+44
to increase code coverage Issue-ID: CCSDK-552 Change-Id: Ib3afe9e2fe682d86cafe050e36dfbb5fa4292fc5 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-11-16Sonar fix: Application.javaArundathi Patil1-4/+10
Fixed sonar issues across this file Issue-ID: CCSDK-726 Change-Id: I416500a26f258cba87576a80c9da371a8a8f1a88 Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
2018-11-16added test case to AaiServiceImplTestSandeep J2-2/+18
to increase code coverage Issue-ID: CCSDK-552 Change-Id: Ib89f25c39bf0878170da6997ca74c587c4c72535 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-11-15Merge "Fixed sonar issue in ExternalKeyValidator"Dan Timoney1-1/+1
2018-11-15Merge "Fixed major sonar issue in PolicySequence"Dan Timoney1-4/+4
2018-11-15Merge "Sonar fixes in PolicyReader.Java"Dan Timoney1-8/+13
2018-11-15Fixed sonar issue in ExternalKeyValidatorezhil1-1/+1
Included empty method to check colletion Issue-ID: CCSDK-690 Change-Id: Ibf393c07f6d57f5871ad8c094c0d4ae1501da856 Signed-off-by: ezhil <ezhrajam@in.ibm.com>
2018-11-15Fixed major sonar issue in PolicySequenceezhil1-4/+4
Fixed variable hide issue Issue-ID: CCSDK-687 Change-Id: I20fbfdd30f76bc55463c9b49fe3ac05dfe8c9f50 Signed-off-by: ezhil <ezhrajam@in.ibm.com>