aboutsummaryrefslogtreecommitdiffstats
path: root/ms/neng
diff options
context:
space:
mode:
authorezhil <ezhrajam@in.ibm.com>2018-11-15 13:47:17 +0530
committerezhil <ezhrajam@in.ibm.com>2018-11-15 13:49:08 +0530
commit3e82776f38b8254de5b8b342ec04fb02c9052556 (patch)
treee910574748b10963d5cc904beab8fb877a14ed62 /ms/neng
parent452a3c355a74436457bd526e08c08583e64a7ae0 (diff)
Sonar fixes in PolicyReader.Java
Replaced duplicate literals with constants Issue-ID: CCSDK-686 Change-Id: I389b4785a16dac8e7e20e7ccaeb05ab3de0256d8 Signed-off-by: ezhil <ezhrajam@in.ibm.com>
Diffstat (limited to 'ms/neng')
-rw-r--r--ms/neng/src/main/java/org/onap/ccsdk/apps/ms/neng/core/policy/PolicyReader.java21
1 files changed, 13 insertions, 8 deletions
diff --git a/ms/neng/src/main/java/org/onap/ccsdk/apps/ms/neng/core/policy/PolicyReader.java b/ms/neng/src/main/java/org/onap/ccsdk/apps/ms/neng/core/policy/PolicyReader.java
index 73f46c95..09a6e49b 100644
--- a/ms/neng/src/main/java/org/onap/ccsdk/apps/ms/neng/core/policy/PolicyReader.java
+++ b/ms/neng/src/main/java/org/onap/ccsdk/apps/ms/neng/core/policy/PolicyReader.java
@@ -37,19 +37,23 @@ public abstract class PolicyReader implements PolicyFinder {
* @param policy the policy
* @return the list of naming-models found in the policy
*/
+ private static final String NAMING_MODELS = "naming-models";
+ private static final String NAMING_TYPE = "naming-type";
+
public static List<Map<String, ?>> namingModels(Map<String, ?> policy) {
+
Set<String> keys = policy.keySet();
// TODO : retrieve naming-models at any level
if (keys.contains("config")) {
@SuppressWarnings("unchecked")
Map<String, ?> config = (Map<String, ?>) policy.get("config");
- List<Map<String, ?>> namingModels = list(map(config, "content"), "naming-models");
+ List<Map<String, ?>> namingModels = list(map(config, "content"), NAMING_MODELS);
if (namingModels == null) {
- namingModels = list(config, "naming-models");
+ namingModels = list(config, NAMING_MODELS);
}
return namingModels;
} else {
- return list(map(map(policy, "input"), "naming-model"), "naming-models");
+ return list(map(map(policy, "input"), "naming-model"), NAMING_MODELS);
}
}
@@ -65,7 +69,7 @@ public abstract class PolicyReader implements PolicyFinder {
Map<String, ?> theModel = null;
if (namingModels != null) {
for (Map<String, ?> model : namingModels) {
- Object val = model.get("naming-type");
+ Object val = model.get(NAMING_TYPE);
if (namingType.equals(val)) {
theModel = model;
break;
@@ -120,8 +124,9 @@ public abstract class PolicyReader implements PolicyFinder {
* Finds the naming-operation from the given naming-model.
*/
public static String namingOperation(Map<String, ?> namimgModel) {
- String propValue = value(namimgModel, "name-operation");
- return propValue;
+ //String propValue = value(namimgModel, "name-operation");
+ //return propValue;
+ return value(namimgModel, "name-operation");
}
/**
@@ -294,8 +299,8 @@ public abstract class PolicyReader implements PolicyFinder {
Map<String, Object> getPolicy(String jsonString) throws Exception {
ObjectMapper mapper = new ObjectMapper();
- Map<String, Object> jsonObject = mapper.readValue(jsonString, new TypeReference<Map<String, Object>>() {});
- return jsonObject;
+ // Map<String, Object> jsonObject = mapper.readValue(jsonString, new TypeReference<Map<String, Object>>() {});
+ return mapper.readValue(jsonString, new TypeReference<Map<String, Object>>() {});
}
static List<Map<String, ?>> list(Map<String, ?> policy, String name) {