Controller Blueprints Microservice

Improve code quality for Performance, JavaDoc, Imports, Probably Bug etc

Change-Id: Ib71b62f14e8e8bd212e671a135025258fd9927b4
Issue-ID: CCSDK-491
Signed-off-by: Muthuramalingam, Brinda Santh(bs2796) <bs2796@att.com>

2 files changed, 2 insertions, 4 deletions

diff --git a/ms/controllerblueprints/modules/service/src/test/java/org/onap/ccsdk/apps/controllerblueprints/service/rs/ModelTypeRestTest.java b/ms/controllerblueprints/modules/service/src/test/java/org/onap/ccsdk/apps/controllerblueprints/service/rs/ModelTypeRestTest.java
index d328b3ea..08bfeb10 100644
--- a/ms/controllerblueprints/modules/service/src/test/java/org/onap/ccsdk/apps/controllerblueprints/service/rs/ModelTypeRestTest.java
+++ b/ms/controllerblueprints/modules/service/src/test/java/org/onap/ccsdk/apps/controllerblueprints/service/rs/ModelTypeRestTest.java
@@ -95,7 +95,7 @@ public class ModelTypeRestTest {
 

         List<ModelType> dbModelTypes = modelTypeRest.searchModelTypes(tags);

         Assert.assertNotNull("Failed to search ResourceMapping by tags", dbModelTypes);

-        Assert.assertEquals("Failed to search ResourceMapping by tags count", true, dbModelTypes.size() > 0);

+        Assert.assertTrue("Failed to search ResourceMapping by tags count", dbModelTypes.size() > 0);

 

     }

 

@@ -109,8 +109,7 @@ public class ModelTypeRestTest {
         List<ModelType> dbDatatypeModelTypes =

                 modelTypeRest.getModelTypeByDefinitionType(BluePrintConstants.MODEL_DEFINITION_TYPE_DATA_TYPE);

         Assert.assertNotNull("Failed to find getModelTypeByDefinitionType by tags", dbDatatypeModelTypes);

-        Assert.assertEquals("Failed to find getModelTypeByDefinitionType by count", true,

-                dbDatatypeModelTypes.size() > 0);

+        Assert.assertTrue("Failed to find getModelTypeByDefinitionType by count", dbDatatypeModelTypes.size() > 0);

     }

 

     @Test

diff --git a/ms/controllerblueprints/modules/service/src/test/java/org/onap/ccsdk/apps/controllerblueprints/service/validator/ServiceTemplateValidationTest.java b/ms/controllerblueprints/modules/service/src/test/java/org/onap/ccsdk/apps/controllerblueprints/service/validator/ServiceTemplateValidationTest.java
index 557c6dd8..0ef54452 100644
--- a/ms/controllerblueprints/modules/service/src/test/java/org/onap/ccsdk/apps/controllerblueprints/service/validator/ServiceTemplateValidationTest.java
+++ b/ms/controllerblueprints/modules/service/src/test/java/org/onap/ccsdk/apps/controllerblueprints/service/validator/ServiceTemplateValidationTest.java
@@ -18,7 +18,6 @@ package org.onap.ccsdk.apps.controllerblueprints.service.validator;
 

 

 import org.apache.commons.io.FileUtils;

-import org.apache.commons.io.IOUtils;

 import org.junit.Assert;

 import org.junit.Test;

 import org.onap.ccsdk.apps.controllerblueprints.service.utils.ConfigModelUtils;