aboutsummaryrefslogtreecommitdiffstats
path: root/appc-inbound
AgeCommit message (Collapse)AuthorFilesLines
2019-06-27Parameterized queriesPatrick Brady8-163/+671
Convert all database queries to use java sql parameterized queries to reduce risk of sql injection attack. Change-Id: I15876ce3a2f2e2dfbd6578f5141367deed75d097 Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: OJSI-25
2019-05-20Update parent versionPatrick Brady21-21/+21
Update the parent version to match the new 2.* parent versioning. Change-Id: I77280d8cf12de1de20c01249491dc85243f5d655 Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1601
2019-05-10Add ConfigModify to if statementPatrick Brady1-8/+10
Requests from cdt with the action set to ConfigModify did not have entries added to the device interface protocol table. With this change the entry will be made in the table. Change-Id: I29835554a0ebf2fea29f1c8745b99ac1813c0d7d Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1593
2019-04-26Increment snapshot versionPatrick Brady22-22/+22
Change from 1.5.0-SNAPSHOT to 1.6.0-SNAPSHOT to prepare for next development cycle. Change-Id: I187785ab4b11a37815289d20ba802c48e86cee7f Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1585
2019-04-10added file to test ActionIdentifier.javaSandeep J1-0/+44
to increase code coverage Issue-ID: APPC-1086 Change-Id: Iba0884ae878488575cda665ed15cca5b301b6b03 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2019-04-10added file to test ScopOverlap.javSandeep J1-0/+48
to increase code coverage Issue-ID: APPC-1086 Change-Id: I21695f6515653e79a7bc09a462ce181aa617105b Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2019-04-10added file to test Request.javaSandeep J1-0/+44
to increase code coverage Issue-ID: APPC-1086 Change-Id: I0afa6d99ba65243bfbae419d075800ecc45aafb6 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2019-04-09removed sonar vulnerabilities in ServiceExecutorSandeep J1-2/+3
to increase code coverage Issue-ID: APPC-1567 Change-Id: Iada27e5e4d40d090275d35dfb3e586fe019cb207 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2019-04-04added test cases to DBServiceTest.javaSandeep J1-0/+21
to increase code coverage Issue-ID: APPC-1086 Change-Id: I149ad0ee6354822fcb9712fe12ad22885b65cf8e Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2019-03-28added test case to DBServiceTest.javaSandeep J1-0/+16
to increase code coverage Issue-ID: APPC-1086 Change-Id: I02b723e7f9aa83e2f7f51aa5a9c8883ac149299c Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2019-03-26added test cases to ArtifactHandlerProviderTestSandeep J1-5/+22
to increase code coverage Issue-ID: APPC-1086 Change-Id: Ic03b32bc4c8b87a76db2e2aae45f7706f19e9bd4 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2019-03-26added test case to DBServiceTest.javaSandeep J1-1/+9
to increase code coverage Issue-ID: APPC-1086 Change-Id: I202822e53c2086b5db41a8028410c07c46821d1d Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2019-03-21Modified code to avoid null pointer exceptionJegadeesh Babu1-4/+7
Sonar fix Issue-ID: APPC-1550 Change-Id: I6c6afcf13e33f06d70883a588574ed83a9e2dfdc Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
2019-03-15Revert "upgrade databind artifact"Patrick Brady9-86/+1
Fasterxml databind is being brought in to karaf by opendaylight and trying to force a different version for the appc components is causing class errors. This reverts commit 52cf1a81d591efb2b1ee4b8c5a70b137dfb6c212. Change-Id: I6d0da2ed081e4abd4b83e8b11935ba43bee0e1aa Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1533
2019-03-13upgrade databind artifactTaka Cho9-1/+86
upgrade jackson's databind from 2.8.11.2 to 2.8.11.3 Change-Id: I9bf3ab8021f91f6ed36bdffdacbaeeac78d2e87c Issue-ID: APPC-1533 Signed-off-by: Taka Cho <takamune.cho@att.com>
2019-03-07Test coverage in RequestValidatorJoss Armstrong1-0/+72
Increased coverage from 61% to 79% Issue-ID: APPC-1436 Change-Id: I4a372d40b5593f32685b09c5240654dab0aee968 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-03-06Test coverage in ArtifactHandlerClientJoss Armstrong5-85/+63
Increase coverage from 34% to 83% Fix for Sonar major issue on branch coverage Issue-ID: APPC-1436 Change-Id: Ie26e2cb71c833e4f086da2a238bd6f956bd85f33 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-03-06Test coverage in ArtifactHandlerProviderJoss Armstrong1-29/+20
Increase coverage from 51% to 96% Fix assertions and Sonar major branch coverage problem Issue-ID: APPC-1335 Change-Id: I1edb662db199dda46972fdf37820aa1de1ad46fc Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-28Changes for design serviceSonali Das5-18/+123
Issue-ID: APPC-1342 Change-Id: Iff66ff977b7ca6bbe0e83fa467b72d253d9200b8 Signed-off-by: Sonali Das <sd394g@att.com>
2019-02-25Changes for new odl versionPatrick Brady20-402/+84
Changes required to update to latest opendaylight version. Some powermock tests have been temporarily removed due to an powermock incompatibility. They will be fixed and re-added. Change-Id: I418d44913fcd42423d2d9bd37b189f6301eaab81 Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1370
2019-02-21Remove duplicate versionsPatrick Brady3-7/+3
These versions are inherited from opendaylight parent poms. Removing the override for these inherited versions. Change-Id: I83b374e4d8815e21fd48bedbe4dd46bc246e44a4 Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1355
2019-02-20Vulnerabilities Fix - XResponseProcessor.javaSudarshan Kumar1-3/+6
Removed printStacktrace and specified specific exception Issue-ID: APPC-1399 Change-Id: I44c938cdd00a88ff76dfa36dbe49942f91546bb2 Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
2019-02-19Correct line indent spacingPatrick Brady2-150/+150
The indent spacing was incorrectly changed to 2 spaces instead of 4 by https://gerrit.onap.org/r/#/c/78396/ The incorrect spacing change was causing merge conflicts in another commit. Change-Id: I6693b3bfaa5685318c8ada5d7984235c788b9504 Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1420
2019-02-18Test coverage in design-services-providerJoss Armstrong4-92/+144
Add test cases to ArtifactHandlerClient Issue-ID: APPC-1436 Change-Id: I0893526b6f3a532ec422b998bb9cc266850a52a7 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-18Test coverage for DesignServiceProviderJoss Armstrong1-0/+54
Add 100% coverage for class Issue-ID: APPC-1436 Change-Id: I7e20fa92e5d6b16f7b3c791538464575024fefc5 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-18Test coverage for SecureRestClientTMJoss Armstrong1-0/+41
Added 100% coverage for class Issue-ID: APPC-1436 Change-Id: I5522672d32720028744f03078287436eed8f2ce5 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-16Added Junit for RequestValidationException.JavaSudarshan Kumar1-0/+34
Added Junit for RequestValidationException.Java Issue-ID: APPC-1372 Change-Id: Ie56b6ff0dc1a3c0fafbd954f658a08965b006519 Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
2019-02-15Support multiple Ansible serversSonali Das3-107/+320
Issue-ID: APPC-1364 Change-Id: I63cf89f5964bcfaba7d1f0b0eac2477f827b69fa Signed-off-by: Sonali Das <sd394g@att.com> Review Comment update Issue-ID: APPC-1364 Change-Id: I03fa97d60c6497218c14b53531c2dea69c7fba34 Signed-off-by: Sonali Das <sd394g@att.com> Review Comment update Issue-ID: APPC-1364 Change-Id: I03fa97d60c6497218c14b53531c2dea69c7fba34 Signed-off-by: Sonali Das <sd394g@att.com> Support multiple Ansible servers Issue-ID: APPC-1364 Change-Id: I63cf89f5964bcfaba7d1f0b0eac2477f827b69fa Signed-off-by: Sonali Das <sd394g@att.com> Support multiple Ansible servers Issue-ID: APPC-1364 Change-Id: I63cf89f5964bcfaba7d1f0b0eac2477f827b69fa Signed-off-by: Sonali Das <sd394g@att.com>
2019-02-15Added Junit for DBException.javaSudarshan Kumar1-0/+40
Added Junit for DBException.java Issue-ID: APPC-1372 Change-Id: Ie5637f33c6a2bc6f51d51f0f94fb780699b3880c Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
2019-02-14Test coverage in XInterfaceServiceJoss Armstrong2-25/+104
Increased coverage from 68% to 100% Issue-ID: APPC-1436 Change-Id: If9f1670ba9955325bf938d7edf3d7d67bb48088c Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-14Test coverage for XResponseProcessorJoss Armstrong1-0/+58
Increased coverage from 0% to 81% Issue-ID: APPC-1436 Change-Id: I6b9805d2e048247759861ebcd65d74507c99aeb0 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-14Added interrupt method to notify caller methodJegadeesh Babu1-1/+4
Called interrupt method on current thread Issue-ID: APPC-1437 Change-Id: I0dbb8cf01f285c01f96fe4f1c0396999e3361373 Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
2019-02-14Test coverage in ArtifactHandlerClientJoss Armstrong1-0/+39
Added partial test coverage Issue-ID: APPC-1436 Change-Id: Ic2520603b33f735cf1bd816544696c3fa29f0303 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-14Added test case for DesignServiceImpl ClassLathishbabu Ganesan4-80/+241
Increased the coverage from 0% to 97.5% Issue-ID: APPC-1420 Change-Id: Iea12e07e91f6d84645dbbc060518c26c1695fd40 Signed-off-by: Lathishbabu Ganesan <lathishbabu.ganesan@ericsson.com>
2019-02-14Junit for ArtifactHandlerInternalExceptionDriptaroop Das1-0/+36
Junit for ArtifactHandlerInternalException Issue-ID: APPC-1412 Change-Id: Ib37177052fea56a31ed486772f0204931e2c9a34 Signed-off-by: Driptaroop Das <driptaroop.das@in.ibm.com>
2019-02-13Replaced prinstacktrace with loggerJegadeesh Babu1-1/+1
Replaced printStackTrace with logger Issue-ID: APPC-1424 Change-Id: I582b497fe3f483ec14abf6b61f488204c02238b8 Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
2019-01-24Fix ServiceExecutorImplJoss Armstrong3-45/+35
Code change to fix handling of vserver-id Issue-ID: APPC-1358 Change-Id: I463fceda2321b5006100b12644708d22fe25a04e Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-01-23Test coverage in appc-interfaces-services packageJoss Armstrong4-3/+156
Increased coverage from 0% to 100% Issue-ID: APPC-1354 Change-Id: Ifb8478104af432b5baf11d21e66f490dcd70b5a9 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-01-23Test coverage in interface-services-executorImplJoss Armstrong7-37/+237
Increased coverage from 39% to 93% Issue-ID: APPC-1354 Change-Id: I372be6e61e6041dbf81607d4386fc5123fa5ee79 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-01-22Test coverage in artifact-handler-utils packageJoss Armstrong1-0/+56
Increased coverage from 21% to 91% Issue-ID: APPC-1335 Change-Id: Ib0ed16e6e0ef01c83666491644564d1c6f341160 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-01-22Increase coverage in artifact-handler-node packageJoss Armstrong4-111/+115
Increased coverage from 56% to 93% Issue-ID: APPC-1335 Change-Id: I65ed7979141a035444ff45e7540d7fb022d24355 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-01-22Coverage for appc-artifact-handler packageJoss Armstrong5-41/+262
Increased coverage from 0% to 95% Issue-ID: APPC-1335 Change-Id: I3c2e1f22009c47cda983e61eda7e98c48564ee98 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-01-21Correct unit tests for DBService classJoss Armstrong5-113/+221
Increased test coverage from 74% to 92% in DBService class Issue-ID: APPC-1335 Change-Id: Iabd792eb104429d5090e0099dba463e8ad6d499a Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-01-18Update install-feature for pre-installPatrick Brady6-18/+6
Since the feature zip files will be extracted during docker build, the install-features scripts need to be modified so that the script will not fail when the zip file does not exist, since the zip file will have already been unzipped. Change-Id: I441064226db956addae5c2f238114ce3965c13ef Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1337
2019-01-08Change parent version to appc snapshotPatrick Brady21-21/+21
Changing to the current release snapshot version of the appc parents instead of the previous release version. This allows updated changes to parents to be in builds. Change-Id: I6cec484012c2cb48ee1ea7f10fd058d017f00947 Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1304
2019-01-07Update parent pom versionPatrick Brady21-21/+21
Update the parent version to appc parent 1.4.1 Change-Id: I185d086595bed6410f7fd6b8c139cc6300e4467e Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1304
2018-11-28Junits for design servicesDilip kumar Pampana2-12/+48
code coverage for design services in appc-inbound Issue-ID: APPC-1211 Change-Id: Ie67937b74a83aee5de469687e4ab63685cb5d6aa Signed-off-by: Dilip kumar Pampana <dilip.kumar.pampana@ibm.com>
2018-11-12Increment version numberPatrick Brady22-22/+22
Changing to version 1.5.0-SNAPSHOT Change-Id: I1e0773d16cb058ac2fb96718581cfbf8d716a2e0 Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1212
2018-10-11Roll to next version after releasePatrick Brady22-22/+22
Change to version 1.4.1-SNAPSHOT Change-Id: Ie6238743cbe2bebeb122ce3985fb2488d9a6c62e Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1212
2018-10-09Change to released parent pomsPatrick Brady21-21/+21
Change-Id: I298b1ac52c849320b67c649017b3604490a5063b Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1212