aboutsummaryrefslogtreecommitdiffstats
path: root/appc-inbound/appc-design-services/provider
AgeCommit message (Collapse)AuthorFilesLines
2019-03-21Modified code to avoid null pointer exceptionJegadeesh Babu1-4/+7
Sonar fix Issue-ID: APPC-1550 Change-Id: I6c6afcf13e33f06d70883a588574ed83a9e2dfdc Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
2019-03-15Revert "upgrade databind artifact"Patrick Brady1-1/+0
Fasterxml databind is being brought in to karaf by opendaylight and trying to force a different version for the appc components is causing class errors. This reverts commit 52cf1a81d591efb2b1ee4b8c5a70b137dfb6c212. Change-Id: I6d0da2ed081e4abd4b83e8b11935ba43bee0e1aa Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1533
2019-03-13upgrade databind artifactTaka Cho1-0/+1
upgrade jackson's databind from 2.8.11.2 to 2.8.11.3 Change-Id: I9bf3ab8021f91f6ed36bdffdacbaeeac78d2e87c Issue-ID: APPC-1533 Signed-off-by: Taka Cho <takamune.cho@att.com>
2019-03-07Test coverage in RequestValidatorJoss Armstrong1-0/+72
Increased coverage from 61% to 79% Issue-ID: APPC-1436 Change-Id: I4a372d40b5593f32685b09c5240654dab0aee968 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-03-06Test coverage in ArtifactHandlerClientJoss Armstrong5-85/+63
Increase coverage from 34% to 83% Fix for Sonar major issue on branch coverage Issue-ID: APPC-1436 Change-Id: Ie26e2cb71c833e4f086da2a238bd6f956bd85f33 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-28Changes for design serviceSonali Das5-18/+123
Issue-ID: APPC-1342 Change-Id: Iff66ff977b7ca6bbe0e83fa467b72d253d9200b8 Signed-off-by: Sonali Das <sd394g@att.com>
2019-02-25Changes for new odl versionPatrick Brady2-14/+6
Changes required to update to latest opendaylight version. Some powermock tests have been temporarily removed due to an powermock incompatibility. They will be fixed and re-added. Change-Id: I418d44913fcd42423d2d9bd37b189f6301eaab81 Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1370
2019-02-20Vulnerabilities Fix - XResponseProcessor.javaSudarshan Kumar1-3/+6
Removed printStacktrace and specified specific exception Issue-ID: APPC-1399 Change-Id: I44c938cdd00a88ff76dfa36dbe49942f91546bb2 Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
2019-02-19Correct line indent spacingPatrick Brady2-150/+150
The indent spacing was incorrectly changed to 2 spaces instead of 4 by https://gerrit.onap.org/r/#/c/78396/ The incorrect spacing change was causing merge conflicts in another commit. Change-Id: I6693b3bfaa5685318c8ada5d7984235c788b9504 Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1420
2019-02-18Test coverage in design-services-providerJoss Armstrong4-92/+144
Add test cases to ArtifactHandlerClient Issue-ID: APPC-1436 Change-Id: I0893526b6f3a532ec422b998bb9cc266850a52a7 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-18Test coverage for DesignServiceProviderJoss Armstrong1-0/+54
Add 100% coverage for class Issue-ID: APPC-1436 Change-Id: I7e20fa92e5d6b16f7b3c791538464575024fefc5 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-18Test coverage for SecureRestClientTMJoss Armstrong1-0/+41
Added 100% coverage for class Issue-ID: APPC-1436 Change-Id: I5522672d32720028744f03078287436eed8f2ce5 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-16Added Junit for RequestValidationException.JavaSudarshan Kumar1-0/+34
Added Junit for RequestValidationException.Java Issue-ID: APPC-1372 Change-Id: Ie56b6ff0dc1a3c0fafbd954f658a08965b006519 Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
2019-02-15Added Junit for DBException.javaSudarshan Kumar1-0/+40
Added Junit for DBException.java Issue-ID: APPC-1372 Change-Id: Ie5637f33c6a2bc6f51d51f0f94fb780699b3880c Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
2019-02-14Test coverage in XInterfaceServiceJoss Armstrong2-25/+104
Increased coverage from 68% to 100% Issue-ID: APPC-1436 Change-Id: If9f1670ba9955325bf938d7edf3d7d67bb48088c Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-14Test coverage for XResponseProcessorJoss Armstrong1-0/+58
Increased coverage from 0% to 81% Issue-ID: APPC-1436 Change-Id: I6b9805d2e048247759861ebcd65d74507c99aeb0 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-14Test coverage in ArtifactHandlerClientJoss Armstrong1-0/+39
Added partial test coverage Issue-ID: APPC-1436 Change-Id: Ic2520603b33f735cf1bd816544696c3fa29f0303 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-14Added test case for DesignServiceImpl ClassLathishbabu Ganesan4-80/+241
Increased the coverage from 0% to 97.5% Issue-ID: APPC-1420 Change-Id: Iea12e07e91f6d84645dbbc060518c26c1695fd40 Signed-off-by: Lathishbabu Ganesan <lathishbabu.ganesan@ericsson.com>
2019-02-14Junit for ArtifactHandlerInternalExceptionDriptaroop Das1-0/+36
Junit for ArtifactHandlerInternalException Issue-ID: APPC-1412 Change-Id: Ib37177052fea56a31ed486772f0204931e2c9a34 Signed-off-by: Driptaroop Das <driptaroop.das@in.ibm.com>
2019-01-08Change parent version to appc snapshotPatrick Brady1-1/+1
Changing to the current release snapshot version of the appc parents instead of the previous release version. This allows updated changes to parents to be in builds. Change-Id: I6cec484012c2cb48ee1ea7f10fd058d017f00947 Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1304
2019-01-07Update parent pom versionPatrick Brady1-1/+1
Update the parent version to appc parent 1.4.1 Change-Id: I185d086595bed6410f7fd6b8c139cc6300e4467e Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1304
2018-11-28Junits for design servicesDilip kumar Pampana2-12/+48
code coverage for design services in appc-inbound Issue-ID: APPC-1211 Change-Id: Ie67937b74a83aee5de469687e4ab63685cb5d6aa Signed-off-by: Dilip kumar Pampana <dilip.kumar.pampana@ibm.com>
2018-11-12Increment version numberPatrick Brady1-1/+1
Changing to version 1.5.0-SNAPSHOT Change-Id: I1e0773d16cb058ac2fb96718581cfbf8d716a2e0 Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1212
2018-10-11Roll to next version after releasePatrick Brady1-1/+1
Change to version 1.4.1-SNAPSHOT Change-Id: Ie6238743cbe2bebeb122ce3985fb2488d9a6c62e Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1212
2018-10-09Change to released parent pomsPatrick Brady1-1/+1
Change-Id: I298b1ac52c849320b67c649017b3604490a5063b Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1212
2018-09-24Add version to pom filesPatrick Brady1-0/+1
Change-Id: Ia7eaffdb1391b0b836a2911395c2b768b4926ef3 Signed-off-by: Patrick Brady <pb071s@att.com> Issue-ID: APPC-1208
2018-09-21Remove logback 1.1.3 security issuePatrick Brady1-1/+11
cdp-pal and eelf are the dependencies using logback-classic 1.1.3. Need to use exclusions option in pom file Change-Id: Id8f5817ec955e2b7b486bc0215c35541086606aa Signed-off-by: Patrick Brady <pb071s@att.com> Issue-ID: APPC-1018
2018-09-11Correct fasterxml errorsPatrick Brady2-4/+10
Different versions of fasterxml were being used at once, causing type errors. Change-Id: I42c28e26386284010fe5c965456e2c72fdb30f3c Signed-off-by: Patrick Brady <pb071s@att.com> Issue-ID: APPC-1202
2018-09-05Code Coverage for XinterfaceServices.javaDilip kumar Pampana1-0/+41
Junit test for code covergae for XinerfaceServices.java in design services Issue-ID: APPC-1190 Change-Id: I8b23975eb1c9d19200b5d0d115763168e48c53b9 Signed-off-by: Dilip kumar Pampana <dilip.kumar.pampana@ibm.com>
2018-08-21Revert "resolving logback-classic 1.13"Patrick Brady1-11/+1
Temporary revert to fix failing bundles. This reverts commit 76b6ff1ce84d4c2ab4518dd5f154083b91680245. Change-Id: Ibce5eee91ad8f1bec9b458a52a7f5d25ada85da9 Signed-off-by: Patrick Brady <pb071s@att.com> Issue-ID: APPC-1018 Signed-off-by: Patrick Brady <pb071s@att.com>
2018-08-20resolving logback-classic 1.13 from security issueTaka Cho1-1/+11
cdp-pal and eelf are the jar using logback-classic 1.1.3. need to use exclusions option in pom file Issue-ID: APPC-1018 Change-Id: I00b41f9c366a5ead3f4205cd6fa6b9eb74599767 Signed-off-by: Taka Cho <tc012c@att.com>
2018-08-14Karaf 4 for appc-inboundPatrick Brady1-9/+7
Change-Id: I94f8b31e509d0e231e36b8b8d2871ad10bdf02f8 Issue-ID: APPC-1148 Signed-off-by: Patrick Brady <pb071s@att.com>
2018-08-02added test case to TestValidatorService.javaSandeep J1-1/+13
to increase code coverage Issue-ID: APPC-1086 Change-Id: Id3d7d93fb02d62be8288ae7065b69b22ce1d8c2f Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-08-01updated existing test case to increase coverageSandeep J1-7/+9
updated existing test case to increase code coverage Issue-ID: APPC-1086 Change-Id: Iea8d0a833872cec864436300c4bcbc9e55cd3316 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-07-31updated test case to increase coverageSandeep J1-6/+5
updated test to cover getAppcTimeStampResponse method in DbResponseProcessor.java Issue-ID: APPC-1086 Change-Id: I6333683181498857aa58ca7ccb404329574513ff Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-07-31Junits for Inbound/designServicesDilip kumar Pampana4-255/+277
Added new test class files for code coverage of DesignDBServices and removed version for mockito-core as it is overriding existing one in pom.xml file in design services provide. Issue-ID: APPC-1117 Change-Id: I9eddf30c7e3c72467f4bf5f5850c22c083f51a9f Signed-off-by: Dilip kumar Pampana <dilip.kumar.pampana@ibm.com>
2018-07-16Tests for appc-inbound/design-servicesDilip kumar Pampana1-0/+12
Test coverage for GetAppcTimestampUTC in inound/ design-services Issue-ID: APPC-1078 Change-Id: I508c3bcebad5c7c35bd2257436ad3f4099eb8345 Signed-off-by: Dilip kumar Pampana <dilip.kumar.pampana@ibm.com>
2018-07-11Fix XML injection issueMei Su1-0/+5
Fix XML injection security issue Issue-ID: APPC-1068 Change-Id: Id534da6d0c8287ba32febd959c81c313ee21302a Signed-off-by: Mei Su <ms6523@att.com>
2018-07-06APPC CDT Future timestamp issue fix -new HTTP reqod74274-4/+35
APPC CDT GUI generated timestamp in user browser in request data. Sometimes the timestamp appeared in future compared to APPC server time. To fix the APPC CDT Future timestamp issue adding a new HTTP request to DesignDBService to get UTC Timestamp from the APPC server. Also adding this request to DbResponseProcessor, RequestValidator to avoid validation failures. Modified DesignDBService.java to satisfy review comments. Made additional corrections after failed build. Change-Id: Ic9d3f1ebb42143e497e21520843a78ecb882d0fc Issue-ID: APPC-1026 Signed-off-by: od7427 <od7427@att.com>
2018-06-14Update license header in appc xml filesJohn McClung1-2/+1
More license header changes to miscellaneous appc xml files to reflect the 2018 changes. Change-Id: Ia71a0711235ab56bf2cd83719964bc12d7aa420b Issue-ID: APPC-1004 Signed-off-by: John McClung <jm1364@att.com>
2018-06-14More lic header updates to various appc xml filesJohn McClung2-4/+2
Modify license header in appc-event-listener, appc-inbound, appc-lifecycle-management and appc-metric xml files to reflect 2018 changes. Change-Id: I0e5d9eb55b92d9b4274f0ebc5c5a1044e451707c Issue-ID: APPC-1003 Signed-off-by: John McClung <jm1364@att.com>
2018-06-13Update lic header in misc appc properties filesJohn McClung2-4/+2
Modify license header in miscellaneous appc properties files to reflect 2018 changes. Change-Id: I21eb99f680ab4cbddbd7f8abe65720c87e2dbb33 Issue-ID: APPC-998 Signed-off-by: John McClung <jm1364@att.com>
2018-06-08Update license header in appc-inbound filesJohn McClung25-50/+25
Modify license header in appc-inbound java files to reflect 2018 changes. Change-Id: I32b2cf9e659bb8987da56415589c6c773698a09c Issue-ID: APPC-984 Signed-off-by: John McClung <jm1364@att.com>
2018-05-22Increment version for new branchPatrick Brady1-1/+1
Change from version 1.3.0-SNAPSHOT to 1.4.0-SNAPSHOT and update version file. Change-Id: I6b54c3e3b97c3ef0a554fb173d0dd261ca2107d3 Signed-off-by: Patrick Brady <pb071s@att.com> Issue-ID: APPC-916
2018-05-10Change Design Service to use DbLibServiceRyan Young1-3/+2
Change-Id: I5b82345d8790fcfe3fdf73c86b413276673361ec Signed-off-by: Ryan Young <ry303t@att.com> Issue-ID: APPC-890
2018-05-01Fixes for the two features that were not installedPatrick Brady1-1/+2
These features relied on exports that didn't exist. Also versions had to be removed from feature files. Change-Id: I1860ae6c46354061943223ac6a201518871d3608 Signed-off-by: Patrick Brady <pb071s@att.com> Issue-ID: APPC-871
2018-04-03Changes made to Inbound/Design-ServicesDilip kumar Pampana1-8/+10
Error Displayed in CDT while saving the artifacts to APPC DB using SAVE ALL TO APPC though the artifacts are saved in DB Issue-ID: APPC-817 Change-Id: I748dd099b3df2ace95b9930aec2fcf1de3f6d148 Signed-off-by: Dilip kumar Pampana <dp583p@att.com>
2018-03-26Add junit coverage to EncryptionTool classLori Keighron1-0/+37
Introduce junit coverage in design-services class Issue-ID: APPC-794 Change-Id: Idbf8d02511b478173950a97c10a642486bc0d45f Signed-off-by: Lori Keighron <lk2924@att.com>
2018-02-27security issue: commons-collectionsTaka Cho1-0/+11
Change-Id: I74a56640065ae6c6a470835ab1022ed0f266fc09 Issue-ID: APPC-665 Signed-off-by: Taka Cho <tc012c@att.com>
2018-02-22ArtifactHandlerClient sonar fixesJakub Dudycz2-95/+103
Change-Id: Ic43b1e4748c753e696ffff1deb89f2b73a8cb9ce Issue-ID: APPC-650 Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>