summaryrefslogtreecommitdiffstats
path: root/appc-inbound/appc-artifact-handler/provider/src
AgeCommit message (Collapse)AuthorFilesLines
2019-07-24Add value of the argumentsPatrick Brady1-3/+31
Also apply the valueof to non svc context arguments. The original code would always treat null arguments as null strings. This replaces that functionality in the prepared statements. Change-Id: I88ab22c87b86a8f5ff41946757c40a399c37a6c3 Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: OJSI-25
2019-07-17Fixes for parameterized sql queriesPatrick Brady2-1/+3
The old non-parameterized queries would treat null entries in the SvcLogicContext as "null" string values. The parameterized query treats these as NULL sql values. This change keeps those values as "null" strings. Change-Id: Iee7f7a1861bdd82dc65d59db2be7862b49cf1207 Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1639
2019-06-27Parameterized queriesPatrick Brady8-163/+671
Convert all database queries to use java sql parameterized queries to reduce risk of sql injection attack. Change-Id: I15876ce3a2f2e2dfbd6578f5141367deed75d097 Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: OJSI-25
2019-05-10Add ConfigModify to if statementPatrick Brady1-8/+10
Requests from cdt with the action set to ConfigModify did not have entries added to the device interface protocol table. With this change the entry will be made in the table. Change-Id: I29835554a0ebf2fea29f1c8745b99ac1813c0d7d Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1593
2019-04-04added test cases to DBServiceTest.javaSandeep J1-0/+21
to increase code coverage Issue-ID: APPC-1086 Change-Id: I149ad0ee6354822fcb9712fe12ad22885b65cf8e Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2019-03-28added test case to DBServiceTest.javaSandeep J1-0/+16
to increase code coverage Issue-ID: APPC-1086 Change-Id: I02b723e7f9aa83e2f7f51aa5a9c8883ac149299c Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2019-03-26added test cases to ArtifactHandlerProviderTestSandeep J1-5/+22
to increase code coverage Issue-ID: APPC-1086 Change-Id: Ic03b32bc4c8b87a76db2e2aae45f7706f19e9bd4 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2019-03-26added test case to DBServiceTest.javaSandeep J1-1/+9
to increase code coverage Issue-ID: APPC-1086 Change-Id: I202822e53c2086b5db41a8028410c07c46821d1d Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2019-03-06Test coverage in ArtifactHandlerProviderJoss Armstrong1-29/+20
Increase coverage from 51% to 96% Fix assertions and Sonar major branch coverage problem Issue-ID: APPC-1335 Change-Id: I1edb662db199dda46972fdf37820aa1de1ad46fc Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-25Changes for new odl versionPatrick Brady5-204/+14
Changes required to update to latest opendaylight version. Some powermock tests have been temporarily removed due to an powermock incompatibility. They will be fixed and re-added. Change-Id: I418d44913fcd42423d2d9bd37b189f6301eaab81 Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1370
2019-02-15Support multiple Ansible serversSonali Das3-107/+320
Issue-ID: APPC-1364 Change-Id: I63cf89f5964bcfaba7d1f0b0eac2477f827b69fa Signed-off-by: Sonali Das <sd394g@att.com> Review Comment update Issue-ID: APPC-1364 Change-Id: I03fa97d60c6497218c14b53531c2dea69c7fba34 Signed-off-by: Sonali Das <sd394g@att.com> Review Comment update Issue-ID: APPC-1364 Change-Id: I03fa97d60c6497218c14b53531c2dea69c7fba34 Signed-off-by: Sonali Das <sd394g@att.com> Support multiple Ansible servers Issue-ID: APPC-1364 Change-Id: I63cf89f5964bcfaba7d1f0b0eac2477f827b69fa Signed-off-by: Sonali Das <sd394g@att.com> Support multiple Ansible servers Issue-ID: APPC-1364 Change-Id: I63cf89f5964bcfaba7d1f0b0eac2477f827b69fa Signed-off-by: Sonali Das <sd394g@att.com>
2019-02-14Added interrupt method to notify caller methodJegadeesh Babu1-1/+4
Called interrupt method on current thread Issue-ID: APPC-1437 Change-Id: I0dbb8cf01f285c01f96fe4f1c0396999e3361373 Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
2019-01-22Test coverage in artifact-handler-utils packageJoss Armstrong1-0/+56
Increased coverage from 21% to 91% Issue-ID: APPC-1335 Change-Id: Ib0ed16e6e0ef01c83666491644564d1c6f341160 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-01-22Increase coverage in artifact-handler-node packageJoss Armstrong4-111/+115
Increased coverage from 56% to 93% Issue-ID: APPC-1335 Change-Id: I65ed7979141a035444ff45e7540d7fb022d24355 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-01-22Coverage for appc-artifact-handler packageJoss Armstrong5-41/+262
Increased coverage from 0% to 95% Issue-ID: APPC-1335 Change-Id: I3c2e1f22009c47cda983e61eda7e98c48564ee98 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-01-21Correct unit tests for DBService classJoss Armstrong5-113/+221
Increased test coverage from 74% to 92% in DBService class Issue-ID: APPC-1335 Change-Id: Iabd792eb104429d5090e0099dba463e8ad6d499a Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2018-09-10Fix for artifact handler rpc errorPatrick Brady6-258/+50
Change over to using blueprint for rpc registration Change-Id: Ie647472eb3e42eb7e878c526b13acbfffd1bc18f Signed-off-by: Patrick Brady <pb071s@att.com> Issue-ID: APPC-1185
2018-08-31Junit for code coverage in artifact-handlerDilip kumar Pampana3-6/+186
Junit Test cases for checking Exceptions part and also for isUpdate in DBService.java file Issue-ID: APPC-1140 Change-Id: Ibbfe9daf5465f4efcc8d42e8ed508d0b5e5129bb Signed-off-by: Dilip kumar Pampana <dilip.kumar.pampana@ibm.com>
2018-08-06Revert query changesPatrick Brady1-5/+7
The changes between patch 3 and patch 4 of this commit https://gerrit.onap.org/r/#/c/55093, where the parameters are sent to the SvcLogicContext instead of values, breaks the save functionality in cdt. When SvcLogicContext is allowed to subsitute the values, the StringUtils.isEmpty functions are skipped over. Although it appears this change is changing a parameterized query to a static statement query, in fact the query is not parameterized in its current form either. In its current form, SvcLogicContext is just subsituting the values into a static statement query. SvcLogicContext does perform a simple single quote escape, which could be duplicated here. Change-Id: If3ffceed5ad147c402355ffef17a8abf0752d5b1 Signed-off-by: Patrick Brady <pb071s@att.com> Issue-ID: APPC-1107
2018-07-24Fix query statements in DBServiceMei Su1-2/+2
Fix query statements related to url in DBService Issue-ID: APPC-1107 Change-Id: I2f8e2bc77c04a4b96160af00bdc9d3debe4395c3 Signed-off-by: Mei Su <ms6523@att.com>
2018-06-22Artifact-Handler - Appc-InboundDilip kumar Pampana4-98/+141
Support Multiple Templates For Configure and ConfigModify for VNFs with VNFC level templates Issue-ID: APPC-1010 Change-Id: I7540af3b793bac696bdc28aabc3c0c8e0c13d29e Signed-off-by: Dilip kumar Pampana <dp583p@att.com>
2018-06-14More lic header updates to various appc xml filesJohn McClung1-2/+1
Modify license header in appc-event-listener, appc-inbound, appc-lifecycle-management and appc-metric xml files to reflect 2018 changes. Change-Id: I0e5d9eb55b92d9b4274f0ebc5c5a1044e451707c Issue-ID: APPC-1003 Signed-off-by: John McClung <jm1364@att.com>
2018-06-13Update lic header in misc appc properties filesJohn McClung1-2/+1
Modify license header in miscellaneous appc properties files to reflect 2018 changes. Change-Id: I21eb99f680ab4cbddbd7f8abe65720c87e2dbb33 Issue-ID: APPC-998 Signed-off-by: John McClung <jm1364@att.com>
2018-06-08Update license header in appc-inbound filesJohn McClung12-24/+12
Modify license header in appc-inbound java files to reflect 2018 changes. Change-Id: I32b2cf9e659bb8987da56415589c6c773698a09c Issue-ID: APPC-984 Signed-off-by: John McClung <jm1364@att.com>
2018-05-23Healthcheck bug fixesBalaji, Ramya (rb111y)1-0/+4
Fixed code to set userid and password correctly. Also set the url in context when passed in reference artifact. Issue-ID: APPC-917 Change-Id: Iba5a873cc311ab5677b6223c08865c048dbdcf00 Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
2018-04-10Fixed multiple templates queriesBalaji, Ramya (rb111y)3-17/+136
Added model id to condition when checking for update/insert of records Issue-ID: APPC-837 Change-Id: I3fb49c378ac8c1d3180b05772d214d5cc8892810 Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
2018-04-06code fix to resolve duplct data in prop filevidhyasree1-7/+12
Code changes to Dbservice.java in artifact-handler Issue-ID: APPC-821 Change-Id: I805a16e90866e946ca2e8d331b2c63b3ef209f71 Signed-off-by: vidhyasree <sn141y@att.com>
2018-03-29Unit test for SdcArtifactHandlerConstants.javaamshegokar1-0/+33
Unit test for SdcArtifactHandlerConstants.java Sonar-Link: https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-artifact-handler-provider%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fartifact%2Fhandler%2Futils%2FSdcArtifactHandlerConstants.java Change-Id: I21e97b7afcd58196ea064be4c4e8e9dc38cf487b Issue-ID: APPC-793 Signed-off-by: amshegokar <AS00500801@techmahindra.com>
2018-03-26Unit test coverage for DBException.javaamshegokar1-0/+37
Unit test coverage for DBException.java Sonar-Link: https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-artifact-handler-provider%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fartifact%2Fhandler%2Fdbservices%2FDBException.java Change-Id: Iae0c5a90358f61560c8e164fa506a0e3e75857f5 Issue-ID: APPC-791 Signed-off-by: amshegokar <AS00500801@techmahindra.com>
2018-03-26Coverage for ArtifactHandlerInternalExceptionamshegokar1-0/+55
Unit test for ArtifactHandlerInternalException.java Sonar-Link: https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-artifact-handler-provider%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fartifact%2Fhandler%2Fnode%2FArtifactHandlerInternalException.java Change-Id: I887613bc793256be84e288ca432d11c45d320cfc Issue-ID: APPC-792 Signed-off-by: amshegokar <AS00500801@techmahindra.com>
2018-02-21DBService sonar fixesJakub Dudycz3-287/+346
Change-Id: I6c58803ab47ff411d7ff29097a7e64a489dfed03 Issue-ID: APPC-605 Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
2018-02-20Update .gitignore with license textSkip Wonnell1-0/+21
Update .gitignore with license text Remove IDE generated files from repository Update .gitignore to ignore IDE Generated files Issue-ID: APPC-637 Change-Id: Ie650e2c6d46d55d06dcc54877533cb3e14be66d6 Signed-off-by: Skip Wonnell <skip@att.com>
2018-02-15ArtifactHandlerNode sonar fixesJakub Dudycz2-246/+307
Change-Id: I4cc803bc6c5d88b569405ea0af918a6c340fce9d Issue-ID: APPC-581 Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
2018-02-14Artifact Handler code changesRamya Balaji2-78/+149
Refactored code for storing reference data and added unit test cases Issue-ID: APPC-543 Change-Id: I60ed5e327324403409ec0d9725c5880038a3e186 Signed-off-by: Ramya Balaji <rb111y@att.com>
2018-02-09ArtifactHandlerProviderUtil sonar fixesJakub Dudycz1-81/+83
Change-Id: Id5fc42637e56cdab8be6c03d269f0bc3ac2e19fe Issue-ID: APPC-582 Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
2018-02-05Artifact Handler updates for ConfigScaleOutRamya Balaji6-56/+112
Code changes and Unit Tests cases for new code Issue-ID: APPC-532 Change-Id: Id945354ec476e4f067cb7a1a411d8c77b3271f42 Signed-off-by: Ramya Balaji <rb111y@att.com>
2018-01-30Removed redundant conditions in DBServiceJakub Dudycz1-141/+170
Change-Id: If78e2ecb407532e3399497f0eda14213130699d1 Issue-ID: APPC-496 Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
2018-01-30Fixed exception handling in ArtifactHandlerNodeJakub Dudycz2-123/+171
Change-Id: I81243ba0704b348995f135d2289135fd9e070928 Issue-ID: APPC-498 Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
2018-01-25Removed unnecesary checksburdziak1-12/+12
Issue-ID: APPC-446 Change-Id: I3d93bcff6c3ed8167dd7f273d90528a76cb2b02f Signed-off-by: burdziak <olaf.burdziakowski@nokia.com>
2018-01-25Logging exceptions in ArtifactHandlerProviderJakub Dudycz1-4/+3
Update Change-Id: I4214b99b84f951a6b508ff40d599585a092467f5 Issue-ID: APPC-495 Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
2018-01-19Fix missing update for protocol in DBService.javaSkip Wonnell1-110/+121
DBService.updateProtocolReference() needs to include the protocol in the SQL update. Also updating file to ONAP java style. Change-Id: I8dc5f8e6387c0a28a32c911e68ecd73ac21dc609 Issue-ID: APPC-435 Signed-off-by: Skip Wonnell <skip@att.com>
2018-01-19Refactor ArtifactHandlerNodekurczews6-235/+179
* replace user-mock with Mockito mock * fix typos Change-Id: Ibc86177c024e5a5e7eec8cf8dd3e49d9a6d1ede4 Issue-ID: APPC-397 Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
2018-01-12Refactor ArtifactHandlerNodekurczews4-230/+235
* Introduce method setAttribute(...) to avoid repeatable instructions and improve readability * Remove prefix from constants (SdcArtifactHandlerConstants.*) Change-Id: I5684e990933aaa66b8dd0a25d702f482489c6b9d Issue-ID: APPC-397 Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
2018-01-09Artifact Handler UpdatesDilip kumar Pampana1-4/+2
replaced Constants.APPC_CONFIG_DIR with System.getenv("APPC_CONFIG_DIR") in dbServices.java Issue-ID: APPC-350 Change-Id: Ib0f3ec47311848a5a75525d0e35361485cc63956 Signed-off-by: Dilip kumar Pampana <dp583p@att.com>
2018-01-08Artifact Handler UpdatesDilip kumar Pampana4-49/+138
Fixed vnfc_reference table, Added code to process VM level capabilities for VNF Issue-ID: APPC-350 Change-Id: If1b8862e1d81c5dc8d3c29b148d5b1d865567951 Signed-off-by: Dilip kumar Pampana <dp583p@att.com>
2017-12-21Fix sonar issues for APPCTaka1-5/+0
Change-Id: I386f6794215eb69b8547fa06193ad78f951b327b Issue-ID: APPC-323 Signed-off-by: Taka <tc012c@att.com>
2017-12-19Update bundle names from openecomp to onapTakamune Cho1-12/+12
Change-Id: Ib0cf4edbab87a32c9d83cc9473412feb77b27a0e Issue-ID: APPC-13 Signed-off-by: Takamune Cho <tc012c@att.com>
2017-12-19Update appc-config-parms to use onap packagingTakamune Cho1-1/+1
Issue-ID: APPC-13 Change-Id: I490847faabfed2e977ee21c0157adf8a790cea65 Signed-off-by: Takamune Cho <tc012c@att.com>
2017-12-13Third part of onap renamePatrick Brady15-0/+0
This part of the commit changes the folder structure on all other folders of appc. Change-Id: I8acfa11cdfcdcd36be0e137245d1dd7324f1abd3 Signed-off-by: Patrick Brady <pb071s@att.com> Issue-ID: APPC-13
2017-12-13First part of onap renamePatrick Brady17-47/+47
This is the first commit of the rename. This commit changes refereces to org.openecomp.appc > org.onap.appc that occur within files. The package folder structure is not changed in this commit. Change-Id: Ic95d749eb99d8a6f4f2b9ee9b06eb41c5cfa7e1c Signed-off-by: Patrick Brady <pb071s@att.com> Issue-ID: APPC-13