summaryrefslogtreecommitdiffstats
path: root/appc-config
AgeCommit message (Collapse)AuthorFilesLines
2019-05-03Add method to escape json stringsPatrick Brady3-0/+86
All backslash escape characters are being stripped out of strings. They need to be added back to strings containing json data. Change-Id: Ic8d9ba95da904b96f65598752133971f8c324694 Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1576
2019-05-03Fix for extra json quotesPatrick Brady1-1/+1
Substring method output was being lost, causing extra quotes to stay in the String. Change-Id: I35e9eee60756b7b743386600e3ab1d203cca036a Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1576
2019-04-22Escape quotes in json stringsPatrick Brady1-2/+11
The JSONObject parser strips all text of backslash escape characters, even if it is treaing the object as a string and not a series of json keys. If a string contains a json object within it, the removal of these escape characters causes problems. Adding the JSONObject.quote method on all strings to automatically add escape characters to any strings which contain characters requiring escapes. Change-Id: Ifac68844dd132971ba35803f1b9c03a5372bd500 Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1576
2019-04-10Fix for Ansible Healthcheck bugJoss Armstrong2-18/+18
Update to directed graph and merge JSON template code Issue-ID: APPC-1472 Change-Id: I4332ad74d34f455261b1c001339d0542be4514fc Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-03-27ConfigComponentAdaptor.java - Sonar FixesDriptaroop Das1-25/+10
ConfigComponentAdaptor.java - Sonar Fixes Issue-ID: APPC-1560 Change-Id: Ia22fc64e378ffb3a206eed256f0a9ab7365381cd Signed-off-by: Driptaroop Das <driptaroop.das@in.ibm.com>
2019-03-27Fix incorrect passing of SvcLogicContext valueJoss Armstrong1-5/+3
EncyrptionToolDGWrapper changes for Multiple Ansible server support not working when retrieving data from SvcLogicContext used for querying DEVICE_AUTHENTICATION table. Issue-ID: APPC-1545 Change-Id: I8f08910156d6e2b4ae6341c847bc773e4d15841e Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-03-26remove cassandra-driver-coreTaka Cho1-6/+0
In appc-config-param, remove cassandra-driver-core to avoid security vulnerability for guava and netty-handler Change-Id: I660ae35c4abbc9537e9f9bf5e18fd630e111ca93 Issue-ID: APPC-1553 Signed-off-by: Taka Cho <takamune.cho@att.com>
2019-03-21Modified code to avoid Null pointer excJegadeesh Babu1-1/+1
Sonar fix Issue-ID: APPC-1547 Change-Id: Ie242256130f255a05366774516cf503c2a3d47cc Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
2019-03-21Fix for incorrect handling of SQL resultsJoss Armstrong1-1/+2
Corrected handling of SQL COUNT query Issue-ID: APPC-1545 Change-Id: I8c246b97c8ed8b483e79ae0e3b2cb51f8b4b62be Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-03-20Suppression of long logs in GraphExecutorJoss Armstrong1-1/+13
Logging full configuration files to info log was causing failures and timeouts on configuration operations in APPC. Some were removed already under this JIRA but this one was missed. Issue-ID: APPC-1489 Change-Id: I619f2d1140095859092d6ceff6c7cb44855fb2e1 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-03-15Revert "upgrade databind artifact"Patrick Brady26-242/+4
Fasterxml databind is being brought in to karaf by opendaylight and trying to force a different version for the appc components is causing class errors. This reverts commit 52cf1a81d591efb2b1ee4b8c5a70b137dfb6c212. Change-Id: I6d0da2ed081e4abd4b83e8b11935ba43bee0e1aa Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1533
2019-03-15added file to test Input.javaSandeep J1-0/+45
to increase code coverage Issue-ID: APPC-1086 Change-Id: I0878084535f77d1be78c82248d597660bb57ddaa Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2019-03-14added test case to cover Parameters.javaSandeep J1-0/+6
to increase code coverage Issue-ID: APPC-1086 Change-Id: Icf7850c8fa43a5d6e5128b00bf708f551c57d1f7 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2019-03-14added test case to VmTest.javaSandeep J1-0/+6
to increase code coverage Issue-ID: APPC-1086 Change-Id: I21c87ab20f6c3faee200fcf2d25120175f58e2c5 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2019-03-14added test case to TunableParametersTest.javaSandeep J1-0/+6
to increase code coverage Issue-ID: APPC-1086 Change-Id: I0ad33fb62276caeb91e08cd1d0aef7a2e2c39864 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2019-03-13Added Junit Class for ParamsHandlerActivatorSudarshan Kumar1-0/+85
Added Junit Class for ParamsHandlerActivator Issue-ID: APPC-1372 Change-Id: I1198cd62354e8781f4fe9e07676ad64fc7f3ccf9 Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
2019-03-13upgrade databind artifactTaka Cho26-4/+242
upgrade jackson's databind from 2.8.11.2 to 2.8.11.3 Change-Id: I9bf3ab8021f91f6ed36bdffdacbaeeac78d2e87c Issue-ID: APPC-1533 Signed-off-by: Taka Cho <takamune.cho@att.com>
2019-03-11added file to test EnvVariables.javaSandeep J1-0/+42
to increase code coverage Issue-ID: APPC-1086 Change-Id: I0ccef8fe411dec8a699152d7710ac83683c5cb72 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2019-03-08added test case to TestDGGeneralDBService.javaSandeep J1-0/+12
to increase code coverage Issue-ID: APPC-1086 Change-Id: Idfc3aa674b566f5e4e04e29396dd9c08607854b6 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2019-03-08added file to test FqdnList.javaSandeep J1-0/+67
to increase code coverage Issue-ID: APPC-1086 Change-Id: Ic2028fa37825facb1e8999a8328c0773eb41abcc Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2019-03-08added file to test Parameters.javaSandeep J1-0/+84
to increase code coverage Issue-ID: APPC-1086 Change-Id: I046d1154ce19801cbc18883799f71ec401baa1cb Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2019-03-06added file to test EscapeUtils.javaSandeep J1-0/+36
to increase code coverage Issue-ID: APPC-1086 Change-Id: I3c98deea811048097be6f87449d0f58b43b29be6 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2019-03-06added file to test Vnfcslist.javaSandeep J1-0/+58
to increase code coverage Issue-ID: APPC-1086 Change-Id: Id574d909b674b1bdad8b96663d3fdb66cc276ecd Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2019-03-05added file to test Vm.javaSandeep J1-0/+55
to increase code coverage Issue-ID: APPC-1086 Change-Id: I251cbcaa1566ad405198a8b8f6669f783aef260e Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2019-03-05added file to test TunableParameters.javaSandeep J1-0/+54
to increase code coverage Issue-ID: APPC-1086 Change-Id: I7844c0c99f1c9ad6e58a6bc7d8b71aee1ff0bd55 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2019-03-04added file to test ArtifactProcessorException.javaSandeep J1-0/+38
to increase code coverage Issue-ID: APPC-1086 Change-Id: If5082027e00615c5633621fdd93be1fe13ca27c7 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2019-03-01Test coverage in ConfigComponentAdaptorJoss Armstrong2-884/+909
Increased coverage from 79% to 89% Fixed indentation Issue-ID: APPC-1497 Change-Id: I9cee309b916eff93887a8d2b7691f9a7c6ba204b Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-27Test coverage in ConfigResourceNodeJoss Armstrong4-70/+508
Add >100 lines of coverage and increase from 71% to 99% Increase branch coverage to fix Sonar major issue Extract repeated strings to constants Issue-ID: APPC-1504 Change-Id: Ib3b1e83d39f02befaede035b84a0ebef96b36cfd Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-27Test coverage in FlowControlNodeJoss Armstrong2-93/+130
Increase line coverage from 72% to 92% Fix for Sonar major issue for branch coverage Issue-ID: APPC-1499 Change-Id: Ie73b6c97fcf50421ca6a73a8273c09ace0faf67f Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-27Test coverage in DBServiceJoss Armstrong2-5/+260
Increase coverage from 71% to 98% Fix for Sonar major issue on branch coverage Issue-ID: APPC-1499 Change-Id: I74261af92b3263a03d29d476ad097182e6112ad9 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-27Test coverage for ObjectFactoryJoss Armstrong1-0/+46
Increase coverage from 0% to 100% Issue-ID: APPC-1499 Change-Id: Ia6209174b99acdeb03698eea9fe96d51a2cccd13 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-26Line and branch coverage for TransactionJoss Armstrong2-55/+120
Increased line coverage from 54% to 99% Added coverage for 50 branches resolving major Sonar issue Issue-ID: APPC-1499 Change-Id: I10dba08c62247401ee4c9fb08fe65f3854445fb5 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-26Fix unit tests for PrecheckOptionJoss Armstrong1-8/+25
Increased line coverage to 100% Increased branch coverage to clear Sonar major warning Removed console logging and cleaned up assertions Issue-ID: APPC-1499 Change-Id: Ifc7163d2e112914749514099779bd5d75ba729c9 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-26Fixed tests on PreCheck classJoss Armstrong1-10/+23
Replaced console printing with assertions Added branch coverage to clear Sonar major warning Increased line coverage to 100% Issue-ID: APPC-1499 Change-Id: Ia027b9d7f414789816d80e12543d27a0baeed9c1 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-26Fix for timeout error when logging >1MB dataJoss Armstrong6-11/+123
Potentially large logs moved to TRACE level, INFO level logs limited in size and related tests updated Issue-ID: APPC-1489 Change-Id: I9ea85e64380479d835da03ed2af3e4ab96ece67e Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-26Test coverage for CCAActivatorJoss Armstrong4-7/+153
Increased coverage from 0% to 93% Issue-ID: APPC-1497 Change-Id: Ie78ac50a08b47cac9bedb9d34b089ac3ad23ab22 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-26Test coverage for ParametersJoss Armstrong1-1/+14
Increased coverage to 100% Issue-ID: APPC-1499 Change-Id: I982023d9f818320f709da552d668b68e5ce0f7b3 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-26Test coverage for ActionIdentifierJoss Armstrong1-6/+17
Increased test coverage to 100% Issue-ID: APPC-1499 Change-Id: I78eee1fdc64840898e1b76984855a43828ee93b4 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-25Changes for new odl versionPatrick Brady2-2/+12
Changes required to update to latest opendaylight version. Some powermock tests have been temporarily removed due to an powermock incompatibility. They will be fixed and re-added. Change-Id: I418d44913fcd42423d2d9bd37b189f6301eaab81 Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1370
2019-02-22Seperated assignment statement from expressionJegadeesh Babu1-1/+4
Sonar bug fix Issue-ID: APPC-1468 Change-Id: I2ff7e01516cf7328357d2a48643947c782ce4fd9 Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
2019-02-21Removed prinstackTraceJegadeesh Babu1-2/+2
Sonar fix Issue-ID: APPC-1475 Change-Id: I0330868328589dded0db6afa7ae2fe75f0b6ada0 Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
2019-02-20Sonar Fix: Removed printStacktraceSudarshan Kumar1-3/+5
Sonar Fix: Removed printStacktrace Issue-ID: APPC-1399 Change-Id: I0d33fac270a2082cc7b284c2df8e47fbf5b139a9 Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
2019-02-18Added test case for DbService utilLathishbabu Ganesan1-0/+80
Increased the coverage from 22% to 82% Issue-ID: APPC-1448 Change-Id: I478367d6f5aac4a453b6d711a81c0ee5cefcdd36 Signed-off-by: Lathishbabu Ganesan <lathishbabu.ganesan@ericsson.com>
2019-02-18Added test case for Flow Controller ActivatorLathishbabu Ganesan1-0/+87
Increased the code coverage from 0% to 97% Issue-ID: APPC-1429 Change-Id: Iada494daad7939b00c76fead73be864c6b40e045 Signed-off-by: Lathishbabu Ganesan <lathishbabu.ganesan@ericsson.com>
2019-02-16Junit class TestSliAuditActivator.java addedSudarshan Kumar1-0/+87
Junit class TestSliAuditActivator.java added Issue-ID: APPC-1372 Change-Id: I9c34fdf596970be4554959f98c19534897792718 Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
2019-02-15Added fix for potential Multiplication overflowJegadeesh Babu1-2/+3
Sonar bug fix Issue-ID: APPC-1438 Change-Id: I5d68c3b9659d8e538bd4a7a6a23aa77c293510f6 Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
2019-02-15Added Test case for General Data ServiceLathishbabu Ganesan1-0/+75
Increased the coverage from 0% to 92% Issue-ID: APPC-1427 Change-Id: I868993463f162da3ea81d9681db109afafb6c90c Signed-off-by: Lathishbabu Ganesan <lathishbabu.ganesan@ericsson.com>
2019-02-15Added test case for Config GeneratorLathishbabu Ganesan1-0/+63
Increased the coverage from 0% to 97% Issue-ID: APPC-1426 Change-Id: I667845ef9b36a85e5be51fd624028063b0f2ea77 Signed-off-by: Lathishbabu Ganesan <lathishbabu.ganesan@ericsson.com>
2019-02-14Check vm-capabilites on vnf-level OS requestsLori Keighron2-2/+22
New per-vm capabilities checking is introduced for vnf-level OpenStack actions Additional changes per initial review. Additional changes in TestVnfc.java per second review. Change-Id: Idd1d834df076c1e525f596b788b69ed63ba9e66b Issue-ID: APPC-1380 Signed-off-by: Lori Keighron <lk2924@att.com>
2019-02-14Code block added to avoid Null pointer ExceptionJegadeesh Babu1-0/+3
Added condition to avoid NullPointer Exception Issue-ID: APPC-1425 Change-Id: I166633ccfcf51a8fcc8d4082aa8d2afa4b299398 Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>