summaryrefslogtreecommitdiffstats
path: root/appc-config/appc-config-adaptor
AgeCommit message (Collapse)AuthorFilesLines
2018-12-11Further fixes for APPC-1270Joss Armstrong2-259/+714
Fixed >100 sonar issues Increased line coverage from 26% to 87% Improved testing Removal of redundant code in class under test Issue-ID: APPC-1270 Change-Id: I63f53f03be815bb951d650df2f77999e5629ad75 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2018-12-06Fix for APPC-1270Joss Armstrong2-219/+318
Reduced testing time from 90 seconds to 2 seconds Removed code smell for multiple instance/static references Added assertions and coverage for success scenarios for all methods Line coverage increased from 55% to 84% Moved construction of objects to protected methods to facilitate testing Issue-ID: APPC-1270 Change-Id: I7945c069c703d2ea3fac9ffa33927856170656c9 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2018-11-12Increment version numberPatrick Brady6-7/+7
Changing to version 1.5.0-SNAPSHOT Change-Id: I1e0773d16cb058ac2fb96718581cfbf8d716a2e0 Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1212
2018-10-11Roll to next version after releasePatrick Brady6-7/+7
Change to version 1.4.1-SNAPSHOT Change-Id: Ie6238743cbe2bebeb122ce3985fb2488d9a6c62e Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1212
2018-10-09Change to released parent pomsPatrick Brady6-6/+6
Change-Id: I298b1ac52c849320b67c649017b3604490a5063b Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1212
2018-10-01Last few pom files missing versionPatrick Brady1-0/+1
Change-Id: I8fbf26f06ea770bae85d0ad4943148225895a885 Signed-off-by: Patrick Brady <pb071s@att.com> Issue-ID: APPC-1208
2018-09-24Add version to pom filesPatrick Brady2-0/+2
Change-Id: Ia7eaffdb1391b0b836a2911395c2b768b4926ef3 Signed-off-by: Patrick Brady <pb071s@att.com> Issue-ID: APPC-1208
2018-09-21Remove logback 1.1.3 security issuePatrick Brady1-1/+11
cdp-pal and eelf are the dependencies using logback-classic 1.1.3. Need to use exclusions option in pom file Change-Id: Id8f5817ec955e2b7b486bc0215c35541086606aa Signed-off-by: Patrick Brady <pb071s@att.com> Issue-ID: APPC-1018
2018-09-11Misplaced shebangs and missing exec flagsNicolas Edel1-2/+2
patch description: Restore of valid shebang lines and exec flags Change-Id: Id44c9d4ac9f2243f478213b34f61a30576ca2235 Issue-ID: APPC-1203 Signed-off-by: Nicolas Edel <nicolas.edel@orange.com>
2018-09-11added test case to ConfigComponentAdaptorTestSandeep J2-0/+59
to increase code coverage Issue-ID: APPC-1086 Change-Id: I49259f114ed7e180c0dd4d71de11da331634dc12 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-09-09added test case to SshJcraftWrapperTestSandeep J1-1/+22
to increase code coverage Issue-ID: APPC-1086 Change-Id: Ic40b87f63f4b14b70870fa717bcf01f206dc982f Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-08-31Remove excess feature filesPatrick Brady1-27/+0
These feature stub files were accidently created, they should not be in these projects. Change-Id: Ib710d4d9be3d2f323ba2e4cfca31b2951777825f Signed-off-by: Patrick Brady <pb071s@att.com> Issue-ID: APPC-1185
2018-08-24Remove old appc-commonRyan Young1-1/+1
Issue-ID: APPC-1159 Change-Id: I65f1bc07fe0088df0624266e6158296ac73884a6 Signed-off-by: Ryan Young <ry303t@att.com>
2018-08-21Revert "resolving logback-classic 1.13"Patrick Brady1-11/+1
Temporary revert to fix failing bundles. This reverts commit 76b6ff1ce84d4c2ab4518dd5f154083b91680245. Change-Id: Ibce5eee91ad8f1bec9b458a52a7f5d25ada85da9 Signed-off-by: Patrick Brady <pb071s@att.com> Issue-ID: APPC-1018 Signed-off-by: Patrick Brady <pb071s@att.com>
2018-08-20resolving logback-classic 1.13 from security issueTaka Cho1-1/+11
cdp-pal and eelf are the jar using logback-classic 1.1.3. need to use exclusions option in pom file Issue-ID: APPC-1018 Change-Id: I00b41f9c366a5ead3f4205cd6fa6b9eb74599767 Signed-off-by: Taka Cho <tc012c@att.com>
2018-08-14Karaf 4 for appc-configPatrick Brady9-118/+209
Change-Id: I3059bf9bca4320d29432b749df6c55aecbdb22e9 Signed-off-by: Patrick Brady <pb071s@att.com> Issue-ID: APPC-1144
2018-08-06updated existing test case to increase coverageSandeep J1-1/+6
updated existing test case to increase code coverage Issue-ID: APPC-1086 Change-Id: I3cec480ee68d5dc1aefd1aa8760ca70b485845b4 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-07-09use try with resourcesKrishnajinka2-38/+38
Issue-ID: APPC-1046 Change-Id: I28ca35b8a888875f91afda05c4dedee3ed301dde Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-06-29Changes to Config Component AdaptorBalaji, Ramya (rb111y)3-5/+61
Issue-ID: APPC-1014 Change-Id: I1ac95c68df92e39678b64919357333cd1664218d Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
2018-06-14Update lic header in appc client and config xmlJohn McClung6-13/+6
Modify license header in appc-adapter xml, appc-client xml and appc-config xml files to reflect 2018 changes. Change-Id: I1b7bd41a43ca5662ed4d293a33f468e443551fd7 Issue-ID: APPC-1000 Signed-off-by: John McClung <jm1364@att.com>
2018-06-11Update license header in misc appc filesJohn McClung8-16/+8
More license header updates to miscellaneous appc files to reflect 2018 changes. Change-Id: I1d1d020792942ffe2d3bbda6eae05c43831ffce1 Issue-ID: APPC-994 Signed-off-by: John McClung <jm1364@att.com>
2018-06-07Fix delimiter string for xml-download CDT actionAlexis de Talhouët1-2/+2
The ssh session is waiting until the </nc:rpc-reply> delimiter is received, but the last item to be sent in the pipe by the device is the trailing ]]>]]> as specified in the command (whether commitCmd or loadConfigurationString). Change-Id: I3a7c5df3f06eb648a0551d7767f90acef533c5ee Issue-ID: APPC-973 Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
2018-06-01Continue removing ECOMP trademark from lic header.John McClung2-4/+3
Remove ECOMP trademark license header in miscellaneous files. Change-Id: I76e386462402cb959de377b56997ecf7986ffd6b Issue-ID: APPC-931 Signed-off-by: John McClung <jm1364@att.com>
2018-05-22Increment version for new branchPatrick Brady4-5/+5
Change from version 1.3.0-SNAPSHOT to 1.4.0-SNAPSHOT and update version file. Change-Id: I6b54c3e3b97c3ef0a554fb173d0dd261ca2107d3 Signed-off-by: Patrick Brady <pb071s@att.com> Issue-ID: APPC-916
2018-05-16Added xmlns to rpc tagBalaji, Ramya (rb111y)1-1/+1
Added the name space specification for the commit sent to the device, to ensure a successful configuration. Issue-ID: APPC-902 Change-Id: Ifd10c182cd2d29a6745d337552ed3294e5b31913 Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
2018-04-11ODL Upgrade Method 2Patrick Brady5-20/+14
Changes necessary to support upgrade to ODL Nitrogen, while continuing to use Karaf 3 style features Change-Id: I2edf619e0b889420c32793b958c0926b0311e71d Signed-off-by: Patrick Brady <pb071s@att.com> Issue-ID: APPC-403
2018-04-09Add junit coverage to TimedOutException classMei Su1-0/+36
Introduce junit-tests for TimedOutException class Issue-ID: APPC-834 Change-Id: If4ba78735064106391d9354b0a7036bd8dd060e6 Signed-off-by: Mei Su <ms6523@att.com>
2018-04-06Add junit coverage to XmlUtil classSam Ollo1-17/+28
Add junit-tests for XmlUtil class Change-Id: I8711f7c0acd8888cbcd869732a7000fdbb168b0e Issue-ID: APPC-832 Signed-off-by: Sam Ollo <so1938@att.com>
2018-04-04Restoring to previous known working versionBalaji, Ramya (rb111y)6-2350/+1753
Discovered muliple issues in the refactored code in these files that has caused failure in existing flow and blocks regression and new feature testing.Reverted class files and UT case files. Issue-ID: APPC-827 Change-Id: I2bdd7f54ab919d0e16c79820ebe0ee4e13dbba03 Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
2018-03-12EncryptionTool unit testsJakub Dudycz1-15/+38
Improved code coverage + some test class refactor. Change-Id: I7e3637c07b580acea383d1ccfd6a0608f69109fe Issue-ID: APPC-722 Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
2018-03-07JUnits for sftp methodsTomek Kaminski2-161/+407
implement unit tests to cover functionality of sftp put and get methods in SshJcraftWrapper.java Change-Id: I238eb1e0816210176da1a1a7874151a624cdbf10 Issue-ID: APPC-676 Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
2018-03-02Unit tests for send methodsTomek Kaminski2-38/+267
Covered functionality of 4 send methods with JUnits Change-Id: I21de5eab799e52899959cf61199a4d185a47268c Issue-ID: APPC-591 Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
2018-02-26Fix Sonar BugTomek Kaminski1-18/+18
Fix for: https://sonar.onap.org/project/issues?id=org.onap.appc%3Aappc&issues=AWGYEYwt8TZzbCgU6gOm&open=AWGYEYwt8TZzbCgU6gOm Change-Id: I632c21efb8e69c04fc346841900d98d4908b360e Issue-ID: APPC-668 Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
2018-02-22EELF logging with error codesTomek Kaminski2-46/+49
Introduced error codes in error logging for compilancy with ONAP logging guidelines Change-Id: If0418a1ea8d91ea84be251df10ca81402fb78b41 Issue-ID: APPC-428 Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
2018-02-22ConfigComponentAdaptor sonar fixes part 2Jakub Dudycz4-204/+258
Change-Id: I1eab3df281f394337fe33c0df07ff26da4302cbd Issue-ID: APPC-648 Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
2018-02-22ConfigComponentAdaptor sonar fixes part 1Jakub Dudycz1-158/+188
Change-Id: I8fdd18225315a936df393fd7e900e9ef2e499122 Issue-ID: APPC-648 Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
2018-02-20Update .gitignore with license textSkip Wonnell3-0/+67
Update .gitignore with license text Remove IDE generated files from repository Update .gitignore to ignore IDE Generated files Issue-ID: APPC-637 Change-Id: Ie650e2c6d46d55d06dcc54877533cb3e14be66d6 Signed-off-by: Skip Wonnell <skip@att.com>
2018-02-14JUnits for receiveUntil methodTomek Kaminski2-31/+275
Test for fonctionallity of receiveUntil method in SshJcraftWrapper.java Issue-ID: APPC-560 Change-Id: Ifb23b5cbc8b74ddea77ab9cfd5eb26f84c521a92 Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
2018-02-09JUnits for SshJcraftWrapper.java connectTomek Kaminski5-105/+445
-added coverage for connect methods -extracted channel provider method for connection -fixed and covered closeConnection method -reduced number of unnecessary variables Change-Id: Ibe2b4d0742a0876c2ef18483d93e7510b0b5c7f0 Issue-ID: APPC-523 Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
2018-02-07Removing old name referencesPatrick Brady3-56/+3
Removing references to bvc, att Change-Id: I794861fe40b96c922f6e5c011b2fe5d2c4bc515b Signed-off-by: Patrick Brady <pb071s@att.com> Issue-ID: APPC-292
2018-02-07Update java files with correct license textSkip Wonnell1-6/+8
Change-Id: I95dab947ad10ec85ae4234aa3396dd374e313739 Issue-ID: APPC-575 Signed-off-by: Skip Wonnell <skip@att.com>
2018-02-06Fix in EncryptionToolburdziak1-1/+1
Change-Id: I024d0fe9cddb63d47561a1586ebd596f76dd83e0 Issue-ID: APPC-554 Signed-off-by: burdziak <olaf.burdziakowski@nokia.com>
2018-02-01Use EELFLogger inside ConfigComponentAdaptorMichal Kabaj3-315/+96
Remove DebugLog implementation and replace its usage with EELFLogger. Change-Id: Id98a398f4fa4f2131d6a1005932a248b5332f356 Issue-ID: APPC-539 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-01-25Fix sonar issues and restore java style formatMichal Kabaj3-1021/+974
Reformat code according to Java Code Guidelines. Refactor of DebugLog test + new JUnits Change-Id: I4f8f03d133180f9315ab596e1093f44582d08068 Issue-ID: APPC-417 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-01-25Sonar fixes in CCAActivatorwejs1-19/+1
Change-Id: I27643c8f8cf0a97b5e6bf374aee1388386f88db0 Issue-ID: APPC-454 Signed-off-by: wejs <maciej.wejs@nokia.com>
2018-01-22Move to EELF loggingTomek Kaminski2-427/+245
Changed all logs to use EELF framework without i18n Fixed another several sonar majors Change-Id: I4754a4428bcbb92170de63e34fc5c9c5cb34d9e9 Issue-ID: APPC-428 Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
2018-01-18Fix several sonar issues in SshJcraftWrapper.javaTomek Kaminski1-217/+174
Fix https://sonar.onap.org/issues/search#issues=AWDAtKQQ-08if2a6wtwt Fix https://sonar.onap.org/issues/search#issues=AWDAtKQU-08if2a6wtxU Fix https://sonar.onap.org/issues/search#issues=AWDAtKQP-08if2a6wtwp Fix variable naming and cleanup unused variables Change-Id: I7bd73035039d82ffbe2248df43006544d3e9ee10 Issue-ID: APPC-407 Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
2018-01-17Add/update license text part 3Skip Wonnell11-245/+373
Convert some file formats from dos to unix Change-Id: Iab31d84016c84bf03df7fdc8cf0c163c23091a88 Issue-ID: APPC-398 Issue-ID: APPC-305 Signed-off-by: Skip Wonnell <skip@att.com>
2018-01-12Add missing license text to pom files, part 1Skip Wonnell3-1/+43
Change-Id: I57a7d2956869519137679550459b001f29992ec2 Issue-ID: APPC-398 Signed-off-by: Skip Wonnell <skip@att.com>
2018-01-11Fix sonar blockerTomek Kaminski1-8/+14
Fix https://sonar.onap.org/issues/search#issues=AWBUkk54-08if2a6vTdT Change-Id: Ic50564d4d47d76ac9bfa83b8ecd6f3d23f11904c Issue-ID: APPC-383 Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>