summaryrefslogtreecommitdiffstats
path: root/appc-config/appc-config-adaptor/provider/src
AgeCommit message (Collapse)AuthorFilesLines
2019-03-27ConfigComponentAdaptor.java - Sonar FixesDriptaroop Das1-25/+10
ConfigComponentAdaptor.java - Sonar Fixes Issue-ID: APPC-1560 Change-Id: Ia22fc64e378ffb3a206eed256f0a9ab7365381cd Signed-off-by: Driptaroop Das <driptaroop.das@in.ibm.com>
2019-03-21Modified code to avoid Null pointer excJegadeesh Babu1-1/+1
Sonar fix Issue-ID: APPC-1547 Change-Id: Ie242256130f255a05366774516cf503c2a3d47cc Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
2019-03-01Test coverage in ConfigComponentAdaptorJoss Armstrong2-884/+909
Increased coverage from 79% to 89% Fixed indentation Issue-ID: APPC-1497 Change-Id: I9cee309b916eff93887a8d2b7691f9a7c6ba204b Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-26Fix for timeout error when logging >1MB dataJoss Armstrong2-5/+49
Potentially large logs moved to TRACE level, INFO level logs limited in size and related tests updated Issue-ID: APPC-1489 Change-Id: I9ea85e64380479d835da03ed2af3e4ab96ece67e Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-26Test coverage for CCAActivatorJoss Armstrong4-7/+153
Increased coverage from 0% to 93% Issue-ID: APPC-1497 Change-Id: Ie78ac50a08b47cac9bedb9d34b089ac3ad23ab22 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-21Removed prinstackTraceJegadeesh Babu1-2/+2
Sonar fix Issue-ID: APPC-1475 Change-Id: I0330868328589dded0db6afa7ae2fe75f0b6ada0 Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
2019-02-15Added fix for potential Multiplication overflowJegadeesh Babu1-2/+3
Sonar bug fix Issue-ID: APPC-1438 Change-Id: I5d68c3b9659d8e538bd4a7a6a23aa77c293510f6 Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
2019-02-11Removed PrintStackTrace SshJcraftWrapper.javaSudarshan Kumar1-7/+6
Removed PrintStackTrace SshJcraftWrapper.java Issue-ID: APPC-1399 Change-Id: Ice16de4fd8d997643d4dea73a4ebacc75f2b2d49 Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
2019-02-05Junit test class added for TemplateException.javaSudarshan Kumar1-0/+50
Junit test class added for TemplateException.java Issue-ID: APPC-1372 Change-Id: I94d97e4b173c51a34a0320f3e24761582fc39101 Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
2019-02-05added test file to cover TemplateException.javaSandeep J1-0/+34
to increase code coverage Issue-ID: APPC-1086 Change-Id: I21877b15110502d75b05fa57eb179fb462e1e755 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2019-01-17added test cases to ConfigComponentAdaptorTestSandeep J1-1/+13
to increase code coverage Issue-ID: APPC-1086 Change-Id: I41734fcfc86da21114daacedaab02fbb2de86504 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-12-11Further fixes for APPC-1270Joss Armstrong2-259/+714
Fixed >100 sonar issues Increased line coverage from 26% to 87% Improved testing Removal of redundant code in class under test Issue-ID: APPC-1270 Change-Id: I63f53f03be815bb951d650df2f77999e5629ad75 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2018-12-06Fix for APPC-1270Joss Armstrong2-219/+318
Reduced testing time from 90 seconds to 2 seconds Removed code smell for multiple instance/static references Added assertions and coverage for success scenarios for all methods Line coverage increased from 55% to 84% Moved construction of objects to protected methods to facilitate testing Issue-ID: APPC-1270 Change-Id: I7945c069c703d2ea3fac9ffa33927856170656c9 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2018-09-11added test case to ConfigComponentAdaptorTestSandeep J2-0/+59
to increase code coverage Issue-ID: APPC-1086 Change-Id: I49259f114ed7e180c0dd4d71de11da331634dc12 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-09-09added test case to SshJcraftWrapperTestSandeep J1-1/+22
to increase code coverage Issue-ID: APPC-1086 Change-Id: Ic40b87f63f4b14b70870fa717bcf01f206dc982f Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-08-06updated existing test case to increase coverageSandeep J1-1/+6
updated existing test case to increase code coverage Issue-ID: APPC-1086 Change-Id: I3cec480ee68d5dc1aefd1aa8760ca70b485845b4 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-07-09use try with resourcesKrishnajinka2-38/+38
Issue-ID: APPC-1046 Change-Id: I28ca35b8a888875f91afda05c4dedee3ed301dde Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-06-29Changes to Config Component AdaptorBalaji, Ramya (rb111y)3-5/+61
Issue-ID: APPC-1014 Change-Id: I1ac95c68df92e39678b64919357333cd1664218d Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
2018-06-11Update license header in misc appc filesJohn McClung8-16/+8
More license header updates to miscellaneous appc files to reflect 2018 changes. Change-Id: I1d1d020792942ffe2d3bbda6eae05c43831ffce1 Issue-ID: APPC-994 Signed-off-by: John McClung <jm1364@att.com>
2018-06-07Fix delimiter string for xml-download CDT actionAlexis de Talhouët1-2/+2
The ssh session is waiting until the </nc:rpc-reply> delimiter is received, but the last item to be sent in the pipe by the device is the trailing ]]>]]> as specified in the command (whether commitCmd or loadConfigurationString). Change-Id: I3a7c5df3f06eb648a0551d7767f90acef533c5ee Issue-ID: APPC-973 Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
2018-06-01Continue removing ECOMP trademark from lic header.John McClung2-4/+3
Remove ECOMP trademark license header in miscellaneous files. Change-Id: I76e386462402cb959de377b56997ecf7986ffd6b Issue-ID: APPC-931 Signed-off-by: John McClung <jm1364@att.com>
2018-05-16Added xmlns to rpc tagBalaji, Ramya (rb111y)1-1/+1
Added the name space specification for the commit sent to the device, to ensure a successful configuration. Issue-ID: APPC-902 Change-Id: Ifd10c182cd2d29a6745d337552ed3294e5b31913 Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
2018-04-11ODL Upgrade Method 2Patrick Brady2-7/+6
Changes necessary to support upgrade to ODL Nitrogen, while continuing to use Karaf 3 style features Change-Id: I2edf619e0b889420c32793b958c0926b0311e71d Signed-off-by: Patrick Brady <pb071s@att.com> Issue-ID: APPC-403
2018-04-09Add junit coverage to TimedOutException classMei Su1-0/+36
Introduce junit-tests for TimedOutException class Issue-ID: APPC-834 Change-Id: If4ba78735064106391d9354b0a7036bd8dd060e6 Signed-off-by: Mei Su <ms6523@att.com>
2018-04-06Add junit coverage to XmlUtil classSam Ollo1-17/+28
Add junit-tests for XmlUtil class Change-Id: I8711f7c0acd8888cbcd869732a7000fdbb168b0e Issue-ID: APPC-832 Signed-off-by: Sam Ollo <so1938@att.com>
2018-04-04Restoring to previous known working versionBalaji, Ramya (rb111y)6-2350/+1753
Discovered muliple issues in the refactored code in these files that has caused failure in existing flow and blocks regression and new feature testing.Reverted class files and UT case files. Issue-ID: APPC-827 Change-Id: I2bdd7f54ab919d0e16c79820ebe0ee4e13dbba03 Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
2018-03-12EncryptionTool unit testsJakub Dudycz1-15/+38
Improved code coverage + some test class refactor. Change-Id: I7e3637c07b580acea383d1ccfd6a0608f69109fe Issue-ID: APPC-722 Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
2018-03-07JUnits for sftp methodsTomek Kaminski2-161/+407
implement unit tests to cover functionality of sftp put and get methods in SshJcraftWrapper.java Change-Id: I238eb1e0816210176da1a1a7874151a624cdbf10 Issue-ID: APPC-676 Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
2018-03-02Unit tests for send methodsTomek Kaminski2-38/+267
Covered functionality of 4 send methods with JUnits Change-Id: I21de5eab799e52899959cf61199a4d185a47268c Issue-ID: APPC-591 Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
2018-02-26Fix Sonar BugTomek Kaminski1-18/+18
Fix for: https://sonar.onap.org/project/issues?id=org.onap.appc%3Aappc&issues=AWGYEYwt8TZzbCgU6gOm&open=AWGYEYwt8TZzbCgU6gOm Change-Id: I632c21efb8e69c04fc346841900d98d4908b360e Issue-ID: APPC-668 Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
2018-02-22EELF logging with error codesTomek Kaminski1-46/+44
Introduced error codes in error logging for compilancy with ONAP logging guidelines Change-Id: If0418a1ea8d91ea84be251df10ca81402fb78b41 Issue-ID: APPC-428 Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
2018-02-22ConfigComponentAdaptor sonar fixes part 2Jakub Dudycz4-204/+258
Change-Id: I1eab3df281f394337fe33c0df07ff26da4302cbd Issue-ID: APPC-648 Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
2018-02-22ConfigComponentAdaptor sonar fixes part 1Jakub Dudycz1-158/+188
Change-Id: I8fdd18225315a936df393fd7e900e9ef2e499122 Issue-ID: APPC-648 Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
2018-02-14JUnits for receiveUntil methodTomek Kaminski2-31/+275
Test for fonctionallity of receiveUntil method in SshJcraftWrapper.java Issue-ID: APPC-560 Change-Id: Ifb23b5cbc8b74ddea77ab9cfd5eb26f84c521a92 Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
2018-02-09JUnits for SshJcraftWrapper.java connectTomek Kaminski4-105/+440
-added coverage for connect methods -extracted channel provider method for connection -fixed and covered closeConnection method -reduced number of unnecessary variables Change-Id: Ibe2b4d0742a0876c2ef18483d93e7510b0b5c7f0 Issue-ID: APPC-523 Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
2018-02-07Removing old name referencesPatrick Brady2-3/+3
Removing references to bvc, att Change-Id: I794861fe40b96c922f6e5c011b2fe5d2c4bc515b Signed-off-by: Patrick Brady <pb071s@att.com> Issue-ID: APPC-292
2018-02-07Update java files with correct license textSkip Wonnell1-6/+8
Change-Id: I95dab947ad10ec85ae4234aa3396dd374e313739 Issue-ID: APPC-575 Signed-off-by: Skip Wonnell <skip@att.com>
2018-02-06Fix in EncryptionToolburdziak1-1/+1
Change-Id: I024d0fe9cddb63d47561a1586ebd596f76dd83e0 Issue-ID: APPC-554 Signed-off-by: burdziak <olaf.burdziakowski@nokia.com>
2018-02-01Use EELFLogger inside ConfigComponentAdaptorMichal Kabaj3-315/+96
Remove DebugLog implementation and replace its usage with EELFLogger. Change-Id: Id98a398f4fa4f2131d6a1005932a248b5332f356 Issue-ID: APPC-539 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-01-25Fix sonar issues and restore java style formatMichal Kabaj3-1021/+974
Reformat code according to Java Code Guidelines. Refactor of DebugLog test + new JUnits Change-Id: I4f8f03d133180f9315ab596e1093f44582d08068 Issue-ID: APPC-417 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-01-25Sonar fixes in CCAActivatorwejs1-19/+1
Change-Id: I27643c8f8cf0a97b5e6bf374aee1388386f88db0 Issue-ID: APPC-454 Signed-off-by: wejs <maciej.wejs@nokia.com>
2018-01-22Move to EELF loggingTomek Kaminski2-427/+245
Changed all logs to use EELF framework without i18n Fixed another several sonar majors Change-Id: I4754a4428bcbb92170de63e34fc5c9c5cb34d9e9 Issue-ID: APPC-428 Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
2018-01-18Fix several sonar issues in SshJcraftWrapper.javaTomek Kaminski1-217/+174
Fix https://sonar.onap.org/issues/search#issues=AWDAtKQQ-08if2a6wtwt Fix https://sonar.onap.org/issues/search#issues=AWDAtKQU-08if2a6wtxU Fix https://sonar.onap.org/issues/search#issues=AWDAtKQP-08if2a6wtwp Fix variable naming and cleanup unused variables Change-Id: I7bd73035039d82ffbe2248df43006544d3e9ee10 Issue-ID: APPC-407 Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
2018-01-17Add/update license text part 3Skip Wonnell11-245/+373
Convert some file formats from dos to unix Change-Id: Iab31d84016c84bf03df7fdc8cf0c163c23091a88 Issue-ID: APPC-398 Issue-ID: APPC-305 Signed-off-by: Skip Wonnell <skip@att.com>
2018-01-11Fix sonar blockerTomek Kaminski1-8/+14
Fix https://sonar.onap.org/issues/search#issues=AWBUkk54-08if2a6vTdT Change-Id: Ic50564d4d47d76ac9bfa83b8ecd6f3d23f11904c Issue-ID: APPC-383 Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
2018-01-10Fix sonar blockersTomek Kaminski2-36/+34
Fix https://sonar.onap.org/issues/search#issues=AWBUkk6L-08if2a6vTgG Change-Id: I5257f208b4df95129fcadfd5952988d8efdd8203 Issue-ID: APPC-383 Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
2018-01-10Fix sonar blockersTomek Kaminski1-6/+6
Fix https://sonar.onap.org/issues/search#issues=AWBUkk6L-08if2a6vTgF Fix https://sonar.onap.org/issues/search#issues=AWBUkk6L-08if2a6vTgG Change-Id: If5fa742580c59db96e62405fd8b02d34de5656ba Issue-ID: APPC-383 Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
2018-01-09Updates to config adaptor bundleGeorge, Lina (lg941u)2-932/+1019
Issue-ID: APPC-373 Change-Id: I4c7f60c8fd8ab80bc03aab717bb8b30d0240c4bc Signed-off-by: George, Lina (lg941u) <lg941u@att.com>
2018-01-03Reformat code according to Java Code GuidelinesMichal Kabaj8-1438/+1217
Align appc-config-adaptor-provider implementation classes with ONAP and Google Java Style guidelines: K&R Style brackets, 120 column limit, indentation fixes, method and property reorder according to visibility. Change-Id: I079e6d9eec5f400db00c5bf41937ca20dd778e72 Issue-ID: APPC-361 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2017-12-21Fix sonar issues for APPCTaka1-6/+0
Change-Id: I386f6794215eb69b8547fa06193ad78f951b327b Issue-ID: APPC-323 Signed-off-by: Taka <tc012c@att.com>