aboutsummaryrefslogtreecommitdiffstats
path: root/appc-config/appc-config-adaptor/provider/src/main
AgeCommit message (Collapse)AuthorFilesLines
2018-12-11Further fixes for APPC-1270Joss Armstrong1-187/+123
Fixed >100 sonar issues Increased line coverage from 26% to 87% Improved testing Removal of redundant code in class under test Issue-ID: APPC-1270 Change-Id: I63f53f03be815bb951d650df2f77999e5629ad75 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2018-12-06Fix for APPC-1270Joss Armstrong1-29/+40
Reduced testing time from 90 seconds to 2 seconds Removed code smell for multiple instance/static references Added assertions and coverage for success scenarios for all methods Line coverage increased from 55% to 84% Moved construction of objects to protected methods to facilitate testing Issue-ID: APPC-1270 Change-Id: I7945c069c703d2ea3fac9ffa33927856170656c9 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2018-09-11added test case to ConfigComponentAdaptorTestSandeep J1-0/+35
to increase code coverage Issue-ID: APPC-1086 Change-Id: I49259f114ed7e180c0dd4d71de11da331634dc12 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-07-09use try with resourcesKrishnajinka2-38/+38
Issue-ID: APPC-1046 Change-Id: I28ca35b8a888875f91afda05c4dedee3ed301dde Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-06-29Changes to Config Component AdaptorBalaji, Ramya (rb111y)2-5/+22
Issue-ID: APPC-1014 Change-Id: I1ac95c68df92e39678b64919357333cd1664218d Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
2018-06-11Update license header in misc appc filesJohn McClung8-16/+8
More license header updates to miscellaneous appc files to reflect 2018 changes. Change-Id: I1d1d020792942ffe2d3bbda6eae05c43831ffce1 Issue-ID: APPC-994 Signed-off-by: John McClung <jm1364@att.com>
2018-06-07Fix delimiter string for xml-download CDT actionAlexis de Talhouët1-2/+2
The ssh session is waiting until the </nc:rpc-reply> delimiter is received, but the last item to be sent in the pipe by the device is the trailing ]]>]]> as specified in the command (whether commitCmd or loadConfigurationString). Change-Id: I3a7c5df3f06eb648a0551d7767f90acef533c5ee Issue-ID: APPC-973 Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
2018-06-01Continue removing ECOMP trademark from lic header.John McClung1-2/+2
Remove ECOMP trademark license header in miscellaneous files. Change-Id: I76e386462402cb959de377b56997ecf7986ffd6b Issue-ID: APPC-931 Signed-off-by: John McClung <jm1364@att.com>
2018-05-16Added xmlns to rpc tagBalaji, Ramya (rb111y)1-1/+1
Added the name space specification for the commit sent to the device, to ensure a successful configuration. Issue-ID: APPC-902 Change-Id: Ifd10c182cd2d29a6745d337552ed3294e5b31913 Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
2018-04-11ODL Upgrade Method 2Patrick Brady1-5/+4
Changes necessary to support upgrade to ODL Nitrogen, while continuing to use Karaf 3 style features Change-Id: I2edf619e0b889420c32793b958c0926b0311e71d Signed-off-by: Patrick Brady <pb071s@att.com> Issue-ID: APPC-403
2018-04-04Restoring to previous known working versionBalaji, Ramya (rb111y)3-1249/+1606
Discovered muliple issues in the refactored code in these files that has caused failure in existing flow and blocks regression and new feature testing.Reverted class files and UT case files. Issue-ID: APPC-827 Change-Id: I2bdd7f54ab919d0e16c79820ebe0ee4e13dbba03 Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
2018-03-07JUnits for sftp methodsTomek Kaminski1-106/+60
implement unit tests to cover functionality of sftp put and get methods in SshJcraftWrapper.java Change-Id: I238eb1e0816210176da1a1a7874151a624cdbf10 Issue-ID: APPC-676 Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
2018-03-02Unit tests for send methodsTomek Kaminski1-33/+58
Covered functionality of 4 send methods with JUnits Change-Id: I21de5eab799e52899959cf61199a4d185a47268c Issue-ID: APPC-591 Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
2018-02-26Fix Sonar BugTomek Kaminski1-18/+18
Fix for: https://sonar.onap.org/project/issues?id=org.onap.appc%3Aappc&issues=AWGYEYwt8TZzbCgU6gOm&open=AWGYEYwt8TZzbCgU6gOm Change-Id: I632c21efb8e69c04fc346841900d98d4908b360e Issue-ID: APPC-668 Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
2018-02-22EELF logging with error codesTomek Kaminski1-46/+44
Introduced error codes in error logging for compilancy with ONAP logging guidelines Change-Id: If0418a1ea8d91ea84be251df10ca81402fb78b41 Issue-ID: APPC-428 Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
2018-02-22ConfigComponentAdaptor sonar fixes part 2Jakub Dudycz3-127/+161
Change-Id: I1eab3df281f394337fe33c0df07ff26da4302cbd Issue-ID: APPC-648 Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
2018-02-22ConfigComponentAdaptor sonar fixes part 1Jakub Dudycz1-158/+188
Change-Id: I8fdd18225315a936df393fd7e900e9ef2e499122 Issue-ID: APPC-648 Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
2018-02-14JUnits for receiveUntil methodTomek Kaminski1-30/+45
Test for fonctionallity of receiveUntil method in SshJcraftWrapper.java Issue-ID: APPC-560 Change-Id: Ifb23b5cbc8b74ddea77ab9cfd5eb26f84c521a92 Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
2018-02-09JUnits for SshJcraftWrapper.java connectTomek Kaminski2-96/+82
-added coverage for connect methods -extracted channel provider method for connection -fixed and covered closeConnection method -reduced number of unnecessary variables Change-Id: Ibe2b4d0742a0876c2ef18483d93e7510b0b5c7f0 Issue-ID: APPC-523 Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
2018-02-07Removing old name referencesPatrick Brady2-3/+3
Removing references to bvc, att Change-Id: I794861fe40b96c922f6e5c011b2fe5d2c4bc515b Signed-off-by: Patrick Brady <pb071s@att.com> Issue-ID: APPC-292
2018-02-07Update java files with correct license textSkip Wonnell1-6/+8
Change-Id: I95dab947ad10ec85ae4234aa3396dd374e313739 Issue-ID: APPC-575 Signed-off-by: Skip Wonnell <skip@att.com>
2018-02-06Fix in EncryptionToolburdziak1-1/+1
Change-Id: I024d0fe9cddb63d47561a1586ebd596f76dd83e0 Issue-ID: APPC-554 Signed-off-by: burdziak <olaf.burdziakowski@nokia.com>
2018-02-01Use EELFLogger inside ConfigComponentAdaptorMichal Kabaj2-225/+96
Remove DebugLog implementation and replace its usage with EELFLogger. Change-Id: Id98a398f4fa4f2131d6a1005932a248b5332f356 Issue-ID: APPC-539 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-01-25Fix sonar issues and restore java style formatMichal Kabaj2-990/+891
Reformat code according to Java Code Guidelines. Refactor of DebugLog test + new JUnits Change-Id: I4f8f03d133180f9315ab596e1093f44582d08068 Issue-ID: APPC-417 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-01-25Sonar fixes in CCAActivatorwejs1-19/+1
Change-Id: I27643c8f8cf0a97b5e6bf374aee1388386f88db0 Issue-ID: APPC-454 Signed-off-by: wejs <maciej.wejs@nokia.com>
2018-01-22Move to EELF loggingTomek Kaminski1-424/+242
Changed all logs to use EELF framework without i18n Fixed another several sonar majors Change-Id: I4754a4428bcbb92170de63e34fc5c9c5cb34d9e9 Issue-ID: APPC-428 Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
2018-01-18Fix several sonar issues in SshJcraftWrapper.javaTomek Kaminski1-217/+174
Fix https://sonar.onap.org/issues/search#issues=AWDAtKQQ-08if2a6wtwt Fix https://sonar.onap.org/issues/search#issues=AWDAtKQU-08if2a6wtxU Fix https://sonar.onap.org/issues/search#issues=AWDAtKQP-08if2a6wtwp Fix variable naming and cleanup unused variables Change-Id: I7bd73035039d82ffbe2248df43006544d3e9ee10 Issue-ID: APPC-407 Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
2018-01-17Add/update license text part 3Skip Wonnell11-245/+373
Convert some file formats from dos to unix Change-Id: Iab31d84016c84bf03df7fdc8cf0c163c23091a88 Issue-ID: APPC-398 Issue-ID: APPC-305 Signed-off-by: Skip Wonnell <skip@att.com>
2018-01-11Fix sonar blockerTomek Kaminski1-8/+14
Fix https://sonar.onap.org/issues/search#issues=AWBUkk54-08if2a6vTdT Change-Id: Ic50564d4d47d76ac9bfa83b8ecd6f3d23f11904c Issue-ID: APPC-383 Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
2018-01-10Fix sonar blockersTomek Kaminski1-9/+6
Fix https://sonar.onap.org/issues/search#issues=AWBUkk6L-08if2a6vTgG Change-Id: I5257f208b4df95129fcadfd5952988d8efdd8203 Issue-ID: APPC-383 Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
2018-01-10Fix sonar blockersTomek Kaminski1-6/+6
Fix https://sonar.onap.org/issues/search#issues=AWBUkk6L-08if2a6vTgF Fix https://sonar.onap.org/issues/search#issues=AWBUkk6L-08if2a6vTgG Change-Id: If5fa742580c59db96e62405fd8b02d34de5656ba Issue-ID: APPC-383 Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
2018-01-09Updates to config adaptor bundleGeorge, Lina (lg941u)2-932/+1019
Issue-ID: APPC-373 Change-Id: I4c7f60c8fd8ab80bc03aab717bb8b30d0240c4bc Signed-off-by: George, Lina (lg941u) <lg941u@att.com>
2018-01-03Reformat code according to Java Code GuidelinesMichal Kabaj8-1438/+1217
Align appc-config-adaptor-provider implementation classes with ONAP and Google Java Style guidelines: K&R Style brackets, 120 column limit, indentation fixes, method and property reorder according to visibility. Change-Id: I079e6d9eec5f400db00c5bf41937ca20dd778e72 Issue-ID: APPC-361 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2017-12-21Fix sonar issues for APPCTaka1-6/+0
Change-Id: I386f6794215eb69b8547fa06193ad78f951b327b Issue-ID: APPC-323 Signed-off-by: Taka <tc012c@att.com>
2017-12-19Update appc-config-parms to use onap packagingTakamune Cho1-9/+13
Issue-ID: APPC-13 Change-Id: I490847faabfed2e977ee21c0157adf8a790cea65 Signed-off-by: Takamune Cho <tc012c@att.com>
2017-12-13Second part of onap renamePatrick Brady13-0/+0
This is the second commit of the rename. The folder structure is renamed for appc-adapters and appc-config in this commit. Change-Id: Iaa2b8c937ff1ca1b5d1178128961fb115ee65d9b Signed-off-by: Patrick Brady <pb071s@att.com> Issue-ID: APPC-13
2017-12-13First part of onap renamePatrick Brady13-13/+13
This is the first commit of the rename. This commit changes refereces to org.openecomp.appc > org.onap.appc that occur within files. The package folder structure is not changed in this commit. Change-Id: Ic95d749eb99d8a6f4f2b9ee9b06eb41c5cfa7e1c Signed-off-by: Patrick Brady <pb071s@att.com> Issue-ID: APPC-13
2017-10-26Fixing problems with features filesPatrick Brady1-1/+1
In progress. Change-Id: Idb0d3f13eaa89d9241f4c543f1222c14ea288f2f Signed-off-by: Patrick Brady <pb071s@att.com> Issue-id: APPC-296
2017-10-03Changes in pom and features.xml filesDilip kumar Pampana1-954/+988
Issue-ID : APPC-240 Change-Id: I42d2277d73163041ccfebe69897f05ac0314e6a1 Signed-off-by: Dilip kumar Pampana <dp583p@att.com>
2017-09-28Fix Blocker/Critical sonar issuesshashikanth1-1/+1
Fix Blocker/Critical sonar issues in appc module https://sonar.onap.org/component_issues?id=org.openecomp.appc%3Aappc#resolved=false|severities=BLOCKER|fileUuids=AV36PknS89V-MRZU58_g Issue-Id: APPC-186 Change-Id: I50868e7e76f03a724d97889432f2dce53552b36f Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
2017-09-27Fix Blocker/Critical sonar issuesshashikanth1-16/+2
Fix Blocker/Critical sonar issues in appc module https://sonar.onap.org/component_issues?id=org.openecomp.appc%3Aappc#resolved=false|severities=BLOCKER|fileUuids=AV36PknS89V-MRZU58_f Fixed issue Close "FileInputStream". Issue-Id: APPC-186 Change-Id: I2fab5e54735992a4cbf2972628574edd17905fe3 Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
2017-09-26Sonar Blockeramshegokar1-3/+1
Fix Sonar Blocker for resource leak Sonar Link: https://sonar.onap.org/component_issues/index?id=org.openecomp.appc%3Aappc#resolved=false|severities=BLOCKER|rules=squid%3AS2095 Change-Id: Id73e2153b13716706b0dce4204d8c7519850afe5 Issue-ID: APPC-236 Signed-off-by: amshegokar <AS00500801@techmahindra.com>
2017-09-20Fix Blocker/Critical sonar issuesshashikanth1-17/+21
Fix Blocker/Critical sonar issues in appc module https://sonar.onap.org/issues/search#issues=AV36Pm5i89V-MRZU59OH Fixed NullPointerException might be thrown as 'data' is nullable here Issue-Id: APPC-186 Change-Id: I65ee1745f5fd5a7f7ac3365704943b25a9341e8a Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
2017-09-07Change to CCSDK and ODL CarbonPatrick Brady3-4/+4
Change-Id: I49a0f436e366ff4a1b99705fb6bb5e7ba82e6ecc Signed-off-by: Patrick Brady <pb071s@att.com> Issue-Id: [APPC-91] Issue-Id: [APPC-158]
2017-08-24Added New Junit Cases for APPC Design ServicesAnand Chaturvedi5-0/+217
Issue-ID: APPC-168 Change-Id: Ib321bb77af3cb47abfce80d96f50a6b75b34b34e Signed-off-by: Anand Chaturvedi <ac204h@att.com>
2017-08-17Initial commit for appc-config-adaptorSkip Wonnell14-0/+3233
This bundle contains utilities used by config-generator. Change-Id: I04877ebe90536fd57368d00c033189c280e77c90 Signed-off-by: Skip Wonnell <kw5258@att.com> Issue-ID: APPC-67