aboutsummaryrefslogtreecommitdiffstats
path: root/appc-adapters/appc-chef-adapter
AgeCommit message (Collapse)AuthorFilesLines
2019-04-02Used constants to avoid dup of literalsJegadeesh Babu1-5/+7
Sonar fix Issue-ID: APPC-1562 Change-Id: Ic9d14b32f4deac975b46154a2ac8e4664ec11c52 Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
2019-04-02Reordered the modifier as per java standardJegadeesh Babu1-2/+4
Sonar fix Issue-ID: APPC-1563 Change-Id: I9a4b82ca67b5c7f5184457b95c347089de728658 Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
2019-03-27Used constants in the place of dup literalsJegadeesh Babu1-4/+5
Sonar fix Issue-ID: APPC-1557 Change-Id: I4b52b9febabd0fae8aa098004aeba0ef9a085710 Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
2019-03-18Revert "upgrade mapper-asl"Patrick Brady1-11/+0
The old version is a newer version of the dependency. This reverts commit 651430451d2134d14daab15ebae29eccc878b52b. Change-Id: I410e9debc0207c12ffa024ff48a69b5f482006de Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1531
2019-03-18Replaced hardcoded value with constant definedJegadeesh Babu1-2/+4
Sonar fix Issue-ID: APPC-1539 Change-Id: Id3891e50bdf89799d1310b37c80ca920d7bdc02c Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
2019-03-15Revert "upgrade databind artifact"Patrick Brady3-47/+0
Fasterxml databind is being brought in to karaf by opendaylight and trying to force a different version for the appc components is causing class errors. This reverts commit 52cf1a81d591efb2b1ee4b8c5a70b137dfb6c212. Change-Id: I6d0da2ed081e4abd4b83e8b11935ba43bee0e1aa Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1533
2019-03-13upgrade databind artifactTaka Cho3-0/+47
upgrade jackson's databind from 2.8.11.2 to 2.8.11.3 Change-Id: I9bf3ab8021f91f6ed36bdffdacbaeeac78d2e87c Issue-ID: APPC-1533 Signed-off-by: Taka Cho <takamune.cho@att.com>
2019-03-12upgrade mapper-aslTaka Cho1-0/+11
move to 1.9.3 for mapper-asl for securilty vulnerability Change-Id: I9189a59ad96af9a9cd761941ed64ed9eae77743f Issue-ID: APPC-1531 Signed-off-by: Taka Cho <takamune.cho@att.com>
2019-03-12Added loggerJegadeesh Babu1-0/+4
Sonar fix Issue-ID: APPC-1527 Change-Id: Ic2708d67b6f2740ddabe834e56b09c11389b8894 Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
2019-02-25Changes for new odl versionPatrick Brady1-1/+1
Changes required to update to latest opendaylight version. Some powermock tests have been temporarily removed due to an powermock incompatibility. They will be fixed and re-added. Change-Id: I418d44913fcd42423d2d9bd37b189f6301eaab81 Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1370
2019-01-18Update install-feature for pre-installPatrick Brady1-3/+1
Since the feature zip files will be extracted during docker build, the install-features scripts need to be modified so that the script will not fail when the zip file does not exist, since the zip file will have already been unzipped. Change-Id: I441064226db956addae5c2f238114ce3965c13ef Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1337
2019-01-08Change parent version to appc snapshotPatrick Brady6-6/+6
Changing to the current release snapshot version of the appc parents instead of the previous release version. This allows updated changes to parents to be in builds. Change-Id: I6cec484012c2cb48ee1ea7f10fd058d017f00947 Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1304
2019-01-07Update parent pom versionPatrick Brady6-6/+6
Update the parent version to appc parent 1.4.1 Change-Id: I185d086595bed6410f7fd6b8c139cc6300e4467e Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1304
2019-01-03Fixed sonar issue in Utils.javaezhil1-7/+2
Change-Id: I5edf48443c10f08200b0ea376194a9a8fc6dc29a Issue-ID: APPC-1302 Signed-off-by: ezhil <ezhrajam@in.ibm.com>
2018-12-18Sonar Fix: ChefResponse.javaArundathi Patil1-4/+6
Fixed sonar issues/code-smells across this file. Issue-ID: APPC-1279 Change-Id: I50d5de26d69928037882686452aecd3deb6edbec Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
2018-11-28Sonar Fix: ChefApiClientFactory.javaArundathi Patil1-3/+3
Fixed sonar issues/code-smells across this file Issue-ID: APPC-1253 Change-Id: Id1060c34f0b99e906dba618d9ea0aebca0fc1beb Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
2018-11-12Increment version numberPatrick Brady6-6/+6
Changing to version 1.5.0-SNAPSHOT Change-Id: I1e0773d16cb058ac2fb96718581cfbf8d716a2e0 Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1212
2018-10-11Roll to next version after releasePatrick Brady6-6/+6
Change to version 1.4.1-SNAPSHOT Change-Id: Ie6238743cbe2bebeb122ce3985fb2488d9a6c62e Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1212
2018-10-09Change to released parent pomsPatrick Brady6-6/+6
Change-Id: I298b1ac52c849320b67c649017b3604490a5063b Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1212
2018-09-21Remove logback 1.1.3 security issuePatrick Brady1-1/+13
cdp-pal and eelf are the dependencies using logback-classic 1.1.3. Need to use exclusions option in pom file Change-Id: Id8f5817ec955e2b7b486bc0215c35541086606aa Signed-off-by: Patrick Brady <pb071s@att.com> Issue-ID: APPC-1018
2018-09-11Misplaced shebangs and missing exec flagsNicolas Edel1-2/+2
patch description: Restore of valid shebang lines and exec flags Change-Id: Id44c9d4ac9f2243f478213b34f61a30576ca2235 Issue-ID: APPC-1203 Signed-off-by: Nicolas Edel <nicolas.edel@orange.com>
2018-08-29upgrade bcprov 1.59 to 1.60 to fix security issueTaka Cho1-0/+5
on chef-adapter, I added a dependency to resolve bcprov-1.59 security issue from Nexus IQ report Change-Id: I238664499becf3a969a7c88ac5a0e7cd2da2aa61 Issue-ID: APPC-1018 Signed-off-by: Taka Cho <tc012c@att.com>
2018-08-24Remove old appc-commonRyan Young1-1/+1
Issue-ID: APPC-1159 Change-Id: I65f1bc07fe0088df0624266e6158296ac73884a6 Signed-off-by: Ryan Young <ry303t@att.com>
2018-08-21Revert "resolving logback-classic 1.13"Patrick Brady1-13/+1
Temporary revert to fix failing bundles. This reverts commit 76b6ff1ce84d4c2ab4518dd5f154083b91680245. Change-Id: Ibce5eee91ad8f1bec9b458a52a7f5d25ada85da9 Signed-off-by: Patrick Brady <pb071s@att.com> Issue-ID: APPC-1018 Signed-off-by: Patrick Brady <pb071s@att.com>
2018-08-20resolving logback-classic 1.13 from security issueTaka Cho1-1/+13
cdp-pal and eelf are the jar using logback-classic 1.1.3. need to use exclusions option in pom file Issue-ID: APPC-1018 Change-Id: I00b41f9c366a5ead3f4205cd6fa6b9eb74599767 Signed-off-by: Taka Cho <tc012c@att.com>
2018-08-19fixing common-collection 3.2.1 security issueTaka Cho1-1/+5
changed pom.xml and features.xml to keep common-collection to 3.2.2 Change-Id: I3ccd44d61f2e58edae9de6d7042cdb752bbd73cb Issue-ID: APPC-1018 Signed-off-by: Taka Cho <tc012c@att.com>
2018-08-17upgrade bcprov to 1.60Taka Cho1-2/+2
upgrade bcprov to 1.60 to avoid security issue Change-Id: I10b20adbcceed68a74ac49dec7a6ade64d34d33c Issue-ID: APPC-1018 Signed-off-by: Taka Cho <tc012c@att.com>
2018-08-13Karaf 4 for first few featuresPatrick Brady7-164/+192
appc-metric appc-dmaap-adapter appc-chef-adapter appc-netconf-adapter appc-rest-adapter Change-Id: I1d5a8e39cac7be74b05a0782f0971f8d08c8162d Signed-off-by: Patrick Brady <pb071s@att.com> Issue-ID: APPC-1029
2018-06-21chef adapter changes for pushjob status nodescheckModaboina, Kusumakumari (km583p)3-79/+120
Issue-ID: APPC-1012 Change-Id: Iac03825b092f62a8d3747a62303f7869bc8280e8 Signed-off-by: Modaboina, Kusumakumari (km583p) <km583p@us.att.com>
2018-06-14Update license header on appc-adapter xml filesJohn McClung6-12/+6
Modify license header on appc-adapter xml and .code_styling xml files to reflect 2018 changes. I also had to fix the xml_version line syntax for the .code_styling xml files. Change-Id: I361f64d3d6edbf43b6c7ae06611f64ee183b7d82 Issue-ID: APPC-999 Signed-off-by: John McClung <jm1364@att.com>
2018-06-13More updates to lic header in appc propertiesJohn McClung2-4/+2
License header fixes to reflect 2018 changes in various appc-adapters, appc-client, appc-common, appc-config, appc-dg and appc-directed-graph java and properties files. Change-Id: Idbe000f175e11ba42f6e83689a2b2d3d353be008 Issue-ID: APPC-996 Signed-off-by: John McClung <jm1364@att.com>
2018-06-01Unit test for ChefApiClientImplTestMichal Kabaj1-3/+15
-Add new JUnits to ChefApiClientImplTest to check if body is properly set for put/post http requests. Change-Id: Ie9ea2de7a1c68fa12815586a4f85646b06ce69a9 Issue-ID: APPC-879 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-06-01Continue removing ECOMP trademark from lic header.John McClung5-12/+5
Remove ECOMP trademark license header in miscellaneous files. Change-Id: I76e386462402cb959de377b56997ecf7986ffd6b Issue-ID: APPC-931 Signed-off-by: John McClung <jm1364@att.com>
2018-05-22Increment version for new branchPatrick Brady4-4/+4
Change from version 1.3.0-SNAPSHOT to 1.4.0-SNAPSHOT and update version file. Change-Id: I6b54c3e3b97c3ef0a554fb173d0dd261ca2107d3 Signed-off-by: Patrick Brady <pb071s@att.com> Issue-ID: APPC-916
2018-04-27Fixes for Chef Adapter bundleWonnell, Skip (kw5258)9-62/+116
Programatically configure values for truststore and password when initializing the HttpClient. Update post and put methods to set entity Add organization into request URI Restore log messages to original values Issue-ID: APPC-868 Change-Id: Ia0fdf13fcb1e3ad91a4d2c5ce704523562191379 Signed-off-by: Wonnell, Skip (kw5258) <kw5258@att.com>
2018-04-25ChefAdapterImpl junitsTomasz Gwozdecki2-8/+58
-Added junit tests for fetchResults method -Support for Michal Kabaj as part of APPC-437 Change-Id: I3219a5ec0ffd530338ce364f608a9706d5a92c03 Issue-ID: APPC-858 Signed-off-by: Tomasz Gwozdecki <tomasz.gwozdecki@nokia.com>
2018-04-11ODL Upgrade Method 2Patrick Brady2-9/+7
Changes necessary to support upgrade to ODL Nitrogen, while continuing to use Karaf 3 style features Change-Id: I2edf619e0b889420c32793b958c0926b0311e71d Signed-off-by: Patrick Brady <pb071s@att.com> Issue-ID: APPC-403
2018-04-06ChefAdapterImpl junitsMichal Kabaj1-0/+40
-Add new JUnits to ChefAdapterImplVNFCOperationsTest Change-Id: Idd4cd456d6409a499e569c7175d97642fc3607d2 Issue-ID: APPC-437 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-03-26ChefAdapterImpl junitsMichal Kabaj2-4/+77
-Add new JUnits to ChefAdapterImplVNFCOperationsTest -remove unused JSONException catch clause from ChefAdapterImpl, when there is no jackson lib used Change-Id: I96b8d6155ca13087b697a19e1fcbba2ee82a8291 Issue-ID: APPC-437 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-03-23ChefAdapterImpl cleanupMichal Kabaj2-301/+24
- Switched usage of RequestContext class for wrapping the SvcLogicContext to using the SvcLogicContext directly - Removed unused RequestContext class Change-Id: I7376e3d6f5602887cf5a25f1f90ff45805c620b2 Issue-ID: APPC-437 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-03-23ChefAdapterImpl junitsMichal Kabaj1-7/+110
Add new JUnits to ChefAdapterImplVNFCOperationsTest Change-Id: I243b2f46fdb75ad3c689b7875361fb9a654eaf60 Issue-ID: APPC-437 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-03-22ChefAdapterImpl junitsMichal Kabaj2-29/+209
- Added new Junit class ChefAdapterImplVNFCOperationsTest - Added unit tests for method vnfcEnvironment - Small refactor to for exception handling in vnfcEnvironment method to improve readability and avoid catching and rethrowing same exception Change-Id: I58a43390ff45598f6d17da48eed3620667008cb7 Issue-ID: APPC-437 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-03-20ChefAdapterImpl JunitsMichal Kabaj2-20/+138
- Added new Unit tests for ChefAdapterImpl checkPushJob method to class ChefAdapterImplJobPusherTest - Added param check in implementation method - Small refactor of nested conditions for improved readability Change-Id: Id65b897535874eea6aafda66b7ac227832446cf4 Issue-ID: APPC-437 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-03-16ChefAdapterImpl JunitsMichal Kabaj3-11/+135
-Added new Unit tests for ChefAdapterImpl pushJob method -Added new Junit class ChefAdapterImplJobPusher -Some minor construction refactor in other junits Change-Id: Id6fbcba2c5f5e11bfad2c7dccf6c06f777756a47 Issue-ID: APPC-437 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-03-16ChefAdapterImpl- checkInfo junitsTomasz Gwozdecki1-1/+44
-Added junit tests for checkInfo method to verify if input params are present -Support for Michal Kabaj as part of APPC-437 Change-Id: I29758f29f32354439ea0471e1afa3df6bb8184b9 Issue-ID: APPC-437 Signed-off-by: Tomasz Gwozdecki <tomasz.gwozdecki@nokia.com>
2018-03-13ChefAdapterImpl JunitsMichal Kabaj5-170/+85
-Added new Unit tests for ChefAdapterImpl#trigger method -Refactored ChefAdapterFactory to allow mock injection -Added new create() method to ChefApiClientFactory which does not set any Chef specific headers for the purpose of trigger method -Cleaned up the trigger method - simplified usage, removed useless doFailure method and inlined its logic and unified HttClient usage -> HttpClient is not used directly but through existing ChefApiClient -removed redundant TestChefAdapterImpl tests which have already been rewritten Change-Id: I830d203877224aa2c5e1b0dff39d1171f1f2f0ef Issue-ID: APPC-437 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-03-12Decouple ChefApiClientImpl from header creationMichal Kabaj4-21/+42
Introduce new FunctionalInterface HttpHeaderFactory to allow customization of http header providers when creating ChefApiClientImpl using ChefApiClientFactory This allows for better encapsulation of header specific values such as: userId,organizations,pemPath. Change-Id: Iec2c7cff8e664a18e15d7e973920152fdb158c98 Issue-ID: APPC-437 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-03-09ChefAdapterImpl JUnitsMichal Kabaj10-36/+316
-Added unit tests for chefXXX methods - extracted new test class -Moved privateKeyCheck method to new class PrivateKeyChecker + JUnits -New Factory class ChefAdapterFactory for ChefAdapterImpl construction -Fixed potential bug with wrong String being assigned in iniSvcLogic method Change-Id: I27badfd01bfaa807b8ecb9b4a4c13e7f026e34af Issue-ID: APPC-437 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-03-08upgrade bcprov to 1.56Taka Cho1-2/+2
there are two versions: 1.55 and 1.47 to be upgraded to 1.56 Change-Id: Ib12c5798e4a53b2c75be448f0e855d61bf168a38 Issue-ID: APPC-708 Signed-off-by: Taka Cho <tc012c@att.com>
2018-03-08upgrade httpclient from 4.5.1 to 4.5.3Taka Cho1-1/+1
Change-Id: I951cc53b6f319bdb9eba25ecdeaffaae5702fbc2 Issue-ID: APPC-703 Signed-off-by: Taka Cho <tc012c@att.com>