aboutsummaryrefslogtreecommitdiffstats
path: root/appc-adapters/appc-chef-adapter
AgeCommit message (Collapse)AuthorFilesLines
2018-04-06ChefAdapterImpl junitsMichal Kabaj1-0/+40
-Add new JUnits to ChefAdapterImplVNFCOperationsTest Change-Id: Idd4cd456d6409a499e569c7175d97642fc3607d2 Issue-ID: APPC-437 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-03-26ChefAdapterImpl junitsMichal Kabaj2-4/+77
-Add new JUnits to ChefAdapterImplVNFCOperationsTest -remove unused JSONException catch clause from ChefAdapterImpl, when there is no jackson lib used Change-Id: I96b8d6155ca13087b697a19e1fcbba2ee82a8291 Issue-ID: APPC-437 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-03-23ChefAdapterImpl cleanupMichal Kabaj2-301/+24
- Switched usage of RequestContext class for wrapping the SvcLogicContext to using the SvcLogicContext directly - Removed unused RequestContext class Change-Id: I7376e3d6f5602887cf5a25f1f90ff45805c620b2 Issue-ID: APPC-437 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-03-23ChefAdapterImpl junitsMichal Kabaj1-7/+110
Add new JUnits to ChefAdapterImplVNFCOperationsTest Change-Id: I243b2f46fdb75ad3c689b7875361fb9a654eaf60 Issue-ID: APPC-437 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-03-22ChefAdapterImpl junitsMichal Kabaj2-29/+209
- Added new Junit class ChefAdapterImplVNFCOperationsTest - Added unit tests for method vnfcEnvironment - Small refactor to for exception handling in vnfcEnvironment method to improve readability and avoid catching and rethrowing same exception Change-Id: I58a43390ff45598f6d17da48eed3620667008cb7 Issue-ID: APPC-437 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-03-20ChefAdapterImpl JunitsMichal Kabaj2-20/+138
- Added new Unit tests for ChefAdapterImpl checkPushJob method to class ChefAdapterImplJobPusherTest - Added param check in implementation method - Small refactor of nested conditions for improved readability Change-Id: Id65b897535874eea6aafda66b7ac227832446cf4 Issue-ID: APPC-437 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-03-16ChefAdapterImpl JunitsMichal Kabaj3-11/+135
-Added new Unit tests for ChefAdapterImpl pushJob method -Added new Junit class ChefAdapterImplJobPusher -Some minor construction refactor in other junits Change-Id: Id6fbcba2c5f5e11bfad2c7dccf6c06f777756a47 Issue-ID: APPC-437 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-03-16ChefAdapterImpl- checkInfo junitsTomasz Gwozdecki1-1/+44
-Added junit tests for checkInfo method to verify if input params are present -Support for Michal Kabaj as part of APPC-437 Change-Id: I29758f29f32354439ea0471e1afa3df6bb8184b9 Issue-ID: APPC-437 Signed-off-by: Tomasz Gwozdecki <tomasz.gwozdecki@nokia.com>
2018-03-13ChefAdapterImpl JunitsMichal Kabaj5-170/+85
-Added new Unit tests for ChefAdapterImpl#trigger method -Refactored ChefAdapterFactory to allow mock injection -Added new create() method to ChefApiClientFactory which does not set any Chef specific headers for the purpose of trigger method -Cleaned up the trigger method - simplified usage, removed useless doFailure method and inlined its logic and unified HttClient usage -> HttpClient is not used directly but through existing ChefApiClient -removed redundant TestChefAdapterImpl tests which have already been rewritten Change-Id: I830d203877224aa2c5e1b0dff39d1171f1f2f0ef Issue-ID: APPC-437 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-03-12Decouple ChefApiClientImpl from header creationMichal Kabaj4-21/+42
Introduce new FunctionalInterface HttpHeaderFactory to allow customization of http header providers when creating ChefApiClientImpl using ChefApiClientFactory This allows for better encapsulation of header specific values such as: userId,organizations,pemPath. Change-Id: Iec2c7cff8e664a18e15d7e973920152fdb158c98 Issue-ID: APPC-437 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-03-09ChefAdapterImpl JUnitsMichal Kabaj10-36/+316
-Added unit tests for chefXXX methods - extracted new test class -Moved privateKeyCheck method to new class PrivateKeyChecker + JUnits -New Factory class ChefAdapterFactory for ChefAdapterImpl construction -Fixed potential bug with wrong String being assigned in iniSvcLogic method Change-Id: I27badfd01bfaa807b8ecb9b4a4c13e7f026e34af Issue-ID: APPC-437 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-03-08upgrade bcprov to 1.56Taka Cho1-2/+2
there are two versions: 1.55 and 1.47 to be upgraded to 1.56 Change-Id: Ib12c5798e4a53b2c75be448f0e855d61bf168a38 Issue-ID: APPC-708 Signed-off-by: Taka Cho <tc012c@att.com>
2018-03-08upgrade httpclient from 4.5.1 to 4.5.3Taka Cho1-1/+1
Change-Id: I951cc53b6f319bdb9eba25ecdeaffaae5702fbc2 Issue-ID: APPC-703 Signed-off-by: Taka Cho <tc012c@att.com>
2018-03-06ChefAdapterImpl JUnitsMichal Kabaj3-9/+103
-Added unit testcases for retrieveData method - extracted new test class -Added unit test for combineStrings method Change-Id: I8adcc9d2dc17e4ebf305fc2a8139095d5841a445 Issue-ID: APPC-437 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-03-01security issue jackson-mapper 1.9.12Taka Cho1-1/+1
Change-Id: I89266f7a8dde8bc409f4edc8bdf91195c4249515 Issue-ID: APPC-675 Signed-off-by: Taka Cho <tc012c@att.com>
2018-03-01ChefAdapterImpl JUnitsMichal Kabaj4-37/+89
-Added new ChefAdapterImplTest class for new ChefAdapterImpl JUnits -Added test for nodeObjectBuilder method - JSON Format is now verified using JSONObject -Unified ChefAdapterImpl construction - removed unused constructors Change-Id: I63f96bac0129b5f13d34efd3a173784e0b1d8a5d Issue-ID: APPC-437 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-02-23ChefApiClient Package Reorganization and cleanupMichal Kabaj17-358/+44
-Reorganize ChefApiClient classes according to their usage, construction and implementation. -Introduce api and impl packages. -Extract interface from ChefApiClient impl -Remove unused old chefapi.* classes Change-Id: Ic1ddbdcfd0e1bbc0830b923da5aac5b68ac44a2f Issue-ID: APPC-437 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-02-20Update .gitignore with license textSkip Wonnell4-1/+89
Update .gitignore with license text Remove IDE generated files from repository Update .gitignore to ignore IDE Generated files Issue-ID: APPC-637 Change-Id: Ie650e2c6d46d55d06dcc54877533cb3e14be66d6 Signed-off-by: Skip Wonnell <skip@att.com>
2018-02-20Update .properties and .xml files with licenseSkip Wonnell1-0/+21
Change-Id: I551f9e9033de2f13028f28ad434003d61102d54f Issue-ID: APPC-637 Signed-off-by: Skip Wonnell <skip@att.com>
2018-02-19ChefApiClient JUnitsMichal Kabaj11-221/+747
Add(fix) JUnits for ChefApiClient + refactor. Junits work on mocked HttpClient instead of attempting to make real calls. All ChefApiClient methods are now tested. Improve readability and refactored the ChefApiClient flow (simplified). Heavily improved SRP in both ChefApiClient and Api request creation. Change-Id: I997490bf269e7d78b741baf7f8d5d7bf64f6b99a Issue-ID: APPC-437 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-02-09ChefAdapterImpl sonar fixesJakub Dudycz1-70/+69
Change-Id: I3e1a496e18a4b9e6e9dc954bc16fb4af991fd5d3 Issue-ID: APPC-579 Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
2018-02-07Change url being used in chef testPatrick Brady1-1/+1
The domain that was being used for the chef test was a real url. The test failed most of the time. Setting it to localhost. Change-Id: I7c162b313b78e174ca3845920dfa88a7004983d5 Signed-off-by: Patrick Brady <pb071s@att.com> Issue-ID: APPC-556
2018-02-07Removing old name referencesPatrick Brady2-2/+2
Removing references to bvc, att Change-Id: I794861fe40b96c922f6e5c011b2fe5d2c4bc515b Signed-off-by: Patrick Brady <pb071s@att.com> Issue-ID: APPC-292
2018-02-07Increase allowed interval in ChefApiClient testSkip Wonnell1-2/+2
Issue-ID: APPC-411 Change-Id: I4936559bfa0cf8dbe89c2a81d464fecc0a49afa0 Signed-off-by: Skip Wonnell <skip@att.com>
2018-02-07ChefActivator JUnitsMichal Kabaj5-42/+137
Add new JUnits for ChefActivator class, minor refactor + cleanup. - Remove redundant getAdapterName() method from ChefAdapter to unify adapter name constant definition Change-Id: I483d34aaa0f4e76a4360b179f1a60cc1263ec9b7 Issue-ID: APPC-437 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-01-25Minor and major fixes in ChefAdapterImplJakub Dudycz2-147/+150
Actually did some other refactor too Change-Id: I4b622018baa2ed130a5904dbc824fc01e82c8a60 Issue-ID: APPC-508 Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
2018-01-25ChefActivator fixesJakub Dudycz1-9/+8
Change-Id: Iddff91573fa5f7cc99171ca0b782415e77560154 Issue-ID: APPC-514 Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
2018-01-25Fix loging in Utilsburdziak1-5/+8
Change-Id: Ibe5250e426bfc3387cbe886be4048f18dbe45c13 Issue-ID: APPC-491 Signed-off-by: burdziak <olaf.burdziakowski@nokia.com>
2018-01-18Reformat and clean up ChefAdapterImpl.javaSkip Wonnell1-426/+345
Fix some Sonar issues Update code to ONAP java style Issue-ID: APPC-419 Change-Id: I0c6b7b684c10b3874c3ef7de40066eb6c3b6345e Signed-off-by: Skip Wonnell <skip@att.com>
2018-01-18Fix bundle name in ChefActivator.javaSkip Wonnell1-1/+1
Issue-ID: APPC-420 Change-Id: Ia55c85cec3024f4199920200e614d60c7822bbbb Signed-off-by: Skip Wonnell <skip@att.com>
2018-01-18fixed some Sonar critical issuesTaka1-2/+0
Change-Id: I9dfe73a45b43919ff7b01ab3217d957a40ac2018 Issue-ID: APPC-408 Signed-off-by: Taka <tc012c@att.com>
2018-01-17Fix random test failure in TestChefApiClientSkip Wonnell2-35/+24
The check of the timestamp header fails when rolling over to a new minute. Change the code to compare the length of the interval instead. Issue-ID: APPC-411 Change-Id: I3a98aab2de878335a2bc320d261fee3101fd0652 Signed-off-by: Skip Wonnell <skip@att.com>
2018-01-09code changes for platform hardening appc adapterskusuma kumari M7-172/+615
Issue-ID: APPC-305 Change-Id: Ice60ca77ffccc409d50ef11318e841c3b1f82ce1 Signed-off-by: kusuma kumari M <km583p@att.com>
2017-12-19Update jaxb-api to 2.2.3 or laterTaka1-1/+1
Issue-ID: APPC-306 Change-Id: I95ba608435bcafff5ea9d960d0295900aa14ebef Signed-off-by: Taka <tc012c@att.com>
2017-12-13Fourth part of onap renamePatrick Brady2-2/+2
Some paths within the docker image need to be updated from opt/openecomp to opt/onap Change-Id: I74b32ba6906a0b7c44764485dccef6140c21afa3 Signed-off-by: Patrick Brady <pb071s@att.com> Issue-ID: APPC-13
2017-12-13Second part of onap renamePatrick Brady17-0/+0
This is the second commit of the rename. The folder structure is renamed for appc-adapters and appc-config in this commit. Change-Id: Iaa2b8c937ff1ca1b5d1178128961fb115ee65d9b Signed-off-by: Patrick Brady <pb071s@att.com> Issue-ID: APPC-13
2017-12-13First part of onap renamePatrick Brady23-158/+158
This is the first commit of the rename. This commit changes refereces to org.openecomp.appc > org.onap.appc that occur within files. The package folder structure is not changed in this commit. Change-Id: Ic95d749eb99d8a6f4f2b9ee9b06eb41c5cfa7e1c Signed-off-by: Patrick Brady <pb071s@att.com> Issue-ID: APPC-13
2017-12-07Fixed several Sonas blockerTaka1-1/+0
Change-Id: Iea0a227957092101094ac99967efdb552453363d Issue-ID: APPC-337 Signed-off-by: Taka <tc012c@att.com>
2017-11-17Bump minor versionJessica Wagantall4-4/+4
Bump minor version in preparation for Amsterdam branching. Change-Id: I83e13547f583db020d6f756ddb8918360c38903b Issue-ID: CIMAN-120 Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org> Signed-off-by: Patrick Brady <pb071s@att.com>
2017-11-07Changing to Amsterdam release versionv1.2.01.0.0-ONAP1.0.0-AmsterdamPatrick Brady4-4/+4
Appc will be realeased as version 1.2.0 since version 1.1.0 already was created spring 2017. Change-Id: I177931e892c2556c11a261f018fd835d62a14d54 Signed-off-by: Patrick Brady <pb071s@att.com> Issue-id: APPC-314
2017-09-18Add Unit Tests for appc-chef-adapterMarcus G K Williams7-79/+218
Issue-Id: APPC-181 Change-Id: Iee824ca929ea46944ac1673e709074687ad812f9 Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
2017-09-15Changing to mariadb java clientPatrick Brady1-6/+3
Changing from the mysql java connector to the mariadb java client. Change-Id: I2f9b1f5da37424d529e196f9b6b8d0bf4f1f9d2f Signed-off-by: Patrick Brady <pb071s@att.com> Issue-id: APPC-198
2017-09-11Correcting problems related to ccsdk,new odlPatrick Brady1-1/+1
Some imports and dependencies needed to be updated which no longer exist in the new ODl version Change-Id: I57c52b73810d3f9770b764a2afe4147d3120a87b Signed-off-by: Patrick Brady <pb071s@att.com> Issue-id: APPC-91 Issue-id: APPC-158
2017-09-07Change to CCSDK and ODL CarbonPatrick Brady8-14/+13
Change-Id: I49a0f436e366ff4a1b99705fb6bb5e7ba82e6ecc Signed-off-by: Patrick Brady <pb071s@att.com> Issue-Id: [APPC-91] Issue-Id: [APPC-158]
2017-09-01Code clean-up in ChefAdapterImpl.javaSkip Wonnell1-116/+67
Fix multiple issues found in Sonar Analysis Issue-ID: APPC-156 Change-Id: I242c45a2eab7c4e31fb42ff9d17405aa3f210147 Signed-off-by: Skip Wonnell <skip@att.com>
2017-08-31Fix sonar blocker in ChefAdpaterSkip Wonnell1-15/+5
Issue-ID: APPC-156 Change-Id: Ic2cbb76bb639094386c14bd06e068c9d5ad7bd0d Signed-off-by: Skip Wonnell <skip@att.com>
2017-08-30ChefAdapter code clean-upSkip Wonnell20-1513/+1359
Issue-ID: APPC-90 Change-Id: I582d6b0c81d5a89938fff6038dfcc221ccaf19c1 Signed-off-by: Skip Wonnell <kw5258@att.com>
2017-08-02Merging in bug fixesPatrick Brady2-60/+95
Change-Id: I85da90b9ba0d03149f42035a820c76ef0285e413 Signed-off-by: Patrick Brady <pb071s@att.com> Issue: APPC-100
2017-07-27Fix resource leak in ChefAdapterImpl.javaSkip Wonnell1-5/+4
Convert to Closeable versions of HttpClient and HttpResponse and instantiate both inside a TWR. Change-Id: I37ac34bab545592f51fb054068065fa1c00f7224 Signed-off-by: Skip Wonnell <kw5258@att.com> Issue: APPC-94
2017-07-20[APPC-93] Resource leak in appc.adapter.chef.chefclient.UtilsSkip Wonnell1-8/+2
Place instantiation of FileReader and BufferedReader inside a TWR Change-Id: Ibc0fffa76e536bdccca92731dc7ebc878faf67a1 Signed-off-by: Skip Wonnell <kw5258@att.com>