summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-03-13ChefAdapterImpl JunitsMichal Kabaj5-170/+85
-Added new Unit tests for ChefAdapterImpl#trigger method -Refactored ChefAdapterFactory to allow mock injection -Added new create() method to ChefApiClientFactory which does not set any Chef specific headers for the purpose of trigger method -Cleaned up the trigger method - simplified usage, removed useless doFailure method and inlined its logic and unified HttClient usage -> HttpClient is not used directly but through existing ChefApiClient -removed redundant TestChefAdapterImpl tests which have already been rewritten Change-Id: I830d203877224aa2c5e1b0dff39d1171f1f2f0ef Issue-ID: APPC-437 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-03-12EncryptionTool unit testsJakub Dudycz1-15/+38
Improved code coverage + some test class refactor. Change-Id: I7e3637c07b580acea383d1ccfd6a0608f69109fe Issue-ID: APPC-722 Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
2018-03-12Decouple ChefApiClientImpl from header creationMichal Kabaj4-21/+42
Introduce new FunctionalInterface HttpHeaderFactory to allow customization of http header providers when creating ChefApiClientImpl using ChefApiClientFactory This allows for better encapsulation of header specific values such as: userId,organizations,pemPath. Change-Id: Iec2c7cff8e664a18e15d7e973920152fdb158c98 Issue-ID: APPC-437 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-03-12Improve coverage FlowControlNode #7kurczews2-47/+97
* refactor & test capabilities data method Change-Id: I523d07e283a347a4ad16f3babc8a25e0dd5a6acc Issue-ID: APPC-440 Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
2018-03-12Unit Test Coverage for ConnectionDetails.javaamshegokar1-0/+63
Unit Test Coverage for ConnectionDetails.java Sonar-Link: https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-dg-common%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fdg%2Fcommon%2Fobjects%2FConnectionDetails.java Change-Id: Ia253f7cea39d980f966f0afc5ab1b64d1e3f527e Issue-ID: APPC-718 Signed-off-by: amshegokar <AS00500801@techmahindra.com>
2018-03-12Unit test Coverage for BundleInfo.javaamshegokar1-0/+64
Unit test Coverage for BundleInfo.java Sonar-Link: https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-dg-mdsal-bundle%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fmdsal%2Fobjects%2FBundleInfo.java Change-Id: I3d0e08b15f362bc00fc8fbbd4d809e88ddc6f792 Issue-ID: APPC-719 Signed-off-by: amshegokar <AS00500801@techmahindra.com>
2018-03-09Adding APPC CDT GuideScott Seabolt41-0/+4037
Initial Draft Issue-ID: APPC-375 Change-Id: I79f453f0451c10fbbe352cf88687eed100f83d65 Signed-off-by: Scott Seabolt <js9808@att.com>
2018-03-09ChefAdapterImpl JUnitsMichal Kabaj10-36/+316
-Added unit tests for chefXXX methods - extracted new test class -Moved privateKeyCheck method to new class PrivateKeyChecker + JUnits -New Factory class ChefAdapterFactory for ChefAdapterImpl construction -Fixed potential bug with wrong String being assigned in iniSvcLogic method Change-Id: I27badfd01bfaa807b8ecb9b4a4c13e7f026e34af Issue-ID: APPC-437 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-03-09Unit test for Workflow Management API classesshubhada3-0/+165
Unit test for Workflow Management API classes Sonar Link: https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-workflow-management-api Change-Id: I641d4b14d213f8369d0b07c92feee49dadbcf70f Issue-ID: APPC-716 Signed-off-by: shubhada <SV00449682@techmahindra.com>
2018-03-09Improve coverage FlowControlNode #6kurczews4-74/+257
* Extract InventoryInfoExtractor as util class * Add test coverage Change-Id: I24f16feddacb6a9898e9c81aa036ba3eafed2967 Issue-ID: APPC-440 Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
2018-03-08upgrade httpclient from 4.5 to 4.5.3Taka Cho2-0/+22
this comes from com.att.nsa.cambriaClient Change-Id: Ib451837526fd6de2a411c530fd3131a26d36473a Issue-ID: APPC-711 Signed-off-by: Taka Cho <tc012c@att.com>
2018-03-08upgrade bcprov to 1.56Taka Cho2-4/+4
there are two versions: 1.55 and 1.47 to be upgraded to 1.56 Change-Id: Ib12c5798e4a53b2c75be448f0e855d61bf168a38 Issue-ID: APPC-708 Signed-off-by: Taka Cho <tc012c@att.com>
2018-03-08upgrade httpclient from 4.5.1 to 4.5.3Taka Cho7-7/+7
Change-Id: I951cc53b6f319bdb9eba25ecdeaffaae5702fbc2 Issue-ID: APPC-703 Signed-off-by: Taka Cho <tc012c@att.com>
2018-03-08Coverage for yang-generator object classshubhada1-0/+81
Unit Test Coverage for Leaf.java Sonar Link: https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-yang-generator%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fyang%2Fobjects Change-Id: I133ffe9688e7b63024d154a8bef2c5559fb546df Issue-ID: APPC-704 Signed-off-by: shubhada <SV00449682@techmahindra.com>
2018-03-07JUnits for sftp methodsTomek Kaminski2-161/+407
implement unit tests to cover functionality of sftp put and get methods in SshJcraftWrapper.java Change-Id: I238eb1e0816210176da1a1a7874151a624cdbf10 Issue-ID: APPC-676 Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
2018-03-06upgrade httpclient from 4.4.1 to 4.5.3Taka Cho1-1/+1
Change-Id: I2f8657097c432e2017ae1287fecc366cb8559076 Issue-ID: APPC-699 Signed-off-by: Taka Cho <tc012c@att.com>
2018-03-06Code changes to processing new group notation typeBalaji, Ramya (rb111y)2-213/+290
Code and Unit Test cases to proces for group notation type existing-value Issue-ID: APPC-621 Change-Id: I8446f5f66c7b240018b0bee00d8b28c6baf673df Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
2018-03-06ChefAdapterImpl JUnitsMichal Kabaj3-9/+103
-Added unit testcases for retrieveData method - extracted new test class -Added unit test for combineStrings method Change-Id: I8adcc9d2dc17e4ebf305fc2a8139095d5841a445 Issue-ID: APPC-437 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-03-06upgrade httpclient from 4.5.2 to 4.5.3Taka Cho1-1/+1
Change-Id: I2cd2eb825a22c48807464d7f7185788fde975981 Issue-ID: APPC-689 Signed-off-by: Taka Cho <tc012c@att.com>
2018-03-06Adding ConfigScaleOut To APP-C Client Libraryvidhyasree3-10/+11
Updating the client library for new action configscaleout based on the updated LCM API Yang model Issue-ID: APPC-478 Change-Id: Ic32f433658be5442e1a5d238a317de85e54fb425 Signed-off-by: vidhyasree <sn141y@att.com>
2018-03-06Improve coverage FlowControlNode #5kurczews3-498/+498
* cleanup formatting shorten constants * Change-Id: Iddc632ae9c3893622c1ba0ce937c2971b792fe37 Issue-ID: APPC-440 Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
2018-03-05Aai Test cases addedDilip kumar Pampana2-2/+32
junits were missed in the code contributions for Beijing for appc-outbound/appc-aai-client Issue-ID: APPC-692 Change-Id: I9bde9cc48e7fa396f2b4ac3af3b181ae03b84143 Signed-off-by: Dilip kumar Pampana <dp583p@att.com>
2018-03-05Unit Test Coverage Part:2amshegokar5-0/+306
Unit Test Coverage for: 1. Snapshot.java 2. Volume.java 3. Volume_.java 4. Template.java 5. SnapshotRestoreResponse.java Sonar Link: https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-iaas-adapter-bundle%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fadapter%2Fopenstack%2Fheat%2Fmodel Change-Id: I18ecc259973bbd3934f9ccd4cc20d897444d9d76 Issue-ID: APPC-686 Signed-off-by: amshegokar <AS00500801@techmahindra.com>
2018-03-05Code changes to retrieve template-idBalaji, Ramya (rb111y)4-41/+162
Functionality to retrieve vf-module and associated model information from A&AI Issue-ID: APPC-623 Change-Id: I9d2e12748641978c689566756a6301808e41b69a Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
2018-03-02ConfigScaleOut flow changesBalaji, Ramya (rb111y)5-99/+319
Code changes and unit test cases to include template id when retrieving vnfc reference data and artifacts from tables. Cleaned up Unit Tests. Issue-ID: APPC-619,APPC-620 Change-Id: I8db08be19b9fa094a07e5c5597c45327824cfb01 Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
2018-03-02Unit tests for send methodsTomek Kaminski2-38/+267
Covered functionality of 4 send methods with JUnits Change-Id: I21de5eab799e52899959cf61199a4d185a47268c Issue-ID: APPC-591 Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
2018-03-02Correct Issue ID APPC LCM GuideScott Seabolt1-33/+92
Previsou submit included an incorrect Issue Id Issue-ID: APPC-657 Change-Id: I11a4a3cd64f52a3c49fa439ee27320b48c6a93bb Signed-off-by: Scott Seabolt <js9808@att.com>
2018-03-02Added missed code to appc-dg-common bundleBalaji, Ramya (rb111y)1-1/+2
Issue-ID: APPC-688 Change-Id: I7cfb5a90005f046336bf7858aa94001bdc5b6b32 Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
2018-03-01security issue jackson-mapper 1.9.12Taka Cho7-7/+7
Change-Id: I89266f7a8dde8bc409f4edc8bdf91195c4249515 Issue-ID: APPC-675 Signed-off-by: Taka Cho <tc012c@att.com>
2018-03-01move powermockito to mocktio appc-clientTaka Cho3-19/+11
Change-Id: I51439e787d3da3d6a785ef6d60712fa71bdb0125 Issue-ID: APPC-677 Signed-off-by: Taka Cho <tc012c@att.com>
2018-03-01 Testcases for Configscaleout actionvidhyasree3-8/+191
Junit testcases for ONAP scaleout feature Issue-ID: APPC-544 Change-Id: I43e211f00e7568cb98e564b1cbf60f96b27c5dfa Signed-off-by: vidhyasree <sn141y@att.com>
2018-03-01Unit test Coverageshubhada2-0/+125
Unit Test Coverage for: 1. EventHeader.java 2. EventStatus.java Sonar Link: https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-message-adapter-api%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fadapter%2Fmessage%2Fevent Change-Id: I6b48fa3ac5af489b24d212ca52bdc1a51b388dbc Issue-ID: APPC-680 Signed-off-by: shubhada <SV00449682@techmahindra.com>
2018-03-01Unit Test Coverageshubhada4-0/+223
Unit Test Coverage for: 1. Data.java 2. CreateSnapshotParams.java 3. Properties.java 4. ResourceData.java Sonar Link: https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-iaas-adapter-bundle%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fadapter%2Fopenstack%2Fheat%2Fmodel Change-Id: I0eeef6216f536483c6b7a45d0847688d6d84fd2f Issue-ID: APPC-685 Signed-off-by: shubhada <SV00449682@techmahindra.com>
2018-03-01ChefAdapterImpl JUnitsMichal Kabaj4-37/+89
-Added new ChefAdapterImplTest class for new ChefAdapterImpl JUnits -Added test for nodeObjectBuilder method - JSON Format is now verified using JSONObject -Unified ChefAdapterImpl construction - removed unused constructors Change-Id: I63f96bac0129b5f13d34efd3a173784e0b1d8a5d Issue-ID: APPC-437 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-03-01Fixes in "appc-dmaap-adapter-bundle"wejs9-119/+578
Correction of Sonar and CheckStyle issues Added JUnit test coverage. Change-Id: I119c7555e33e09c87b572ff0b63f55e2884be75f Issue-ID: APPC-646 Signed-off-by: wejs <maciej.wejs@nokia.com>
2018-03-01appc-dg-common sonar fixes part 2Jakub Dudycz19-251/+294
Sonar fixes in whole module Change-Id: I9d2d7f092fc44217c794ea3a4d4b12b1ad641ff0 Issue-ID: APPC-673 Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
2018-03-01Improve coverage flow/controller/node #4kurczews2-37/+103
Issue-ID: APPC-440 Change-Id: Iee74ce27c3978d265fccc79dacaf8df965768a36 Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
2018-02-28Add missing mockito-core dependencyMichal Kabaj1-0/+4
TestAppcDmaapListenerActivator in appc-event-listener-bundle has compilationissues in development environment due to missing mockito-core test dependency. Change-Id: I1e46bd4866b5c02b06eb71fef9aba08e2b7f1012 Issue-ID: APPC-678 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-02-28Extraction of try catch in ConfigurationFactorykjaniak2-25/+44
Try catch block placed in new private method getClonedDefaultConfiguration, minor changes added, UT for class added. Change-Id: Ic908e6d3a8fe179a2a38d922d10e24cff76a21da Issue-ID: APPC-674 Signed-off-by: kjaniak <kornel.janiak@nokia.com>
2018-02-28appc-dg-common sonar fixes part 1Jakub Dudycz30-332/+377
Initial code refactor and imports rearrangement Change-Id: I4b96f82a4ebc30539872d9678cd5c2badc994256 Issue-ID: APPC-673 Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
2018-02-28roll back the logback versionTaka Cho3-5/+5
Change-Id: I34661e29c605b7731c92412d9c0c57c91583e8a4 Issue-ID: APPC-684 Signed-off-by: Taka Cho <tc012c@att.com>
2018-02-28Code fix for attach and detach volumesPatrick Brady4-430/+436
Cherry-picked to split up commit https://gerrit.onap.org/r/#/c/31149/ into individual jira tickets. open stack consumes cdp-pal openstack jars to connect to cinder, this fix retrives set of volumes from volumeservice provider and performs attach or detach through compute service. Change-Id: I59bce60d9f79ba9285f284fe1f56945e63d0bcba Signed-off-by: Patrick Brady <pb071s@att.com> Signed-off-by: kusuma kumari M <km583p@att.com> Issue-ID: APPC-448
2018-02-27security issue: commons-collectionsTaka Cho12-11/+86
Change-Id: I74a56640065ae6c6a470835ab1022ed0f266fc09 Issue-ID: APPC-665 Signed-off-by: Taka Cho <tc012c@att.com>
2018-02-26Add assertj artifact test dependencyMichal Kabaj1-0/+12
Add new assertion libraries for writing improved unit test assertions in a fluent style manner: - assertj-core - assertj-guava Change-Id: Ifca841a88f91219c13b50f7b80c7e0fe660bea19 Issue-ID: APPC-437 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-02-26appc-network-client-provider sonar fixes part 2Jakub Dudycz14-145/+169
Sonar fixes in whole module Change-Id: If36f6b7762c0caa1ccd4f5c9efa57c08f97a2c87 Issue-ID: APPC-672 Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
2018-02-26appc-network-client-provider sonar fixes part 1Jakub Dudycz13-250/+227
Initial code reformat and imports rearrangement Change-Id: Iacc8f3b4313415da2fb7215dd4a529c1f06de039 Issue-ID: APPC-672 Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
2018-02-26appc-config-generator-provider sonar fixes part 2Jakub Dudycz17-153/+134
Sonar fixes in whole module Change-Id: I55856a6ce73a73098dadb2c5b9428437349ed8a8 Issue-ID: APPC-671 Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
2018-02-26appc-config-generator-provider sonar fixes part 1Jakub Dudycz9-66/+69
Initial code reformat and import rearrangement Change-Id: I0a808bc3043d8558d96f15e0b695fddf5333bab1 Issue-ID: APPC-671 Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
2018-02-26CompareNode sonar fixesJakub Dudycz1-68/+41
Change-Id: Ia467508aa17737caa056b5ed0b6dd28ee4c01a35 Issue-ID: APPC-670 Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
2018-02-26PropertyDefinitionNode sonar fixesJakub Dudycz2-149/+171
Change-Id: Ibc198788f20a8555628d75c785ebcc60908b39db Issue-ID: APPC-664 Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>