summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2019-03-01Test coverage for HttpClientTestJoss Armstrong1-0/+100
Added test coverage for untested class Increased coverage from 0% to 89% Issue-ID: APPC-1520 Change-Id: I113d515df3b6f6ef12565cf390f0bd2f2e8ac2f0 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-03-01Test coverage in RestClientInvokerJoss Armstrong1-0/+120
Added test for untested class Increased test coverage from 0% to 94% Issue-ID: APPC-1520 Change-Id: I51610584cd203f5de7286c325332cade6f3c2bd6 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-03-01Handled exceptionJegadeesh Babu1-0/+3
Sonar fix Issue-ID: APPC-1518 Change-Id: Ia052693a420bbd7b06048336d518a49e598b4265 Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
2019-03-01Handled interrupted exception sonar fixJegadeesh Babu1-5/+10
Sonar fix Issue-ID: APPC-1517 Change-Id: I0a9fb64812c84963b08a53b09358f598d96eb014 Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
2019-03-01Test coverage in ConfigComponentAdaptorJoss Armstrong2-884/+909
Increased coverage from 79% to 89% Fixed indentation Issue-ID: APPC-1497 Change-Id: I9cee309b916eff93887a8d2b7691f9a7c6ba204b Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-03-01Added loggerJegadeesh Babu1-6/+10
Sonar fix Issue-ID: APPC-1513 Change-Id: Ie6a28085288457b8bf8fea5c6d21313e61532f7c Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
2019-02-28Changes for design serviceSonali Das5-18/+123
Issue-ID: APPC-1342 Change-Id: Iff66ff977b7ca6bbe0e83fa467b72d253d9200b8 Signed-off-by: Sonali Das <sd394g@att.com>
2019-02-28Added Junit Class For LicenseModelBuilder.javaSudarshan Kumar1-0/+63
Added Junit Class For LicenseModelBuilder.java Issue-ID: APPC-1372 Change-Id: I9acb703ccec2775c5c64e0be3a14ea93eb85b868 Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
2019-02-28Test coverage in AppcProviderLcmJoss Armstrong2-30/+345
Increased coverage from 74% to 100% Fixed Sonar major issue for branch coverage Issue-ID: APPC-1509 Change-Id: I8d487b295af7930dfcf917970f9806ac37023853 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-28added GetTemplateConfig_Saltstack DGGanesh Chandrasekaran1-0/+638
Issue-ID: APPC-1101 Change-Id: I185caa7cbd23cf5ce7973d74f9b9cde896267433 Signed-off-by: Ganesh Chandrasekaran <ganesh.c@samsung.com>
2019-02-28added new saltstack-adapter-1.0 DGGanesh Chandrasekaran1-0/+275
Issue-ID: APPC-1101 Change-Id: Id5df4a856f73dddcecf7f4751ed07bdfceadf85a Signed-off-by: Ganesh Chandrasekaran <ganesh.c@samsung.com>
2019-02-28Test coverage in RestAdapterImplJoss Armstrong1-95/+77
Increased coverage from 69% to 98% Fixed Sonar major issue for branch coverage Issue-ID: APPC-1512 Change-Id: Idb989cf6266b4e7c7dda1e9bca72483038649eda Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-28Test coverage in TopologyServiceJoss Armstrong2-7/+118
Increased coverage from 80% to 97% Fix Sonar major issue for branch coverage Issue-ID: APPC-1509 Change-Id: I2f5af194b44e5871fc00c9cc12123fa6d6c1fd5d Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-28CachedElement.java - Sonar FixesDriptaroop Das1-7/+6
CachedElement.java - Sonar Fixes Issue-ID: APPC-1508 Change-Id: I24bdb1ab1e3c00975eba4ea92dcf34b8e26849dc Signed-off-by: Driptaroop Das <driptaroop.das@in.ibm.com>
2019-02-28Added test case for Rebuild ServerLathishbabu Ganesan1-0/+26
Issue-ID: APPC-1502 Change-Id: Idff986e1727e13c5a402184b416365328418c7ab Signed-off-by: Lathishbabu Ganesan <lathishbabu.ganesan@ericsson.com>
2019-02-28Test coverage in MockQueryHelperJoss Armstrong3-1/+134
Increased coverage from 17% to 91% Fixed Sonar major issue for branch coverage Issue-ID: APPC-1509 Change-Id: I822053c74db8f16875448206a22048032d30ad45 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-28Added null check to avoid null pointer exceptionJegadeesh Babu1-7/+11
Sonar fix Issue-ID: APPC-1505 Change-Id: Iefd8a45aacb6e8de50c16c36fe9ab551401ca417 Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
2019-02-27Test coverage in ConfigResourceNodeJoss Armstrong4-70/+508
Add >100 lines of coverage and increase from 71% to 99% Increase branch coverage to fix Sonar major issue Extract repeated strings to constants Issue-ID: APPC-1504 Change-Id: Ib3b1e83d39f02befaede035b84a0ebef96b36cfd Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-27Test coverage in FlowControlNodeJoss Armstrong2-93/+130
Increase line coverage from 72% to 92% Fix for Sonar major issue for branch coverage Issue-ID: APPC-1499 Change-Id: Ie73b6c97fcf50421ca6a73a8273c09ace0faf67f Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-27Fix failing powermock testsPatrick Brady16-3/+2623
The version of javassist coming from opendaylight is not working correctly with powermock. Adding a test scoped dependency for a working version of javassist. Test classes added in this commit are not new, they were temporarily removed as part of https://gerrit.onap.org/r/#/c/79046/ Change-Id: I193873c0d4abd7b11592a95bff9a6b07cf2d7191 Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1277
2019-02-27Handled interrupted exceptionJegadeesh Babu1-0/+3
Sonar fix Issue-ID: APPC-1490 Change-Id: I261e2d4739bf5a1d3f11dc1774b04da98a366c16 Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
2019-02-27Test coverage in DBServiceJoss Armstrong2-5/+260
Increase coverage from 71% to 98% Fix for Sonar major issue on branch coverage Issue-ID: APPC-1499 Change-Id: I74261af92b3263a03d29d476ad097182e6112ad9 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-27Test coverage for ObjectFactoryJoss Armstrong1-0/+46
Increase coverage from 0% to 100% Issue-ID: APPC-1499 Change-Id: Ia6209174b99acdeb03698eea9fe96d51a2cccd13 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-27Added test cases for Sequence Generator classLathishbabu Ganesan1-0/+86
Increased the code coverage from 0% to 100% Issue-ID: APPC-1457 Change-Id: Id71298cb482a1c9ca00c3ced9685087e56c249ca Signed-off-by: Lathishbabu Ganesan <lathishbabu.ganesan@ericsson.com>
2019-02-27Added test case for Stack ResourceLathishbabu Ganesan1-0/+51
Increased the coverage from 0% to 100% Issue-ID: APPC-1501 Change-Id: Idb8d7b6efc7831dc0c6ca8094783cbc84ecfd14e Signed-off-by: Lathishbabu Ganesan <lathishbabu.ganesan@ericsson.com>
2019-02-27Additional test case to cover Reboot scenarioLathishbabu Ganesan1-0/+22
Issue-ID: APPC-1507 Change-Id: I1afa62d34bec6cc3bb56abd4fa5ffc9a5beee67a Signed-off-by: Lathishbabu Ganesan <lathishbabu.ganesan@ericsson.com>
2019-02-27Handled interrupted exceptionJegadeesh Babu1-0/+3
Sonar fix Issue-ID: APPC-1506 Change-Id: If1e6e2aee7a2345a8e228e9cd793d02aa6eb685e Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
2019-02-27Added Null checkJegadeesh Babu1-1/+7
Code to avoid null pointer Exception Issue-ID: APPC-1451 Change-Id: I5e2324a2ddffbc50251ee93a1278cfb68e62a551 Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
2019-02-26Line and branch coverage for TransactionJoss Armstrong2-55/+120
Increased line coverage from 54% to 99% Added coverage for 50 branches resolving major Sonar issue Issue-ID: APPC-1499 Change-Id: I10dba08c62247401ee4c9fb08fe65f3854445fb5 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-26Replaced print statement with loggerJegadeesh Babu1-1/+2
Sonar Fix Issue-ID: APPC-1500 Change-Id: I25e885297e3e3881e8164e2bbd6f608f808ac76b Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
2019-02-26Fix unit tests for PrecheckOptionJoss Armstrong1-8/+25
Increased line coverage to 100% Increased branch coverage to clear Sonar major warning Removed console logging and cleaned up assertions Issue-ID: APPC-1499 Change-Id: Ifc7163d2e112914749514099779bd5d75ba729c9 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-26Fixed tests on PreCheck classJoss Armstrong1-10/+23
Replaced console printing with assertions Added branch coverage to clear Sonar major warning Increased line coverage to 100% Issue-ID: APPC-1499 Change-Id: Ia027b9d7f414789816d80e12543d27a0baeed9c1 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-26Fix for timeout error when logging >1MB dataJoss Armstrong6-11/+123
Potentially large logs moved to TRACE level, INFO level logs limited in size and related tests updated Issue-ID: APPC-1489 Change-Id: I9ea85e64380479d835da03ed2af3e4ab96ece67e Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-26Added test case for Attach volume classLathishbabu Ganesan1-2/+18
Issue-ID: APPC-1467 Change-Id: Ifc902979c955df03ab847b4dd770bf737ff69eb9 Signed-off-by: Lathishbabu Ganesan <lathishbabu.ganesan@ericsson.com>
2019-02-26Added test case for Appc ProviderLathishbabu Ganesan1-0/+124
Increased the coverage from 0% to 96% Issue-ID: APPC-1454 Change-Id: I5bfb97101dd7ef5e9c138694b783be8cdd511f0e Signed-off-by: Lathishbabu Ganesan <lathishbabu.ganesan@ericsson.com>
2019-02-26Fix for casting/subclassing in MetricRegistryJoss Armstrong2-11/+40
Put in code to avoid cast exceptions from this class and updated tests Issue-ID: APPC-1480 Change-Id: I8b54d93e52eb523f08d13e874b4d18d05feede6b Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-26Test coverage for CCAActivatorJoss Armstrong4-7/+153
Increased coverage from 0% to 93% Issue-ID: APPC-1497 Change-Id: Ie78ac50a08b47cac9bedb9d34b089ac3ad23ab22 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-26Handled interrupted exception RecheckedJegadeesh Babu1-0/+3
Rechecked sonar fix Issue-ID: APPC-1492 Change-Id: I8cec7e0e0cb5614e959f6eaa35271f55ddbba24b Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
2019-02-26Added logger statementJegadeesh Babu1-1/+6
Sonar vulnerabilty fix Issue-ID: APPC-1498 Change-Id: I29de3443a5a96c4d4bc5c7bab24b4fdb7f3358d3 Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
2019-02-26Test coverage for ParametersJoss Armstrong1-1/+14
Increased coverage to 100% Issue-ID: APPC-1499 Change-Id: I982023d9f818320f709da552d668b68e5ce0f7b3 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-26Test coverage for ActionIdentifierJoss Armstrong1-6/+17
Increased test coverage to 100% Issue-ID: APPC-1499 Change-Id: I78eee1fdc64840898e1b76984855a43828ee93b4 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-26Update GetDevRunningConfig for SaltstackDGGanesh Chandrasekaran1-496/+876
Issue-ID: APPC-1101 Change-Id: Ie3cbfb05b1dd7a1ecc15e0d7b844801769836fab Signed-off-by: Ganesh Chandrasekaran <ganesh.c@samsung.com>
2019-02-26APPC Generic Saltstack DG additionGanesh Chandrasekaran1-0/+491
Issue-ID: APPC-1101 Change-Id: Ie240bb949481a7c59a508c2157a4ace95fe4a861 Signed-off-by: Ganesh Chandrasekaran <ganesh.c@samsung.com>
2019-02-25Changes for new odl versionPatrick Brady64-3208/+277
Changes required to update to latest opendaylight version. Some powermock tests have been temporarily removed due to an powermock incompatibility. They will be fixed and re-added. Change-Id: I418d44913fcd42423d2d9bd37b189f6301eaab81 Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1370
2019-02-25Test coverage in RequestValidatorImplJoss Armstrong2-26/+51
Increased coverage from 78% to 89% Issue-ID: APPC-1485 Change-Id: I2b4e87d0ae9b344ef59005bc19cd2600e4e041e8 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-22Test coverage in ExecuteNodeActionImplJoss Armstrong2-8/+62
Increase coverage from 42% to 92% Issue-ID: APPC-1477 Change-Id: Ic9ef407663d0a79ccec8ed7045230c4d734a3cc4 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-22Test coverage in MetricRegistryImplJoss Armstrong2-11/+65
Added test coverage for MetricRegistryImpl Issue-ID: APPC-1478 Change-Id: I91eff5418ec14d294fa80af3d6d7025338b82072 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-22Test coverage in MessageAdapterImplJoss Armstrong2-11/+113
Added test cases for untested portions of code Issue-ID: APPC-1481 Change-Id: Id61ec5c5824c3d9fecbfb83d47bfa0164ae96759 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-22Test coverage in AbstractRequestHandlerImplJoss Armstrong1-8/+64
Increased coverage from 72% to 95% Issue-ID: APPC-1484 Change-Id: I1bbb8aaf1b7ca33b20d8768cacd14c7bdabe5caa Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-22Test coverage for RequestValidationPolicyJoss Armstrong2-7/+90
Added test cases for untested parts of code Issue-ID: APPC-1482 Change-Id: I3dfa64b4eb1f69a08ca3346d75ae362affd55e0d Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>