summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2019-01-14Fix unit tests in provider-lcm-serviceJoss Armstrong7-912/+92
Increased line coverage from 69% to 87% Removed PrepareForTest annotations for classes under test Issue-ID: APPC-1326 Change-Id: I75be7235f4c13b0f395843907958d7391a333a32 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-01-14Fix VM Snapshot error during image validationJoss Armstrong2-3/+7
prefix image name with 'in:' and surround with quotes to deal with change to Glance that no longer supports image names including colons passed as plain strings Issue-ID: APPC-869 Change-Id: If81accc3edd7b4805eb965b11f466df9654d6010 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-01-11Fixed sonar issue in ProviderAdapterImplezhil1-5/+2
Change-Id: I0a2e6f4ad94ad3c172ca15b0111892d38b188a55 Issue-ID: APPC-1299 Signed-off-by: ezhil <ezhrajam@in.ibm.com>
2019-01-11Fix for unit tests in appc-data-access-libJoss Armstrong2-11/+5
Increased test coverage from 32% to 82% Removed PrepareForTest annotation from class under test Issue-ID: APPC-1324 Change-Id: I58f7e495d0405d994132eea20ebae248d8887238 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-01-11Fix unit test with @PrepareForTest annotationJoss Armstrong1-22/+3
Removed annotation and fixed tests. Increased package line coverage from 50% to 88% Issue-ID: APPC-1323 Change-Id: Iae5441e5e6243755f8ec6ab178668a5c985eaf6a Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-01-11Add code coverage for metric-service-policy codeJoss Armstrong8-50/+188
Increased line coverage from 0% to 79% Issue-ID: APPC-1321 Change-Id: I79f65d97055248b73da875e9591bd2c6e86afca4 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-01-10Added JUNIT test for PreCheckOption.javaezhil1-0/+64
Change-Id: Id50d6b00a1c86ca5a350dc0f5f36f0decc28d413 Issue-ID: APPC-1314 Signed-off-by: ezhil <ezhrajam@in.ibm.com>
2019-01-10Test coverage in appc-dg-sshJoss Armstrong7-188/+356
Increased line coverage from 49% to 93% Issue-ID: APPC-1313 Change-Id: I2f27742fd996cd6d07668fd61c887e29f2140818 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-01-09Test coverage for appc-provider-topologyJoss Armstrong2-20/+14
Increased line coverage from 0% to 86% Issue-ID: APPC-1317 Change-Id: I2297634d50a389c8c250981656e00a9bb2741ea3 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-01-09Added Junit test file for ActionIdentifier.javaezhil1-0/+44
Change-Id: Ia9a2a0df159448354ed094875e5ba16316a87432 Issue-ID: APPC-1315 Signed-off-by: ezhil <ezhrajam@in.ibm.com>
2019-01-09Added test file to Transaction.javaezhil1-0/+107
Change-Id: I75419387c7b36790c5e41f9577672bcb1c65eba4 Issue-ID: APPC-1307 Signed-off-by: ezhil <ezhrajam@in.ibm.com>
2019-01-09Test Coverage in appc-dg-netconfJoss Armstrong6-64/+23
Increased coverage from 22% to 97% Issue-ID: APPC-1311 Change-Id: I631cfdb29e4c374f0f015d3a81b4918eed6894ec Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-01-08Test coverage in appc-dg-mdsal-bundleJoss Armstrong9-31/+325
Increase test coverage from 11% to 77% Issue-ID: APPC-1308 Change-Id: I5cb45e2879bcf97a182687276fdf926f769b0e51 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-01-08Change parent version to appc snapshotPatrick Brady218-219/+219
Changing to the current release snapshot version of the appc parents instead of the previous release version. This allows updated changes to parents to be in builds. Change-Id: I6cec484012c2cb48ee1ea7f10fd058d017f00947 Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1304
2019-01-07Increase unit test coverage in appc-dg-aai projectJoss Armstrong5-15/+321
Increased line coverage from 11% to 93% Issue-ID: APPC-1305 Change-Id: Iab844f4b6a048eee884c92d397c87159d38b0aa5 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-01-07Update parent pom versionPatrick Brady219-220/+221
Update the parent version to appc parent 1.4.1 Change-Id: I185d086595bed6410f7fd6b8c139cc6300e4467e Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1304
2019-01-07Fixes feature install on latest ccsdkPatrick Brady4-55/+6
Updated rest adapter to resolve dependencies the same way that other appc features do. This fixed the karaf crash during install. Added necessary dependencies as embedded or karaf bundles to other appc features, as needed. Change-Id: Id04d08cd09c2ff0cae0db8ecbc61405da10882d7 Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1304
2019-01-04Dependency changes to overcomeBalaji, Ramya (rb111y)4-6/+36
linkage error Issue-ID: APPC-1289 Change-Id: I7a424430bc3510c87b087913fad8992378e27a1b Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
2019-01-03Sonar Fix: AAIResourceNode.javaArundathi Patil1-5/+4
Fixed sonar issues/code-smells across this file. Issue-ID: APPC-1265 Change-Id: Id0339b89f05ba3d55d6b01a0c885fabcadcd86da Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
2019-01-03Fixed sonar issue in Utils.javaezhil1-7/+2
Change-Id: I5edf48443c10f08200b0ea376194a9a8fc6dc29a Issue-ID: APPC-1302 Signed-off-by: ezhil <ezhrajam@in.ibm.com>
2019-01-03Increase code coverage in appc-dg-dependency-modelJoss Armstrong5-10/+204
Increased coverage of sub-project from 50% to 80% Issue-ID: APPC-1301 Change-Id: Ib69b010cd34302a8a9c3b9a291bcbc351babd731 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-01-02Fixed sonar in SequenceGeneratorDBservices.javaezhil1-8/+20
Change-Id: I9931d24771399dedb8c7884d1009d6c3cb84ba16 Issue-ID: APPC-1297 Signed-off-by: ezhil <ezhrajam@in.ibm.com>
2019-01-02Fixed sonar issues in CreateSapshot.javaezhil1-2/+2
Change-Id: Ib3c1e84cdbec3e2698f55b13c038afdf9e51d294 Issue-ID: APPC-1298 Signed-off-by: ezhil <ezhrajam@in.ibm.com>
2018-12-31Fix for test coverage in dg common impl packageJoss Armstrong11-37/+225
Increased test coverage from 42% to 73% Issue-ID: APPC-1296 Change-Id: Ib36c86c325bbc49a14a8ae7076a3b3da14c89b6f Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2018-12-20Test coverage in OAM and OAM message-adapterJoss Armstrong5-40/+307
Increased coverage from 19% to 96% for oam package. Increased coverage from 14% to 93% for oam.message-adapter package. Issue-ID: APPC-1290 Change-Id: I91c313ba42b49718445463a524bf80ac0734b0a9 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2018-12-19Fix for test coverage in oam.utils packageJoss Armstrong6-18/+157
Removed 'PrepareForTest' annotations which were preventing test coverage of classes in appc.oam.utils package. Added unit tests for untested code. Increased line coverage of the package from 49% to 83%. Issue-ID: APPC-1287 Change-Id: I893de5281f8c46e92269be895ef304bbf87c88b9 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2018-12-19Sonar fix: ServiceCatalogV3.javaArundathi Patil1-2/+2
Fixed sonar issues/code-smells across this file Issue-ID: APPC-1281 Change-Id: I118fe3da8ae3ac3c46ad5f2128353e332387086c Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
2018-12-18Sonar Fix: ConnectionBuilder.javaArundathi Patil1-3/+3
Fixed sonar issues/code-smells across this file Issue-ID: APPC-1278 Change-Id: Ic81337c3a2f8c60f5a25adfc10fb4416311de08d Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
2018-12-18Sonar Fix: ChefResponse.javaArundathi Patil1-4/+6
Fixed sonar issues/code-smells across this file. Issue-ID: APPC-1279 Change-Id: I50d5de26d69928037882686452aecd3deb6edbec Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
2018-12-18Sonar fix: ProviderAdapter.javaArundathi Patil1-1/+2
Fixed sonar issues/code-smells across this file. Issue-ID: APPC-1280 Change-Id: I168acf475095b7ef1a40cc1662d844470f045a5d Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
2018-12-18Fix for APPC-1286Joss Armstrong8-85/+593
Increased test coverage from 49% to 73% for package. Added coverage for 4 classes that were previously at 0% coverage. Refactored slow running code into a method that can be mocked to speed up execution of unit tests. Issue-ID: APPC-1286 Change-Id: I3ebe5f6bfbc59228b57d20a3c45081e40ee8e31e Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2018-12-17Fix for OOM-1538Joss Armstrong1-1/+3
This is APPC code change, values.yaml in OOM project also requires update. This is using EncryptionTool class already present in APPC for decryption of password. Alternative may be to use the CryptoUtils class from SO to have common encrypted string? Issue-ID: OOM-1538 Change-Id: I8201dd2587604c19ac584c7af1a9281ab96340d2 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2018-12-14add config modify LCM sample requestTaka Cho1-0/+34
per user request, adding one LCM:config-modify request sample Change-Id: I9902c19feae704b4b97838b71bab691154b3f68f Issue-ID: APPC-1273 Signed-off-by: Taka Cho <takamune.cho@att.com>
2018-12-14Possible fix for NoClassDefFoundErrorBalaji, Ramya (rb111y)9-106/+108
Changed package structure, pom file for Utils classto expose it under export-package for DMaap adapter bundle Issue-ID: APPC-1247 Change-Id: I1662d3af027982a87c063cabee77a645f2bc3afa Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
2018-12-13Fix for APPC-1271Joss Armstrong3-36/+148
Replaced slow running tests which wait for timeout Testing time reduced from 22 seconds to 0.5 seconds Improved tests and line coverage increased from 26% to 96% Issue-ID: APPC-1271 Change-Id: I88713e5c819e5ce1bf695f6de3834db7c3007285 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2018-12-12formatted code in LRUCacheTest.javaSandeep J1-5/+12
and removed unused imports Issue-ID: APPC-1086 Change-Id: I18009404898a938ec23be77bfcf94084f4e9badd Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-12-11Further fixes for APPC-1270Joss Armstrong2-259/+714
Fixed >100 sonar issues Increased line coverage from 26% to 87% Improved testing Removal of redundant code in class under test Issue-ID: APPC-1270 Change-Id: I63f53f03be815bb951d650df2f77999e5629ad75 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2018-12-06Fix for APPC-1270Joss Armstrong2-219/+318
Reduced testing time from 90 seconds to 2 seconds Removed code smell for multiple instance/static references Added assertions and coverage for success scenarios for all methods Line coverage increased from 55% to 84% Moved construction of objects to protected methods to facilitate testing Issue-ID: APPC-1270 Change-Id: I7945c069c703d2ea3fac9ffa33927856170656c9 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2018-12-06Unit test fixes for APPC-1267Joss Armstrong7-242/+98
Removed code smell for <65% branch coverage - now 86%. Test cases now cover success scenarios for all methods. Coverage increased to 97%. Removed classloader code and unnecessary resource files Moved construction of objects to protected methods to facilitate testing. Issue-ID: APPC-1267 Change-Id: I07656a5464410ca5ca3cca55cefd54c03a711385 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2018-12-05Unit tests for APPC-1268Joss Armstrong1-0/+426
Added unit tests for AppcProviderLcm class and increase line coverage from 0% to 80% Issue-ID: APPC-1268 Change-Id: Ic0657a5c1b90daff9507d6f7b4e9ea2fbc7c67b5 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2018-12-03Fix for APPC-1264Joss Armstrong20-406/+298
Fixed broken unit tests. Improved unit testing and increased line and branch coverage. Deleted unused and duplicated files used in tests. Issue-ID: APPC-1264 Change-Id: Idea7d46f4a6c9c591617fb973a8d33e5275e4579 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2018-12-03added test case to ConfigurationHelperTest.javaSandeep J1-0/+9
to increase code coverage Issue-ID: APPC-1086 Change-Id: Ibc9c9eb7ae15b0f3ad8d728d495de4fff4512982 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-12-01Sonar Fix: AnsibleMessageParser.javaArundathi Patil1-1/+4
Fixed sonar issues/code-smells across this file. Issue-ID: APPC-1256 Change-Id: I70480e3867c0ab49325d10e0ec91e76bf6979c50 Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
2018-11-30Fix for APPC-1263Joss Armstrong6-176/+111
Removal of unused code. Refactoring of duplicated code and replacement with FileUtils library function and adding test case for ArtifactTransformer Issue-ID: APPC-1263 Change-Id: I4eab0cefa09620bae18c08ec2c4307d54dddd872 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2018-11-29Test case improvements for APPC-1262Joss Armstrong7-25/+153
Improvements to existing test cases and new test case to increase coverage of PropertyDefinition code from 84% to 96% and coverage of ArtifactProcess code to 95% Issue-ID: APPC-1262 Change-Id: Ibfd46c341e218ffac0505b097770c64aa00a494e Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2018-11-29Docs steamlining and adding detail to bug listPatrick Brady1-69/+23
Pairing down the list of fixed bugs to the more important ones and adding detail to the remaining list. Change-Id: Ia5c650d75f6abd02cee6ec91d38fdf7d2fe0159c Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1035
2018-11-29Update release notes with workaroundsPatrick Brady1-3/+23
Change-Id: I4f32f65c24cf8b96864b69cdc2d9e16794a3a9e0 Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1254
2018-11-29added test cases to TestPropertyDefinitionNodeSandeep J1-0/+46
to increase code coverage Issue-ID: APPC-1086 Change-Id: Ib2e6bcd3a479ed9c8335461ddbfe4e3fd36a7bab Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-11-29added test cases to TestMergeNode.javaSandeep J1-0/+40
to increase code coverage Issue-ID: APPC-1086 Change-Id: I7113c096993247135d54dcb9b686f1006907ca33 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-11-28added test cases to TimeTest.javaSandeep J1-0/+21
to increase code coverage Issue-ID: APPC-1086 Change-Id: I204a69f765356a4ea045793b0fefb69b68a406bf Signed-off-by: Sandeep J <sandeejh@in.ibm.com>