summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2019-07-30Major- Unused "context" local variable.anushadasari1-1/+0
If a local variable is declared but not used, it is dead code and should be removed. Doing so will improve maintainability because developers will not wonder what the variable is used for. Issue-ID: APPC-1675 Change-Id: I9cccd6fd529591cbbe7095cce9d5687a712f42d9 Signed-off-by: anushadasari <danush10@in.ibm.com>
2019-07-29AAPC-1659 removing unused importThugutla Sailakshmi1-1/+0
removing unused import Issue-ID: APPC-1659 Change-Id: Ib7696e4e0fbefe329eda4eb56feb24701f17c4e6 Signed-off-by: Thugutla Sailakshmi <tsaila10@in.ibm.com>
2019-07-29SonarFix- MigrateServer.javaanushadasari1-2/+0
The imports part of a file should be handled by the Integrated Development Environment (IDE), not manually by the developer. Unused and useless imports should not occur if that is the case. Leaving them in reduces the code's readability, since their presence can be confusing. Change-Id: Ic0af785e3d3863f4555ab9614d7a8b3b0f2150b3 Issue-ID: APPC-1670 Signed-off-by: anushadasari <danush10@in.ibm.com>
2019-07-26APPC-1663anushadasari1-1/+0
The imports part of a file should be handled by the Integrated Development Environment (IDE), not manually by the developer. Unused and useless imports should not occur if that is the case. Leaving them in reduces the code's readability, since their presence can be confusing. Issue-ID: APPC-1663 Change-Id: I98a98f59847a4cdea298f82531530db4048b65b0 Signed-off-by: anushadasari <danush10@in.ibm.com>
2019-07-26AAPC-1658 removing unused importThugutla Sailakshmi1-1/+0
removing unused import Issue-ID: APPC-1658 Change-Id: I3eb674031487937b461d045c31d4aa9108b38de6 Signed-off-by: Thugutla Sailakshmi <tsaila10@in.ibm.com>
2019-07-26SonarFix-Remove declaration of thrown exceptionanushadasari1-1/+1
Remove the declaration of thrown exception 'org.onap.appc.exceptions.APPCException', as it cannot be thrown from method's body. Issue-ID: APPC-1664 Change-Id: I0c66da105d735b4ac97ee35d1e6bea122be80722 Signed-off-by: anushadasari <danush10@in.ibm.com>
2019-07-24Prepared statements for DG servicesPatrick Brady13-453/+1153
Convert sql queries to prepared statements in other parts of appc. Change-Id: If29225394de2ab286e4f2f7bdd17f6af6b286576 Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: OJSI-25
2019-07-24Add value of the argumentsPatrick Brady1-3/+31
Also apply the valueof to non svc context arguments. The original code would always treat null arguments as null strings. This replaces that functionality in the prepared statements. Change-Id: I88ab22c87b86a8f5ff41946757c40a399c37a6c3 Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: OJSI-25
2019-07-24AAPC-1655anushadasari1-2/+0
The imports part of a file should be handled by the Integrated Development Environment (IDE), not manually by the developer. Unused and useless imports should not occur if that is the case. Leaving them in reduces the code's readability, since their presence can be confusing. Issue-ID: APPC-1655 Change-Id: I64e50083b9b0fe40fa0ba32723e30adb0dbce08e Signed-off-by: Dasari Anusha <danush10@in.ibm.com> Signed-off-by: anushadasari <danush10@in.ibm.com>
2019-07-24AAPC-1661-remove unused import 'java.util.TimeZone'Thugutla Sailakshmi1-1/+0
remove unused import 'java.util.TimeZone' Issue-ID: APPC-1661 Change-Id: I94d4c39a83fb815343fd373557a7d36b3e1213b8 Signed-off-by: Thugutla Sailakshmi <tsaila10@in.ibm.com>
2019-07-23APPC -1653anushadasari1-1/+0
The imports part of a file should be handled by the Integrated Development Environment (IDE), not manually by the developer. Unused and useless imports should not occur if that is the case. Leaving them in reduces the code's readability, since their presence can be confusing. Issue-ID: APPC-1653 Change-Id: I9e3e3b7994cb689e14b70aab73d5dfea54fa4a1f Signed-off-by: anushadasari <danush10@in.ibm.com>
2019-07-23APPC-1652- Removing Duplicate importanushadasari1-1/+1
Unused and useless imports should not occur if that is the case. Leaving them in reduces the code's readability, since their presence can be confusing. Issue-ID: APPC-1652 Change-Id: I64e50083b9b0fe40fa0ba32723e30adb0dbce08e Signed-off-by: Dasari Anusha <danush10@in.ibm.com> Signed-off-by: anushadasari <danush10@in.ibm.com> Change-Id: I1ddafa429afb23a0eb6cb120a20a774ff9a032b8
2019-07-23APPC-1654anushadasari1-1/+1
Remove the declaration of thrown exception 'org.onap.appc.exceptions.APPCException', as it cannot be thrown from method's body. Issue-ID: APPC-1654 Change-Id: Ib08561aaecf8dea445e0f5ceb3a6d35795dfd8bd Signed-off-by: anushadasari <danush10@in.ibm.com>
2019-07-19remove opendaylight-karaf-emptyTaka Cho3-41/+0
opendaylight-karaf-empty is for testing purpose and outdated Issue-ID: APPC-1651 Change-Id: I768b7afa9a60db6413f71320fd11575b1fafce97 Signed-off-by: Taka Cho <takamune.cho@att.com>
2019-07-17Replace Lists with new ArrayListPatrick Brady1-2/+2
The Lists.newArrayList method is not being used here in a way that provides significant benefit over new ArrayList and Lists was causing a class not found exception. Change-Id: I61bbfc5e55cb283c10f3681a7e336ae346347d03 Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1613
2019-07-17Fixes for parameterized sql queriesPatrick Brady2-1/+3
The old non-parameterized queries would treat null entries in the SvcLogicContext as "null" string values. The parameterized query treats these as NULL sql values. This change keeps those values as "null" strings. Change-Id: Iee7f7a1861bdd82dc65d59db2be7862b49cf1207 Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1639
2019-07-15Sonar Fix - Removed unnecessary cast to DateSudarshan Kumar1-1/+3
Sonar Fix - Removed unnecessary cast to Date Issue-ID: APPC-1629 Change-Id: Ie37c511ac63abd71708700b376a836e4ed03e92f Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
2019-07-12Sonar Fix - Removed unused Variable Utils.javaSudarshan Kumar1-1/+0
Sonar Fix - Removed unused Variable Utils.java Issue-ID: APPC-1629 Change-Id: I557c065ff835834f5eed5eb80bd7136e182217f5 Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
2019-07-11Sonar Fix - String comparisonSudarshan Kumar1-2/+2
Sonar Fix - String comparison Issue-ID: APPC-1629 Change-Id: I8ea38dfaf629c2be624552a1cf0b0f0e877117cb Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
2019-07-11Sonar Fix - String ComparisonSudarshan Kumar1-1/+1
Sonar Fix - String Comparison Issue-ID: APPC-1629 Change-Id: Ia13da99f101d479aba7009ba4dffc201aa9a3ffe Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
2019-07-10Marked field transientjegadeeshbabu11-1/+3
Handled non-serializable fields Issue-ID: APPC-1637 Change-Id: I3398620e396c3f8bc1504eca8d312bc35d3bbbfd Signed-off-by: jegadeeshbabu1 <jegabab1@in.ibm.com>
2019-07-10Adhered serializable class contractsjegadeeshbabu11-1/+3
Marked member transient Issue-ID: APPC-1634 Change-Id: I7bbbf941e692c2755122f3d40a7ca79c59f21749 Signed-off-by: jegadeeshbabu1 <jegabab1@in.ibm.com>
2019-07-10Updated to be an instance variablejegadeeshbabu11-1/+3
Removed static keyword Issue-ID: APPC-1636 Change-Id: I507d306f50acc010db4d944a078b4d15f5c719a4 Signed-off-by: jegadeeshbabu1 <jegabab1@in.ibm.com>
2019-07-09Sonar Fix- Removed Unused private fieldSudarshan Kumar1-1/+0
Sonar Fix- Removed Unused private field Issue-ID: APPC-1629 Change-Id: Iaab259140e29200473147097c552f75783e5cd0d Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
2019-07-06Fixed netconf-xml parsing issueLathish3-11/+76
Issue-ID: APPC-1624 Change-Id: I12aa5f1a42d5e09b5eb8886132ea9e5a2c84ef5e Signed-off-by: Lathish <lathishbabu.ganesan@est.tech>
2019-06-27Parameterized queriesPatrick Brady8-163/+671
Convert all database queries to use java sql parameterized queries to reduce risk of sql injection attack. Change-Id: I15876ce3a2f2e2dfbd6578f5141367deed75d097 Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: OJSI-25
2019-06-19update appc release noteTaka Cho1-2/+3
fix appc cluster issue release new appc docker Issue-ID: APPC-1293 Change-Id: Id4897669e29f3c7c156a3c4c945825758c268a51 Signed-off-by: Taka Cho <takamune.cho@att.com>
2019-06-18Added cvaas file name in Audit and SyncLathish2-1041/+1067
Issue-ID: APPC-1590 Change-Id: I09345570fe6cd158102844070e62df7fb1a7aed9 Signed-off-by: Lathish <lathishbabu.ganesan@est.tech>
2019-06-14fix document errorTaka Cho1-1/+1
missing underline Issue-ID: APPC-1595 Change-Id: Ia1eb87c5f34c43c56e037e9bf925857ecbb9d758 Signed-off-by: Taka Cho <takamune.cho@att.com>
2019-06-14update dublin release noteTaka Cho1-1/+2
remove known-issue APPC-1613 Issue-ID: APPC-1293 Change-Id: Ibacdb95bdc94bee2449596948055bbff3bd51e9e Signed-off-by: Taka Cho <takamune.cho@att.com>
2019-06-10Fixed incorrect error messageLathish1-1/+1
Issue-ID: APPC-1623 Change-Id: Ib6c58be5e5ddb41c39788208238234335f72e7ea Signed-off-by: Lathish <lathishbabu.ganesan@est.tech>
2019-06-05Document OJSI-185 vulnerabilityKrzysztof Opasiak1-0/+1
Issue-ID: OJSI-185 Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com> Change-Id: I6cbe6a6cb0129bd4ac6ccba35cf018f4a04f80e5
2019-06-05Document OJSI-113 vulnerabilityKrzysztof Opasiak1-0/+1
Issue-ID: OJSI-113 Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com> Change-Id: I9d0c35e01dd4f2b42bd115455863ca2d0b8dc3c7
2019-06-05Document OJSI-112 vulnerabilityKrzysztof Opasiak1-0/+1
Issue-ID: OJSI-112 Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com> Change-Id: Id28f332ddcdd5c69f5a82758d05c10d19606faff
2019-06-05Document OJSI-95 vulnerabilityKrzysztof Opasiak1-0/+1
Issue-ID: OJSI-95 Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com> Change-Id: Ica05a626601673f672cc0be6a8c6cdcbe94323f8
2019-06-05Document OJSI-63 (CVE-2019-12124) vulnerabilityKrzysztof Opasiak1-0/+1
Issue-ID: OJSI-63 Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com> Change-Id: Ide989877e0f2765302ad423c0b421e972b4e8046
2019-06-05Document OJSI-29 vulnerabilityKrzysztof Opasiak1-0/+1
Issue-ID: OJSI-29 Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com> Change-Id: Ib8f54aa42fc78198c8b0043b2aa79580a5950672
2019-06-05Document OJSI-25 (CVE-2019-12316) vulnerabilityKrzysztof Opasiak1-0/+2
Issue-ID: OJSI-25 Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com> Change-Id: Ia880184484aadea9147fcac301c87063a00f92ab
2019-06-05Document fixed OJSI-104 vulnerabilityKrzysztof Opasiak1-0/+1
Issue-ID: OJSI-104 Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com> Change-Id: I42365c3038eb38f170b1543d9f78d68b2e5c9de4
2019-06-05Document fixed OJSI-146 vulnerabilityKrzysztof Opasiak1-0/+2
Issue-ID: OJSI-146 Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com> Change-Id: I9e02cc26f7cfa9c11941b4ce4aef5de561f4b764
2019-06-05Improve security release notesKrzysztof Opasiak1-123/+129
In order to provide users with more details of project's state in terms of security let's divide the security release notes into three sections: - Fixed Security Issues Contains a list of security fixes merged during this release (especially those reported via OJSI tickets). - Known Security Issues Contains a list of vulnerabilities detected in project during release which have not been fixed yet and thus should be mitigated by the user. - Known Vulnerabilities in Used Modules Contains information about NexusIQ scan results Issue-ID: SECCOM-238 Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com> Change-Id: I9fee2338091ed5a879e0989d13501008d7d6013f
2019-06-05Fix for jackson annotationPatrick Brady1-5/+3
Fasterxml jackson annotations was not available during runtime and was causing json property annotations to be ignored and json was not parsing. Change-Id: I1cb48e6fc54fc39d24bde1683cb141f1f64c9906 Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1613
2019-06-05Fix for documentation of DistributeTrafficCheckLukasz Rajewski1-67/+69
Change-Id: I260ef22fb00755e6818868fdadd35bcd88162ffd Signed-off-by: Lukasz Rajewski <lukasz.rajewski@orange.com> Issue-ID: APPC-1447
2019-06-04Documentation for DistributeTraffic LCMsLukasz Rajewski2-16/+140
Documentation for Distribute Traffic and Distribute Traffic Check LCMs Change-Id: I8dc6ec3110c711857d8788f01edfcca87a887317 Signed-off-by: Lukasz Rajewski <lukasz.rajewski@orange.com> Issue-ID: APPC-1447 (cherry picked from commit 284d93a4770224956138eec224479fef9d356fff)
2019-06-04APPC release note updateTaka Cho1-1/+104
Updated Dublin release note Issue-ID: APPC-1293 Change-Id: I86ebb4365aed65b90e13a46e8e691f39382ecfd4 Signed-off-by: Taka Cho <takamune.cho@att.com>
2019-06-03Fix for null dmaap return statusPatrick Brady2-1/+5
The setResponse method was returning before actually setting the status values in cases where the status field was not first initialized. This behavior did not make sense since the status field would never be initialized in cases where the OutgoingMessage was generated using the IncomingMessage.toOutgoing(). Change-Id: Ib399daf3644095a2eeffe718d0f6a27473b01ee9 Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1619
2019-05-28InventoryNames in ansible adapter fixedLukasz Rajewski2-98/+92
This change fixes support for InventoryNames parameter in LCM request going to Ansible server. Also ansible adapter DG has been modified to consider new parameter added Change-Id: I68aa8efa34b79ef2f669d81563510fea7bb0a730 Signed-off-by: Lukasz Rajewski <lukasz.rajewski@orange.com> Issue-ID: APPC-1612 (cherry picked from commit 7155b808084ff6e49f6eef01ac7defd9a7754a3a)
2019-05-22fix CDT doc image referenceTaka Cho1-1/+1
rename to image41 Issue-ID: APPC-1295 Change-Id: Iee331769a9a0e46e87631c14849142033b855e34 Signed-off-by: Taka Cho <takamune.cho@att.com>
2019-05-22Fix for support of InventoryNamesLukasz Rajewski2-3/+5
This change addes support for InventoryNames parameter in LCM request going to Ansible server Change-Id: I9aea0b5407460d5dc0b2691e73ba795f8fe2af15 Signed-off-by: Lukasz Rajewski <lukasz.rajewski@orange.com> Issue-ID: APPC-1612
2019-05-22Fix escapeInternalJson methodPatrick Brady1-8/+23
The method incorrectly handled cases where the json string contained json objects internally. These cases should be handled correctly now. Change-Id: I43b40414526bcb6577242ab737097dfb9119e618 Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1576