summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-12-18Sonar Fix: ChefResponse.javaArundathi Patil1-4/+6
Fixed sonar issues/code-smells across this file. Issue-ID: APPC-1279 Change-Id: I50d5de26d69928037882686452aecd3deb6edbec Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
2018-12-18Sonar fix: ProviderAdapter.javaArundathi Patil1-1/+2
Fixed sonar issues/code-smells across this file. Issue-ID: APPC-1280 Change-Id: I168acf475095b7ef1a40cc1662d844470f045a5d Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
2018-12-18Fix for APPC-1286Joss Armstrong8-85/+593
Increased test coverage from 49% to 73% for package. Added coverage for 4 classes that were previously at 0% coverage. Refactored slow running code into a method that can be mocked to speed up execution of unit tests. Issue-ID: APPC-1286 Change-Id: I3ebe5f6bfbc59228b57d20a3c45081e40ee8e31e Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2018-12-17Fix for OOM-1538Joss Armstrong1-1/+3
This is APPC code change, values.yaml in OOM project also requires update. This is using EncryptionTool class already present in APPC for decryption of password. Alternative may be to use the CryptoUtils class from SO to have common encrypted string? Issue-ID: OOM-1538 Change-Id: I8201dd2587604c19ac584c7af1a9281ab96340d2 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2018-12-14add config modify LCM sample requestTaka Cho1-0/+34
per user request, adding one LCM:config-modify request sample Change-Id: I9902c19feae704b4b97838b71bab691154b3f68f Issue-ID: APPC-1273 Signed-off-by: Taka Cho <takamune.cho@att.com>
2018-12-14Possible fix for NoClassDefFoundErrorBalaji, Ramya (rb111y)9-106/+108
Changed package structure, pom file for Utils classto expose it under export-package for DMaap adapter bundle Issue-ID: APPC-1247 Change-Id: I1662d3af027982a87c063cabee77a645f2bc3afa Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
2018-12-13Fix for APPC-1271Joss Armstrong3-36/+148
Replaced slow running tests which wait for timeout Testing time reduced from 22 seconds to 0.5 seconds Improved tests and line coverage increased from 26% to 96% Issue-ID: APPC-1271 Change-Id: I88713e5c819e5ce1bf695f6de3834db7c3007285 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2018-12-12formatted code in LRUCacheTest.javaSandeep J1-5/+12
and removed unused imports Issue-ID: APPC-1086 Change-Id: I18009404898a938ec23be77bfcf94084f4e9badd Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-12-11Further fixes for APPC-1270Joss Armstrong2-259/+714
Fixed >100 sonar issues Increased line coverage from 26% to 87% Improved testing Removal of redundant code in class under test Issue-ID: APPC-1270 Change-Id: I63f53f03be815bb951d650df2f77999e5629ad75 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2018-12-06Fix for APPC-1270Joss Armstrong2-219/+318
Reduced testing time from 90 seconds to 2 seconds Removed code smell for multiple instance/static references Added assertions and coverage for success scenarios for all methods Line coverage increased from 55% to 84% Moved construction of objects to protected methods to facilitate testing Issue-ID: APPC-1270 Change-Id: I7945c069c703d2ea3fac9ffa33927856170656c9 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2018-12-06Unit test fixes for APPC-1267Joss Armstrong7-242/+98
Removed code smell for <65% branch coverage - now 86%. Test cases now cover success scenarios for all methods. Coverage increased to 97%. Removed classloader code and unnecessary resource files Moved construction of objects to protected methods to facilitate testing. Issue-ID: APPC-1267 Change-Id: I07656a5464410ca5ca3cca55cefd54c03a711385 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2018-12-05Unit tests for APPC-1268Joss Armstrong1-0/+426
Added unit tests for AppcProviderLcm class and increase line coverage from 0% to 80% Issue-ID: APPC-1268 Change-Id: Ic0657a5c1b90daff9507d6f7b4e9ea2fbc7c67b5 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2018-12-03Fix for APPC-1264Joss Armstrong20-406/+298
Fixed broken unit tests. Improved unit testing and increased line and branch coverage. Deleted unused and duplicated files used in tests. Issue-ID: APPC-1264 Change-Id: Idea7d46f4a6c9c591617fb973a8d33e5275e4579 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2018-12-03added test case to ConfigurationHelperTest.javaSandeep J1-0/+9
to increase code coverage Issue-ID: APPC-1086 Change-Id: Ibc9c9eb7ae15b0f3ad8d728d495de4fff4512982 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-12-01Sonar Fix: AnsibleMessageParser.javaArundathi Patil1-1/+4
Fixed sonar issues/code-smells across this file. Issue-ID: APPC-1256 Change-Id: I70480e3867c0ab49325d10e0ec91e76bf6979c50 Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
2018-11-30Fix for APPC-1263Joss Armstrong6-176/+111
Removal of unused code. Refactoring of duplicated code and replacement with FileUtils library function and adding test case for ArtifactTransformer Issue-ID: APPC-1263 Change-Id: I4eab0cefa09620bae18c08ec2c4307d54dddd872 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2018-11-29Test case improvements for APPC-1262Joss Armstrong7-25/+153
Improvements to existing test cases and new test case to increase coverage of PropertyDefinition code from 84% to 96% and coverage of ArtifactProcess code to 95% Issue-ID: APPC-1262 Change-Id: Ibfd46c341e218ffac0505b097770c64aa00a494e Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2018-11-29Docs steamlining and adding detail to bug listPatrick Brady1-69/+23
Pairing down the list of fixed bugs to the more important ones and adding detail to the remaining list. Change-Id: Ia5c650d75f6abd02cee6ec91d38fdf7d2fe0159c Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1035
2018-11-29Update release notes with workaroundsPatrick Brady1-3/+23
Change-Id: I4f32f65c24cf8b96864b69cdc2d9e16794a3a9e0 Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1254
2018-11-29added test cases to TestPropertyDefinitionNodeSandeep J1-0/+46
to increase code coverage Issue-ID: APPC-1086 Change-Id: Ib2e6bcd3a479ed9c8335461ddbfe4e3fd36a7bab Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-11-29added test cases to TestMergeNode.javaSandeep J1-0/+40
to increase code coverage Issue-ID: APPC-1086 Change-Id: I7113c096993247135d54dcb9b686f1006907ca33 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-11-28added test cases to TimeTest.javaSandeep J1-0/+21
to increase code coverage Issue-ID: APPC-1086 Change-Id: I204a69f765356a4ea045793b0fefb69b68a406bf Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-11-28added test case to TestSignal.javaSandeep J1-1/+8
to increase code coverage Issue-ID: APPC-1086 Change-Id: If908db1d5e0f45e34d4378129f41bf2908f872e2 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-11-28Sonar Fix: ChefApiClientFactory.javaArundathi Patil1-3/+3
Fixed sonar issues/code-smells across this file Issue-ID: APPC-1253 Change-Id: Id1060c34f0b99e906dba618d9ea0aebca0fc1beb Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
2018-11-28Sonar Fix: ConnectionBuilder.javaArundathi Patil1-2/+2
Fixed sonar issues/code-smells across this file Issue-ID: APPC-1252 Change-Id: I8f07da91c7b29012c8d4b72af8b94ee5c5a017a4 Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
2018-11-28Sonar Fix: AnsibleResult.javaArundathi Patil1-8/+8
Fixed sonar issues/code-smells across the file. Issue-ID: APPC-1250 Change-Id: I9adca61255c1e20094bf992bfa1430ee4af50528 Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
2018-11-28added test case to TestXSLTTransformerNodeSandeep J1-1/+11
to increase code coverage Issue-ID: APPC-1086 Change-Id: I4e185d1c1117f0bab6a63618621b55aef376a2c9 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-11-28added test case to TestDataTool.javaSandeep J1-2/+9
to increase code coverage Issue-ID: APPC-1086 Change-Id: If4e5bacbfe63bca2d0859f2f86623044c6cba3a2 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-11-28added test case to TestPatternNode.javaSandeep J1-1/+16
to increase code coverage Issue-ID: APPC-1086 Change-Id: I4b0ac6e586245c532a2a698b2907d518ce4d6adb Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-11-28added test case to TestConvertNode.javaSandeep J1-1/+52
to increase code coverage Issue-ID: APPC-1086 Change-Id: Ia5890e45849fad0a17753fe03c217a60777a8945 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-11-28Junits for design servicesDilip kumar Pampana2-12/+48
code coverage for design services in appc-inbound Issue-ID: APPC-1211 Change-Id: Ie67937b74a83aee5de469687e4ab63685cb5d6aa Signed-off-by: Dilip kumar Pampana <dilip.kumar.pampana@ibm.com>
2018-11-27Update Release dateGildas Lanilis1-1/+1
Make release date consistant with all projects. Change-Id: I159d51437a0dc6ff7e94cfa743db49d1ad323c89 Issue-ID: DOC-333 Signed-off-by: Gildas Lanilis <gildas.lanilis@huawei.com>
2018-11-261.4.3 Release NoteTaka Cho1-3/+14
updating release note for 1.4.3 Change-Id: I10aa8760ace6f8a0f790ff69974c28c0c69b7ff6 Issue-ID: APPC-1035 Signed-off-by: Taka Cho <takamune.cho@att.com>
2018-11-19Fix for Class dependency errorsBalaji, Ramya (rb111y)1-2/+1
Issue-ID: APPC-1231 Change-Id: I0edce5fad720a5a6326ea7d0845e61db69665289 Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
2018-11-16More code changes for importingBalaji, Ramya (rb111y)2-0/+3
Adding explicit import/exports to pom, to see if issue the issue will resolve. Issue-ID: APPC-1231 Change-Id: I2138d9a8b8ddea151a97562663236061fef60275 Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
2018-11-15Add w3c importPatrick Brady1-1/+1
Change-Id: I7eb93f41fb2fc505af609e9c2d53bc4c45d8aee1 Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1241
2018-11-14update release note for R3Taka Cho1-0/+158
this is release note for Casablanca release Change-Id: I0b595d6cc47591d0bb46b4c8d73008a24b003548 Issue-ID: APPC-1035 Signed-off-by: Taka Cho <takamune.cho@att.com>
2018-11-12Increment version numberPatrick Brady255-278/+278
Changing to version 1.5.0-SNAPSHOT Change-Id: I1e0773d16cb058ac2fb96718581cfbf8d716a2e0 Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1212
2018-11-08Code modification attempts to fix issue1.4.1Balaji, Ramya (rb111y)1-2/+3
Issue-ID: APPC-1231 Change-Id: I710487b70624b1f4736de29f84f627a8f7a2ccf7 Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
2018-11-07More logging added to debugBalaji, Ramya (rb111y)4-4/+24
Issue-ID: APPC-1231 Change-Id: I45790aff545c566fbf62ea1908143b15f3920122 Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
2018-11-07Added more logging to narrrow down issueBalaji, Ramya (rb111y)4-60/+75
Issue-ID: APPC-1231 Change-Id: I145c1309cb80b46477eca665ace5ce2358fac819 Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
2018-10-29output payload is blank when doing healthcheckShailendra Borale1-1/+1
Changed the payload attribute name to output-payload Change-Id: I2b0e6de88e87c8be1f24a1d4822c8a60ec49dc7b Issue-ID: APPC-1233 Signed-off-by: Shailendra Borale <sb8915@att.com>
2018-11-05correct unnecessary license statmentTaka Cho3-47/+14
there are three files have in-line or incorrect license statements Change-Id: I7bb99782fcf2d5c567016ee12042ae19ea66f9e4 Issue-ID: APPC-1229 Signed-off-by: Taka Cho <takamune.cho@att.com>
2018-10-31Fixed Mock code issue for Reboot actionBalaji, Ramya (rb111y)1-3/+0
Removed code that mocked backend execution for Reboot since backend implementation is available Issue-ID: APPC-1226 Change-Id: Ie12603b9c7ffe80628fd0f46fa15fdc86d652d96 Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
2018-10-31remove mockito from client-libTaka Cho2-0/+18
exlcude mockito and add scope:test for mockito Change-Id: I6b13c409db8d350c6dbfd23f99f05421b6ecde82 Issue-ID: APPC-1157 Signed-off-by: Taka Cho <takamune.cho@att.com>
2018-10-30Fix capitalization difference in json formatPatrick Brady3-3/+3
The "r" was not capitalized in SubrequestID, but the message policy is sending does have a capital "r". Change-Id: I4a0c11278ea7d81c2fc0fe5a16696d0fd7d48df6 Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1224
2018-10-29Update of DistributeTraffic LCM API docLukasz Rajewski1-9/+28
Modified description of DistributeTraffic LCM API with correct information about payload parameters and with example of payload followed with information about associated CDT template. Issue-ID: APPC-1171 Change-Id: I3c86095c3752d39f869793253e19c9a56e5da2a1 Signed-off-by: Łukasz Rajewski <lukasz.rajewski@orange.com>
2018-10-25Fix missing javax.messagingPatrick Brady1-1/+1
Change-Id: I79f37091b5b66d2812ea6d49ac9ef44a44dc91fc Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1220
2018-10-24Fix jersey and javax dependenciesPatrick Brady1-2/+2
Change-Id: Ib2865fea0bd4c0ed73d8db0b9326bbc3d19c12c6 Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1219
2018-10-17Make validation of DistributeTraffic less strict.Tomek Osinski2-21/+1
In order to pass configuration-parameters we need to make validation less strict. Issue-ID: APPC-1173 Change-Id: I62e3f0acce8d4b577705dd5fe3b7e6ea7740cae1 Signed-off-by: Tomek Osinski <tomasz.osinski2@orange.com>