diff options
| author |   Joss Armstrong <joss.armstrong@ericsson.com> | 2019-02-21 19:16:35 +0000 |
|---|---|---|
| committer |   Takamune Cho <takamune.cho@att.com> | 2019-02-22 18:18:43 +0000 |
| commit | 57293e84a0aa7405c9688448483d811d707e199a (patch) | |
| tree | b486d3d72138f8c998f18b741470c15ad9235742 /appc-metric/appc-metric-bundle/src/main | |
| parent | 6c2b81d1d39e734435cabd66518fff26bcd49aec (diff) | |
Test coverage in MetricRegistryImpl
Added test coverage for MetricRegistryImpl
Issue-ID: APPC-1478
Change-Id: I91eff5418ec14d294fa80af3d6d7025338b82072
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Diffstat (limited to 'appc-metric/appc-metric-bundle/src/main')
| -rw-r--r-- | appc-metric/appc-metric-bundle/src/main/java/org/onap/appc/metricservice/impl/MetricRegistryImpl.java | 16 |
1 files changed, 5 insertions, 11 deletions
diff --git a/appc-metric/appc-metric-bundle/src/main/java/org/onap/appc/metricservice/impl/MetricRegistryImpl.java b/appc-metric/appc-metric-bundle/src/main/java/org/onap/appc/metricservice/impl/MetricRegistryImpl.java index af05285d0..48d1c6fac 100644 --- a/appc-metric/appc-metric-bundle/src/main/java/org/onap/appc/metricservice/impl/MetricRegistryImpl.java +++ b/appc-metric/appc-metric-bundle/src/main/java/org/onap/appc/metricservice/impl/MetricRegistryImpl.java @@ -5,6 +5,8 @@ * Copyright (C) 2017-2018 AT&T Intellectual Property. All rights reserved. * ================================================================================ * Copyright (C) 2017 Amdocs + * ================================================================================ + * Modifications Copyright (C) 2019 Ericsson * ============================================================================= * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -38,7 +40,7 @@ import org.onap.appc.metricservice.policy.impl.PolicyBuilderFactoryImpl; public class MetricRegistryImpl implements MetricRegistry { private String name; - private Map<String,Metric> concurrentMetricMap=new ConcurrentHashMap<String,Metric>(); + private Map<String, Metric> concurrentMetricMap = new ConcurrentHashMap<>(); public MetricRegistryImpl(String name) { this.name = name; @@ -46,11 +48,7 @@ public class MetricRegistryImpl implements MetricRegistry { @Override public boolean register(Metric metric) { - if(concurrentMetricMap.get(metric.name())==null){ - concurrentMetricMap.put(metric.name(),metric); - return true; - } - return false; + return (concurrentMetricMap.putIfAbsent(metric.name(), metric) == null); } @Override @@ -70,11 +68,7 @@ public class MetricRegistryImpl implements MetricRegistry { @Override public Counter counter(String value) { - if(concurrentMetricMap.get(value)!=null ) - return (Counter)concurrentMetricMap.get(value) ; - else - return null; - + return (Counter)concurrentMetricMap.get(value); } @Override |