Refactor Status to be immutable

Change Status class to be immutable.
Add convenience method to convert from a LCMCommandStatus to
a Status object.

Change-Id: I9e47750d15b5ee0f5649b2fabf6387aa12ff9c9d
Signed-off-by: Gary Wu <gary.i.wu@huawei.com>

3 files changed, 7 insertions, 11 deletions

diff --git a/appc-dispatcher/appc-request-handler/appc-request-handler-core/src/test/java/org/openecomp/appc/requesthandler/TestConverter.java b/appc-dispatcher/appc-request-handler/appc-request-handler-core/src/test/java/org/openecomp/appc/requesthandler/TestConverter.java
index 46875a269..aaf17fba9 100644
--- a/appc-dispatcher/appc-request-handler/appc-request-handler-core/src/test/java/org/openecomp/appc/requesthandler/TestConverter.java
+++ b/appc-dispatcher/appc-request-handler/appc-request-handler-core/src/test/java/org/openecomp/appc/requesthandler/TestConverter.java
@@ -324,8 +324,7 @@ public class TestConverter {
 
 	private ResponseContext buildAsyncResponse() {
 		ResponseContext asyncResponse = createResponseContextWithSubObjects();
-		asyncResponse.getStatus().setCode(LCMCommandStatus.SUCCESS.getResponseCode());
-		asyncResponse.getStatus().setMessage(LCMCommandStatus.SUCCESS.getResponseMessage());
+		asyncResponse.setStatus(LCMCommandStatus.SUCCESS.toStatus(null));
 		asyncResponse.getCommonHeader().setOriginatorId("oid");
 		asyncResponse.getCommonHeader().setApiVer("2.0.0");
 		asyncResponse.getCommonHeader().setRequestId("reqid");
@@ -339,9 +338,8 @@ public class TestConverter {
 		ResponseContext responseContext = new ResponseContext();
 		CommonHeader commonHeader = new CommonHeader();
 		Flags flags = new Flags();
-		Status status = new Status();
 		responseContext.setCommonHeader(commonHeader);
-		responseContext.setStatus(status);
+		responseContext.setStatus(new Status(0, null));
 		commonHeader.setFlags(flags);
 		return responseContext;
 	}
diff --git a/appc-dispatcher/appc-request-handler/appc-request-handler-core/src/test/java/org/openecomp/appc/requesthandler/TestRequestHandler.java b/appc-dispatcher/appc-request-handler/appc-request-handler-core/src/test/java/org/openecomp/appc/requesthandler/TestRequestHandler.java
index e4c1e92d3..e060775ce 100644
--- a/appc-dispatcher/appc-request-handler/appc-request-handler-core/src/test/java/org/openecomp/appc/requesthandler/TestRequestHandler.java
+++ b/appc-dispatcher/appc-request-handler/appc-request-handler-core/src/test/java/org/openecomp/appc/requesthandler/TestRequestHandler.java
@@ -302,12 +302,12 @@ public class TestRequestHandler {
 
 
 		ResponseContext responseContext = new ResponseContext();
-		responseContext.setStatus(new Status());
+		responseContext.setStatus(new Status(0, null));
 		responseContext.setAdditionalContext(new HashMap<String, String>(4));
 		responseContext.setCommonHeader(input1.getRequestContext().getCommonHeader());
 		runtimeContext.setResponseContext(responseContext);
 		when(runtimeContext.getResponseContext()).thenReturn(responseContext);
-		responseContext.setStatus(new Status());
+		responseContext.setStatus(new Status(0, null));
 		runtimeContext.setResponseContext(responseContext);
 		PowerMockito.whenNew(RuntimeContext.class).withAnyArguments().thenReturn(runtimeContext);
 
@@ -451,7 +451,7 @@ public class TestRequestHandler {
 		output.getVnfContext().setId(vnfId);
 		output.getResponseContext().getCommonHeader().setApiVer("2.0.0");
 		output.getResponseContext().getCommonHeader().setTimestamp(new Date());
-		output.getResponseContext().getStatus().setCode(LCMCommandStatus.SUCCESS.getResponseCode());
+		output.getResponseContext().setStatus(LCMCommandStatus.SUCCESS.toStatus(null));
 		output.setTimeStart(new Date());
 		output.getResponseContext().getCommonHeader().setOriginatorId(originatorId);
 		output.getResponseContext().getCommonHeader().setRequestId(requestId);
@@ -566,9 +566,8 @@ public class TestRequestHandler {
 		ResponseContext responseContext = new ResponseContext();
 		CommonHeader commonHeader = new CommonHeader();
 		Flags flags = new Flags();
-		Status status = new Status();
 		responseContext.setCommonHeader(commonHeader);
-		responseContext.setStatus(status);
+		responseContext.setStatus(new Status(0, null));
 		commonHeader.setFlags(flags);
 		return responseContext;
 	}
diff --git a/appc-dispatcher/appc-request-handler/appc-request-handler-core/src/test/java/org/openecomp/appc/requesthandler/TestRequestValidator.java b/appc-dispatcher/appc-request-handler/appc-request-handler-core/src/test/java/org/openecomp/appc/requesthandler/TestRequestValidator.java
index 344f20478..becd95d46 100644
--- a/appc-dispatcher/appc-request-handler/appc-request-handler-core/src/test/java/org/openecomp/appc/requesthandler/TestRequestValidator.java
+++ b/appc-dispatcher/appc-request-handler/appc-request-handler-core/src/test/java/org/openecomp/appc/requesthandler/TestRequestValidator.java
@@ -601,9 +601,8 @@ public class TestRequestValidator {
         ResponseContext responseContext = new ResponseContext();
         CommonHeader commonHeader = new CommonHeader();
         Flags flags = new Flags();
-        Status status = new Status();
         responseContext.setCommonHeader(commonHeader);
-        responseContext.setStatus(status);
+        responseContext.setStatus(new Status(0, null));
         commonHeader.setFlags(flags);
         return responseContext;
     }