appc-config-generator-provider sonar fixes part 2

Sonar fixes in whole module

Change-Id: I55856a6ce73a73098dadb2c5b9428437349ed8a8
Issue-ID: APPC-671
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>

8 files changed, 54 insertions, 66 deletions

diff --git a/appc-config/appc-config-generator/provider/src/main/java/org/onap/sdnc/config/generator/tool/CheckDataTool.java b/appc-config/appc-config-generator/provider/src/main/java/org/onap/sdnc/config/generator/tool/CheckDataTool.java
index 4488e0be8..3895aa47f 100644
--- a/appc-config/appc-config-generator/provider/src/main/java/org/onap/sdnc/config/generator/tool/CheckDataTool.java
+++ b/appc-config/appc-config-generator/provider/src/main/java/org/onap/sdnc/config/generator/tool/CheckDataTool.java
@@ -24,6 +24,8 @@
 
 package org.onap.sdnc.config.generator.tool;
 
+import com.att.eelf.configuration.EELFLogger;
+import com.att.eelf.configuration.EELFManager;
 import java.io.StringReader;
 import javax.xml.parsers.DocumentBuilder;
 import javax.xml.parsers.DocumentBuilderFactory;
@@ -31,11 +33,15 @@ import org.codehaus.jettison.json.JSONArray;
 import org.codehaus.jettison.json.JSONException;
 import org.codehaus.jettison.json.JSONObject;
 import org.onap.sdnc.config.generator.ConfigGeneratorConstant;
-import org.w3c.dom.Document;
 import org.xml.sax.InputSource;
 
 public class CheckDataTool {
 
+    private static final EELFLogger logger = EELFManager.getInstance().getLogger(CheckDataTool.class);
+    private static final String STR_INPUT_DATA = "Input data: \n";
+
+    private CheckDataTool() {}
+
     public static String checkData(String data) {
         boolean isJSON = isJSON(data);
         if (isJSON) {
@@ -54,33 +60,26 @@ public class CheckDataTool {
         try {
             new JSONObject(data);
         } catch (JSONException ex) {
+            logger.error(STR_INPUT_DATA + data + "\n is not json object", ex);
             try {
                 new JSONArray(data);
             } catch (JSONException ex1) {
+                logger.error(STR_INPUT_DATA + data + "\n is not json array", ex1);
                 return false;
             }
         }
         return true;
-
-        // try {
-        // final ObjectMapper mapper = new ObjectMapper();
-        // mapper.readTree(data);
-        // return true;
-        // } catch (IOException e) {
-        // return false;
-        // }
     }
 
     public static boolean isXML(String data) {
         try {
             DocumentBuilderFactory dbFactory = DocumentBuilderFactory.newInstance();
             DocumentBuilder dBuilder = dbFactory.newDocumentBuilder();
-            Document doc = dBuilder.parse(new InputSource(new StringReader(data)));
+            dBuilder.parse(new InputSource(new StringReader(data)));
             return true;
         } catch (Exception ex) {
+            logger.error(STR_INPUT_DATA + data + "\n is not xml document", ex);
             return false;
         }
-
     }
-
 }
diff --git a/appc-config/appc-config-generator/provider/src/main/java/org/onap/sdnc/config/generator/tool/Constants.java b/appc-config/appc-config-generator/provider/src/main/java/org/onap/sdnc/config/generator/tool/Constants.java
index 00fda9fb7..7193dc91e 100644
--- a/appc-config/appc-config-generator/provider/src/main/java/org/onap/sdnc/config/generator/tool/Constants.java
+++ b/appc-config/appc-config-generator/provider/src/main/java/org/onap/sdnc/config/generator/tool/Constants.java
@@ -26,11 +26,10 @@ package org.onap.sdnc.config.generator.tool;
 
 public class Constants {
 
-    public static final String DBLIB_SERVICE =
-        "org.onap.ccsdk.sli.core.dblib.DBResourceManager";
+    public static final String DBLIB_SERVICE = "org.onap.ccsdk.sli.core.dblib.DBResourceManager";
     public static final String DEVICE_AUTHENTICATION = "DEVICE_AUTHENTICATION";
     public static final String SCHEMA_SDNCTL = "SDNCTL";
-
     public static final String APPC_CONFIG_DIR = "/opt/onap/appc/data/properties";
 
+    private Constants() {}
 }
diff --git a/appc-config/appc-config-generator/provider/src/main/java/org/onap/sdnc/config/generator/tool/CustomJsonNodeFactory.java b/appc-config/appc-config-generator/provider/src/main/java/org/onap/sdnc/config/generator/tool/CustomJsonNodeFactory.java
index 7a44b8b47..b0d96583b 100644
--- a/appc-config/appc-config-generator/provider/src/main/java/org/onap/sdnc/config/generator/tool/CustomJsonNodeFactory.java
+++ b/appc-config/appc-config-generator/provider/src/main/java/org/onap/sdnc/config/generator/tool/CustomJsonNodeFactory.java
@@ -29,8 +29,8 @@ import com.fasterxml.jackson.databind.node.TextNode;
 
 public class CustomJsonNodeFactory extends JsonNodeFactory {
 
+    @Override
     public TextNode textNode(String text) {
         return new CustomTextNode(text);
     }
-
 }
diff --git a/appc-config/appc-config-generator/provider/src/main/java/org/onap/sdnc/config/generator/tool/CustomTextNode.java b/appc-config/appc-config-generator/provider/src/main/java/org/onap/sdnc/config/generator/tool/CustomTextNode.java
index 2cfc643aa..101ad2a5c 100644
--- a/appc-config/appc-config-generator/provider/src/main/java/org/onap/sdnc/config/generator/tool/CustomTextNode.java
+++ b/appc-config/appc-config-generator/provider/src/main/java/org/onap/sdnc/config/generator/tool/CustomTextNode.java
@@ -44,9 +44,6 @@ public class CustomTextNode extends TextNode {
     }
 
     protected static void appendQuoted(StringBuilder sb, String content) {
-        // sb.append('"');
         CharTypes.appendQuoted(sb, content);
-        // sb.append('"');
     }
-
 }
diff --git a/appc-config/appc-config-generator/provider/src/main/java/org/onap/sdnc/config/generator/tool/DbServiceUtil.java b/appc-config/appc-config-generator/provider/src/main/java/org/onap/sdnc/config/generator/tool/DbServiceUtil.java
index c98429c02..a37b258f5 100644
--- a/appc-config/appc-config-generator/provider/src/main/java/org/onap/sdnc/config/generator/tool/DbServiceUtil.java
+++ b/appc-config/appc-config-generator/provider/src/main/java/org/onap/sdnc/config/generator/tool/DbServiceUtil.java
@@ -24,10 +24,12 @@
 
 package org.onap.sdnc.config.generator.tool;
 
+import com.google.common.collect.Lists;
 import java.io.File;
 import java.net.URL;
 import java.sql.SQLException;
 import java.util.ArrayList;
+import java.util.List;
 import java.util.Properties;
 import javax.sql.rowset.CachedRowSet;
 import org.onap.ccsdk.sli.core.dblib.DBResourceManager;
@@ -38,41 +40,36 @@ public class DbServiceUtil {
 
     private static final Logger log = LoggerFactory.getLogger(DbServiceUtil.class);
 
-    private static Properties props;
+    private static Properties properties;
     private static DBResourceManager jdbcDataSource = null;
 
 
-    public static boolean updateDB(String tableName, ArrayList inputArgs, String scema,
-        String whereClause, String setCluase) throws SQLException {
+    public static boolean updateDB(String tableName, List<String> inputArgs, String whereClause, String setClause)
+        throws SQLException {
         String updatePasswordString =
-            "update " + tableName + " set " + setCluase + " where " + whereClause;
-        boolean result =
-            jdbcDataSource.writeData(updatePasswordString, inputArgs, Constants.SCHEMA_SDNCTL);
-        return result;
+            "update " + tableName + " set " + setClause + " where " + whereClause;
+
+        return jdbcDataSource.writeData(updatePasswordString, Lists.newArrayList(inputArgs), Constants.SCHEMA_SDNCTL);
     }
 
 
-    public static CachedRowSet getData(String tableName, ArrayList argList, String schema,
+    public static CachedRowSet getData(String tableName, List<String> argList, String schema,
         String getselectData, String getDataClasue) throws SQLException {
         String selectQuery =
             "select " + getselectData + "from " + tableName + " where " + getDataClasue;
-        CachedRowSet data = jdbcDataSource.getData(selectQuery, argList, schema);
-        return data;
+        return jdbcDataSource.getData(selectQuery, Lists.newArrayList(argList), schema);
     }
 
 
     public static DBResourceManager initDbLibService() throws Exception {
-        props = new Properties();
+        properties = new Properties();
         File file = new File("/opt/onap/appc/data/properties/dblib.properties");
         URL propURL = file.toURI().toURL();
-        props.load(propURL.openStream());
+        properties.load(propURL.openStream());
 
         // this is an expected difference in CCSDK
-        jdbcDataSource = new DBResourceManager(props);
+        jdbcDataSource = new DBResourceManager(properties);
 
         return jdbcDataSource;
-
     }
-
-
 }
diff --git a/appc-config/appc-config-generator/provider/src/main/java/org/onap/sdnc/config/generator/tool/EscapeUtils.java b/appc-config/appc-config-generator/provider/src/main/java/org/onap/sdnc/config/generator/tool/EscapeUtils.java
index 177716187..8d3493fe4 100644
--- a/appc-config/appc-config-generator/provider/src/main/java/org/onap/sdnc/config/generator/tool/EscapeUtils.java
+++ b/appc-config/appc-config-generator/provider/src/main/java/org/onap/sdnc/config/generator/tool/EscapeUtils.java
@@ -28,9 +28,7 @@ import org.apache.commons.lang3.StringUtils;
 
 public class EscapeUtils {
 
-    public EscapeUtils() {
-        // TODO Auto-generated constructor stub
-    }
+    private EscapeUtils() {}
 
     public static String escapeSql(String str) {
         if (str == null) {
diff --git a/appc-config/appc-config-generator/provider/src/main/java/org/onap/sdnc/config/generator/tool/LogParserTool.java b/appc-config/appc-config-generator/provider/src/main/java/org/onap/sdnc/config/generator/tool/LogParserTool.java
index ebd58b01c..a9a7ecaf1 100644
--- a/appc-config/appc-config-generator/provider/src/main/java/org/onap/sdnc/config/generator/tool/LogParserTool.java
+++ b/appc-config/appc-config-generator/provider/src/main/java/org/onap/sdnc/config/generator/tool/LogParserTool.java
@@ -37,14 +37,14 @@ public class LogParserTool {
     private static final EELFLogger log = EELFManager.getInstance().getLogger(JSONTool.class);
 
     private String[] singleLines;
-    private List<String> recentErrors = new ArrayList<String>();
-    ;
+    private List<String> recentErrors = new ArrayList<>();
     private Date todaysDate = new Date();
     private SimpleDateFormat dFormat = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss");
-    private final int minMilli = 60000;
-    private final int IN_TIME = 0;
-    private final int NOT_IN_TIME = 1;
-    private final int NO_DATE = 2;
+
+    private static final int MIN_MILLI = 60000;
+    private static final int IN_TIME = 0;
+    private static final int NOT_IN_TIME = 1;
+    private static final int NO_DATE = 2;
 
     public String parseErrorLog(String data) {
         singleLines = data.split("\\r?\\n");
@@ -52,9 +52,9 @@ public class LogParserTool {
             getNearestDates();
 
         } catch (Exception e) {
-            e.printStackTrace();
+            log.error("Failed to get nearest dates", e);
         }
-        if (recentErrors.size() == 0) {
+        if (recentErrors.isEmpty()) {
             recentErrors.clear();
             return "Did not find the string 'Starting orchestration of file backed up to /var/opt/MetaSwitch/orch/orch_conf.json' in the log file with timestamp within the last 5 minutes";
         } else if (recentErrors.size() == 1) {
@@ -68,7 +68,7 @@ public class LogParserTool {
         }
     }
 
-    public void getNearestDates() throws ParseException {
+    private void getNearestDates() throws ParseException {
         int result;
         for (int i = singleLines.length - 1; i >= 0; i--) {
             if (singleLines[i].contains("Starting orchestration of file backed up to")
@@ -87,16 +87,14 @@ public class LogParserTool {
         Date newDate;
         try {
             newDate = dFormat.parse(line.substring(0, 19));
-            if ((todaysDate.getTime() - newDate.getTime()) <= 5 * minMilli) {
+            if ((todaysDate.getTime() - newDate.getTime()) <= 5 * MIN_MILLI) {
                 return IN_TIME;
             } else {
                 return NOT_IN_TIME;
             }
         } catch (ParseException e) {
-            e.printStackTrace();
+            log.error("Failed to parse date", e);
             return NO_DATE;
         }
     }
-
-
 }
diff --git a/appc-config/appc-config-generator/provider/src/main/java/org/onap/sdnc/config/generator/tool/MergeTool.java b/appc-config/appc-config-generator/provider/src/main/java/org/onap/sdnc/config/generator/tool/MergeTool.java
index 1126c2adb..e31cc5e93 100644
--- a/appc-config/appc-config-generator/provider/src/main/java/org/onap/sdnc/config/generator/tool/MergeTool.java
+++ b/appc-config/appc-config-generator/provider/src/main/java/org/onap/sdnc/config/generator/tool/MergeTool.java
@@ -26,14 +26,13 @@ package org.onap.sdnc.config.generator.tool;
 
 import com.att.eelf.configuration.EELFLogger;
 import com.att.eelf.configuration.EELFManager;
-import com.fasterxml.jackson.core.JsonParseException;
-import com.fasterxml.jackson.databind.JsonMappingException;
 import com.fasterxml.jackson.databind.JsonNode;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import java.io.IOException;
 import java.io.StringWriter;
 import java.util.Iterator;
 import java.util.Map;
+import java.util.Map.Entry;
 import org.apache.commons.lang3.StringUtils;
 import org.apache.velocity.Template;
 import org.apache.velocity.VelocityContext;
@@ -44,9 +43,10 @@ import org.apache.velocity.runtime.resource.loader.StringResourceLoader;
 import org.apache.velocity.runtime.resource.util.StringResourceRepository;
 import org.onap.sdnc.config.generator.ConfigGeneratorConstant;
 
-
 public class MergeTool {
 
+    private MergeTool() {}
+
     private static final EELFLogger log = EELFManager.getInstance().getLogger(MergeTool.class);
 
     public static String mergeMap2TemplateData(String template, Map<String, String> dataMap) {
@@ -64,19 +64,16 @@ public class MergeTool {
 
         Template t = ve.getTemplate("TemplateResource");
         VelocityContext context = new VelocityContext();
-        Iterator<Map.Entry<String, String>> entries = dataMap.entrySet().iterator();
-        while (entries.hasNext()) {
-            Map.Entry<String, String> entry = entries.next();
+        for (Entry<String, String> entry : dataMap.entrySet()) {
             context.put(entry.getKey(), entry.getValue());
         }
         t.merge(context, writer);
         return writer.toString();
     }
 
-
     public static String mergeJson2TemplateData(String template, String jsonData,
-        String templateType, String doPrettyOutput)
-        throws JsonParseException, JsonMappingException, IOException {
+        String templateType, String doPrettyOutput) throws IOException {
+
         String mergedData = template;
         if (StringUtils.isNotBlank(template) && StringUtils.isNotBlank(jsonData)) {
             Velocity.init();
@@ -99,17 +96,20 @@ public class MergeTool {
             writer.flush();
             mergedData = writer.toString();
 
-            if (StringUtils.isNotBlank(templateType) && StringUtils.isNotBlank(doPrettyOutput)
-                && ConfigGeneratorConstant.Y.equalsIgnoreCase(doPrettyOutput)
-                && (ConfigGeneratorConstant.DATA_TYPE_JSON.equalsIgnoreCase(templateType)
-                || ConfigGeneratorConstant.DATA_TYPE_XML
-                .equalsIgnoreCase(templateType))) {
+            if (prettyPrint(templateType, doPrettyOutput)) {
                 // Perform Prettying
-
             }
         }
         return mergedData;
+    }
 
+    private static boolean isJsonOrXml(String templateType) {
+        return ConfigGeneratorConstant.DATA_TYPE_JSON.equalsIgnoreCase(templateType)
+            || ConfigGeneratorConstant.DATA_TYPE_XML.equalsIgnoreCase(templateType);
     }
 
+    private static boolean prettyPrint(String templateType, String doPrettyOutput) {
+        return StringUtils.isNotBlank(templateType) && StringUtils.isNotBlank(doPrettyOutput)
+            && ConfigGeneratorConstant.Y.equalsIgnoreCase(doPrettyOutput) && isJsonOrXml(templateType);
+    }
 }