fixed some Sonar critical issues

Change-Id: I9dfe73a45b43919ff7b01ab3217d957a40ac2018
Issue-ID: APPC-408
Signed-off-by: Taka <tc012c@att.com>

4 files changed, 22 insertions, 0 deletions

diff --git a/appc-adapters/appc-iaas-adapter/appc-iaas-adapter-bundle/src/main/java/org/onap/appc/adapter/iaas/provider/operation/common/constants/Constants.java b/appc-adapters/appc-iaas-adapter/appc-iaas-adapter-bundle/src/main/java/org/onap/appc/adapter/iaas/provider/operation/common/constants/Constants.java
index 503cb1ae8..819118f48 100644
--- a/appc-adapters/appc-iaas-adapter/appc-iaas-adapter-bundle/src/main/java/org/onap/appc/adapter/iaas/provider/operation/common/constants/Constants.java
+++ b/appc-adapters/appc-iaas-adapter/appc-iaas-adapter-bundle/src/main/java/org/onap/appc/adapter/iaas/provider/operation/common/constants/Constants.java
@@ -29,6 +29,9 @@ package org.onap.appc.adapter.iaas.provider.operation.common.constants;
  */
 public class Constants {
 
+    private Constants() {
+    }
+
     public static final String DATE_FORMAT = "yyyy-MM-dd HH:mm:ss";
 
     public static final String MDC_SERVICE = "service";
diff --git a/appc-adapters/appc-iaas-adapter/appc-iaas-adapter-bundle/src/main/java/org/onap/appc/adapter/iaas/provider/operation/common/constants/Property.java b/appc-adapters/appc-iaas-adapter/appc-iaas-adapter-bundle/src/main/java/org/onap/appc/adapter/iaas/provider/operation/common/constants/Property.java
index 90532b92d..363b7a6e9 100644
--- a/appc-adapters/appc-iaas-adapter/appc-iaas-adapter-bundle/src/main/java/org/onap/appc/adapter/iaas/provider/operation/common/constants/Property.java
+++ b/appc-adapters/appc-iaas-adapter/appc-iaas-adapter-bundle/src/main/java/org/onap/appc/adapter/iaas/provider/operation/common/constants/Property.java
@@ -29,6 +29,8 @@ package org.onap.appc.adapter.iaas.provider.operation.common.constants;
  */
 public class Property {
 
+    private Property() {
+    }
     public static final String PROVIDER = "provider";
     public static final String PROVIDER_IDENTITY = "identity";
     public static final String PROVIDER_TENANT = "tenant";
diff --git a/appc-adapters/appc-iaas-adapter/appc-iaas-adapter-bundle/src/main/java/org/onap/appc/adapter/iaas/provider/operation/common/enums/Operation.java b/appc-adapters/appc-iaas-adapter/appc-iaas-adapter-bundle/src/main/java/org/onap/appc/adapter/iaas/provider/operation/common/enums/Operation.java
index 34f763144..81e1c9289 100644
--- a/appc-adapters/appc-iaas-adapter/appc-iaas-adapter-bundle/src/main/java/org/onap/appc/adapter/iaas/provider/operation/common/enums/Operation.java
+++ b/appc-adapters/appc-iaas-adapter/appc-iaas-adapter-bundle/src/main/java/org/onap/appc/adapter/iaas/provider/operation/common/enums/Operation.java
@@ -27,76 +27,91 @@ package org.onap.appc.adapter.iaas.provider.operation.common.enums;
  */
 public enum Operation {
     EVACUATE_SERVICE {
+        @Override
         public String toString() {
             return "evacuateServer";
         }
     },
     MIGRATE_SERVICE {
+        @Override
         public String toString() {
             return "migrateServer";
         }
     },
     REBUILD_SERVICE {
+        @Override
         public String toString() {
             return "rebuildServer";
         }
     },
     RESTART_SERVICE {
+        @Override
         public String toString() {
             return "restartServer";
         }
     },
     VMSTATUSCHECK_SERVICE {
+        @Override
         public String toString() {
             return "vmStatuschecker";
         }
     },
     SNAPSHOT_SERVICE {
+        @Override
         public String toString() {
             return "createSnapshot";
         }
     },
     TERMINATE_STACK {
+        @Override
         public String toString() {
             return "terminateStack";
         }
     },
     SNAPSHOT_STACK {
+        @Override
         public String toString() {
             return "snapshotStack";
         }
     },
     START_SERVICE {
+        @Override
         public String toString() {
             return "startServer";
         }
     },
     STOP_SERVICE {
+        @Override
         public String toString() {
             return "stopServer";
         }
     },
     TERMINATE_SERVICE {
+        @Override
         public String toString() {
             return "terminateServer";
         }
     },
     LOOKUP_SERVICE {
+        @Override
         public String toString() {
             return "lookupServer";
         }
     },
     RESTORE_STACK {
+        @Override
         public String toString() {
             return "restoreStack";
         }
     },
     ATTACHVOLUME_SERVICE {
+        @Override
         public String toString(){
             return "attachVolume";
         }
     },
     DETACHVOLUME_SERVICE {
+        @Override
         public String toString(){
             return "dettachVolume";
         }
diff --git a/appc-adapters/appc-iaas-adapter/appc-iaas-adapter-bundle/src/main/java/org/onap/appc/adapter/iaas/provider/operation/common/enums/Outcome.java b/appc-adapters/appc-iaas-adapter/appc-iaas-adapter-bundle/src/main/java/org/onap/appc/adapter/iaas/provider/operation/common/enums/Outcome.java
index 972409174..5760879e1 100644
--- a/appc-adapters/appc-iaas-adapter/appc-iaas-adapter-bundle/src/main/java/org/onap/appc/adapter/iaas/provider/operation/common/enums/Outcome.java
+++ b/appc-adapters/appc-iaas-adapter/appc-iaas-adapter-bundle/src/main/java/org/onap/appc/adapter/iaas/provider/operation/common/enums/Outcome.java
@@ -29,11 +29,13 @@ package org.onap.appc.adapter.iaas.provider.operation.common.enums;
  */
 public enum Outcome {
     FAILURE {
+        @Override
         public String toString() {
             return "failure";
         }
     },
     SUCCESS {
+        @Override
         public String toString() {
             return "success";
         }