summaryrefslogtreecommitdiffstats
path: root/appc-adapters/appc-dmaap-adapter/appc-message-adapter-api
diff options
context:
space:
mode:
authorwejs <maciej.wejs@nokia.com>2018-02-23 15:59:31 +0100
committerPatrick Brady <pb071s@att.com>2018-03-01 08:40:41 +0000
commit1aeaed6f086ebd2c6621867146112e4f2f675429 (patch)
treeb9a1d21676419888869b784ce922b140c429d6fd /appc-adapters/appc-dmaap-adapter/appc-message-adapter-api
parent1e65cff150f78124da0a7d2df84d1e92fbd00ac3 (diff)
Fixes in "appc-dmaap-adapter-bundle"
Correction of Sonar and CheckStyle issues Added JUnit test coverage. Change-Id: I119c7555e33e09c87b572ff0b63f55e2884be75f Issue-ID: APPC-646 Signed-off-by: wejs <maciej.wejs@nokia.com>
Diffstat (limited to 'appc-adapters/appc-dmaap-adapter/appc-message-adapter-api')
-rw-r--r--appc-adapters/appc-dmaap-adapter/appc-message-adapter-api/src/main/java/org/onap/appc/adapter/message/Consumer.java30
-rw-r--r--appc-adapters/appc-dmaap-adapter/appc-message-adapter-api/src/main/java/org/onap/appc/adapter/message/Producer.java24
2 files changed, 27 insertions, 27 deletions
diff --git a/appc-adapters/appc-dmaap-adapter/appc-message-adapter-api/src/main/java/org/onap/appc/adapter/message/Consumer.java b/appc-adapters/appc-dmaap-adapter/appc-message-adapter-api/src/main/java/org/onap/appc/adapter/message/Consumer.java
index 92033064c..e3a46087d 100644
--- a/appc-adapters/appc-dmaap-adapter/appc-message-adapter-api/src/main/java/org/onap/appc/adapter/message/Consumer.java
+++ b/appc-adapters/appc-dmaap-adapter/appc-message-adapter-api/src/main/java/org/onap/appc/adapter/message/Consumer.java
@@ -9,15 +9,15 @@
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
- *
+ *
* http://www.apache.org/licenses/LICENSE-2.0
- *
+ *
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
- *
+ *
* ECOMP is a trademark and service mark of AT&T Intellectual Property.
* ============LICENSE_END=========================================================
*/
@@ -30,14 +30,14 @@ public interface Consumer {
/**
* Gets a batch of messages from the topic. Defaults to 1000 messages with 15s wait for messages if empty.
- *
+ *
* @return A list of strings representing the messages pulled from the topic.
*/
- public List<String> fetch();
+ List<String> fetch();
/**
* Gets a batch of messages from the topic.
- *
+ *
* @param waitMs
* The amount of time to wait in milliseconds if the topic is empty for data to be written. Should be no
* less than 15000ms to prevent too many requests
@@ -45,29 +45,29 @@ public interface Consumer {
* The amount of messages to fetch
* @return A list of strings representing the messages pulled from the topic.
*/
- public List<String> fetch(int waitMs, int limit);
+ List<String> fetch(int waitMs, int limit);
/**
- * Updates the api credentials for making authenticated requests
- *
+ * Updates the api credentials for making authenticated requests.
+ *
* @param apiKey
* The public key to authenticate with
* @param apiSecret
* The secret key to authenticate with
*/
- public void updateCredentials(String apiKey, String apiSecret);
+ void updateCredentials(String apiKey, String apiSecret);
/**
* Creates a dmaap client using a https connection
- *
+ *
* @param yes
- * True if https should be used, false otherwise
+ * True if https should be used, false otherwise.
*/
- public void useHttps(boolean yes);
+ default void useHttps(boolean yes) {}
/**
- * Closes the dmaap client https connection
+ * Closes the dmaap client https connection.
*/
- void close();
+ default void close() {}
}
diff --git a/appc-adapters/appc-dmaap-adapter/appc-message-adapter-api/src/main/java/org/onap/appc/adapter/message/Producer.java b/appc-adapters/appc-dmaap-adapter/appc-message-adapter-api/src/main/java/org/onap/appc/adapter/message/Producer.java
index 52ead0253..c7194d080 100644
--- a/appc-adapters/appc-dmaap-adapter/appc-message-adapter-api/src/main/java/org/onap/appc/adapter/message/Producer.java
+++ b/appc-adapters/appc-dmaap-adapter/appc-message-adapter-api/src/main/java/org/onap/appc/adapter/message/Producer.java
@@ -9,15 +9,15 @@
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
- *
+ *
* http://www.apache.org/licenses/LICENSE-2.0
- *
+ *
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
- *
+ *
* ECOMP is a trademark and service mark of AT&T Intellectual Property.
* ============LICENSE_END=========================================================
*/
@@ -26,29 +26,29 @@ package org.onap.appc.adapter.message;
public interface Producer {
- public boolean post(String partition, String data);
+ boolean post(String partition, String data);
/**
- * Updates the api credentials for making authenticated requests
- *
+ * Updates the api credentials for making authenticated requests.
+ *
* @param apiKey
* The public key to authenticate with
* @param apiSecret
* The secret key to authenticate with
*/
- public void updateCredentials(String apiKey, String apiSecret);
+ void updateCredentials(String apiKey, String apiSecret);
/**
- * Creates a dmaap client using a https connection
- *
+ * Creates a dmaap client using a https connection.
+ *
* @param yes
* True if https should be used, false otherwise
*/
- public void useHttps(boolean yes);
+ default void useHttps(boolean yes) {}
/**
- * Closes the dmaap client https connection
+ * Closes the dmaap client https connection.
*/
- void close();
+ default void close() {}
}