summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJoss Armstrong <joss.armstrong@ericsson.com>2019-02-22 14:56:40 +0000
committerTakamune Cho <takamune.cho@att.com>2019-02-22 17:06:02 +0000
commit8c0057e9f185d0ca632c2072a182cbee46f92c50 (patch)
treeb47ef05b0c76c52286fb8f3b95ee94fa60d85690
parentb9a571dbcf43810353c3f00a6839d80570ed1d6b (diff)
Test coverage in AbstractRequestHandlerImpl
Increased coverage from 72% to 95% Issue-ID: APPC-1484 Change-Id: I1bbb8aaf1b7ca33b20d8768cacd14c7bdabe5caa Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
-rwxr-xr-xappc-dispatcher/appc-request-handler/appc-request-handler-core/src/test/java/org/onap/appc/requesthandler/impl/AbstractRequestHandlerImplTest.java72
1 files changed, 64 insertions, 8 deletions
diff --git a/appc-dispatcher/appc-request-handler/appc-request-handler-core/src/test/java/org/onap/appc/requesthandler/impl/AbstractRequestHandlerImplTest.java b/appc-dispatcher/appc-request-handler/appc-request-handler-core/src/test/java/org/onap/appc/requesthandler/impl/AbstractRequestHandlerImplTest.java
index 226c670da..a2c3ec360 100755
--- a/appc-dispatcher/appc-request-handler/appc-request-handler-core/src/test/java/org/onap/appc/requesthandler/impl/AbstractRequestHandlerImplTest.java
+++ b/appc-dispatcher/appc-request-handler/appc-request-handler-core/src/test/java/org/onap/appc/requesthandler/impl/AbstractRequestHandlerImplTest.java
@@ -1,6 +1,6 @@
/*
* ============LICENSE_START=======================================================
- * Copyright (C) 2018 Ericsson. All rights reserved.
+ * Copyright (C) 2018-2019 Ericsson. All rights reserved.
* ================================================================================
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this
* file except in compliance with the License. You may obtain a copy of the License at
@@ -24,19 +24,14 @@ import static org.mockito.Mockito.doThrow;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.spy;
import static org.mockito.Mockito.times;
-import static org.powermock.api.mockito.PowerMockito.mockStatic;
-
-import com.att.eelf.configuration.EELFLogger;
-import com.att.eelf.configuration.EELFLogger.Level;
-import com.att.eelf.configuration.EELFManager;
-
import java.util.Arrays;
import java.util.Date;
import java.util.List;
-
import org.junit.Assert;
import org.junit.Before;
+import org.junit.Rule;
import org.junit.Test;
+import org.junit.rules.ExpectedException;
import org.junit.runner.RunWith;
import org.mockito.Mockito;
import org.onap.appc.domainmodel.lcm.ActionIdentifiers;
@@ -54,19 +49,32 @@ import org.onap.appc.executor.objects.LCMCommandStatus;
import org.onap.appc.lockmanager.api.LockException;
import org.onap.appc.messageadapter.MessageAdapter;
import org.onap.appc.metricservice.MetricRegistry;
+import org.onap.appc.metricservice.MetricService;
import org.onap.appc.metricservice.impl.MetricRegistryImpl;
+import org.onap.appc.metricservice.metric.DispatchingFunctionCounterBuilder;
+import org.onap.appc.metricservice.metric.DispatchingFuntionMetric;
+import org.onap.appc.metricservice.metric.MetricBuilderFactory;
import org.onap.appc.metricservice.metric.MetricType;
import org.onap.appc.metricservice.metric.impl.DispatchingFuntionMetricImpl;
+import org.onap.appc.metricservice.policy.PolicyBuilderFactory;
+import org.onap.appc.metricservice.policy.PublishingPolicy;
+import org.onap.appc.metricservice.policy.ScheduledPolicyBuilder;
import org.onap.appc.requesthandler.exceptions.RequestValidationException;
import org.onap.appc.requesthandler.helper.RequestValidator;
import org.onap.appc.requesthandler.objects.RequestHandlerInput;
import org.onap.appc.requesthandler.objects.RequestHandlerOutput;
import org.onap.appc.transactionrecorder.TransactionRecorder;
+import org.osgi.framework.Bundle;
+import org.osgi.framework.BundleContext;
import org.osgi.framework.FrameworkUtil;
+import org.osgi.framework.ServiceReference;
import org.powermock.api.mockito.PowerMockito;
import org.powermock.core.classloader.annotations.PrepareForTest;
import org.powermock.modules.junit4.PowerMockRunner;
import org.powermock.reflect.Whitebox;
+import com.att.eelf.configuration.EELFLogger;
+import com.att.eelf.configuration.EELFLogger.Level;
+import com.att.eelf.configuration.EELFManager;
@RunWith(PowerMockRunner.class)
@PrepareForTest({FrameworkUtil.class})
@@ -74,6 +82,13 @@ public class AbstractRequestHandlerImplTest implements LocalRequestHanlderTestHe
private AbstractRequestHandlerImpl requestHandler;
private TransactionRecorder recorder;
+ private final BundleContext bundleContext = Mockito.mock(BundleContext.class);
+ private final Bundle bundleService = Mockito.mock(Bundle.class);
+ private final ServiceReference sref = Mockito.mock(ServiceReference.class);
+ private final MetricService metricService = Mockito.mock(MetricService.class);
+
+ @Rule
+ public ExpectedException expectedEx = ExpectedException.none();
@Before
public void setUp() throws Exception {
@@ -186,6 +201,47 @@ public class AbstractRequestHandlerImplTest implements LocalRequestHanlderTestHe
Assert.assertEquals(19, i);
}
+ @Test
+ public void testMetric() throws Exception {
+ PowerMockito.mockStatic(FrameworkUtil.class);
+ PowerMockito.when(FrameworkUtil.getBundle(MetricService.class)).thenReturn(bundleService);
+ PowerMockito.when(bundleService.getBundleContext()).thenReturn(bundleContext);
+ PowerMockito.when(bundleContext.getServiceReference(MetricService.class.getName())).thenReturn(sref);
+ PowerMockito.when(bundleContext.getService(sref)).thenReturn(metricService);
+ MetricRegistry metricRegistry = Mockito.mock(MetricRegistry.class);
+ DispatchingFuntionMetric dispatchingFunctionMetric = Mockito.mock(DispatchingFuntionMetric.class);
+ DispatchingFunctionCounterBuilder dispatchingFunctionCounterBuilder = Mockito.mock(DispatchingFunctionCounterBuilder.class);
+ MetricBuilderFactory metricBuilderFactory = Mockito.mock(MetricBuilderFactory.class);
+ Mockito.when(dispatchingFunctionCounterBuilder.withName("DISPATCH_FUNCTION")).thenReturn(dispatchingFunctionCounterBuilder);
+ Mockito.when(dispatchingFunctionCounterBuilder.withType(MetricType.COUNTER)).thenReturn(dispatchingFunctionCounterBuilder);
+ Mockito.when(dispatchingFunctionCounterBuilder.withAcceptRequestValue(0)).thenReturn(dispatchingFunctionCounterBuilder);
+ Mockito.when(dispatchingFunctionCounterBuilder.withRejectRequestValue(0)).thenReturn(dispatchingFunctionCounterBuilder);
+ Mockito.when(dispatchingFunctionCounterBuilder.build()).thenReturn(dispatchingFunctionMetric);
+ Mockito.when(metricBuilderFactory.dispatchingFunctionCounterBuilder()).thenReturn(dispatchingFunctionCounterBuilder);
+ Mockito.when(metricRegistry.metricBuilderFactory()).thenReturn(metricBuilderFactory);
+ Mockito.when(metricService.createRegistry("APPC")).thenReturn(metricRegistry);
+ Mockito.when(metricRegistry.register(dispatchingFunctionMetric)).thenReturn(true);
+
+ PublishingPolicy publishingPolicy = Mockito.mock(PublishingPolicy.class);
+ PolicyBuilderFactory policyBuilderFactory = Mockito.mock(PolicyBuilderFactory.class);
+ ScheduledPolicyBuilder scheduledPolicyBuilder = Mockito.mock(ScheduledPolicyBuilder.class);
+ Mockito.when(policyBuilderFactory.scheduledPolicyBuilder()).thenReturn(scheduledPolicyBuilder);
+ Mockito.when(scheduledPolicyBuilder.withPublishers(Mockito.any())).thenReturn(scheduledPolicyBuilder);
+ Mockito.when(scheduledPolicyBuilder.withMetrics(Mockito.any())).thenReturn(scheduledPolicyBuilder);
+ Mockito.when(scheduledPolicyBuilder.build()).thenReturn(publishingPolicy);
+ Mockito.when(metricRegistry.policyBuilderFactory()).thenReturn(policyBuilderFactory);
+ Whitebox.invokeMethod(requestHandler, "initMetric");
+ Mockito.verify(publishingPolicy).init();
+ }
+
+ @Test
+ public void testMetricNullMetricService() throws Exception {
+ expectedEx.expect(NullPointerException.class);
+ expectedEx.expectMessage("org.onap.appc.metricservice.MetricService is null. " +
+ "Failed to init Metric");
+ Whitebox.invokeMethod(requestHandler, "initMetric");
+ }
+
private RequestHandlerInput setupTestForHandleRequest() {
Whitebox.setInternalState(requestHandler, "isMetricEnabled", true);
MetricRegistry metricRegistry = spy(new MetricRegistryImpl("TEST_METRIC_REGISTRY"));