aboutsummaryrefslogtreecommitdiffstats
path: root/src/main/java/org/onap
diff options
context:
space:
mode:
authorrama-huawei <rama.subba.reddy.s@huawei.com>2017-09-28 14:11:07 +0530
committerRama SubbaReddy <rama.subba.reddy.s@huawei.com>2017-09-28 09:09:02 +0000
commit0a6e3351cce03350b59d9af91cbe38f3233ca0ff (patch)
treeeaa26241d9329d70e88824995211966b0a28bd78 /src/main/java/org/onap
parentc3da674039c279812a11b187059003216413b1cc (diff)
Used entrySet instead of keySet
Issue-id: CIMAN-65 Change-Id: I58cba3d30e6866050801fb94426cdc0b26a2f75f Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com>
Diffstat (limited to 'src/main/java/org/onap')
-rw-r--r--src/main/java/org/onap/aai/datarouter/entity/AaiEventEntity.java11
-rw-r--r--src/main/java/org/onap/aai/datarouter/entity/AggregationEntity.java22
2 files changed, 19 insertions, 14 deletions
diff --git a/src/main/java/org/onap/aai/datarouter/entity/AaiEventEntity.java b/src/main/java/org/onap/aai/datarouter/entity/AaiEventEntity.java
index c32cd6f..0391ae3 100644
--- a/src/main/java/org/onap/aai/datarouter/entity/AaiEventEntity.java
+++ b/src/main/java/org/onap/aai/datarouter/entity/AaiEventEntity.java
@@ -72,9 +72,9 @@ public class AaiEventEntity implements DocumentStoreDataEntity, Serializable {
protected String entityType;
protected String entityPrimaryKeyName;
protected String entityPrimaryKeyValue;
- protected ArrayList<String> searchTagCollection = new ArrayList<String>();
- protected ArrayList<String> searchTagIdCollection = new ArrayList<String>();
- protected ArrayList<String> crossEntityReferenceCollection = new ArrayList<String>();
+ protected ArrayList<String> searchTagCollection = new ArrayList<>();
+ protected ArrayList<String> searchTagIdCollection = new ArrayList<>();
+ protected ArrayList<String> crossEntityReferenceCollection = new ArrayList<>();
protected String lastmodTimestamp;
protected String link;
@@ -95,7 +95,7 @@ public class AaiEventEntity implements DocumentStoreDataEntity, Serializable {
private static String convertBytesToHexString(byte[] bytesToConvert) {
- StringBuffer hexString = new StringBuffer();
+ StringBuilder hexString = new StringBuilder();
for (int i = 0; i < bytesToConvert.length; i++) {
hexString.append(Integer.toHexString(0xFF & bytesToConvert[i]));
}
@@ -104,13 +104,12 @@ public class AaiEventEntity implements DocumentStoreDataEntity, Serializable {
private static String concatArray(List<String> list, char delimiter) {
- if (list == null || list.size() == 0) {
+ if (list == null || list.isEmpty()) {
return "";
}
StringBuilder result = new StringBuilder(64);
- int listSize = list.size();
boolean firstValue = true;
for (String item : list) {
diff --git a/src/main/java/org/onap/aai/datarouter/entity/AggregationEntity.java b/src/main/java/org/onap/aai/datarouter/entity/AggregationEntity.java
index 44927eb..56ef6fd 100644
--- a/src/main/java/org/onap/aai/datarouter/entity/AggregationEntity.java
+++ b/src/main/java/org/onap/aai/datarouter/entity/AggregationEntity.java
@@ -49,6 +49,8 @@ public class AggregationEntity implements DocumentStoreDataEntity, Serializable
public void setLink(String link) {
this.link = link;
}
+
+ @Override
public String getId() {
// make sure that deliveFields() is called before getting the id
return id;
@@ -66,7 +68,7 @@ public class AggregationEntity implements DocumentStoreDataEntity, Serializable
}
- Map<String, String> attributes = new HashMap<String, String>();
+ Map<String, String> attributes = new HashMap<>();
ObjectMapper mapper = new ObjectMapper();
/**
@@ -86,20 +88,22 @@ public class AggregationEntity implements DocumentStoreDataEntity, Serializable
while (nodes.hasNext()) {
Map.Entry<String, JsonNode> entry = (Map.Entry<String, JsonNode>) nodes.next();
- if (!entry.getKey().equalsIgnoreCase("relationship-list")){
+ if (!"relationship-list".equalsIgnoreCase(entry.getKey())){
attributes.put(entry.getKey(), entry.getValue().asText());
}
}
}
public void copyAttributeKeyValuePair(Map<String, Object> map){
- for(String key: map.keySet()){
- if (!key.equalsIgnoreCase("relationship-list")){ // ignore relationship data which is not required in aggregation
- this.attributes.put(key, map.get(key).toString()); // not sure if entity attribute can contain an object as value
+ for(Map.Entry<String, Object> entry: map.entrySet()){
+ String key = entry.getKey();
+ Object value = entry.getValue();
+ if (!"relationship-list".equalsIgnoreCase(key)){ // ignore relationship data which is not required in aggregation
+ this.attributes.put(key, value.toString()); // not sure if entity attribute can contain an object as value
}
}
}
-
+
public void addAttributeKeyValuePair(String key, String value){
this.attributes.put(key, value);
}
@@ -108,8 +112,10 @@ public class AggregationEntity implements DocumentStoreDataEntity, Serializable
ObjectNode rootNode = mapper.createObjectNode();
rootNode.put("link", this.getLink());
rootNode.put("lastmodTimestamp", lastmodTimestamp);
- for (String key: this.attributes.keySet()){
- rootNode.put(key, this.attributes.get(key));
+ for (Map.Entry<String, String> entry: this.attributes.entrySet()){
+ String key = entry.getKey();
+ String value = entry.getValue();
+ rootNode.put(key, value);
}
return rootNode.toString();
}