summaryrefslogtreecommitdiffstats
path: root/aai-core
AgeCommit message (Collapse)AuthorFilesLines
2024-08-05Add test for transaction rollback in HttpEntryFiete Ostkamp33-63/+189
- verify that transaction is rolled back when writing a request in a batch fails - remove all unused imports Issue-ID: AAI-3942 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de> Change-Id: I93cd1efa08db533a088e242694f07ff10db36b4e
2024-08-01Add tests for the NotificationServiceFiete Ostkamp7-83/+375
- change approach how ValidationService is injected into NotificationService - add tests for NotificationService - assert invokation of NotificationService instead of ValidationService in HttpEntryTest now Issue-ID: AAI-3940 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de> Change-Id: I4476857f7192f53de216f0515f0e69c642c33d1c
2024-07-23Make JMS-based messaging compatible with tracingFiete Ostkamp13-420/+560
- use dependency injection instead of new Foo() for jms related classes - inject interfaces and not their implementations - add integration test that asserts message sending via JMS to Kafka [1] [1] this also prepares removal of ActiveMQ as a middleman Issue-ID: AAI-3932 Change-Id: Icbdd264f5b52adc72aa05046ed66d9bd5108c372 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de>
2024-07-20Extract HttpEntry notification logic into a separate NotificationServiceFiete Ostkamp19-271/+235
- introduce NotificationService - rename ueb package to notification - remove meaningless javadocs Issue-ID: AAI-3930 Change-Id: Ic6ffd5511235d2400b0d6db71f7d7aa13d2b076b Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de>
2024-07-09Bump aai-common version to 1.14.5-SNAPSHOTFiete Ostkamp1-1/+1
Issue-ID: AAI-3928 Change-Id: I0bf49334b9c48df447082979e4311e922052775d Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de>
2024-07-08Update Janusgraph to 0.6.0 in aai-commonFiete Ostkamp5-1072/+1082
- update Tinkerpop (3.4.13 -> 3.5.0) + Janusgraph (0.5.0 -> 0.6.0) - bump version to 1.14.4-SNAPSHOT Issue-ID: AAI-3914 Change-Id: I4beeb2db6f2ba4b9ee25b084bb42dd551cda1375 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de>
2024-07-03Pagination will throw an IllegalArgumentException if there are no vertices ↵Fiete Ostkamp3-2034/+2060
of the requested type - provide empty PaginationResponse when traversal.next() throws IllegalArgumentException Issue-ID: AAI-3917 Change-Id: I280f216050ea16953015023146d40674e067f028 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de>
2024-06-28Update Janusgraph to 0.5.0 in aai-commonFiete Ostkamp3-195/+20
- update tinkerpop to 3.4.13 - update janusgraph to 0.5.0 - restore the total-pages header that was accidentally removed in the last pagination commit - remove stateful pagination logic from HttpEntry Issue-ID: AAI-3900 Change-Id: I5fac397ece75136673b8dc3866e10ff15dfdcee3 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de>
2024-06-26Add gremlin-based pagination to aai-commonFiete Ostkamp12-85/+549
- enhance query building to support gremlin-based pagination - pagination is supported in two variants: with and without the total count of elements [1] - enhance query building to support gremlin-based sorting - add query logging that is currently disabled [1] due to the design of gremlin, including the total count results in a full graph scan. As such there is the option to not include it, which should make it (much) faster for the first pages that are returned. Issue-ID: AAI-3893 Change-Id: I6bc0c9b9f398556cc41a0a8f82e24e50c85e5690 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de>
2024-06-19Update Janusgraph to 0.4.0 in aai-commonFiete Ostkamp1-1/+1
- update tinkerpop to 3.4.0 + janusgraph to 0.4.0 - bump snapshot version to 1.14.2-SNAPSHOT Issue-ID: AAI-3888 Change-Id: I2e45b37e4cda4f82c46399a899ba28f7463c0a95 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de>
2024-06-17Bump aai-common version to 1.14.1Fiete Ostkamp1-1/+1
Issue-ID: AAI-3883 Change-Id: If89ec7af4b54462852c5578597112eb371b0c2f6 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de>
2024-06-15Update tinkerpop to 3.3.11 in aai-commonFiete Ostkamp2-1/+6
Issue-ID: AAI-3875 Change-Id: Iba69b1d4850fcd86dc0ee9cd209c74396e2e8f4a Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de>
2024-06-04Merge "Update janusgraph to 0.3.3"Fiete Ostkamp10-21/+47
2024-06-04Update janusgraph to 0.3.3Fiete Ostkamp10-21/+47
- update tinkerpop version from 3.2.11 to 3.3.0 - update janusgraph from 0.2.3 to 0.3.3 - the default GraphSON version would change with this update but was held back [1] - add jackson-dataformat-xml dependency to aai-core as the XmlMapper is used in the ErrorLogHelper [1] a separate story AAI-3796 - Use GraphSON v2 or v3 in AAI has been created for this Issue-ID: AAI-3795 Change-Id: I4539e83aa74c260d5238ebe869e9884d4396e9f4 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de>
2024-05-29Refactor the ValidationServiceFiete Ostkamp3-86/+103
- slightly refactor the code - assert it's invocation in the HttpEntryTest Issue-ID: AAI-3864 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de> Change-Id: If8d218f5c6467956e25fd1c4deb588f3fb5c7d2c
2024-05-28Refactor HttpEntry class - Part 1Fiete Ostkamp4-60/+60
- simplify setHttpEntryProperties (later on this will likely be done in the constructor) - move some logic of UEBNotification into separate methods - resolve jsonassert dependency conflict Issue-ID: AAI-3863 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de> Change-Id: Ic84b43156890352509dc9c547478abdf53e96d6a
2024-04-12Change AAI-Common SNAPSHOT Version from 1.13.5 to 1.13.6Singh1-1/+1
- Update AAI-common version from 1.13.5-SNAPSHOT to 1.13.6-SNAPSHOT Issue-ID: AAI-3792 Change-Id: Ic281351007bab8bbc634c8f431be6bcd27ad83cd Signed-off-by: Singh <soumya.e.singh@accenture.com>
2024-04-10Remove DMaaP dependency from AAI-CommonSingh16-411/+593
- Remove Dmaap dependency in AAI-Common and replace it with Kafka. Issue-ID: AAI-3792 Change-Id: If3fd5c3bdc2448f7e260a26000b02a510c80d7fb Signed-off-by: Singh <soumya.e.singh@accenture.com>
2024-02-26Only load SchemaService related beans in aai-common when ↵Fiete Ostkamp2-9/+2
schema.translator.list=schema-service - conditionally load schema-service related config, otherwise use the ConfigTranslator - this prepares locally running traversal via mvn spring-boot:run Issue-ID: AAI-3787 Change-Id: I9415802fb708933e8596b62e7540fa8a156e4cd6 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de>
2024-02-21Enhance SchemaGenerator to also generate indices for relationshipsFiete Ostkamp5-116/+359
- generate edge indexes when they not already exist - reindex existing indexes when they are not in status ENABLED - try to recover indexes that are in INSTALLED state - bump version to 1.13.5 Issue-ID: AAI-3782 Change-Id: I127e0f83b17485d7a6721206ade92cd50c89a51b Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de>
2024-02-06Switch aai-common baseimage back to java 8Fiete Ostkamp1-1/+1
- downgrade base image to java 8 until aai-common is compatible with java 11 Issue-ID: AAI-3766 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de> Change-Id: I90505b6a15b92fcf983e6444b60523574b2d2388
2024-02-05Bump version to 1.13.3Fiete Ostkamp1-1/+1
Issue-ID: AAI-3762 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de> Change-Id: I8fc12af8d43996ca5408679e78632ca91f13a6e3
2024-02-05Pivoting a TraversalURIOptimisedQuery is broken in release 1.13.2Fiete Ostkamp5-44/+180
- fix query building for TraversalURIOptimizedQuery - enable DataLinkTests for TRAVERSAL_URI again - add further tests to test pivoting more directly - roll back version to 1.13.2 to rerelease fixed version - add python six dependency to fix upstream issue with sphinxcontrib-swagger dependency Issue-ID: AAI-3758 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de> Change-Id: I3e54216e00d0491d64265e149f55cf8aba6fabd9
2024-01-29Update tinkerpop to 3.2.11Fiete Ostkamp1-2/+1
- update tinkerpop from 3.2.4 to 3.2.11 - bump version to 1.13.3 Issue-ID: AAI-3745 Change-Id: I492aba96f8e4916bc99e80fc24e9e20da26c20ba Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de>
2024-01-25Update tinkerpop to 3.2.4Fiete Ostkamp11-39/+357
- work around hasStep inlining - add tests that more directly assert traversal state - add TinkerpopUpgradeTests test suite [1] - bump aai-common version to 1.13.2 [1] this allows to run the tests that are likely affected by a tinkerpop upgrade Issue-ID: AAI-3740 Change-Id: I86fb9b0c86802c7c0f74a5aae0976e81bf501eb0 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de>
2024-01-22Merge "Revert "Update tinkerpop to 3.2.3 in aai-core""Nandkishor Patke5-179/+105
2024-01-20Update tinkerpop to 3.2.3 in aai-coreFiete Ostkamp1-4/+8
- no not apply the InlineFilterStrategy optimisation [1] [1] the strategy aggregates consecutive has-steps into one has([...]). This messes with the container and parent query step indices that are saved while building the query. Issue-ID: AAI-3554 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de> Change-Id: I5b63ce16b8020633ea059fed7f70577661758415
2024-01-20Revert "Update tinkerpop to 3.2.3 in aai-core"Fiete Ostkamp5-179/+105
This reverts commit 4e7ca21da096ff03ca70451fb5e7b95d3fd18f6e. Reason for revert: This is not properly fixing the underlying issue and was merged prematurely Issue-ID: AAI-3554 Change-Id: I3ff720bd5322712bdde13d774cc4366a9ed28650 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de>
2024-01-20Merge "Update tinkerpop to 3.2.3 in aai-core"Nandkishor Patke5-105/+179
2024-01-19Update tinkerpop to 3.2.3 in aai-coreFiete Ostkamp5-105/+179
- eagerly clone queries as they are optimised at a later stage when called lazily Issue-ID: AAI-3554 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de> Change-Id: I18e97635d61e8cb08981cfea0143994f1572b39e
2024-01-15Ensure HttpEntry bean is request scoped in aai-commonFiete Ostkamp1-2/+26
- declare separate request scoped HttpEntry beans - leave the existing prototype scoped HttpEntry beans in place [1] - disable flaky test [1] some of the existing tests (in traversal+resources) use them in a non-web context In those cases, using request scoped beans requires extra annotations to make it work Issue-ID: AAI-3723 Change-Id: I1295fe8d18f3364472f4230f28ea6ef936c5f42b Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de>
2024-01-11Update spring boot to 2.4Fiete Ostkamp15-20/+15
- update spring boot from 2.3 to 2.4 - remove compile-time dependency on powermock introduced by eelf-core - remove dependencyManagement declarations for powermock since it's not used anymore Issue-ID: AAI-3725 Change-Id: I05a35e0cee80b27123f28bb8eeb8ed885c83a173 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de>
2024-01-10Update spring boot to 2.3Fiete Ostkamp3-5/+5
- update to 2.3 - bump version of all submodules to 1.13.1-SNAPSHOT Issue-ID: AAI-3724 Change-Id: Id089e27b236476907c4e7ca7e51d72b74d387d1c Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de>
2024-01-10Merge "Update spring boot to 2.2"Lukasz Rajewski2-21/+12
2024-01-10Ensure HttpEntry bean is request scoped in aai-commonFiete Ostkamp2-4/+6
- change beans to request scoped since the transaction handling inside it is not thread-safe - bean injection in jersey is "request" scoped by default, but in a spring web context it is "prototype" - in the prototype scope, multiple threads could access the same HttpEntry Issue-ID: AAI-3723 Change-Id: I083e3b06cdbe4491f22746033cdcc80aa48a2d1b Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de>
2024-01-10Update spring boot to 2.2Fiete Ostkamp2-21/+12
- update spring dependency to 2.2.13 - remove profile based switch between spring versions 1.5.22 and 2.1.12 - migrate testng based tests in aai-els-onap-logging to junit 4 - rely more on boms for dependencyManagement by removing separate declarations (of spring and jackson) - resolve some build warnings by adding dependency + plugin versions - resolve some build warnings by removing duplicate declarations of dependencies - resolve build warning about ambiguous reference to JsonObject.addProperty() Issue-ID: AAI-3711 Change-Id: I7559e90ffb65199ee46bc5b7cdf5d9e73b7d87bc Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de>
2023-12-29Upversion to 1.13.0Fiete Ostkamp1-1/+1
- increase version from 1.12.0 to 1.13.0 - release will incorporate refactorings of the past 13 months Issue-ID: AAI-3705 Change-Id: Iddac93ac90914c232269435501cc625b15f9df75 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de>
2023-12-22Refactor ErrorLogHelperFiete Ostkamp2-123/+0
- change is designed to not make any changes to the serialised objects [1] - introduce common error response object that is used for both service and policy, xml + json format - separate creation of error response and the marshalling of it - increase test coverage - use jackson object mappers for marshalling json and xml objects instead of custom MapperUtil - make code more functional - use more descriptive variable names [1] only the internal representation changes to account for both Service- and PolicyException Issue-ID: AAI-3695 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de> Change-Id: I1e82bf4f0706704679d14aac98969fa00beed758
2023-08-16Merge "Refactor HttpEntryTest"Lukasz Rajewski8-446/+812
2023-08-16Refactor HttpEntryTestFiete Ostkamp8-446/+812
- make test cases independently runnable by removing shared state - let method naming better reflect what is being tested - assign commonly used objects on the class level when they are not modified in the test case - parse error response object and assert error messages Other: - remove unnecessary saving in map in EdgeSerializer Issue-ID: AAI-3658 Change-Id: I3b9704b8a6b6cfa6ecf4930dc3b1d1a7ce84764a Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de>
2023-08-11Refactor DBSerializer verifyResourceVersion methodFiete Ostkamp2-76/+91
- assign variables closer to where they are used - have a less complex validation logic - rename related test cases to better understand what they are doing - add further test cases (this would actually be better covered via a parameterized test) - rename DBSerializer variable in test cases to better match whith the name of the type it's representing Issue-ID: AAI-3657 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de> Change-Id: Id7976b0123c17178845db115c09b5c00d2361e6d
2023-08-08Make URIParser code more readable - Part 2Fiete Ostkamp2-50/+41
- declare variables closer to where they are used - move more validation into the validatePath method - increment the global index variable i in fewer places Issue-ID: AAI-3656 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de> Change-Id: I64380b84370a362113bf64c4edff3d389ffb290e
2023-08-04Make URIParser code more readableFiete Ostkamp2-90/+110
Issue-ID: AAI-3655 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de> Change-Id: I26350e7279287c711f38194dbc1e8d302cf9a26d
2022-11-21[AAI] Up-version aai-common to 1.12.0 for LondonNiharika Sharma1-1/+1
Issue-ID: AAI-3594 Signed-off-by: Niharika Sharma <niharika.sharma@amdocs.com> Change-Id: I83c7fe88ef4227b00efdfa0b4c6a102dca7a3f35
2022-11-14[AAI] Upversion aai-common to 1.9.5Niharika Sharma1-1/+1
Issue-ID: AAI-3594 Signed-off-by: Niharika Sharma <niharika.sharma@amdocs.com> Change-Id: I16555822aa3de1ac7a19a08fd378e1eb4c36e23e
2022-11-11Merge "Partially resolve resource leak warnings in aai-common"William Reehil3-77/+80
2022-11-11Merge "Reduce the number of raw-type related warnings in aai-common"William Reehil19-38/+74
2022-11-10Replace deprecated methods in aai-commonFiete Ostkamp26-101/+147
Issue-ID: AAI-3589 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de> Change-Id: I9e32b879ee0d143a6b66e06d425bed7412139e58
2022-11-09Reduce the number of raw-type related warnings in aai-commonFiete Ostkamp19-43/+100
Issue-ID: AAI-3586 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de> Change-Id: If4affb02cfe40b4b82ecbdbb1a25d919d88be25c
2022-11-09Partially resolve resource leak warnings in aai-commonFiete Ostkamp3-77/+80
Issue-ID: AAI-3585 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de> Change-Id: Ic871d58bafb385737ecea6ea18c2fb589f4dc369