summaryrefslogtreecommitdiffstats
path: root/aai-core
AgeCommit message (Collapse)AuthorFilesLines
2018-12-05Improve the performance of resoures microservice1.4.0Kajur, Harish (vk250x)27-2208/+5528
Currently the findSubGraph is being invoked and causing additional calls to the database by backing a tree backed vertex and slowing the performance of GET ALLs Original intention of both of them was to pre fetch depth 0, 1, and 2 at once so we don't have to get them at each depth but since that was not done right there is extra amount of time After the aai-uri migration to ensure all vertexes have the aai-uri and also to make sure they are unique across graph we don't need to traverse a vertex to find the parents to build aai-uri it was done previously when there was no aai-uri to derive the uri of a given vertex and its not necessary anymore so there would be performance improvements of vserver when there are a lot of relationships Currently the edge labels are retrieved for each vertex a and b and the performance of the GET with relationships will be propotional to the GET request and how many cousin edges it has and the more cousin edges there are the more slower the response time will be as for each cousin vertex its trying to get the edge in between so the code is modified to only go to the database for the edge label when there are multiple edge labels (cousin edges) between a and b If there are only one edge label and its a cousin vertex then we can use the edge rule to be able to figure out the edge label Improve PUT on the cloud region by modifying the getEdgesBetween method which currently was retrieving all the parent child edges between a and b and then only using the first edge The traversal itself was too complicated and was costly in terms of database retrieval and calls and optimized the code to utilize the edge information so we can modify the query to db at runtime based on the information provided so when a 10000 vservers under a tenant adding a new vserver under tenant would be slow because of the old query performance as it was taking some time there but with this optimization, its only spending at most a millisecond or 2 in that method Also noticed that when a PUT operation takes place, the method calls the related objects to create a dmaap event which was in turn calling the findParents and actually utilizing the parents to create the dmaap event and would spend quite a lot of time here because of the expensive call of the findParents in this case we need those vertexes So optimized the code so based on a given vertex, we have the aai-uri and the newly added metadata uriTemplate to break the aai-uri into its parent aai-uri and grand parent aai-uri and so forth With this breakdown, we can get the list of aai-uris which are parents, grandparents and then use the aai-uri to look them up which is O(1) lookup time due to the fact they are unique indexes The time it takes when doing a traversal to find the parents is propotional to the number of edges but this will be optimistic Another area which was improved was the json path execution of the edge rules so when the edge rules get loaded into memory it creates a document object, it utilizes the jsonpath to query information about the edge rules but the only thing here is each time it gets called the query gets invoked and uses jsonpath to retrieve the edge rules when we can cached them based on the filter so that the user executed and if the filter is the same as before, the expected edge rules will return the same Too much time was spent making the query and retrieving and building the edgerules So a cache is a perfect way to optimize this part Issue-ID: AAI-1987 Change-Id: Ieb8237de3fd31136ceac14bf4a8216a7ab3b7179 Signed-off-by: Kajur, Harish (vk250x) <vk250x@att.com>
2018-11-19AAI-1523 checkstyle warnings for aai-coreKeong Lim4-79/+79
Issue-ID: AAI-1523 re-indent code with spaces to clean up some checkstyle warnings for aai-core test (part of 24k lines of output) Change-Id: I3b33fbe46458e4f0f3273c48ff9cfb0673ae18f4 Signed-off-by: Keong Lim <keong.lim@huawei.com>
2018-11-01Fix bug on create created ts and modified tsKajur, Harish (vk250x)2-11/+52
where on create the values should be the same but it ends up being different sometimes Issue-ID: AAI-1832 Change-Id: Ia8cfb75a5812e6b59f8000a820cf3605ab17eb2b Signed-off-by: Kajur, Harish (vk250x) <vk250x@att.com>
2018-11-01Add capability to record timestampKajur, Harish (vk250x)4-1/+352
Issue-ID: AAI-1831 Change-Id: Ifcadf1caa0f7764c759997f10f3f789b1a702872 Signed-off-by: Kajur, Harish (vk250x) <vk250x@att.com>
2018-11-01Add required properties to schemaKajur, Harish (vk250x)1-0/+156
Issue-ID: AAI-1826 Change-Id: Ifc7122880e2c98888aa6b478cba3f70fb4c62e52 Signed-off-by: Kajur, Harish (vk250x) <vk250x@att.com>
2018-11-01Replace platform specific line seperators SystemKajur, Harish (vk250x)5-189/+196
Issue-ID: AAI-1463 Change-Id: Ibdd3803dd825342d54dfa1b008f1a8c2d78d6198 Signed-off-by: Kajur, Harish (vk250x) <vk250x@att.com>
2018-11-01Add support for v15 APIsKajur, Harish (vk250x)1-6/+6
Issue-ID: AAI-1812 Change-Id: I2542371baf8f33da1ab2ea3b19073b1f1dc870f4 Signed-off-by: Kajur, Harish (vk250x) <vk250x@att.com>
2018-10-22Merge "fix xsd generation when obj crosses oxm files"James Forsyth11-110/+566
2018-10-13fix xsd generation when obj crosses oxm filesLaMont, William (wl2432)11-110/+566
Issue-ID: AAI-1654 Change-Id: I118b0d94099c7f986303fc9dd9e5dae5144b4bbb Signed-off-by: LaMont, William (wl2432) <wl2432@us.att.com>
2018-10-13Merge "some test cases added"James Forsyth1-32/+57
2018-10-13Merge "exception scenario covered in AAIGraphTest.java"James Forsyth1-0/+12
2018-10-12Upversion aai-common to 1.4.0-SNAPSHOTKajur, Harish (vk250x)1-2/+2
Issue-ID: AAI-1726 Change-Id: Ia7fc62d72baefad98d0aa97ffb1f5df1d25693f1 Signed-off-by: Kajur, Harish (vk250x) <vk250x@att.com>
2018-09-28Merge "test case to check the singleton instance"James Forsyth1-0/+40
2018-09-27test case to check the singleton instanceasgar1-0/+40
Change-Id: I9c6472923df7ec6a250e3b81c6b5f833b53d5c29 Issue-ID: AAI-1646 Signed-off-by: Mohamed Asgar Samiulla <sammoham@in.ibm.com>
2018-09-27Merge "Upversion to 1.3.1"Venkata Harish Kajur1-2/+2
2018-09-26Upversion to 1.3.1Jimmy Forsyth1-2/+2
Issue-ID: AAI-1678 Change-Id: I2bafe046d5c99e3db63862dd5b1ca1ed2da5135b Signed-off-by: Jimmy Forsyth <jf2512@att.com>
2018-09-20exception scenario covered in AAIGraphTest.javaasgar1-0/+12
Change-Id: I63009b10aec1e1a73348eaeaa536b1a64dcc11b8 Issue-ID: AAI-1662 Signed-off-by: Mohamed Asgar Samiulla <sammoham@in.ibm.com>
2018-09-20Exclude groovy indyVenkata Harish K Kajur1-0/+6
Issue-ID: AAI-1632 Change-Id: I4c52de06f20d1a89ff2403b98af73a89a04467ea Signed-off-by: Venkata Harish K Kajur <vk250x@att.com>
2018-09-20some test cases addedasgar1-32/+57
Change-Id: Iaf98e45665979d156838d1c7596845108b015cc7 Issue-ID: AAI-1661 Signed-off-by: Mohamed Asgar Samiulla <sammoham@in.ibm.com>
2018-09-19Update guava to 19.0Kajur, Harish (vk250x)1-1/+1
Issue-ID: AAI-1298 Change-Id: I0a880be136f8ea3c0d780e0f9653006a5d5ebc61 Signed-off-by: Kajur, Harish (vk250x) <vk250x@att.com>
2018-09-19Merge "Test cases added for RequestError.java"James Forsyth1-0/+53
2018-09-19Merge "Added unit test for PolicyException.java"James Forsyth1-0/+68
2018-09-19Merge "Test case coverage for MapperUtil.java"Venkata Harish Kajur1-33/+52
2018-09-18Specify groovy 2.4.15Jimmy Forsyth1-0/+7
Issue-ID: AAI-1632 Change-Id: I4f6c566dcd2737424bcc42642147f912e745b94f Signed-off-by: Jimmy Forsyth <jf2512@att.com>
2018-09-18Update to latest versions of depsJimmy Forsyth1-6/+6
Issue-ID: AAI-1628 Change-Id: I88cc21c2b3233eff34febda18497a5131deb4e05 Signed-off-by: Jimmy Forsyth <jf2512@att.com>
2018-09-18Exclude the dom4j dependencyKajur, Harish (vk250x)1-0/+4
Issue-ID: AAI-1298 Change-Id: Idc5c6652eb4bf11204f53f88193d0ca0c3b2cf5e Signed-off-by: Kajur, Harish (vk250x) <vk250x@att.com>
2018-09-17Test cases added for RequestError.javaasgar1-0/+53
Change-Id: I16d1fbe7ca03ecd6659161ae9bfbf3d4bd5c59be Issue-ID: AAI-1610 Signed-off-by: Mohamed Asgar Samiulla <sammoham@in.ibm.com>
2018-09-17Added unit test for PolicyException.javaasgar1-0/+68
Change-Id: I76ecc0d4e4193be1343afae2906fb179768dbbdb Issue-ID: AAI-1607 Signed-off-by: Mohamed Asgar Samiulla <sammoham@in.ibm.com>
2018-09-14Merge "minor fixes in GremlinQueryBuilder.java"James Forsyth1-711/+709
2018-09-14minor fixes in GremlinQueryBuilder.javaasgar1-711/+709
Change-Id: Ifa94277e74486bc2086ce5cad5077d59cdbf0f29 Issue-ID: AAI-1595 Signed-off-by: Mohamed Asgar Samiulla <sammoham@in.ibm.com>
2018-09-12fixes in AAIResponseMessageData.javaasgar1-28/+30
Change-Id: I52a88526180acde91c6d9818d446e22ce175244d Issue-ID: AAI-1569 Signed-off-by: Mohamed Asgar Samiulla <sammoham@in.ibm.com>
2018-09-12Test case coverage for MapperUtil.javaasgar1-33/+52
Change-Id: I60628cd098911f945042f731b779ec9d49f84ecb Issue-ID: AAI-1594 Signed-off-by: Mohamed Asgar Samiulla <sammoham@in.ibm.com>
2018-09-11Merge "sonar fixes for AutoGenerateHtml.java"James Forsyth1-37/+40
2018-09-11Merge "constant instead of literal AJSC_HOME"James Forsyth1-76/+79
2018-09-11Merge "Sonar fixes in MapperUtil.java"James Forsyth1-21/+27
2018-09-11sonar fixes for AutoGenerateHtml.javaasgar1-37/+40
Change-Id: If5ac08fa880d911bbe4f6115f98ea194fb9029cf Issue-ID: AAI-1568 Signed-off-by: Mohamed Asgar Samiulla <sammoham@in.ibm.com>
2018-09-11Add a private constructor in AAIUtils.javaasgar1-21/+30
Change-Id: I7a2beeede4cb8303b7f9801532a651895cbce389 Issue-ID: AAI-1566 Signed-off-by: Mohamed Asgar Samiulla <sammoham@in.ibm.com>
2018-09-11constant instead of literal AJSC_HOMEasgar1-76/+79
Change-Id: Ideacc3d44016f20700b2758aed35c8a552b39916 Issue-ID: AAI-1565 Signed-off-by: Mohamed Asgar Samiulla <sammoham@in.ibm.com>
2018-09-11Sonar fixes in MapperUtil.javaasgar1-21/+27
Change-Id: If7d53a2f8c5199e9634e36a4ab018a78affb65f8 Issue-ID: AAI-1567 Signed-off-by: Mohamed Asgar Samiulla <sammoham@in.ibm.com>
2018-09-06Merge "renaming/constant instead of literal/unused items"James Forsyth5-259/+274
2018-09-06Merge "private constructor to hide the implicit public"Tian Lee2-159/+170
2018-09-06renaming/constant instead of literal/unused itemsasgar5-259/+274
Change-Id: I2634a375c4b2a371b33dcb6dd2d3aa21cfe54297 Issue-ID: AAI-1558 Signed-off-by: Mohamed Asgar Samiulla <sammoham@in.ibm.com>
2018-09-06private constructor to hide the implicit publicasgar2-159/+170
Adding a private constructor to hide the implicit public constructor. Change-Id: Id6ded8cf328843c8e77fc652391f5c5edc80aa47 Issue-ID: AAI-1578 Signed-off-by: Mohamed Asgar Samiulla <sammoham@in.ibm.com>
2018-09-06Return expression instead of temporary variableasgar4-68/+67
Change-Id: Ib5d939c99fc4fb9845f06e787b3915640acfce3e Issue-ID: AAI-1575 Signed-off-by: Mohamed Asgar Samiulla <sammoham@in.ibm.com>
2018-08-24Merge "Fix sonar issues"James Forsyth3-23/+20
2018-08-23Update xsd element to generate boolean to falseKajur, Harish (vk250x)2-8/+8
Issue-ID: AAI-1536 Change-Id: If1cc9291e28dd0381115a0bf6c5a44faa7fdbe01 Signed-off-by: Kajur, Harish (vk250x) <vk250x@att.com>
2018-08-23Fix sonar issuesParshad Patel3-23/+20
Fix use try-with-resources issues Issue-ID: AAI-1368 Change-Id: I267df61915ac1596cc8645c62ccf43eb04fd7ac5 Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2018-08-22Merge "Sonar violation"Venkata Harish Kajur3-13/+17
2018-08-22Sonar violationArindam Mondal3-13/+17
Issue-ID: AAI-1521 Change-Id: I34b801a1ec9525e6b1785914f8d02f938cbf0ee7 Signed-off-by: Arindam Mondal <arind.mondal@samsung.com>
2018-08-21Sonar issue fixes for PutOperation.javaasgar1-83/+84
Issue-ID: AAI-1525 Change-Id: I34e8618223c5ca4aeefbc37dc148b556877f444e Signed-off-by: Mohamed Asgar Samiulla <sammoham@in.ibm.com>