summaryrefslogtreecommitdiffstats
path: root/aai-core/src
AgeCommit message (Collapse)AuthorFilesLines
2024-01-19Update tinkerpop to 3.2.3 in aai-coreFiete Ostkamp4-104/+178
- eagerly clone queries as they are optimised at a later stage when called lazily Issue-ID: AAI-3554 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de> Change-Id: I18e97635d61e8cb08981cfea0143994f1572b39e
2023-12-22Refactor ErrorLogHelperFiete Ostkamp2-123/+0
- change is designed to not make any changes to the serialised objects [1] - introduce common error response object that is used for both service and policy, xml + json format - separate creation of error response and the marshalling of it - increase test coverage - use jackson object mappers for marshalling json and xml objects instead of custom MapperUtil - make code more functional - use more descriptive variable names [1] only the internal representation changes to account for both Service- and PolicyException Issue-ID: AAI-3695 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de> Change-Id: I1e82bf4f0706704679d14aac98969fa00beed758
2023-08-16Merge "Refactor HttpEntryTest"Lukasz Rajewski8-446/+812
2023-08-16Refactor HttpEntryTestFiete Ostkamp8-446/+812
- make test cases independently runnable by removing shared state - let method naming better reflect what is being tested - assign commonly used objects on the class level when they are not modified in the test case - parse error response object and assert error messages Other: - remove unnecessary saving in map in EdgeSerializer Issue-ID: AAI-3658 Change-Id: I3b9704b8a6b6cfa6ecf4930dc3b1d1a7ce84764a Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de>
2023-08-11Refactor DBSerializer verifyResourceVersion methodFiete Ostkamp2-76/+91
- assign variables closer to where they are used - have a less complex validation logic - rename related test cases to better understand what they are doing - add further test cases (this would actually be better covered via a parameterized test) - rename DBSerializer variable in test cases to better match whith the name of the type it's representing Issue-ID: AAI-3657 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de> Change-Id: Id7976b0123c17178845db115c09b5c00d2361e6d
2023-08-08Make URIParser code more readable - Part 2Fiete Ostkamp2-50/+41
- declare variables closer to where they are used - move more validation into the validatePath method - increment the global index variable i in fewer places Issue-ID: AAI-3656 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de> Change-Id: I64380b84370a362113bf64c4edff3d389ffb290e
2023-08-04Make URIParser code more readableFiete Ostkamp2-90/+110
Issue-ID: AAI-3655 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de> Change-Id: I26350e7279287c711f38194dbc1e8d302cf9a26d
2022-11-11Merge "Partially resolve resource leak warnings in aai-common"William Reehil3-77/+80
2022-11-11Merge "Reduce the number of raw-type related warnings in aai-common"William Reehil19-38/+74
2022-11-10Replace deprecated methods in aai-commonFiete Ostkamp26-101/+147
Issue-ID: AAI-3589 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de> Change-Id: I9e32b879ee0d143a6b66e06d425bed7412139e58
2022-11-09Reduce the number of raw-type related warnings in aai-commonFiete Ostkamp19-43/+100
Issue-ID: AAI-3586 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de> Change-Id: If4affb02cfe40b4b82ecbdbb1a25d919d88be25c
2022-11-09Partially resolve resource leak warnings in aai-commonFiete Ostkamp3-77/+80
Issue-ID: AAI-3585 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de> Change-Id: Ic871d58bafb385737ecea6ea18c2fb589f4dc369
2022-11-07Reduce the number of problems in aai-common by removing unused importsFiete Ostkamp179-3349/+2798
- run mvn spotless:apply across aai-commmon to remove unused imports - run mvn formatter:format across aai-common Issue-ID: AAI-3583 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de> Change-Id: I2dfeb395eafa2824ce8369bba3a18db3e1845522
2022-10-18Update aai-common dependenciesFiete Ostkamp1-42/+42
Issue-ID: AAI-3553 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de> Change-Id: I2b79669b922a43d30b7d412bfd86f1506f6b4f6f
2022-10-14Remove the apache commons-lang dependency in aai-commonFiete Ostkamp26-164/+156
Issue-ID: AAI-3551 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de> Change-Id: Ib68b6fb43044532abf39c1ac088ef969c5aa00c2
2022-10-13Migrate Mockito 1 to version 2 in aai-coreFiete Ostkamp5-27/+35
Issue-ID: AAI-3549 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de> Change-Id: Ibb8edcd80fe3b112af0d113894122ce0b256006b
2022-09-29Replace deprecated Gremlin query in aai-commonFiete Ostkamp1-16/+25
addInE and addOutE are deprecated since Gremlin 3.1.0. Issue-ID: AAI-3534 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de> Change-Id: I4c4db97d8075e9c75b13ee206c27b8c01b5e0cf4
2022-01-20[AAI] Ignore DataCopyTest to try to release a docker imagewr148d1-1/+2
Issue-ID: AAI-3428 Signed-off-by: wr148d <wr148d@att.com> Change-Id: I46def8946547ef522b8f16671c80138aa4737552
2022-01-20[AAI] Update the tests to ignore OwnerCheckTestwr148d1-2/+3
Issue-ID: AAI-3428 Change-Id: I1a75ce29981338edf28cff1f248066b3bee9e80d Signed-off-by: wr148d <wr148d@att.com>
2022-01-13[AAI] Revert some testing changes to ignore tests and rollback of eclipse ↵wr148d1-3/+1
perisistence Issue-ID: AAI-3428 Change-Id: Ib1a1235d44c1c0ddc767ad944eccafec7de618d1 Signed-off-by: wr148d <wr148d@att.com>
2022-01-11Updating the eclipse persistence version to 2.6.0 to resolve an issuewr148d2-0/+4
Issue-ID: AAI-3428 Change-Id: I514120be2e021e580e98cfe8a97689ec4598f523 Signed-off-by: wr148d <wr148d@att.com>
2021-07-02Fix all blocker sonar issues and some checkstyleLiard Samuel30-325/+392
Issue-ID: AAI-3362 Signed-off-by: sliard <samuel.liard@gmail.com> Change-Id: I365be3e8afe75b54f5a65deadb054df73857274e
2021-04-14Added proxy args in the haproxy DockerfileRenu Kumari1-0/+2
Added DirtiesContext to URIToRelationshipObjectTest for successful test case execution. Issue-ID: AAI-3318 Signed-off-by: Renu Kumari <renu.kumari@bell.ca> Change-Id: I53d9b031f93515fdec16fe3f7b0a580c8439b5b3
2021-04-06Fixed Concurrent Updates overriding the AAI objectNiharika Sharma1-0/+16
Issue-ID: AAI-3308 Signed-off-by: Niharika Sharma <niharika.sharma@amdocs.com> Change-Id: I7d2d591928987b9f5f9465325fc1c4d03dee3db2
2021-01-06Use data owner attribute instead of owning entity for OwnerCheckM.Hosnidokht4-48/+97
Issue-ID: AAI-3226 Signed-off-by: Mohammad Hosnidokht <mohammad.hosnidokht@yoppworks.com> Change-Id: I8222546e7264e99ca3e53fe1212a45008c1064e6
2020-11-10Filter get all pnf by owning entity if multi tenancy is enabledRodrigo Lima2-11/+28
Issue-ID: AAI-3214 Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com> Change-Id: I97e62e12f06938294d9969d21b4dcacae9d01d78
2020-10-06Fixed concurrency issue in PNF uploadingNiharika Sharma1-4/+23
Issue-ID: AAI-3100 Signed-off-by: Niharika Sharma <niharika.sharma@amdocs.com> Change-Id: I34fe77179efc5590f6e70b0bb2b97e7229f0adf3
2020-09-15Add ownercheck side effect to enrichData method in dbserializerRodrigo Lima1-1/+2
Issue-ID: AAI-3184 Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com> Change-Id: I3c8b3d33613c5345fc767fb03f1c4be79a321acc
2020-09-11Update ownercheck side effectRodrigo Lima1-2/+2
- Use both E and both V to select owning entity Issue-ID: AAI-3176 Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com> Change-Id: I2e453dfd3c52c0de67981b8344434576fc514d0f
2020-09-10Add side effect to check pnf owning entityRodrigo Lima6-4/+416
- Create side effect to check : user's groups contains pnf's owning entity name - Create unit tests for side effect - Add new process method in HttpEntry to pass set of groups - Pass set of groups to db serializer Issue-ID: AAI-3176 Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com> Change-Id: I4bc7ab6e22bce8cbe60bd7ef6bb5db73dac3a1c4
2020-08-11Add dirty context to junit to fix spring failureHarish Venkata Kajur1-0/+2
Issue-ID: AAI-3105 Change-Id: I7b387c76009dba950aea0debf382f316c558d6ad Signed-off-by: Harish Venkata Kajur <vk250x@att.com>
2020-08-05Merge "Junit testcase for JSONStrategy"William Reehil1-1/+9
2020-07-13Merge "TreeFormat - Removed problems triggering Sonar errors"William Reehil1-45/+61
2020-07-13Merge "Fix sonar issues in SchemaGenerator"William Reehil1-51/+55
2020-07-13Merge "Fix minor sonar issues"William Reehil3-12/+10
2020-07-13Merge "Removed problems triggering Sonar errors"William Reehil1-52/+76
2020-07-10Fix sonar issues in SchemaGeneratorFrancis Toth1-51/+55
Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: I1ba6fd929992699477502c46c1a5595a162d3209 Issue-ID: AAI-2902
2020-07-10Fix minor sonar issuesFrancis Toth3-12/+10
Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: Iea540bb663429d55ce90879f9d9a22888c583833 Issue-ID: AAI-2128
2020-07-09Merge "Fix minor sonar issues in SchemaGenerator4Hist"William Reehil2-76/+40
2020-07-06Merge "Removed critical code smell"William Reehil1-3/+4
2020-07-06Merge "Critical Sonar bug fix"William Reehil1-2/+2
2020-06-29Merge "Fix the list endpoints test npe issue"William Reehil1-0/+2
2020-06-15Fix sonar issues in AggregateRodrigo Lima1-2/+2
- check obj.isPresent() in method processInput - return Optional.empty instead of null in method createPropertiesObject Issue-ID: AAI-2934 Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com> Change-Id: Iebe0184ce39f244dd56e6861617cbf4e5dafb06c
2020-06-15TreeFormat - Removed problems triggering Sonar errorsChris André1-45/+61
- Removed all unchecked access to Optional.get() - Renamed LOGGER to TREE_FORMAT_LOGGER, following Sonar's suggestion Issue-ID: AAI-2931 Signed-off-by: Chris Andre <chris.andre@yoppworks.com> Change-Id: I7536309220f2dfb4b75ecbcd6b9e36797c5f1826
2020-06-09Fix the list endpoints test npe issueHarish Venkata Kajur1-0/+2
Issue-ID: AAI-2927 Change-Id: I8449e52a42fa7dcf8194680f5a2da5c2b6b6c439 Signed-off-by: Harish Venkata Kajur <vk250x@att.com>
2020-06-08Removed problems triggering Sonar errorsChris André1-52/+76
- Made recurrent strings constant - Refactored `createFilteredPropertyMap` to use a more functional approach - Added test for the presence of Optional in `getPropertyFilteredObject` & `filterProperties` Issue-ID: AAI-2926 Signed-off-by: Chris Andre <chris.andre@yoppworks.com> Change-Id: I6078bd1d903d6739326ce7154cb83c1ded1e6b04
2020-06-03Removed critical code smellezhil1-3/+4
Removed critical code smell in AAIUnmarshallingException Issue-ID: AAF-1120 Change-Id: I0949e9f2f466ac98db39cfa1adf50f86a531b3a5 Signed-off-by: ezhil <ezhrajam@in.ibm.com>
2020-06-03Critical Sonar bug fixezhil1-2/+2
Sonar critical bug fix in HttpsAuthClient Issue-ID: AAF-1120 Change-Id: I840d7d4ac56767fd56f687f850bec879a4edeca9 Signed-off-by: ezhil <ezhrajam@in.ibm.com>
2020-05-12aai-common support for v20LaMont, William(wl2432)25-154/+960
Issue-ID: AAI-2904 Change-Id: I6dca2f785882b38ca2b2474a11affaa0328c003a Signed-off-by: LaMont, William(wl2432) <wl2432@att.com>
2020-05-07Fix minor sonar issues in SchemaGenerator4HistFrancis Toth2-76/+40
Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: Ie4f64b8d9f43bf98c76c1751025ceaf2dae59180 Issue-ID: AAI-2901