aboutsummaryrefslogtreecommitdiffstats
path: root/aai-core/src/main
AgeCommit message (Collapse)AuthorFilesLines
2023-08-16Merge "Refactor HttpEntryTest"Lukasz Rajewski1-9/+3
2023-08-16Refactor HttpEntryTestFiete Ostkamp1-9/+3
- make test cases independently runnable by removing shared state - let method naming better reflect what is being tested - assign commonly used objects on the class level when they are not modified in the test case - parse error response object and assert error messages Other: - remove unnecessary saving in map in EdgeSerializer Issue-ID: AAI-3658 Change-Id: I3b9704b8a6b6cfa6ecf4930dc3b1d1a7ce84764a Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de>
2023-08-11Refactor DBSerializer verifyResourceVersion methodFiete Ostkamp1-19/+12
- assign variables closer to where they are used - have a less complex validation logic - rename related test cases to better understand what they are doing - add further test cases (this would actually be better covered via a parameterized test) - rename DBSerializer variable in test cases to better match whith the name of the type it's representing Issue-ID: AAI-3657 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de> Change-Id: Id7976b0123c17178845db115c09b5c00d2361e6d
2023-08-08Make URIParser code more readable - Part 2Fiete Ostkamp1-49/+40
- declare variables closer to where they are used - move more validation into the validatePath method - increment the global index variable i in fewer places Issue-ID: AAI-3656 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de> Change-Id: I64380b84370a362113bf64c4edff3d389ffb290e
2023-08-04Make URIParser code more readableFiete Ostkamp1-90/+69
Issue-ID: AAI-3655 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de> Change-Id: I26350e7279287c711f38194dbc1e8d302cf9a26d
2022-11-11Merge "Partially resolve resource leak warnings in aai-common"William Reehil2-75/+79
2022-11-11Merge "Reduce the number of raw-type related warnings in aai-common"William Reehil14-28/+40
2022-11-10Replace deprecated methods in aai-commonFiete Ostkamp18-57/+70
Issue-ID: AAI-3589 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de> Change-Id: I9e32b879ee0d143a6b66e06d425bed7412139e58
2022-11-09Reduce the number of raw-type related warnings in aai-commonFiete Ostkamp14-33/+66
Issue-ID: AAI-3586 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de> Change-Id: If4affb02cfe40b4b82ecbdbb1a25d919d88be25c
2022-11-09Partially resolve resource leak warnings in aai-commonFiete Ostkamp2-75/+79
Issue-ID: AAI-3585 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de> Change-Id: Ic871d58bafb385737ecea6ea18c2fb589f4dc369
2022-11-07Reduce the number of problems in aai-common by removing unused importsFiete Ostkamp103-1185/+1194
- run mvn spotless:apply across aai-commmon to remove unused imports - run mvn formatter:format across aai-common Issue-ID: AAI-3583 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de> Change-Id: I2dfeb395eafa2824ce8369bba3a18db3e1845522
2022-10-18Update aai-common dependenciesFiete Ostkamp1-42/+42
Issue-ID: AAI-3553 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de> Change-Id: I2b79669b922a43d30b7d412bfd86f1506f6b4f6f
2022-10-14Remove the apache commons-lang dependency in aai-commonFiete Ostkamp20-93/+108
Issue-ID: AAI-3551 Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de> Change-Id: Ib68b6fb43044532abf39c1ac088ef969c5aa00c2
2021-07-02Fix all blocker sonar issues and some checkstyleLiard Samuel19-286/+332
Issue-ID: AAI-3362 Signed-off-by: sliard <samuel.liard@gmail.com> Change-Id: I365be3e8afe75b54f5a65deadb054df73857274e
2021-04-06Fixed Concurrent Updates overriding the AAI objectNiharika Sharma1-0/+16
Issue-ID: AAI-3308 Signed-off-by: Niharika Sharma <niharika.sharma@amdocs.com> Change-Id: I7d2d591928987b9f5f9465325fc1c4d03dee3db2
2021-01-06Use data owner attribute instead of owning entity for OwnerCheckM.Hosnidokht2-30/+29
Issue-ID: AAI-3226 Signed-off-by: Mohammad Hosnidokht <mohammad.hosnidokht@yoppworks.com> Change-Id: I8222546e7264e99ca3e53fe1212a45008c1064e6
2020-11-10Filter get all pnf by owning entity if multi tenancy is enabledRodrigo Lima2-11/+28
Issue-ID: AAI-3214 Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com> Change-Id: I97e62e12f06938294d9969d21b4dcacae9d01d78
2020-10-06Fixed concurrency issue in PNF uploadingNiharika Sharma1-4/+23
Issue-ID: AAI-3100 Signed-off-by: Niharika Sharma <niharika.sharma@amdocs.com> Change-Id: I34fe77179efc5590f6e70b0bb2b97e7229f0adf3
2020-09-15Add ownercheck side effect to enrichData method in dbserializerRodrigo Lima1-1/+2
Issue-ID: AAI-3184 Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com> Change-Id: I3c8b3d33613c5345fc767fb03f1c4be79a321acc
2020-09-11Update ownercheck side effectRodrigo Lima1-2/+2
- Use both E and both V to select owning entity Issue-ID: AAI-3176 Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com> Change-Id: I2e453dfd3c52c0de67981b8344434576fc514d0f
2020-09-10Add side effect to check pnf owning entityRodrigo Lima3-4/+174
- Create side effect to check : user's groups contains pnf's owning entity name - Create unit tests for side effect - Add new process method in HttpEntry to pass set of groups - Pass set of groups to db serializer Issue-ID: AAI-3176 Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com> Change-Id: I4bc7ab6e22bce8cbe60bd7ef6bb5db73dac3a1c4
2020-07-13Merge "TreeFormat - Removed problems triggering Sonar errors"William Reehil1-45/+61
2020-07-13Merge "Fix sonar issues in SchemaGenerator"William Reehil1-51/+55
2020-07-13Merge "Fix minor sonar issues"William Reehil2-9/+7
2020-07-13Merge "Removed problems triggering Sonar errors"William Reehil1-52/+76
2020-07-10Fix sonar issues in SchemaGeneratorFrancis Toth1-51/+55
Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: I1ba6fd929992699477502c46c1a5595a162d3209 Issue-ID: AAI-2902
2020-07-10Fix minor sonar issuesFrancis Toth2-9/+7
Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: Iea540bb663429d55ce90879f9d9a22888c583833 Issue-ID: AAI-2128
2020-07-09Merge "Fix minor sonar issues in SchemaGenerator4Hist"William Reehil2-76/+40
2020-07-06Merge "Removed critical code smell"William Reehil1-3/+4
2020-07-06Merge "Critical Sonar bug fix"William Reehil1-2/+2
2020-06-15Fix sonar issues in AggregateRodrigo Lima1-2/+2
- check obj.isPresent() in method processInput - return Optional.empty instead of null in method createPropertiesObject Issue-ID: AAI-2934 Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com> Change-Id: Iebe0184ce39f244dd56e6861617cbf4e5dafb06c
2020-06-15TreeFormat - Removed problems triggering Sonar errorsChris André1-45/+61
- Removed all unchecked access to Optional.get() - Renamed LOGGER to TREE_FORMAT_LOGGER, following Sonar's suggestion Issue-ID: AAI-2931 Signed-off-by: Chris Andre <chris.andre@yoppworks.com> Change-Id: I7536309220f2dfb4b75ecbcd6b9e36797c5f1826
2020-06-08Removed problems triggering Sonar errorsChris André1-52/+76
- Made recurrent strings constant - Refactored `createFilteredPropertyMap` to use a more functional approach - Added test for the presence of Optional in `getPropertyFilteredObject` & `filterProperties` Issue-ID: AAI-2926 Signed-off-by: Chris Andre <chris.andre@yoppworks.com> Change-Id: I6078bd1d903d6739326ce7154cb83c1ded1e6b04
2020-06-03Removed critical code smellezhil1-3/+4
Removed critical code smell in AAIUnmarshallingException Issue-ID: AAF-1120 Change-Id: I0949e9f2f466ac98db39cfa1adf50f86a531b3a5 Signed-off-by: ezhil <ezhrajam@in.ibm.com>
2020-06-03Critical Sonar bug fixezhil1-2/+2
Sonar critical bug fix in HttpsAuthClient Issue-ID: AAF-1120 Change-Id: I840d7d4ac56767fd56f687f850bec879a4edeca9 Signed-off-by: ezhil <ezhrajam@in.ibm.com>
2020-05-12aai-common support for v20LaMont, William(wl2432)13-87/+732
Issue-ID: AAI-2904 Change-Id: I6dca2f785882b38ca2b2474a11affaa0328c003a Signed-off-by: LaMont, William(wl2432) <wl2432@att.com>
2020-05-07Fix minor sonar issues in SchemaGenerator4HistFrancis Toth2-76/+40
Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: Ie4f64b8d9f43bf98c76c1751025ceaf2dae59180 Issue-ID: AAI-2901
2020-04-21AAI-common sonar fixesDavid Brilla13-218/+146
Issue-ID: AAI-2786 Change-Id: Ia37e660886fce56c8ab5c53888fcbf265692a359 Signed-off-by: David Brilla <david.brilla@tieto.com>
2020-03-10Reenable spring-boot2 in aai-commonJimmy Forsyth2-18/+15
Issue-ID: AAI-2831 Signed-off-by: Jimmy Forsyth <jf2512@att.com> Change-Id: I9f3f1d8d1d9ef45786d0f17afa5c824e90c77263
2020-03-10Move back to spring-boot 1.5 for bugfixJimmy Forsyth2-15/+18
Issue-ID: AAI-2831 Signed-off-by: Jimmy Forsyth <jf2512@att.com> Change-Id: I1e3d278fe343e4f05cdfd71d2443aef19c8541c2
2020-03-03Update aai-common to be spring boot 2 compatibleHarish Venkata Kajur2-18/+15
Issue-ID: AAI-2806 Change-Id: Idad79373209ef25bb26551253aa8ad86e4a75549 Signed-off-by: Harish Venkata Kajur <vk250x@att.com>
2020-02-25Enhancements for the aai-common libraryKajur, Harish (vk250x)150-7680/+6549
Issue-ID: AAI-2806 Change-Id: I2dbb46b897b35136ac1bb802978d3f974af1b307 Signed-off-by: Kajur, Harish (vk250x) <vk250x@att.com>
2020-02-21AAI-common sonar fixesDavid Brilla5-23/+21
Fixing bugs, code smells of aai-common repo found on sonar. Issue-ID: AAI-2786 Change-Id: I421f8b46f385c7334b0f3cd80c07cb2f833f127f Signed-off-by: David Brilla <david.brilla@tieto.com>
2020-02-14[AAI-2528] | Update to spring-boot 2.1.6.RELEASESneha Dantkale1-19/+15
Issue-ID: AAI-2528 Change-Id: I87756450c12538af3f21e4affa24ef76724d232c Signed-off-by: Sneha Dantkale <Sneha.dantkale@amdocs.com> Change-Id: I9437899ba1c7f2aec816a8076c954b080f9512fb Signed-off-by: Sneha Dantkale <Sneha.dantkale@amdocs.com> Change-Id: If3ad26f98c815e4872320b2652cf6c2e0b675de0 Signed-off-by: Sneha Dantkale <Sneha.dantkale@amdocs.com>
2020-02-13ListEndpoints fixMatej Babej1-6/+5
Fixing 4 code smells Issue-ID: AAI-2794 Change-Id: Ica204021dd343ec7deac01587287e361efda4643 Signed-off-by: Matej Babej <matej.babej@tieto.com>
2020-02-11Use "instanceof" instedDavid Brilla1-3/+4
Bug correction, from class.toString comparing to instanceof Issue-ID: AAI-2786 Change-Id: Idbbdaaa37208b8c40556a42255aa43175c14b1c7 Signed-off-by: David Brilla <david.brilla@tieto.com>
2020-02-11Use isAssignableFrom insteadDavid Brilla1-3/+3
Change from class -> string -> equals to isAssignableFrom Issue-ID: AAI-2786 Change-Id: I0f48ad5b7ad5728b397c54bfa883fea9431dd0a5 Signed-off-by: David Brilla <david.brilla@tieto.com>
2019-08-28Update core logic to change how toKajur, Harish (vk250x)1-322/+313
handle cassandra shutdown so that it returns an approprate 500 error Issue-ID: AAI-2082 Change-Id: Ia1b668de9dca90c44fa36b75a901b7cd596fe7d5 Signed-off-by: Kajur, Harish (vk250x) <vk250x@att.com>
2019-08-20Merge "Fixed Sonar "Blocker Bugs""James Forsyth2-50/+38
2019-07-25Sonar Fix- URIParser.javadinesha1-9/+7
Fixed sonar issues across this file Issue-ID: AAI-2525 Change-Id: Ibc7f1e9a64de5283bcc9845522817c1dff30e5e6 Signed-off-by: dinesha <dineshgs@in.ibm.com>