Improve JUnit test coverage

* Fixed a typo in DenialOfServiceTaf
* Added a JUnit for DenialOfServiceTaf
* Cleaned up JU_Cached, JU_AuthzEnv (WIP)

Issue-ID: AAF-128
Change-Id: I76ace8aff3f72538f40068f6cc9c80f24aee7403
Signed-off-by: IanHowell <ian.howell@att.com>

Increase coverage in cadi/client and cadi/core

Get coverage for Holder, NulTaf, and NullTafResp to 100%

Issue-ID: AAF-128
Change-Id: Ica83c29311801d499f922ccb4c33fb7f4e58f686
Signed-off-by: IanHowell <ian.howell@att.com>

Improve coverage of the Tafs

Issue-ID: AAF-128
Change-Id: I07f9ebee0a64c598047e74801a266898107783f7
Signed-off-by: IanHowell <ian.howell@att.com>

Improve test coverage of XReader

Issue-ID: AAF-128
Change-Id: I9b369b803743166027170b4a8ca50bd337e45b7b
Signed-off-by: IanHowell <ian.howell@att.com>

Improve coverage of GreatCircle

Issue-ID: AAF-128
Change-Id: Id5e41a481db1106d050fb216664c1aa1e07cef2a
Signed-off-by: IanHowell <ian.howell@att.com>

Suppress test output

Issue-ID: AAF-128
Change-Id: I7a7afe7617c81403d27baf89353f175d9cead165
Signed-off-by: IanHowell <ian.howell@att.com>

Move JU_DNSLocator to the correct package

Change-Id: Ic8feddf7444afcaaaa252a40d340116597533f46
Signed-off-by: IanHowell <ian.howell@att.com>

9 files changed, 859 insertions, 67 deletions

diff --git a/cadi/core/src/main/java/org/onap/aaf/cadi/taf/dos/DenialOfServiceTaf.java b/cadi/core/src/main/java/org/onap/aaf/cadi/taf/dos/DenialOfServiceTaf.java
index 1f6391fe..44a3a4a3 100644
--- a/cadi/core/src/main/java/org/onap/aaf/cadi/taf/dos/DenialOfServiceTaf.java
+++ b/cadi/core/src/main/java/org/onap/aaf/cadi/taf/dos/DenialOfServiceTaf.java
@@ -110,8 +110,8 @@ public class DenialOfServiceTaf implements HttpTaf {
 	 *  
 	 */
 	public static Counter isDeniedIP(String ipvX) {
-		if(deniedID!=null) {
-			return deniedID.get(ipvX);
+		if(deniedIP!=null) {
+			return deniedIP.get(ipvX);
 		}
 		return null;
 	}
diff --git a/cadi/core/src/test/java/org/onap/aaf/cadi/test/JU_Symm.java b/cadi/core/src/test/java/org/onap/aaf/cadi/test/JU_Symm.java
index 34f528f4..57cc2229 100644
--- a/cadi/core/src/test/java/org/onap/aaf/cadi/test/JU_Symm.java
+++ b/cadi/core/src/test/java/org/onap/aaf/cadi/test/JU_Symm.java
@@ -21,29 +21,38 @@
  ******************************************************************************/
 package org.onap.aaf.cadi.test;
 
+import static org.hamcrest.CoreMatchers.*;
+import static org.junit.Assert.*;
+import static org.mockito.Mockito.*;
+import java.lang.reflect.*;
+import org.junit.*;
+
 import java.io.ByteArrayInputStream;
 import java.io.ByteArrayOutputStream;
+import java.io.PrintStream;
 import java.util.Arrays;
 
-import java.lang.reflect.*;
-import org.junit.Before;
-import org.junit.Test;
 import org.onap.aaf.cadi.CadiException;
 import org.onap.aaf.cadi.PropAccess;
 import org.onap.aaf.cadi.Symm;
 
-import static org.hamcrest.CoreMatchers.*;
-import static org.junit.Assert.*;
-import static org.mockito.Mockito.*;
-
 public class JU_Symm {
 	private Symm defaultSymm;
 
+	private ByteArrayOutputStream outStream;
+
 	@Before
 	public void setup() throws Exception {
-	defaultSymm = new Symm(
-			"ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/".toCharArray()
-			,76, "Use default!" ,true);
+		defaultSymm = new Symm(
+				"ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/".toCharArray()
+				,76, "Use default!" ,true);
+		outStream = new ByteArrayOutputStream();
+		System.setOut(new PrintStream(outStream));
+	}
+
+	@After
+	public void tearDown() {
+		System.setOut(System.out);
 	}
 
 	@Test
diff --git a/cadi/core/src/test/java/org/onap/aaf/cadi/test/taf/JU_EpiTaf.java b/cadi/core/src/test/java/org/onap/aaf/cadi/test/taf/JU_EpiTaf.java
new file mode 100644
index 00000000..baab0b6a
--- /dev/null
+++ b/cadi/core/src/test/java/org/onap/aaf/cadi/test/taf/JU_EpiTaf.java
@@ -0,0 +1,104 @@
+/*******************************************************************************
+ * ============LICENSE_START====================================================
+ * * org.onap.aaf
+ * * ===========================================================================
+ * * Copyright © 2017 AT&T Intellectual Property. All rights reserved.
+ * * ===========================================================================
+ * * Licensed under the Apache License, Version 2.0 (the "License");
+ * * you may not use this file except in compliance with the License.
+ * * You may obtain a copy of the License at
+ * * 
+ *  *      http://www.apache.org/licenses/LICENSE-2.0
+ * * 
+ *  * Unless required by applicable law or agreed to in writing, software
+ * * distributed under the License is distributed on an "AS IS" BASIS,
+ * * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * * See the License for the specific language governing permissions and
+ * * limitations under the License.
+ * * ============LICENSE_END====================================================
+ * *
+ * *
+ ******************************************************************************/
+package org.onap.aaf.cadi.test.taf;
+
+import static org.junit.Assert.*;
+import static org.hamcrest.CoreMatchers.*;
+import org.junit.*;
+
+import java.io.IOException;
+
+import org.onap.aaf.cadi.Access;
+import org.onap.aaf.cadi.CadiException;
+import org.onap.aaf.cadi.Taf;
+import org.onap.aaf.cadi.taf.TafResp;
+import org.onap.aaf.cadi.taf.TafResp.RESP;
+
+import org.onap.aaf.cadi.taf.EpiTaf;
+import org.onap.aaf.cadi.taf.NullTaf;
+import org.onap.aaf.cadi.Taf.LifeForm;
+import org.onap.aaf.cadi.principal.TaggedPrincipal;
+
+public class JU_EpiTaf {
+
+	@Test(expected = CadiException.class)
+	@SuppressWarnings("unused")
+	public void constructorTest() throws CadiException {
+		EpiTaf et = new EpiTaf();
+	}
+
+	@Test
+	public void validateTryAnotherTest() throws CadiException {
+		EpiTaf et = new EpiTaf(new TryAnotherTaf());
+		TafResp output = et.validate(LifeForm.CBLF);
+		assertThat(output.isAuthenticated(), is(RESP.NO_FURTHER_PROCESSING));
+	}
+
+	@Test
+	public void validateTryAuthenticatingTest() throws CadiException {
+		EpiTaf et = new EpiTaf(new TryAuthenticatingTaf(), new TryAuthenticatingTaf());
+		TafResp output = et.validate(LifeForm.CBLF);
+		assertThat(output.isAuthenticated(), is(RESP.TRY_AUTHENTICATING));
+		output = et.validate(LifeForm.CBLF);
+		assertThat(output.isAuthenticated(), is(RESP.TRY_AUTHENTICATING));
+	}
+
+	@Test
+	public void validateDefaultCaseTest() throws CadiException {
+		EpiTaf et = new EpiTaf(new NullTaf());
+		TafResp output = et.validate(LifeForm.CBLF);
+		assertThat(output.isAuthenticated(), is(RESP.NO_FURTHER_PROCESSING));
+	}
+
+	class TryAnotherTafResp implements TafResp {
+		@Override public boolean isValid() { return false; } 
+		@Override public String desc() { return null; } 
+		@Override public RESP isAuthenticated() { return RESP.TRY_ANOTHER_TAF; } 
+		@Override public RESP authenticate() throws IOException { return null; } 
+		@Override public TaggedPrincipal getPrincipal() { return null; } 
+		@Override public Access getAccess() { return null; } 
+		@Override public boolean isFailedAttempt() { return false; } 
+	}
+
+	class TryAnotherTaf implements Taf {
+		@Override public TafResp validate(LifeForm reading, String ... info) { return new TryAnotherTafResp(); }
+	}
+
+	class TryAuthenticatingResp implements TafResp {
+		@Override public boolean isValid() { return false; } 
+		@Override public String desc() { return null; } 
+		@Override public RESP isAuthenticated() { return RESP.TRY_AUTHENTICATING; } 
+		@Override public RESP authenticate() throws IOException { return null; } 
+		@Override public TaggedPrincipal getPrincipal() { return null; } 
+		@Override public Access getAccess() { return null; } 
+		@Override public boolean isFailedAttempt() { return false; } 
+	}
+
+	class TryAuthenticatingTaf implements Taf {
+		@Override public TafResp validate(LifeForm reading, String ... info) { return new TryAuthenticatingResp(); }
+	}
+
+	class EpiTafStub extends EpiTaf {
+		public EpiTafStub() throws CadiException { }
+	}
+
+}
diff --git a/cadi/core/src/test/java/org/onap/aaf/cadi/test/taf/JU_NullTaf.java b/cadi/core/src/test/java/org/onap/aaf/cadi/test/taf/JU_NullTaf.java
new file mode 100644
index 00000000..9131172e
--- /dev/null
+++ b/cadi/core/src/test/java/org/onap/aaf/cadi/test/taf/JU_NullTaf.java
@@ -0,0 +1,65 @@
+/*******************************************************************************
+ * ============LICENSE_START====================================================
+ * * org.onap.aaf
+ * * ===========================================================================
+ * * Copyright © 2017 AT&T Intellectual Property. All rights reserved.
+ * * ===========================================================================
+ * * Licensed under the Apache License, Version 2.0 (the "License");
+ * * you may not use this file except in compliance with the License.
+ * * You may obtain a copy of the License at
+ * * 
+ *  *      http://www.apache.org/licenses/LICENSE-2.0
+ * * 
+ *  * Unless required by applicable law or agreed to in writing, software
+ * * distributed under the License is distributed on an "AS IS" BASIS,
+ * * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * * See the License for the specific language governing permissions and
+ * * limitations under the License.
+ * * ============LICENSE_END====================================================
+ * *
+ * *
+ ******************************************************************************/
+package org.onap.aaf.cadi.test.taf;
+
+import static org.junit.Assert.*;
+import static org.hamcrest.CoreMatchers.*;
+import org.junit.*;
+
+import java.io.IOException;
+
+import org.onap.aaf.cadi.Access;
+import org.onap.aaf.cadi.CachedPrincipal.Resp;
+import org.onap.aaf.cadi.taf.TafResp;
+import org.onap.aaf.cadi.taf.TafResp.RESP;
+
+import org.onap.aaf.cadi.taf.NullTaf;
+
+public class JU_NullTaf {
+
+	@Test
+	public void test() throws IOException {
+		NullTaf nt = new NullTaf();
+		TafResp singleton1 = nt.validate(null);
+		TafResp singleton2 = nt.validate(null, null, null);
+		Resp singleton3 = nt.revalidate(null, null);
+		
+		assertThat(singleton1, is(singleton2));
+		
+		assertFalse(singleton1.isValid());
+		
+		assertThat(singleton1.isAuthenticated(), is(RESP.NO_FURTHER_PROCESSING));
+		
+		assertThat(singleton1.desc(), is("All Authentication denied"));
+		
+		assertThat(singleton1.authenticate(), is(RESP.NO_FURTHER_PROCESSING));
+		
+		assertThat(singleton1.getPrincipal(), is(nullValue()));
+		
+		assertThat(singleton1.getAccess(), is(Access.NULL));
+		
+		assertTrue(singleton1.isFailedAttempt());
+
+		assertThat(singleton3, is(Resp.NOT_MINE));
+	}
+
+}
diff --git a/cadi/core/src/test/java/org/onap/aaf/cadi/test/taf/JU_NullTafRespTest.java b/cadi/core/src/test/java/org/onap/aaf/cadi/test/taf/JU_PuntTafResp.java
index aabed1ed..8c5397dc 100644
--- a/cadi/core/src/test/java/org/onap/aaf/cadi/test/taf/JU_NullTafRespTest.java
+++ b/cadi/core/src/test/java/org/onap/aaf/cadi/test/taf/JU_PuntTafResp.java
@@ -22,41 +22,33 @@
 package org.onap.aaf.cadi.test.taf;
 
 import static org.junit.Assert.*;
+import static org.hamcrest.CoreMatchers.*;
+import org.junit.*;
 
 import java.io.IOException;
 
-import org.junit.Before;
-import org.junit.Test;
 import org.onap.aaf.cadi.Access;
-import org.onap.aaf.cadi.taf.TafResp;
 import org.onap.aaf.cadi.taf.TafResp.RESP;
 
-public class JU_NullTafRespTest {
-
-// 	@Before
-// 	public void setUp() throws Exception {
-// 	}
-
-// 	@Test
-// 	public void test() throws IOException {
-// 		TafResp singleton = NullTafResp.singleton();
-// 		TafResp singleton1 = NullTafResp.singleton();
-		
-// 		assertEquals(singleton, singleton1);
-		
-// 		assertFalse(singleton.isValid());
-		
-// 		assertEquals(singleton.isAuthenticated(), RESP.NO_FURTHER_PROCESSING);
-		
-// 		assertEquals(singleton.desc(), "All Authentication denied");
-		
-// 		assertEquals(singleton.authenticate(), RESP.NO_FURTHER_PROCESSING);
-		
-// 		assertNull(singleton.getPrincipal());
-		
-// 		assertEquals(singleton.getAccess(), Access.NULL);
-		
-// 		assertEquals(singleton.isFailedAttempt(), true);
-// 	}
+import org.onap.aaf.cadi.taf.PuntTafResp;
+
+
+public class JU_PuntTafResp {
+
+	@Test
+	public void test() throws IOException {
+		String name = "name";
+		String explanation = "example explanation";
+
+		PuntTafResp punt = new PuntTafResp(name, explanation);
+
+		assertFalse(punt.isValid());
+		assertThat(punt.isAuthenticated(), is(RESP.TRY_ANOTHER_TAF));
+		assertThat(punt.desc(), is(name + " is not processing this transaction: " + explanation));
+		assertThat(punt.authenticate(), is(RESP.TRY_ANOTHER_TAF));
+		assertThat(punt.getPrincipal(), is(nullValue()));
+		assertThat(punt.getAccess(), is(Access.NULL));
+		assertFalse(punt.isFailedAttempt());
+	}
 
 }
diff --git a/cadi/core/src/test/java/org/onap/aaf/cadi/test/taf/JU_TrustNotTafResp.java b/cadi/core/src/test/java/org/onap/aaf/cadi/test/taf/JU_TrustNotTafResp.java
new file mode 100644
index 00000000..798348e8
--- /dev/null
+++ b/cadi/core/src/test/java/org/onap/aaf/cadi/test/taf/JU_TrustNotTafResp.java
@@ -0,0 +1,72 @@
+/*******************************************************************************
+ * ============LICENSE_START====================================================
+ * * org.onap.aaf
+ * * ===========================================================================
+ * * Copyright © 2017 AT&T Intellectual Property. All rights reserved.
+ * * ===========================================================================
+ * * Licensed under the Apache License, Version 2.0 (the "License");
+ * * you may not use this file except in compliance with the License.
+ * * You may obtain a copy of the License at
+ * * 
+ *  *      http://www.apache.org/licenses/LICENSE-2.0
+ * * 
+ *  * Unless required by applicable law or agreed to in writing, software
+ * * distributed under the License is distributed on an "AS IS" BASIS,
+ * * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * * See the License for the specific language governing permissions and
+ * * limitations under the License.
+ * * ============LICENSE_END====================================================
+ * *
+ * *
+ ******************************************************************************/
+package org.onap.aaf.cadi.test.taf;
+
+import static org.junit.Assert.*;
+import static org.hamcrest.CoreMatchers.*;
+import static org.mockito.Mockito.*;
+import org.junit.*;
+import org.mockito.*;
+
+import java.io.IOException;
+
+import org.onap.aaf.cadi.Access;
+import org.onap.aaf.cadi.taf.TafResp;
+import org.onap.aaf.cadi.taf.TafResp.RESP;
+import org.onap.aaf.cadi.taf.TrustNotTafResp;
+import org.onap.aaf.cadi.principal.TaggedPrincipal;
+
+public class JU_TrustNotTafResp {
+
+	@Mock
+	TafResp delegateMock;
+
+	@Mock
+	TaggedPrincipal principalMock;
+
+	@Mock
+	Access accessMock;
+
+	private final String description = "Example Description";
+
+	@Before
+	public void setup() throws IOException {
+		MockitoAnnotations.initMocks(this);
+
+		when(delegateMock.getPrincipal()).thenReturn(principalMock);
+		when(delegateMock.getAccess()).thenReturn(accessMock);
+	}
+
+	@Test
+	public void test() throws IOException {
+		TrustNotTafResp ttr = new TrustNotTafResp(delegateMock, description);
+		assertThat(ttr.isValid(), is(false));
+		assertThat(ttr.desc(), is(description));
+		assertThat(ttr.authenticate(), is(RESP.NO_FURTHER_PROCESSING));
+		assertThat(ttr.isAuthenticated(), is(RESP.NO_FURTHER_PROCESSING));
+		assertThat(ttr.getPrincipal(), is(principalMock));
+		assertThat(ttr.getAccess(), is(accessMock));
+		assertThat(ttr.isFailedAttempt(), is(true));
+		assertThat(ttr.toString(), is(description));
+	}
+
+}
diff --git a/cadi/core/src/test/java/org/onap/aaf/cadi/test/taf/JU_TrustTafResp.java b/cadi/core/src/test/java/org/onap/aaf/cadi/test/taf/JU_TrustTafResp.java
new file mode 100644
index 00000000..04e3a1fc
--- /dev/null
+++ b/cadi/core/src/test/java/org/onap/aaf/cadi/test/taf/JU_TrustTafResp.java
@@ -0,0 +1,82 @@
+/*******************************************************************************
+ * ============LICENSE_START====================================================
+ * * org.onap.aaf
+ * * ===========================================================================
+ * * Copyright © 2017 AT&T Intellectual Property. All rights reserved.
+ * * ===========================================================================
+ * * Licensed under the Apache License, Version 2.0 (the "License");
+ * * you may not use this file except in compliance with the License.
+ * * You may obtain a copy of the License at
+ * * 
+ *  *      http://www.apache.org/licenses/LICENSE-2.0
+ * * 
+ *  * Unless required by applicable law or agreed to in writing, software
+ * * distributed under the License is distributed on an "AS IS" BASIS,
+ * * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * * See the License for the specific language governing permissions and
+ * * limitations under the License.
+ * * ============LICENSE_END====================================================
+ * *
+ * *
+ ******************************************************************************/
+package org.onap.aaf.cadi.test.taf;
+
+import static org.junit.Assert.*;
+import static org.hamcrest.CoreMatchers.*;
+import static org.mockito.Mockito.*;
+import org.junit.*;
+import org.mockito.*;
+
+import java.io.IOException;
+
+import org.onap.aaf.cadi.Access;
+import org.onap.aaf.cadi.taf.TafResp;
+import org.onap.aaf.cadi.taf.TafResp.RESP;
+import org.onap.aaf.cadi.taf.TrustTafResp;
+import org.onap.aaf.cadi.principal.TaggedPrincipal;
+
+public class JU_TrustTafResp {
+
+	@Mock
+	TafResp delegateMock;
+
+	@Mock
+	TaggedPrincipal principalMock;
+
+	@Mock
+	Access accessMock;
+
+	private final String description = "Example Description";
+	private final String anotherDescription = "Another Description";
+	private final String name = "name";
+
+	private final RESP resp = RESP.IS_AUTHENTICATED;
+
+	@Before
+	public void setup() throws IOException {
+		MockitoAnnotations.initMocks(this);
+
+		when(delegateMock.desc()).thenReturn(anotherDescription);
+		when(delegateMock.isValid()).thenReturn(true);
+		when(delegateMock.isAuthenticated()).thenReturn(resp);
+		when(delegateMock.authenticate()).thenReturn(resp);
+		when(delegateMock.getAccess()).thenReturn(accessMock);
+		when(delegateMock.isFailedAttempt()).thenReturn(true);
+
+		when(principalMock.getName()).thenReturn(name);
+	}
+
+	@Test
+	public void test() throws IOException {
+		TrustTafResp ttr = new TrustTafResp(delegateMock, principalMock, description);
+		assertThat(ttr.isValid(), is(true));
+		assertThat(ttr.desc(), is(description + ' ' + anotherDescription));
+		assertThat(ttr.authenticate(), is(resp));
+		assertThat(ttr.isAuthenticated(), is(resp));
+		assertThat(ttr.getPrincipal(), is(principalMock));
+		assertThat(ttr.getAccess(), is(accessMock));
+		assertThat(ttr.isFailedAttempt(), is(true));
+		assertThat(ttr.toString(), is(name + " by trust of " + description + ' ' + anotherDescription));
+	}
+
+}
diff --git a/cadi/core/src/test/java/org/onap/aaf/cadi/test/taf/dos/JU_DenialOfServiceTaf.java b/cadi/core/src/test/java/org/onap/aaf/cadi/test/taf/dos/JU_DenialOfServiceTaf.java
new file mode 100644
index 00000000..40933b41
--- /dev/null
+++ b/cadi/core/src/test/java/org/onap/aaf/cadi/test/taf/dos/JU_DenialOfServiceTaf.java
@@ -0,0 +1,369 @@
+/*******************************************************************************
+ * ============LICENSE_START====================================================
+ * * org.onap.aaf
+ * * ===========================================================================
+ * * Copyright © 2017 AT&T Intellectual Property. All rights reserved.
+ * * ===========================================================================
+ * * Licensed under the Apache License, Version 2.0 (the "License");
+ * * you may not use this file except in compliance with the License.
+ * * You may obtain a copy of the License at
+ * *
+ *  *      http://www.apache.org/licenses/LICENSE-2.0
+ * *
+ *  * Unless required by applicable law or agreed to in writing, software
+ * * distributed under the License is distributed on an "AS IS" BASIS,
+ * * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * * See the License for the specific language governing permissions and
+ * * limitations under the License.
+ * * ============LICENSE_END====================================================
+ * *
+ * *
+ ******************************************************************************/
+package org.onap.aaf.cadi.test.taf.dos;
+
+import static org.junit.Assert.*;
+import static org.hamcrest.CoreMatchers.*;
+import static org.mockito.Mockito.*;
+import org.junit.*;
+import org.mockito.*;
+
+import java.io.BufferedReader;
+import java.io.File;
+import java.io.FileReader;
+import java.io.IOException;
+import java.lang.reflect.Field;
+import java.util.List;
+
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+
+import org.onap.aaf.cadi.Access;
+import org.onap.aaf.cadi.CachedPrincipal.Resp;
+import org.onap.aaf.cadi.CadiException;
+import org.onap.aaf.cadi.config.Config;
+import org.onap.aaf.cadi.taf.TafResp;
+import org.onap.aaf.cadi.Taf.LifeForm;
+import org.onap.aaf.cadi.taf.dos.DenialOfServiceTaf;
+import org.onap.aaf.cadi.taf.dos.DenialOfServiceTaf.Counter;
+
+public class JU_DenialOfServiceTaf {
+
+	@Mock
+	HttpServletResponse respMock;
+
+	@Mock
+	HttpServletRequest reqMock1;
+
+	@Mock
+	HttpServletRequest reqMock2;
+
+	@Mock
+	HttpServletRequest reqMock3;
+
+	@Mock
+	Access accessMock;
+
+	private File dosIPFile;
+	private File dosIDFile;
+	private File dosDir;
+	private final String dosDirName = "test";
+	
+	private final String id1 = "id1";
+	private final String id2 = "id2";
+
+	private final String ip1 = "111.111.111.111";
+	private final String ip2 = "222.222.222.222";
+
+	@Before
+	public void setup() throws IOException {
+		MockitoAnnotations.initMocks(this);
+
+		dosDir = new File(dosDirName);
+		dosDir.mkdirs();
+		dosIPFile = new File(dosDirName, "/dosIP");
+		dosIDFile = new File(dosDirName, "/dosID");
+		dosIPFile.delete();
+		dosIDFile.delete();
+
+		when(accessMock.getProperty(Config.AAF_DATA_DIR, null)).thenReturn(dosDirName);
+		when(reqMock1.getRemoteAddr()).thenReturn(ip1);
+		when(reqMock2.getRemoteAddr()).thenReturn(ip2);
+
+		setPrivateField(DenialOfServiceTaf.class, "deniedIP", null);
+		setPrivateField(DenialOfServiceTaf.class, "deniedID", null);
+		setPrivateField(DenialOfServiceTaf.class, "dosIP", null);
+		setPrivateField(DenialOfServiceTaf.class, "dosID", null);
+	}
+
+	@After
+	public void tearDown() {
+		dosIPFile = new File(dosDirName, "/dosIP");
+		dosIDFile = new File(dosDirName, "/dosID");
+		dosIPFile.delete();
+		dosIDFile.delete();
+	}
+
+	@Test
+	public void constructorTest() throws CadiException {
+		@SuppressWarnings("unused")
+		DenialOfServiceTaf dost;
+
+		// coverage...
+		when(accessMock.getProperty(Config.AAF_DATA_DIR, null)).thenReturn(null);
+		dost = new DenialOfServiceTaf(accessMock);
+
+		when(accessMock.getProperty(Config.AAF_DATA_DIR, null)).thenReturn(dosDirName);
+		dost = new DenialOfServiceTaf(accessMock);
+
+		// more coverage...
+		dost = new DenialOfServiceTaf(accessMock);
+
+		// more coverage...
+		setPrivateField(DenialOfServiceTaf.class, "dosID", null);
+		dost = new DenialOfServiceTaf(accessMock);
+	}
+
+	@Test
+	public void validateTest() throws CadiException {
+		DenialOfServiceTaf dost;
+		TafResp tafResp;
+
+		dost = new DenialOfServiceTaf(accessMock);
+		tafResp = dost.validate(LifeForm.SBLF, reqMock1, respMock);
+
+		assertThat(tafResp.desc(), is("DenialOfServiceTaf is not processing this transaction: This Transaction is not denied"));
+
+		assertThat(DenialOfServiceTaf.denyIP(ip1), is(true));
+
+		tafResp = dost.validate(LifeForm.SBLF, reqMock1, respMock);
+		assertThat(tafResp.desc(), is(ip1 + " is on the IP Denial list"));
+
+		tafResp = dost.validate(LifeForm.SBLF, reqMock2, respMock);
+		assertThat(tafResp.desc(), is("DenialOfServiceTaf is not processing this transaction: This Transaction is not denied"));
+	}
+
+	@Test
+	public void revalidateTest() throws CadiException {
+		DenialOfServiceTaf dost = new DenialOfServiceTaf(accessMock);
+		Resp resp = dost.revalidate(null, null);
+		assertThat(resp, is(Resp.NOT_MINE));
+	}
+
+	@Test
+	public void denyIPTest() throws CadiException {
+		assertThat(DenialOfServiceTaf.isDeniedIP(ip1), is(nullValue()));
+		assertThat(DenialOfServiceTaf.denyIP(ip1), is(true));  // true because it's been added
+		assertThat(DenialOfServiceTaf.denyIP(ip2), is(true));  // true because it's been added
+		assertThat(DenialOfServiceTaf.denyIP(ip1), is(false)); // false because it's already been added
+		assertThat(DenialOfServiceTaf.denyIP(ip2), is(false)); // false because it's already been added
+
+		Counter counter;
+		counter = DenialOfServiceTaf.isDeniedIP(ip1);
+		assertThat(counter.getName(), is(ip1));
+		assertThat(counter.getCount(), is(0));
+		assertThat(counter.getLast(), is(0L));
+		assertThat(counter.toString(), is(ip1 + " is on the denied list, but has not attempted Access" ));
+
+		DenialOfServiceTaf dost = new DenialOfServiceTaf(accessMock);
+		dost.validate(LifeForm.SBLF, reqMock1, respMock);
+		long approxTime = System.currentTimeMillis();
+
+		counter = DenialOfServiceTaf.isDeniedIP(ip1);
+		assertThat(counter.getName(), is(ip1));
+		assertThat(counter.getCount(), is(1));
+		assertThat((Math.abs(approxTime - counter.getLast()) < 10), is(true));
+		assertThat(counter.toString().contains(ip1), is(true));
+		assertThat(counter.toString().contains(" has been denied 1 times since "), is(true));
+		assertThat(counter.toString().contains(".  Last denial was "), is(true));
+
+		// coverage...
+		dost.validate(LifeForm.SBLF, reqMock1, respMock);
+
+		assertThat(DenialOfServiceTaf.removeDenyIP(ip1), is(true));
+		assertThat(DenialOfServiceTaf.removeDenyIP(ip1), is(false));
+		assertThat(DenialOfServiceTaf.removeDenyIP(ip2), is(true));
+		assertThat(DenialOfServiceTaf.removeDenyIP(ip2), is(false));
+	}
+
+	@Test
+	public void denyIDTest() throws CadiException {
+		assertThat(DenialOfServiceTaf.isDeniedID(id1), is(nullValue()));
+		assertThat(DenialOfServiceTaf.denyID(id1), is(true));  // true because it's been added
+		assertThat(DenialOfServiceTaf.denyID(id2), is(true));  // true because it's been added
+		assertThat(DenialOfServiceTaf.denyID(id1), is(false)); // false because it's already been added
+		assertThat(DenialOfServiceTaf.denyID(id2), is(false)); // false because it's already been added
+
+		Counter counter;
+		counter = DenialOfServiceTaf.isDeniedID(id1);
+		assertThat(counter.getName(), is(id1));
+		assertThat(counter.getCount(), is(0));
+		assertThat(counter.getLast(), is(0L));
+
+		assertThat(DenialOfServiceTaf.removeDenyID(id1), is(true));
+		assertThat(DenialOfServiceTaf.removeDenyID(id1), is(false));
+		assertThat(DenialOfServiceTaf.removeDenyID(id2), is(true));
+		assertThat(DenialOfServiceTaf.removeDenyID(id2), is(false));
+	}
+
+	@Test
+	public void reportTest() throws CadiException {
+		DenialOfServiceTaf dost = new DenialOfServiceTaf(accessMock);
+		List<String> denials = dost.report();
+		assertThat(denials.size(), is(0));
+
+		DenialOfServiceTaf.denyID(id1);
+		DenialOfServiceTaf.denyID(id2);
+
+		DenialOfServiceTaf.denyIP(ip1);
+		DenialOfServiceTaf.denyIP(ip2);
+
+		denials = dost.report();
+		assertThat(denials.size(), is(4));
+		for (String denied : denials) {
+			switch (denied.split(" ", 2)[0]) {
+				case ip1:
+				case ip2:
+				case id1:
+				case id2:
+					break;
+				default:
+					fail("The line: [" + denied + "] shouldn't be in the report");
+			}
+		}
+	}
+
+	@Test
+	public void respDenyIDTest() {
+		TafResp tafResp = DenialOfServiceTaf.respDenyID(accessMock, id1);
+		assertThat(tafResp.desc(), is(id1 + " is on the Identity Denial list"));
+	}
+
+	@Test
+	public void ipFileIOTest() throws CadiException, IOException {
+		@SuppressWarnings("unused")
+		DenialOfServiceTaf dost;
+
+		dosIPFile.createNewFile();
+
+		// coverage...
+		DenialOfServiceTaf.denyIP(ip1);
+		DenialOfServiceTaf.removeDenyIP(ip1);
+
+		dost = new DenialOfServiceTaf(accessMock);
+		DenialOfServiceTaf.denyIP(ip1);
+		DenialOfServiceTaf.denyIP(ip2);
+		// coverage...
+		DenialOfServiceTaf.denyIP(ip2);
+
+		String contents = readContentsFromFile(dosIPFile);
+		assertThat(contents.contains(ip1), is(true));
+		assertThat(contents.contains(ip2), is(true));
+
+		// Removing all ips should delete the file
+		assertThat(dosIPFile.exists(), is(true));
+		DenialOfServiceTaf.removeDenyIP(ip1);
+		DenialOfServiceTaf.removeDenyIP(ip2);
+		assertThat(dosIPFile.exists(), is(false));
+
+		dosIPFile.createNewFile();
+
+		DenialOfServiceTaf.denyIP(ip1);
+		DenialOfServiceTaf.denyIP(ip2);
+
+		setPrivateField(DenialOfServiceTaf.class, "dosIP", null);
+		dost = new DenialOfServiceTaf(accessMock);
+
+		contents = readContentsFromFile(dosIPFile);
+		assertThat(contents.contains(ip1), is(true));
+		assertThat(contents.contains(ip2), is(true));
+
+		dosIPFile.delete();
+
+		// coverage...
+		setPrivateField(DenialOfServiceTaf.class, "deniedIP", null);
+		DenialOfServiceTaf.denyIP(ip1);
+		dosIPFile.delete();
+		DenialOfServiceTaf.removeDenyIP(ip1);
+
+		// coverage...
+		dosIPFile.delete();
+		setPrivateField(DenialOfServiceTaf.class, "dosIP", null);
+		dost = new DenialOfServiceTaf(accessMock);
+	}
+
+	@Test
+	public void idFileIOTest() throws CadiException, IOException {
+		@SuppressWarnings("unused")
+		DenialOfServiceTaf dost;
+
+		dosIDFile.createNewFile();
+
+		// coverage...
+		DenialOfServiceTaf.denyID(id1);
+		DenialOfServiceTaf.removeDenyID(id1);
+
+		dost = new DenialOfServiceTaf(accessMock);
+		DenialOfServiceTaf.denyID(id1);
+		DenialOfServiceTaf.denyID(id2);
+		// coverage...
+		DenialOfServiceTaf.denyID(id2);
+
+		String contents = readContentsFromFile(dosIDFile);
+		assertThat(contents.contains(id1), is(true));
+		assertThat(contents.contains(id2), is(true));
+
+		// Removing all ids should delete the file
+		assertThat(dosIDFile.exists(), is(true));
+		DenialOfServiceTaf.removeDenyID(id1);
+		DenialOfServiceTaf.removeDenyID(id2);
+		assertThat(dosIDFile.exists(), is(false));
+
+		dosIDFile.createNewFile();
+
+		DenialOfServiceTaf.denyID(id1);
+		DenialOfServiceTaf.denyID(id2);
+
+		setPrivateField(DenialOfServiceTaf.class, "dosID", null);
+		dost = new DenialOfServiceTaf(accessMock);
+
+		contents = readContentsFromFile(dosIDFile);
+		assertThat(contents.contains(id1), is(true));
+		assertThat(contents.contains(id2), is(true));
+
+		dosIDFile.delete();
+
+		// coverage...
+		setPrivateField(DenialOfServiceTaf.class, "deniedID", null);
+		DenialOfServiceTaf.denyID(id1);
+		dosIDFile.delete();
+		DenialOfServiceTaf.removeDenyID(id1);
+
+		// coverage...
+		dosIDFile.delete();
+		setPrivateField(DenialOfServiceTaf.class, "dosID", null);
+		dost = new DenialOfServiceTaf(accessMock);
+	}
+
+	private void setPrivateField(Class<?> clazz, String fieldName, Object value) {
+		try {
+			Field field = clazz.getDeclaredField(fieldName);
+			field.setAccessible(true);
+			field.set(null, value);
+			field.setAccessible(false);
+		} catch(Exception e) {
+			System.err.println("Could not set field [" + fieldName + "] to " + value);
+		}
+	}
+
+	private String readContentsFromFile(File file) throws IOException {
+		BufferedReader br = new BufferedReader(new FileReader(file));
+		StringBuilder sb = new StringBuilder();
+		String line;
+		while ((line = br.readLine()) != null) {
+			sb.append(line);
+		}
+		br.close();
+		return sb.toString();
+	}
+
+}
diff --git a/cadi/core/src/test/java/org/onap/aaf/cadi/test/wsse/JU_XReader.java b/cadi/core/src/test/java/org/onap/aaf/cadi/test/wsse/JU_XReader.java
index b97b0632..b07cd296 100644
--- a/cadi/core/src/test/java/org/onap/aaf/cadi/test/wsse/JU_XReader.java
+++ b/cadi/core/src/test/java/org/onap/aaf/cadi/test/wsse/JU_XReader.java
@@ -21,43 +21,142 @@
  ******************************************************************************/
 package org.onap.aaf.cadi.test.wsse;
 
+import static org.junit.Assert.*;
+import static org.hamcrest.CoreMatchers.*;
+import org.junit.*;
+
+import java.io.File;
 import java.io.FileInputStream;
+import java.io.FileNotFoundException;
+import java.io.IOException;
+import java.io.PrintWriter;
 
+import javax.xml.stream.XMLStreamException;
 import javax.xml.stream.events.XMLEvent;
 
-import org.junit.Test;
 import org.onap.aaf.cadi.wsse.XEvent;
 import org.onap.aaf.cadi.wsse.XReader;
 
 public class JU_XReader {
-	// TODO: Gabe [JUnit] Class not found error
+
+	private final static String TEST_DIR_NAME = "test";
+	private final static String TEST_XML_NAME = "test.xml";
+	private static File testXML;
+
+	private final static String COMMENT = "a comment";
+	private final static String OUTER_TAG = "outerTag";
+	private final static String INNER_TAG = "innerTag";
+	private final static String DATA_TAG = "dataTag";
+	private final static String DATA = "some text that represents data";
+	private final static String SELF_CLOSING_TAG = "selfClosingTag";
+	private final static String PREFIX = "prefix";
+	private final static String SUFFIX = "suffix";
+
+	@BeforeClass
+	public static void setupOnce() throws IOException {
+		testXML = setupXMLFile();
+	}
+
+	@AfterClass
+	public static void tearDownOnce() {
+		testXML.delete();
+	}
+
 	@Test
-	public void test() throws Exception {
-		FileInputStream fis = new FileInputStream("test/CBUSevent.xml");
+	public void test() throws XMLStreamException, IOException {
+		FileInputStream fis = new FileInputStream(TEST_DIR_NAME + '/' + TEST_XML_NAME);
 		try {
 			XReader xr = new XReader(fis);
-			while (xr.hasNext()) {
-				XEvent xe = xr.nextEvent();
-				switch (xe.getEventType()) {
-				case XMLEvent.START_DOCUMENT:
-					System.out.println("Start Document");
-					break;
-				case XMLEvent.START_ELEMENT:
-					System.out.println("Start Event: " + xe.asStartElement().getName());
-					break;
-				case XMLEvent.END_ELEMENT:
-					System.out.println("End Event: " + xe.asEndElement().getName());
-					break;
-				case XMLEvent.CHARACTERS:
-					System.out.println("Characters: " + xe.asCharacters().getData());
-					break;
-				case XMLEvent.COMMENT:
-					System.out.println("Comment: " + ((XEvent.Comment) xe).value);
-					break;
-				}
-			}
+			assertThat(xr.hasNext(), is(true));
+			XEvent xe;
+
+			xe = getNextEvent(xr);
+			assertThat(xe.getEventType(), is(XMLEvent.START_DOCUMENT));
+
+			xe = getNextEvent(xr);
+			assertThat(xe.getEventType(), is(XMLEvent.START_ELEMENT));
+
+			xe = getNextEvent(xr);
+			assertThat(xe.getEventType(), is(XMLEvent.COMMENT));
+			assertThat(((XEvent.Comment)xe).value, is(COMMENT));
+
+			xe = getNextEvent(xr);
+			assertThat(xe.getEventType(), is(XMLEvent.START_ELEMENT));
+			assertThat(xe.asStartElement().getName().toString(), is(OUTER_TAG));
+
+			xe = getNextEvent(xr);
+			assertThat(xe.getEventType(), is(XMLEvent.START_ELEMENT));
+			assertThat(xe.asStartElement().getName().toString(), is(INNER_TAG));
+
+			xe = getNextEvent(xr);
+			assertThat(xe.getEventType(), is(XMLEvent.START_ELEMENT));
+			assertThat(xe.asStartElement().getName().toString(), is(DATA_TAG));
+
+			xe = getNextEvent(xr);
+			assertThat(xe.getEventType(), is(XMLEvent.CHARACTERS));
+			assertThat(xe.asCharacters().getData().toString(), is(DATA));
+
+			xe = getNextEvent(xr);
+			assertThat(xe.getEventType(), is(XMLEvent.END_ELEMENT));
+			assertThat(xe.asEndElement().getName().toString(), is(DATA_TAG));
+
+			xe = getNextEvent(xr);
+			assertThat(xe.getEventType(), is(XMLEvent.START_ELEMENT));
+			assertThat(xe.asStartElement().getName().toString(), is(SELF_CLOSING_TAG));
+
+			xe = getNextEvent(xr);
+			assertThat(xe.getEventType(), is(XMLEvent.START_ELEMENT));
+			assertThat(xe.asStartElement().getName().toString(), is(SUFFIX));
+
+			xe = getNextEvent(xr);
+			assertThat(xe.getEventType(), is(XMLEvent.END_ELEMENT));
+			assertThat(xe.asEndElement().getName().toString(), is(INNER_TAG));
+
+			xe = getNextEvent(xr);
+			assertThat(xe.getEventType(), is(XMLEvent.END_ELEMENT));
+			assertThat(xe.asEndElement().getName().toString(), is(OUTER_TAG));
+
+			assertThat(xr.hasNext(), is(false));
+
 		} finally {
 			fis.close();
 		}
 	}
-}
\ No newline at end of file
+
+	// @Test
+	// public void tagTest() {
+	// 	String prefix = "prefix";
+	// 	String name = "name";
+	// 	String value = "value";
+	// 	XReader.Tag tag = new Tag(prefix, name, value);
+
+	// 	assertThat(tag.toString(), is(prefix + ':' + name + "=\'" + value + "'"));
+	// }
+
+
+	private static XEvent getNextEvent(XReader xr) throws XMLStreamException {
+		if (xr.hasNext()) {
+			return xr.nextEvent();
+		}
+		return null;
+	}
+
+	private static File setupXMLFile() throws IOException {
+		File xmlFile = new File(TEST_DIR_NAME, TEST_XML_NAME);
+		PrintWriter writer = new PrintWriter(xmlFile);
+		writer.println("    ");  // Whitespace before the document - this is for coverage
+		writer.println("<?xml version=\"1.0\" encoding=\"UTF-8\"?>");
+		writer.println("<!DOCTYPE xml>");
+		writer.println("<!--" + COMMENT + "-->");
+		writer.println("<" + OUTER_TAG + ">");
+		writer.println("  <" + INNER_TAG + ">");
+		writer.println("    <" + DATA_TAG + ">" + DATA + "</" + DATA_TAG + ">");
+		writer.println("    <" + SELF_CLOSING_TAG + " withAnAttribute=\"That has nested \\\" marks\" />");
+		writer.println("    <" + PREFIX + ":" + SUFFIX + "/>");
+		writer.println("  </" + INNER_TAG + ">");
+		writer.println("</" + OUTER_TAG + ">");
+		writer.flush();
+		writer.close();
+		return xmlFile;
+	}
+}