Improve coverage of cadi-core

* Reduced complexity of HttpEpiTaf and LoginPageTafResp
* Applied ONAP's code style to HttpEpiTaf and LoginPageTafResp
* wrote JUnits for HttpEpiTaf and LoginPageTafResp

Issue-ID: AAF-225
Change-Id: I28059237e838d0276593d556d2e04fe3a7b852c6
Signed-off-by: IanHowell <ian.howell@att.com>

2 files changed, 246 insertions, 0 deletions

diff --git a/cadi/core/src/test/java/org/onap/aaf/cadi/taf/test/JU_HttpEpiTaf.java b/cadi/core/src/test/java/org/onap/aaf/cadi/taf/test/JU_HttpEpiTaf.java
new file mode 100644
index 00000000..93a20474
--- /dev/null
+++ b/cadi/core/src/test/java/org/onap/aaf/cadi/taf/test/JU_HttpEpiTaf.java
@@ -0,0 +1,145 @@
+/**
+ * ============LICENSE_START====================================================
+ * org.onap.aaf
+ * ===========================================================================
+ * Copyright (c) 2018 AT&T Intellectual Property. All rights reserved.
+ * ===========================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END====================================================
+ *
+ */
+
+package org.onap.aaf.cadi.taf.test;
+
+import static org.hamcrest.CoreMatchers.is;
+import static org.junit.Assert.assertThat;
+import static org.junit.Assert.fail;
+import static org.mockito.Mockito.when;
+
+import java.io.ByteArrayOutputStream;
+import java.io.PrintStream;
+import java.net.URI;
+import java.net.URISyntaxException;
+
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+
+import org.junit.Before;
+import org.junit.Test;
+import org.mockito.Mock;
+import org.mockito.MockitoAnnotations;
+import org.onap.aaf.cadi.Access.Level;
+import org.onap.aaf.cadi.CachedPrincipal.Resp;
+import org.onap.aaf.cadi.CadiException;
+import org.onap.aaf.cadi.Locator;
+import org.onap.aaf.cadi.PropAccess;
+import org.onap.aaf.cadi.Taf.LifeForm;
+import org.onap.aaf.cadi.TrustChecker;
+import org.onap.aaf.cadi.taf.HttpEpiTaf;
+import org.onap.aaf.cadi.taf.HttpTaf;
+import org.onap.aaf.cadi.taf.NullTaf;
+import org.onap.aaf.cadi.taf.Redirectable;
+import org.onap.aaf.cadi.taf.TafResp;
+import org.onap.aaf.cadi.taf.TafResp.RESP;
+
+public class JU_HttpEpiTaf {
+
+	private PropAccess access;
+
+	@Mock private Locator<URI> locMock;
+	@Mock private TrustChecker trustCheckerMock;
+	@Mock private HttpServletRequest reqMock;
+	@Mock private HttpServletResponse respMock;
+	@Mock private HttpTaf tafMock;
+	@Mock private TafResp trespMock;
+	@Mock private Redirectable redirMock;
+
+	@Before
+	public void setup() throws URISyntaxException {
+		MockitoAnnotations.initMocks(this);
+
+		access = new PropAccess(new PrintStream(new ByteArrayOutputStream()), new String[0]);
+	}
+
+	@Test
+	public void test() throws Exception {
+		HttpEpiTaf taf;
+		try {
+			taf = new HttpEpiTaf(access, locMock, trustCheckerMock);
+			fail("Should've thrown an exception");
+		} catch (CadiException e) {
+			assertThat(e.getMessage(), is("Need at least one HttpTaf implementation in constructor"));
+		}
+
+		taf = new HttpEpiTaf(access, locMock, trustCheckerMock, new NullTaf());
+		taf.validate(LifeForm.CBLF, reqMock, respMock);
+
+		// Coverage of tricorderScan
+		taf.validate(LifeForm.LFN, reqMock, respMock);
+		when(reqMock.getHeader("User-Agent")).thenReturn("Non-mozilla-header");
+		taf.validate(LifeForm.LFN, reqMock, respMock);
+		when(reqMock.getHeader("User-Agent")).thenReturn("Mozilla-header");
+		taf.validate(LifeForm.LFN, reqMock, respMock);
+
+		access.setLogLevel(Level.DEBUG);
+		taf.validate(LifeForm.CBLF, reqMock, respMock);
+
+		when(tafMock.validate(LifeForm.CBLF, reqMock, respMock)).thenReturn(trespMock);
+		when(trespMock.isAuthenticated()).thenReturn(RESP.TRY_ANOTHER_TAF);
+		taf = new HttpEpiTaf(access, locMock, trustCheckerMock, tafMock);
+		taf.validate(LifeForm.CBLF, reqMock, respMock);
+
+		when(trespMock.isAuthenticated()).thenReturn(RESP.IS_AUTHENTICATED);
+		taf.validate(LifeForm.CBLF, reqMock, respMock);
+
+		when(trespMock.isAuthenticated()).thenReturn(RESP.TRY_AUTHENTICATING);
+		taf.validate(LifeForm.CBLF, reqMock, respMock);
+
+		taf = new HttpEpiTaf(access, locMock, trustCheckerMock, tafMock, tafMock);
+		taf.validate(LifeForm.CBLF, reqMock, respMock);
+
+		when(tafMock.validate(LifeForm.CBLF, reqMock, respMock)).thenReturn(redirMock);
+		when(redirMock.isAuthenticated()).thenReturn(RESP.TRY_AUTHENTICATING);
+		taf.validate(LifeForm.CBLF, reqMock, respMock);
+
+		taf = new HttpEpiTaf(access, locMock, trustCheckerMock, tafMock, tafMock);
+		taf.validate(LifeForm.CBLF, reqMock, respMock);
+
+		taf = new HttpEpiTaf(access, locMock, trustCheckerMock, tafMock);
+		taf.validate(LifeForm.CBLF, reqMock, respMock);
+
+		taf = new HttpEpiTaf(access, locMock, null, tafMock);
+		when(redirMock.isAuthenticated()).thenReturn(RESP.IS_AUTHENTICATED);
+		try {
+			taf.validate(LifeForm.CBLF, reqMock, respMock);
+			fail("Should've thrown an exception");
+		} catch (Exception e) {
+		}
+
+		assertThat(taf.revalidate(null), is(false));
+		assertThat(taf.revalidate(null), is(false));
+
+		when(tafMock.revalidate(null, null)).thenReturn(Resp.NOT_MINE);
+		assertThat(taf.revalidate(null, null), is(Resp.NOT_MINE));
+		when(tafMock.revalidate(null, null)).thenReturn(Resp.REVALIDATED);
+		assertThat(taf.revalidate(null, null), is(Resp.REVALIDATED));
+
+		when(tafMock.revalidate(null, null)).thenReturn(Resp.NOT_MINE).thenReturn(Resp.NOT_MINE).thenReturn(Resp.REVALIDATED);
+		taf = new HttpEpiTaf(access, locMock, trustCheckerMock, tafMock, tafMock, tafMock);
+		assertThat(taf.revalidate(null, null), is(Resp.REVALIDATED));
+
+		taf.toString();
+
+	}
+
+}
diff --git a/cadi/core/src/test/java/org/onap/aaf/cadi/taf/test/JU_LoginPageTafResp.java b/cadi/core/src/test/java/org/onap/aaf/cadi/taf/test/JU_LoginPageTafResp.java
new file mode 100644
index 00000000..3124bbd4
--- /dev/null
+++ b/cadi/core/src/test/java/org/onap/aaf/cadi/taf/test/JU_LoginPageTafResp.java
@@ -0,0 +1,101 @@
+/**
+ * ============LICENSE_START====================================================
+ * org.onap.aaf
+ * ===========================================================================
+ * Copyright (c) 2018 AT&T Intellectual Property. All rights reserved.
+ * ===========================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END====================================================
+ *
+ */
+
+package org.onap.aaf.cadi.taf.test;
+
+import static org.hamcrest.CoreMatchers.is;
+import static org.junit.Assert.assertThat;
+import static org.mockito.Matchers.any;
+import static org.mockito.Mockito.when;
+
+import java.io.ByteArrayOutputStream;
+import java.io.IOException;
+import java.io.PrintStream;
+import java.net.URI;
+import java.net.URISyntaxException;
+import java.util.ArrayList;
+import java.util.List;
+
+import javax.servlet.http.HttpServletResponse;
+
+import org.junit.Before;
+import org.junit.Test;
+import org.mockito.Mock;
+import org.mockito.MockitoAnnotations;
+import org.onap.aaf.cadi.Access;
+import org.onap.aaf.cadi.Locator;
+import org.onap.aaf.cadi.Locator.Item;
+import org.onap.aaf.cadi.LocatorException;
+import org.onap.aaf.cadi.PropAccess;
+import org.onap.aaf.cadi.taf.LoginPageTafResp;
+import org.onap.aaf.cadi.taf.Redirectable;
+import org.onap.aaf.cadi.taf.TafResp;
+import org.onap.aaf.cadi.taf.TafResp.RESP;
+
+public class JU_LoginPageTafResp {
+
+	private static final String uriString = "example.com";
+
+	private URI uri;
+	private Access access;
+	private List<Redirectable> redirectables;
+
+	@Mock private HttpServletResponse respMock;
+	@Mock private Locator<URI> locatorMock;
+	@Mock private Redirectable redirMock;
+
+	@Before
+	public void setup() throws URISyntaxException {
+		MockitoAnnotations.initMocks(this);
+
+		access = new PropAccess(new PrintStream(new ByteArrayOutputStream()), new String[0]);
+
+		redirectables = new ArrayList<>();
+		uri = new URI(uriString);
+	}
+
+	@Test
+	public void test() throws LocatorException, IOException {
+		TafResp resp;
+		resp = LoginPageTafResp.create(access, null, respMock, redirectables);
+		assertThat(resp.desc(), is("All Authentication denied"));
+
+		redirectables.add(redirMock);
+		redirectables.add(redirMock);
+		resp = LoginPageTafResp.create(access, null, respMock, redirectables);
+		assertThat((Redirectable)resp, is(redirMock));
+
+		resp = LoginPageTafResp.create(access, locatorMock, respMock, redirectables);
+		assertThat(resp.desc(), is("All Authentication denied"));
+
+		when(locatorMock.get((Item)any())).thenReturn(uri);
+		resp = LoginPageTafResp.create(access, locatorMock, respMock, redirectables);
+		assertThat(resp.desc(), is("Multiple Possible HTTP Logins available.  Redirecting to Login Choice Page"));
+		assertThat(resp.authenticate(), is(RESP.HTTP_REDIRECT_INVOKED));
+		assertThat(resp.isAuthenticated(), is(RESP.TRY_AUTHENTICATING));
+
+		redirectables = new ArrayList<>();
+		resp = LoginPageTafResp.create(access, locatorMock, respMock, redirectables);
+		assertThat(resp.desc(), is("All Authentication denied"));
+
+	}
+
+}