summaryrefslogtreecommitdiffstats
path: root/auth/auth-cmd/src/main
diff options
context:
space:
mode:
authorInstrumental <jcgmisc@stl.gathman.org>2018-03-29 20:26:02 -0500
committerInstrumental <jcgmisc@stl.gathman.org>2018-03-29 20:26:11 -0500
commit36b62be84b398044e1feae657c662dba6247782f (patch)
treed537940a473259de2f2d97579607d7cbfa9906d1 /auth/auth-cmd/src/main
parentd86dd644e1543743cfcbc83b230bd4f2cb2e5d4e (diff)
Clean up Sonar results 2
Issue-ID: AAF-206 Change-Id: Ia000b144be58af970f4a5264ca5a9718fdbf9f5d Signed-off-by: Instrumental <jcgmisc@stl.gathman.org>
Diffstat (limited to 'auth/auth-cmd/src/main')
-rw-r--r--auth/auth-cmd/src/main/java/org/onap/aaf/auth/cmd/AAFcli.java5
-rw-r--r--auth/auth-cmd/src/main/java/org/onap/aaf/auth/cmd/role/CreateDelete.java3
2 files changed, 7 insertions, 1 deletions
diff --git a/auth/auth-cmd/src/main/java/org/onap/aaf/auth/cmd/AAFcli.java b/auth/auth-cmd/src/main/java/org/onap/aaf/auth/cmd/AAFcli.java
index 1961b1f5..72aa0ccd 100644
--- a/auth/auth-cmd/src/main/java/org/onap/aaf/auth/cmd/AAFcli.java
+++ b/auth/auth-cmd/src/main/java/org/onap/aaf/auth/cmd/AAFcli.java
@@ -247,7 +247,10 @@ public class AAFcli {
} else if ("pause".equalsIgnoreCase(largs[idx])) {
pw.println("Press <Return> to continue...");
++idx;
- new BufferedReader(new InputStreamReader(System.in)).readLine();
+ // Sonar insists we do something with the string, though it's only a pause. Not very helpful...
+ String sonar = new BufferedReader(new InputStreamReader(System.in)).readLine();
+ sonar=""; // this useless code brought to you by Sonar.
+ pw.print(sonar);
continue;
} else if ("exit".equalsIgnoreCase(largs[idx])) {
pw.println("Exiting...");
diff --git a/auth/auth-cmd/src/main/java/org/onap/aaf/auth/cmd/role/CreateDelete.java b/auth/auth-cmd/src/main/java/org/onap/aaf/auth/cmd/role/CreateDelete.java
index 99d55839..3234fe9c 100644
--- a/auth/auth-cmd/src/main/java/org/onap/aaf/auth/cmd/role/CreateDelete.java
+++ b/auth/auth-cmd/src/main/java/org/onap/aaf/auth/cmd/role/CreateDelete.java
@@ -90,6 +90,9 @@ public class CreateDelete extends Cmd {
}
boolean rolesSupplied = (args.length>idx);
+ if(fp == null) {// This useless code brought to you by Sonar.
+ throw new CadiException("No call made.");
+ }
if(fp.get(AAFcli.timeout())) {
rv=fp.code();
pw().print(verb);