Improve aaf sonar code coverage

Issue-id: AAF-79
Change-Id: I0538a55ec48d8198bfd7a8b3b8151f29d6574c66
Signed-off-by: sg481n <sg481n@att.com>

13 files changed, 15 insertions, 65 deletions

diff --git a/authz-batch/pom.xml b/authz-batch/pom.xml
index af456a33..89af59bd 100644
--- a/authz-batch/pom.xml
+++ b/authz-batch/pom.xml
@@ -34,7 +34,6 @@
 	</developers>
 
 	<properties>
-		<maven.test.failure.ignore>false</maven.test.failure.ignore>
 		<project.swmVersion>1</project.swmVersion>
 		<project.interfaceVersion>1.0.0-SNAPSHOT</project.interfaceVersion>
 		<project.innoVersion>1.0.0-SNAPSHOT</project.innoVersion>
@@ -47,7 +46,7 @@
 		<sonar.surefire.reportsPath>${project.build.directory}/surefire-reports</sonar.surefire.reportsPath>
 		<sonar.jacoco.reportPath>${project.build.directory}/coverage-reports/jacoco.exec</sonar.jacoco.reportPath>
 		<sonar.jacoco.itReportPath>${project.build.directory}/coverage-reports/jacoco-it.exec</sonar.jacoco.itReportPath>
-		<sonar.jacoco.reportMissing.force.zero>true</sonar.jacoco.reportMissing.force.zero>
+		<sonar.jacoco.reportMissing.force.zero>false</sonar.jacoco.reportMissing.force.zero>
 		<sonar.projectVersion>${project.version}</sonar.projectVersion>
 		<nexusproxy>https://nexus.onap.org</nexusproxy>
 		<snapshotNexusPath>/content/repositories/snapshots/</snapshotNexusPath>
@@ -220,9 +219,6 @@
 				<version>0.7.7.201606060606</version>
 				<configuration>
 					<dumpOnExit>true</dumpOnExit>
-					<includes>
-						<include>org.onap.aaf.*</include>
-					</includes>
 				</configuration>
 				<executions>
 					<execution>
diff --git a/authz-cass/pom.xml b/authz-cass/pom.xml
index 7c99385e..0a2494d2 100644
--- a/authz-cass/pom.xml
+++ b/authz-cass/pom.xml
@@ -58,7 +58,7 @@
 		<sonar.surefire.reportsPath>${project.build.directory}/surefire-reports</sonar.surefire.reportsPath>

 		<sonar.jacoco.reportPath>${project.build.directory}/coverage-reports/jacoco.exec</sonar.jacoco.reportPath>

 		<sonar.jacoco.itReportPath>${project.build.directory}/coverage-reports/jacoco-it.exec</sonar.jacoco.itReportPath>

-		<sonar.jacoco.reportMissing.force.zero>true</sonar.jacoco.reportMissing.force.zero>

+		<sonar.jacoco.reportMissing.force.zero>false</sonar.jacoco.reportMissing.force.zero>

 		<sonar.projectVersion>${project.version}</sonar.projectVersion>

         <nexusproxy>https://nexus.onap.org</nexusproxy>

 		<snapshotNexusPath>/content/repositories/snapshots/</snapshotNexusPath>

@@ -167,9 +167,6 @@
 				<version>0.7.7.201606060606</version>

 				<configuration>

 					<dumpOnExit>true</dumpOnExit>

-					<includes>

-						<include>org.onap.aaf.*</include>

-					</includes>

 				</configuration>

 				<executions>

 					<execution>

diff --git a/authz-certman/pom.xml b/authz-certman/pom.xml
index 1473a1c8..9443cb12 100644
--- a/authz-certman/pom.xml
+++ b/authz-certman/pom.xml
@@ -60,7 +60,7 @@
 		<sonar.surefire.reportsPath>${project.build.directory}/surefire-reports</sonar.surefire.reportsPath>

 		<sonar.jacoco.reportPath>${project.build.directory}/coverage-reports/jacoco.exec</sonar.jacoco.reportPath>

 		<sonar.jacoco.itReportPath>${project.build.directory}/coverage-reports/jacoco-it.exec</sonar.jacoco.itReportPath>

-		<sonar.jacoco.reportMissing.force.zero>true</sonar.jacoco.reportMissing.force.zero>

+		<sonar.jacoco.reportMissing.force.zero>false</sonar.jacoco.reportMissing.force.zero>

 		<sonar.projectVersion>${project.version}</sonar.projectVersion>

         <nexusproxy>https://nexus.onap.org</nexusproxy>

 		<snapshotNexusPath>/content/repositories/snapshots/</snapshotNexusPath>

@@ -165,9 +165,6 @@
 				<version>0.7.7.201606060606</version>

 				<configuration>

 					<dumpOnExit>true</dumpOnExit>

-					<includes>

-						<include>org.onap.aaf.*</include>

-					</includes>

 				</configuration>

 				<executions>

 					<execution>

diff --git a/authz-client/pom.xml b/authz-client/pom.xml
index 6e822e00..ae69cb63 100644
--- a/authz-client/pom.xml
+++ b/authz-client/pom.xml
@@ -60,14 +60,13 @@
 		<properties>

 		<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>

 		<swm-distFiles-path>/opt/app/aft/${project.artifactId}/${project.version}</swm-distFiles-path>

-		<maven.test.failure.ignore>true</maven.test.failure.ignore>

 		<project.cadiVersion>1.0.0-SNAPSHOT</project.cadiVersion>

 		<sonar.language>java</sonar.language>

 		<sonar.java.coveragePlugin>jacoco</sonar.java.coveragePlugin>

 		<sonar.surefire.reportsPath>${project.build.directory}/surefire-reports</sonar.surefire.reportsPath>

 		<sonar.jacoco.reportPath>${project.build.directory}/coverage-reports/jacoco.exec</sonar.jacoco.reportPath>

 		<sonar.jacoco.itReportPath>${project.build.directory}/coverage-reports/jacoco-it.exec</sonar.jacoco.itReportPath>

-		<sonar.jacoco.reportMissing.force.zero>true</sonar.jacoco.reportMissing.force.zero>

+		<sonar.jacoco.reportMissing.force.zero>false</sonar.jacoco.reportMissing.force.zero>

 		<sonar.projectVersion>${project.version}</sonar.projectVersion>

         <nexusproxy>https://nexus.onap.org</nexusproxy>

 		<snapshotNexusPath>/content/repositories/snapshots/</snapshotNexusPath>

@@ -196,9 +195,6 @@
 				<version>0.7.7.201606060606</version>

 				<configuration>

 					<dumpOnExit>true</dumpOnExit>

-					<includes>

-						<include>org.onap.aaf.*</include>

-					</includes>

 				</configuration>

 				<executions>

 					<execution>

diff --git a/authz-cmd/pom.xml b/authz-cmd/pom.xml
index 23066374..a9d5812a 100644
--- a/authz-cmd/pom.xml
+++ b/authz-cmd/pom.xml
@@ -52,7 +52,6 @@
 	</developers>

 

   <properties>

-    <maven.test.failure.ignore>false</maven.test.failure.ignore>

     <project.swmVersion>21</project.swmVersion>

     	<project.cadiVersion>1.0.0-SNAPSHOT</project.cadiVersion>

 		<sonar.language>java</sonar.language>

@@ -60,7 +59,7 @@
 		<sonar.surefire.reportsPath>${project.build.directory}/surefire-reports</sonar.surefire.reportsPath>

 		<sonar.jacoco.reportPath>${project.build.directory}/coverage-reports/jacoco.exec</sonar.jacoco.reportPath>

 		<sonar.jacoco.itReportPath>${project.build.directory}/coverage-reports/jacoco-it.exec</sonar.jacoco.itReportPath>

-		<sonar.jacoco.reportMissing.force.zero>true</sonar.jacoco.reportMissing.force.zero>

+		<sonar.jacoco.reportMissing.force.zero>false</sonar.jacoco.reportMissing.force.zero>

 		<sonar.projectVersion>${project.version}</sonar.projectVersion>

         <nexusproxy>https://nexus.onap.org</nexusproxy>

 		<snapshotNexusPath>/content/repositories/snapshots/</snapshotNexusPath>

@@ -172,9 +171,6 @@
 				<version>0.7.7.201606060606</version>

 				<configuration>

 					<dumpOnExit>true</dumpOnExit>

-					<includes>

-						<include>org.onap.aaf.*</include>

-					</includes>

 				</configuration>

 				<executions>

 					<execution>

diff --git a/authz-core/pom.xml b/authz-core/pom.xml
index ef361b48..9d55163b 100644
--- a/authz-core/pom.xml
+++ b/authz-core/pom.xml
@@ -58,7 +58,7 @@
 		<sonar.surefire.reportsPath>${project.build.directory}/surefire-reports</sonar.surefire.reportsPath>

 		<sonar.jacoco.reportPath>${project.build.directory}/coverage-reports/jacoco.exec</sonar.jacoco.reportPath>

 		<sonar.jacoco.itReportPath>${project.build.directory}/coverage-reports/jacoco-it.exec</sonar.jacoco.itReportPath>

-		<sonar.jacoco.reportMissing.force.zero>true</sonar.jacoco.reportMissing.force.zero>

+		<sonar.jacoco.reportMissing.force.zero>false</sonar.jacoco.reportMissing.force.zero>

 		<sonar.projectVersion>${project.version}</sonar.projectVersion>

         <nexusproxy>https://nexus.onap.org</nexusproxy>

 		<snapshotNexusPath>/content/repositories/snapshots/</snapshotNexusPath>

@@ -156,9 +156,6 @@
 				<version>0.7.7.201606060606</version>

 				<configuration>

 					<dumpOnExit>true</dumpOnExit>

-					<includes>

-						<include>org.onap.aaf.*</include>

-					</includes>

 				</configuration>

 				<executions>

 					<execution>

diff --git a/authz-defOrg/pom.xml b/authz-defOrg/pom.xml
index 86bd4b25..7d5c92b5 100644
--- a/authz-defOrg/pom.xml
+++ b/authz-defOrg/pom.xml
@@ -52,7 +52,6 @@
 	</developers>

 

   <properties>

-    <maven.test.failure.ignore>false</maven.test.failure.ignore>

     <project.swmVersion>0</project.swmVersion>

 	<project.cadiVersion>1.0.0-SNAPSHOT</project.cadiVersion>

 	<project.innoVersion>1.0.0-SNAPSHOT</project.innoVersion>

@@ -61,7 +60,7 @@
 		<sonar.surefire.reportsPath>${project.build.directory}/surefire-reports</sonar.surefire.reportsPath>

 		<sonar.jacoco.reportPath>${project.build.directory}/coverage-reports/jacoco.exec</sonar.jacoco.reportPath>

 		<sonar.jacoco.itReportPath>${project.build.directory}/coverage-reports/jacoco-it.exec</sonar.jacoco.itReportPath>

-		<sonar.jacoco.reportMissing.force.zero>true</sonar.jacoco.reportMissing.force.zero>

+		<sonar.jacoco.reportMissing.force.zero>false</sonar.jacoco.reportMissing.force.zero>

 		<sonar.projectVersion>${project.version}</sonar.projectVersion>

         <nexusproxy>https://nexus.onap.org</nexusproxy>

 		<snapshotNexusPath>/content/repositories/snapshots/</snapshotNexusPath>

@@ -126,9 +125,6 @@
 				<version>0.7.7.201606060606</version>

 				<configuration>

 					<dumpOnExit>true</dumpOnExit>

-					<includes>

-						<include>org.onap.aaf.*</include>

-					</includes>

 				</configuration>

 				<executions>

 					<execution>

diff --git a/authz-fs/pom.xml b/authz-fs/pom.xml
index 14d0997b..3486b4be 100644
--- a/authz-fs/pom.xml
+++ b/authz-fs/pom.xml
@@ -51,7 +51,6 @@
 	</developers>

 

 	<properties>

-		<maven.test.failure.ignore>true</maven.test.failure.ignore>

 		<project.swmVersion>9</project.swmVersion>

 		<project.cadiVersion>1.0.0-SNAPSHOT</project.cadiVersion>

 	     <project.innoVersion>1.0.0-SNAPSHOT</project.innoVersion>

@@ -60,7 +59,7 @@
 		<sonar.surefire.reportsPath>${project.build.directory}/surefire-reports</sonar.surefire.reportsPath>

 		<sonar.jacoco.reportPath>${project.build.directory}/coverage-reports/jacoco.exec</sonar.jacoco.reportPath>

 		<sonar.jacoco.itReportPath>${project.build.directory}/coverage-reports/jacoco-it.exec</sonar.jacoco.itReportPath>

-		<sonar.jacoco.reportMissing.force.zero>true</sonar.jacoco.reportMissing.force.zero>

+		<sonar.jacoco.reportMissing.force.zero>false</sonar.jacoco.reportMissing.force.zero>

 		<sonar.projectVersion>${project.version}</sonar.projectVersion>

         <nexusproxy>https://nexus.onap.org</nexusproxy>

 		<snapshotNexusPath>/content/repositories/snapshots/</snapshotNexusPath>

@@ -148,9 +147,6 @@
 				<version>0.7.7.201606060606</version>

 				<configuration>

 					<dumpOnExit>true</dumpOnExit>

-					<includes>

-						<include>org.onap.aaf.*</include>

-					</includes>

 				</configuration>

 				<executions>

 					<execution>

diff --git a/authz-gui/pom.xml b/authz-gui/pom.xml
index 0aee3c60..6e15c179 100644
--- a/authz-gui/pom.xml
+++ b/authz-gui/pom.xml
@@ -34,7 +34,6 @@
 
 
 	<properties>
-		<maven.test.failure.ignore>true</maven.test.failure.ignore>
 		<project.swmVersion>28</project.swmVersion>
 		<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
 		<skipTests>false</skipTests>
@@ -47,7 +46,7 @@
 		<sonar.surefire.reportsPath>${project.build.directory}/surefire-reports</sonar.surefire.reportsPath>
 		<sonar.jacoco.reportPath>${project.build.directory}/coverage-reports/jacoco.exec</sonar.jacoco.reportPath>
 		<sonar.jacoco.itReportPath>${project.build.directory}/coverage-reports/jacoco-it.exec</sonar.jacoco.itReportPath>
-		<sonar.jacoco.reportMissing.force.zero>true</sonar.jacoco.reportMissing.force.zero>
+		<sonar.jacoco.reportMissing.force.zero>false</sonar.jacoco.reportMissing.force.zero>
 		<sonar.projectVersion>${project.version}</sonar.projectVersion>
 		<nexusproxy>https://nexus.onap.org</nexusproxy>
 		<snapshotNexusPath>/content/repositories/snapshots/</snapshotNexusPath>
@@ -214,9 +213,6 @@
 				<version>0.7.7.201606060606</version>
 				<configuration>
 					<dumpOnExit>true</dumpOnExit>
-					<includes>
-						<include>org.onap.aaf.*</include>
-					</includes>
 				</configuration>
 				<executions>
 					<execution>
diff --git a/authz-gw/pom.xml b/authz-gw/pom.xml
index 64f9ab5e..7d74359c 100644
--- a/authz-gw/pom.xml
+++ b/authz-gw/pom.xml
@@ -51,7 +51,6 @@
 	</developers>

 

 	<properties>

-		<maven.test.failure.ignore>true</maven.test.failure.ignore>

 		<project.swmVersion>30</project.swmVersion>

 			<project.innoVersion>1.0.0-SNAPSHOT</project.innoVersion>

 		<project.cadiVersion>1.0.0-SNAPSHOT</project.cadiVersion>

@@ -60,7 +59,7 @@
 		<sonar.surefire.reportsPath>${project.build.directory}/surefire-reports</sonar.surefire.reportsPath>

 		<sonar.jacoco.reportPath>${project.build.directory}/coverage-reports/jacoco.exec</sonar.jacoco.reportPath>

 		<sonar.jacoco.itReportPath>${project.build.directory}/coverage-reports/jacoco-it.exec</sonar.jacoco.itReportPath>

-		<sonar.jacoco.reportMissing.force.zero>true</sonar.jacoco.reportMissing.force.zero>

+		<sonar.jacoco.reportMissing.force.zero>false</sonar.jacoco.reportMissing.force.zero>

 		<sonar.projectVersion>${project.version}</sonar.projectVersion>

         <nexusproxy>https://nexus.onap.org</nexusproxy>

 		<snapshotNexusPath>/content/repositories/snapshots/</snapshotNexusPath>

@@ -158,9 +157,6 @@
 				<version>0.7.7.201606060606</version>

 				<configuration>

 					<dumpOnExit>true</dumpOnExit>

-					<includes>

-						<include>org.onap.aaf.*</include>

-					</includes>

 				</configuration>

 				<executions>

 					<execution>

diff --git a/authz-service/pom.xml b/authz-service/pom.xml
index 507f2b4f..c389525f 100644
--- a/authz-service/pom.xml
+++ b/authz-service/pom.xml
@@ -52,8 +52,7 @@
 

 	<properties>

 	<maven.build.timestamp.format>yyyy.MM.dd'T'hh.mm.ss'Z'</maven.build.timestamp.format>

-		<maven.test.failure.ignore>true</maven.test.failure.ignore>

-		<project.swmVersion>1</project.swmVersion>

+				<project.swmVersion>1</project.swmVersion>

 			<project.innoVersion>1.0.0-SNAPSHOT</project.innoVersion>

 		<project.cadiVersion>1.0.0-SNAPSHOT</project.cadiVersion>

         <dockerLocation>${basedir}/target/</dockerLocation>

@@ -63,7 +62,7 @@
 		<sonar.surefire.reportsPath>${project.build.directory}/surefire-reports</sonar.surefire.reportsPath>

 		<sonar.jacoco.reportPath>${project.build.directory}/coverage-reports/jacoco.exec</sonar.jacoco.reportPath>

 		<sonar.jacoco.itReportPath>${project.build.directory}/coverage-reports/jacoco-it.exec</sonar.jacoco.itReportPath>

-		<sonar.jacoco.reportMissing.force.zero>true</sonar.jacoco.reportMissing.force.zero>

+		<sonar.jacoco.reportMissing.force.zero>false</sonar.jacoco.reportMissing.force.zero>

 		<sonar.projectVersion>${project.version}</sonar.projectVersion>

         <nexusproxy>https://nexus.onap.org</nexusproxy>

 		<docker.push.registry>localhost:5000</docker.push.registry>

@@ -496,9 +495,6 @@
 				<version>0.7.7.201606060606</version>

 				<configuration>

 					<dumpOnExit>true</dumpOnExit>

-					<includes>

-						<include>org.onap.aaf.*</include>

-					</includes>

 				</configuration>

 				<executions>

 					<execution>

diff --git a/authz-test/pom.xml b/authz-test/pom.xml
index 17cb314f..e73cb341 100644
--- a/authz-test/pom.xml
+++ b/authz-test/pom.xml
@@ -53,7 +53,6 @@
 

 

 	<properties>

-		<maven.test.failure.ignore>false</maven.test.failure.ignore>

 		<project.swmVersion>0</project.swmVersion>

 					<project.innoVersion>1.0.0-SNAPSHOT</project.innoVersion>

 		<project.cadiVersion>1.0.0-SNAPSHOT</project.cadiVersion>

@@ -62,7 +61,7 @@
 		<sonar.surefire.reportsPath>${project.build.directory}/surefire-reports</sonar.surefire.reportsPath>

 		<sonar.jacoco.reportPath>${project.build.directory}/coverage-reports/jacoco.exec</sonar.jacoco.reportPath>

 		<sonar.jacoco.itReportPath>${project.build.directory}/coverage-reports/jacoco-it.exec</sonar.jacoco.itReportPath>

-		<sonar.jacoco.reportMissing.force.zero>true</sonar.jacoco.reportMissing.force.zero>

+		<sonar.jacoco.reportMissing.force.zero>false</sonar.jacoco.reportMissing.force.zero>

 		<sonar.projectVersion>${project.version}</sonar.projectVersion>

         <nexusproxy>https://nexus.onap.org</nexusproxy>

 		<snapshotNexusPath>/content/repositories/snapshots/</snapshotNexusPath>

@@ -134,7 +133,7 @@
 	          <groupId>org.apache.maven.plugins</groupId>

 	          <artifactId>maven-surefire-plugin</artifactId>

 	          <configuration>

-				<excludes>

+			<excludes>

 	              <exclude>**/AAFJUnitTest.java</exclude>

 				</excludes>

 	          </configuration>

@@ -188,9 +187,6 @@
 				<version>0.7.7.201606060606</version>

 				<configuration>

 					<dumpOnExit>true</dumpOnExit>

-					<includes>

-						<include>org.onap.aaf.*</include>

-					</includes>

 				</configuration>

 				<executions>

 					<execution>

diff --git a/pom.xml b/pom.xml
index 33d432e7..6aa23537 100644
--- a/pom.xml
+++ b/pom.xml
@@ -58,7 +58,6 @@
 	</description>
 	<properties>
 		<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
-		<skipTests>false</skipTests>
 		<project.interfaceVersion>1.0.0-SNAPSHOT</project.interfaceVersion>
 		<project.innoVersion>1.0.0-SNAPSHOT</project.innoVersion>
 		<project.cadiVersion>1.0.0-SNAPSHOT</project.cadiVersion>
@@ -68,7 +67,7 @@
 		<sonar.surefire.reportsPath>${project.build.directory}/surefire-reports</sonar.surefire.reportsPath>
 		<sonar.jacoco.reportPath>${project.build.directory}/coverage-reports/jacoco.exec</sonar.jacoco.reportPath>
 		<sonar.jacoco.itReportPath>${project.build.directory}/coverage-reports/jacoco-it.exec</sonar.jacoco.itReportPath>
-		<sonar.jacoco.reportMissing.force.zero>true</sonar.jacoco.reportMissing.force.zero>
+		<sonar.jacoco.reportMissing.force.zero>false</sonar.jacoco.reportMissing.force.zero>
 		<sonar.projectVersion>${project.version}</sonar.projectVersion>
 		<nexusproxy>https://nexus.onap.org</nexusproxy>
 		<snapshotNexusPath>/content/repositories/snapshots/</snapshotNexusPath>
@@ -95,7 +94,6 @@
 				  <artifactId>maven-surefire-plugin</artifactId>
 				  <version>2.17</version>
 				  <configuration>
-					<skipTests>${skipTests}</skipTests>
 					<includes>
 					  <include>**/JU*.java</include>
 					</includes>
@@ -265,9 +263,6 @@
 				<version>0.7.7.201606060606</version>
 				<configuration>
 					<dumpOnExit>true</dumpOnExit>
-					<includes>
-						<include>org.onap.aaf.*</include>
-					</includes>
 				</configuration>
 				<executions>
 					<execution>