summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorwaqas.ikram <waqas.ikram@est.tech>2023-02-17 12:25:41 +0000
committerwaqas.ikram <waqas.ikram@est.tech>2023-02-17 12:30:30 +0000
commite977d2299c6efc1a667b7538fce6d1725315c177 (patch)
tree2d7f2da1458b90daa84bd5bca5d375e62b8a252f
parenta10c3965ce777ed7c6b90adf39b667dddaba726d (diff)
Adding -ve test cases for Create AS
Change-Id: I5eb0f8329dc5b0a2b5a8fddc3049b46f2de85632 Issue-ID: SO-4068 Signed-off-by: waqas.ikram <waqas.ikram@est.tech>
-rw-r--r--so-cnfm/so-cnfm-lcm/so-cnfm-lcm-bpmn-flows/src/test/java/org/onap/so/cnfm/lcm/bpmn/flows/tasks/CreateAsTaskTest.java181
1 files changed, 177 insertions, 4 deletions
diff --git a/so-cnfm/so-cnfm-lcm/so-cnfm-lcm-bpmn-flows/src/test/java/org/onap/so/cnfm/lcm/bpmn/flows/tasks/CreateAsTaskTest.java b/so-cnfm/so-cnfm-lcm/so-cnfm-lcm-bpmn-flows/src/test/java/org/onap/so/cnfm/lcm/bpmn/flows/tasks/CreateAsTaskTest.java
index bd0afe9..c5683e8 100644
--- a/so-cnfm/so-cnfm-lcm/so-cnfm-lcm-bpmn-flows/src/test/java/org/onap/so/cnfm/lcm/bpmn/flows/tasks/CreateAsTaskTest.java
+++ b/so-cnfm/so-cnfm-lcm/so-cnfm-lcm-bpmn-flows/src/test/java/org/onap/so/cnfm/lcm/bpmn/flows/tasks/CreateAsTaskTest.java
@@ -25,14 +25,18 @@ import static com.github.tomakehurst.wiremock.client.WireMock.notFound;
import static com.github.tomakehurst.wiremock.client.WireMock.ok;
import static com.github.tomakehurst.wiremock.client.WireMock.okJson;
import static com.github.tomakehurst.wiremock.client.WireMock.put;
+import static com.github.tomakehurst.wiremock.client.WireMock.serverError;
import static com.github.tomakehurst.wiremock.client.WireMock.urlMatching;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertTrue;
import static org.onap.aaiclient.client.aai.AAIVersion.V19;
+import static org.onap.so.cnfm.lcm.bpmn.flows.CamundaVariableNameConstants.CREATE_AS_RESPONSE_PARAM_NAME;
import static org.onap.so.cnfm.lcm.model.utils.AdditionalParamsConstants.CLOUD_OWNER_PARAM_KEY;
import static org.onap.so.cnfm.lcm.model.utils.AdditionalParamsConstants.CLOUD_REGION_PARAM_KEY;
+import static org.onap.so.cnfm.lcm.model.utils.AdditionalParamsConstants.RESOURCE_ID_KEY;
import static org.onap.so.cnfm.lcm.model.utils.AdditionalParamsConstants.SERVICE_INSTANCE_ID_PARAM_KEY;
import static org.onap.so.cnfm.lcm.model.utils.AdditionalParamsConstants.SERVICE_INSTANCE_NAME_PARAM_KEY;
import static org.onap.so.cnfm.lcm.model.utils.AdditionalParamsConstants.TENANT_ID_PARAM_KEY;
@@ -42,6 +46,7 @@ import java.io.File;
import java.io.IOException;
import java.nio.file.Files;
import java.nio.file.Path;
+import java.time.LocalDateTime;
import java.util.Map;
import java.util.Optional;
import java.util.UUID;
@@ -53,13 +58,19 @@ import org.junit.Test;
import org.onap.aaiclient.client.aai.entities.Results;
import org.onap.aaiclient.client.graphinventory.entities.Resource;
import org.onap.so.cnfm.lcm.bpmn.flows.BaseTest;
+import org.onap.so.cnfm.lcm.bpmn.flows.exceptions.AsRequestProcessingException;
import org.onap.so.cnfm.lcm.bpmn.flows.service.JobExecutorService;
+import org.onap.so.cnfm.lcm.bpmn.flows.service.WorkflowQueryService;
+import org.onap.so.cnfm.lcm.database.beans.AsInst;
import org.onap.so.cnfm.lcm.database.beans.Job;
import org.onap.so.cnfm.lcm.database.beans.JobStatusEnum;
+import org.onap.so.cnfm.lcm.database.beans.State;
import org.onap.so.cnfm.lcm.model.AsInstance;
import org.onap.so.cnfm.lcm.model.AsInstance.InstantiationStateEnum;
import org.onap.so.cnfm.lcm.model.CreateAsRequest;
+import org.onap.so.cnfm.lcm.model.ErrorDetails;
import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.http.HttpStatus;
import com.fasterxml.jackson.core.JsonProcessingException;
import com.fasterxml.jackson.databind.ObjectMapper;
@@ -68,19 +79,22 @@ import com.fasterxml.jackson.databind.ObjectMapper;
*
*/
public class CreateAsTaskTest extends BaseTest {
+ private static final String DUMMY_VALUE = "DUMMY_VALUE";
private static final String SRC_TEST_DIR = "src/test/resources";
private static final String TENAT_ID = UUID.randomUUID().toString();
private static final String CLOUD_OWNER = "CloudOwner";
private static final String CLOUD_REGION = "CloudRegion";
private static final String ASD_ID = UUID.randomUUID().toString();
private static final String AS_NAME = "CreateAsService-" + ASD_ID;
- private static final String SDC_GET_RESOURCE_URL = "/sdc/v1/catalog/resources/" + ASD_ID + "/toscaModel";
private static final String RESOURCE_ASD_PACKAGE_CSAR_PATH =
SRC_TEST_DIR + "/resource-Generatedasdpackage-csar.csar";
@Autowired
private JobExecutorService objUnderTest;
+ @Autowired
+ private WorkflowQueryService workflowQueryService;
+
@Before
public void before() {
wireMockServer.resetAll();
@@ -94,9 +108,7 @@ public class CreateAsTaskTest extends BaseTest {
@Test
public void testCreateAsWorkflow_SuccessfullCase() throws InterruptedException, IOException {
- wireMockServer.stubFor(get(SDC_GET_RESOURCE_URL)
- .willReturn(aResponse().withBody(getFileContent(getAbsolutePath(RESOURCE_ASD_PACKAGE_CSAR_PATH)))
- .withHeader(ACCEPT, APPLICATION_OCTET_STREAM_VALUE)));
+ mockSdcResourceEndpoint(ASD_ID);
final CreateAsRequest createAsRequest = getCreateAsRequest();
@@ -136,15 +148,176 @@ public class CreateAsTaskTest extends BaseTest {
}
+ @Test
+ public void testCreateAsWorkflow_FailsToGetAsPackage() throws InterruptedException {
+ final String asdId = UUID.randomUUID().toString();
+ final String asName = AS_NAME + "-" + System.currentTimeMillis();
+
+ final CreateAsRequest createAsRequest = getCreateAsRequest(asdId, asName);
+
+ wireMockServer.stubFor(
+ get(getSdcResourceUrl(asdId)).willReturn(aResponse().withStatus(HttpStatus.NOT_FOUND.value())));
+ try {
+ objUnderTest.runCreateAsJob(createAsRequest);
+ } catch (final Exception exception) {
+ assertEquals(AsRequestProcessingException.class, exception.getClass());
+ }
+
+ final Optional<Job> optional = getJobByResourceId(createAsRequest.getAsdId());
+ assertTrue(optional.isPresent());
+ final Job job = optional.get();
+
+ assertTrue(waitForProcessInstanceToFinish(job.getProcessInstanceId()));
+
+ final HistoricProcessInstance historicProcessInstance = getHistoricProcessInstance(job.getProcessInstanceId());
+ assertNotNull(historicProcessInstance);
+
+ assertEquals(HistoricProcessInstance.STATE_COMPLETED, historicProcessInstance.getState());
+
+ final HistoricVariableInstance nsResponseVariable =
+ getVariable(job.getProcessInstanceId(), CREATE_AS_RESPONSE_PARAM_NAME);
+ assertNull(nsResponseVariable);
+
+ final Optional<ErrorDetails> errorDetailsOptional =
+ workflowQueryService.getErrorDetails(job.getProcessInstanceId());
+ assertTrue(errorDetailsOptional.isPresent());
+
+ final ErrorDetails errorDetails = errorDetailsOptional.get();
+ assertNotNull(errorDetails);
+ assertNotNull(errorDetails.getDetail());
+
+ final HistoricVariableInstance doesAsPackageExistsVar =
+ getVariable(job.getProcessInstanceId(), "doesAsPackageExists");
+ assertNotNull(doesAsPackageExistsVar);
+ assertFalse((boolean) doesAsPackageExistsVar.getValue());
+
+ }
+
+ @Test
+ public void testCreateAsWorkflow_AsInstanceExistsInDb() throws IOException, InterruptedException {
+ final String asdId = UUID.randomUUID().toString();
+ final String asName = AS_NAME + "-" + System.currentTimeMillis();
+
+ mockSdcResourceEndpoint(asdId);
+
+ final CreateAsRequest createAsRequest = getCreateAsRequest(asdId, asName);
+
+ databaseServiceProvider.saveAsInst(new AsInst().asdId(asdId).name(createAsRequest.getAsInstanceName())
+ .asPackageId(UUID.randomUUID().toString()).asdInvariantId(asdId).asProvider(DUMMY_VALUE)
+ .asApplicationName(DUMMY_VALUE).asApplicationVersion(DUMMY_VALUE).serviceInstanceId(DUMMY_VALUE)
+ .serviceInstanceName(DUMMY_VALUE).cloudOwner(DUMMY_VALUE).cloudRegion(DUMMY_VALUE).tenantId(DUMMY_VALUE)
+ .status(State.INSTANTIATED).statusUpdatedTime(LocalDateTime.now()));
+
+ try {
+ objUnderTest.runCreateAsJob(createAsRequest);
+ } catch (final Exception exception) {
+ assertEquals(AsRequestProcessingException.class, exception.getClass());
+ }
+
+ final Optional<Job> optional = getJobByResourceId(createAsRequest.getAsdId());
+ assertTrue(optional.isPresent());
+ final Job job = optional.get();
+ assertEquals(JobStatusEnum.ERROR, job.getStatus());
+
+ assertTrue(waitForProcessInstanceToFinish(job.getProcessInstanceId()));
+
+ final HistoricProcessInstance historicProcessInstance = getHistoricProcessInstance(job.getProcessInstanceId());
+ assertNotNull(historicProcessInstance);
+ assertEquals(HistoricProcessInstance.STATE_COMPLETED, historicProcessInstance.getState());
+
+ assertTrue(databaseServiceProvider.isAsInstExists(createAsRequest.getAsInstanceName()));
+
+ final Optional<ErrorDetails> errorDetailsOptional =
+ workflowQueryService.getErrorDetails(job.getProcessInstanceId());
+ assertTrue(errorDetailsOptional.isPresent());
+
+ final ErrorDetails errorDetails = errorDetailsOptional.get();
+ assertNotNull(errorDetails);
+ assertNotNull(errorDetails.getDetail());
+
+ final HistoricVariableInstance doesAsInstanceExistsVar =
+ getVariable(job.getProcessInstanceId(), "doesAsInstanceExists");
+ assertNotNull(doesAsInstanceExistsVar);
+ assertTrue((boolean) doesAsInstanceExistsVar.getValue());
+
+ }
+
+ @Test
+ public void testCreateAsWorkflow_FailToCreateResouceInAai() throws InterruptedException, IOException {
+ final String asdId = UUID.randomUUID().toString();
+ final String asName = AS_NAME + "-" + System.currentTimeMillis();
+ final String resourceId = UUID.randomUUID().toString();
+
+ mockSdcResourceEndpoint(asdId);
+
+ final CreateAsRequest createAsRequest = getCreateAsRequest(asdId, asName, resourceId);
+
+
+ final String modelEndpoint = "/aai/" + V19 + "/network/generic-vnfs/generic-vnf/" + resourceId;
+ wireMockServer.stubFor(
+ get(urlMatching(modelEndpoint + "\\?resultIndex=0&resultSize=1&format=count")).willReturn(notFound()));
+ wireMockServer.stubFor(put(urlMatching(modelEndpoint)).willReturn(serverError()));
+
+ try {
+ objUnderTest.runCreateAsJob(createAsRequest);
+ } catch (final Exception exception) {
+ assertEquals(AsRequestProcessingException.class, exception.getClass());
+ }
+
+ final Optional<Job> optional = getJobByResourceId(createAsRequest.getAsdId());
+ assertTrue(optional.isPresent());
+ final Job job = optional.get();
+
+ assertTrue(waitForProcessInstanceToFinish(job.getProcessInstanceId()));
+
+ final HistoricProcessInstance historicProcessInstance = getHistoricProcessInstance(job.getProcessInstanceId());
+ assertNotNull(historicProcessInstance);
+
+ assertEquals(HistoricProcessInstance.STATE_COMPLETED, historicProcessInstance.getState());
+ assertTrue(databaseServiceProvider.isAsInstExists(createAsRequest.getAsInstanceName()));
+
+ final Optional<ErrorDetails> errorDetailsOptional =
+ workflowQueryService.getErrorDetails(job.getProcessInstanceId());
+ assertTrue(errorDetailsOptional.isPresent());
+
+ final ErrorDetails errorDetails = errorDetailsOptional.get();
+ assertNotNull(errorDetails);
+ assertNotNull(errorDetails.getDetail());
+
+ }
+
+ private void mockSdcResourceEndpoint(final String asdId) throws IOException {
+ wireMockServer.stubFor(get(getSdcResourceUrl(asdId))
+ .willReturn(aResponse().withBody(getFileContent(getAbsolutePath(RESOURCE_ASD_PACKAGE_CSAR_PATH)))
+ .withHeader(ACCEPT, APPLICATION_OCTET_STREAM_VALUE)));
+ }
+
private CreateAsRequest getCreateAsRequest() {
return getCreateAsRequest(ASD_ID, AS_NAME);
}
+ private String getSdcResourceUrl(final String asdId) {
+ return "/sdc/v1/catalog/resources/" + asdId + "/toscaModel";
+ }
+
private CreateAsRequest getCreateAsRequest(final String asdId, final String asName) {
final Map<String, Object> additionalParams = Map.of(SERVICE_INSTANCE_ID_PARAM_KEY, SERVICE_INSTANCE_ID,
SERVICE_INSTANCE_NAME_PARAM_KEY, SERVICE_INSTANCE_NAME, CLOUD_OWNER_PARAM_KEY, CLOUD_OWNER,
CLOUD_REGION_PARAM_KEY, CLOUD_REGION, TENANT_ID_PARAM_KEY, TENAT_ID);
+ return getCreateAsRequest(asdId, asName, additionalParams);
+ }
+
+ private CreateAsRequest getCreateAsRequest(final String asdId, final String asName, final String resourceId) {
+ final Map<String, Object> additionalParams = Map.of(SERVICE_INSTANCE_ID_PARAM_KEY, SERVICE_INSTANCE_ID,
+ SERVICE_INSTANCE_NAME_PARAM_KEY, SERVICE_INSTANCE_NAME, CLOUD_OWNER_PARAM_KEY, CLOUD_OWNER,
+ CLOUD_REGION_PARAM_KEY, CLOUD_REGION, TENANT_ID_PARAM_KEY, TENAT_ID, RESOURCE_ID_KEY, resourceId);
+
+ return getCreateAsRequest(asdId, asName, additionalParams);
+ }
+
+ private CreateAsRequest getCreateAsRequest(final String asdId, final String asName,
+ final Map<String, Object> additionalParams) {
return new CreateAsRequest().asdId(asdId).asInstanceName(asName).additionalParams(additionalParams);
}