aboutsummaryrefslogtreecommitdiffstats
path: root/openecomp-be/backend/openecomp-sdc-vendor-software-product-manager/src/test/java/org/openecomp/sdc/vendorsoftwareproduct/impl/ComponentManagerImplTest.java
blob: 34af0e67b2a70880e64ce7172a8d2ce3ca47ef4c (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
package org.openecomp.sdc.vendorsoftwareproduct.impl;

import org.mockito.InjectMocks;
import org.mockito.Mock;
import org.mockito.Mockito;
import org.mockito.MockitoAnnotations;
import org.mockito.Spy;
import org.openecomp.sdc.common.errors.CoreException;
import org.openecomp.sdc.vendorsoftwareproduct.NicManager;
import org.openecomp.sdc.vendorsoftwareproduct.dao.ComponentDao;
import org.openecomp.sdc.vendorsoftwareproduct.dao.type.ComponentEntity;
import org.openecomp.sdc.vendorsoftwareproduct.dao.type.NicEntity;
import org.openecomp.sdc.vendorsoftwareproduct.errors.VendorSoftwareProductErrorCodes;
import org.openecomp.sdc.vendorsoftwareproduct.services.composition.CompositionEntityDataManager;
import org.openecomp.sdc.vendorsoftwareproduct.types.CompositionEntityResponse;
import org.openecomp.sdc.vendorsoftwareproduct.types.QuestionnaireResponse;
import org.openecomp.sdc.vendorsoftwareproduct.types.composition.ComponentData;
import org.openecomp.sdc.vendorsoftwareproduct.types.composition.CompositionEntityType;
import org.openecomp.sdc.vendorsoftwareproduct.types.composition.CompositionEntityValidationData;
import org.openecomp.sdc.vendorsoftwareproduct.types.composition.Nic;
import org.openecomp.sdc.versioning.dao.types.Version;
import org.openecomp.sdc.versioning.errors.VersioningErrorCodes;
import org.testng.Assert;
import org.testng.annotations.BeforeMethod;
import org.testng.annotations.Test;

import java.util.Arrays;
import java.util.Collection;

import static org.mockito.Matchers.anyObject;
import static org.mockito.Mockito.doReturn;
import static org.mockito.Mockito.never;
import static org.mockito.Mockito.verify;

public class ComponentManagerImplTest {
  private static final String COMP_NOT_EXIST_MSG =
      "Vendor Software Product Component with Id 1 does not exist for Vendor Software Product with id VSP_ID and version 0.1";
  private static final String USER = "componentsTestUser";
  private static final String VSP_ID = "VSP_ID";
  private static final Version VERSION = new Version(0, 1);
  private static final String COMP1_ID = "1";
  private static final String COMP2_ID = "2";

  @Mock
  private ComponentDao componentDaoMock;
  @Mock
  private CompositionEntityDataManager compositionEntityDataManagerMock;
  @Mock
  private NicManager nicManagerMock;
  @InjectMocks
  @Spy
  private ComponentManagerImpl componentManager;

  @BeforeMethod
  public void setUp() throws Exception {
    MockitoAnnotations.initMocks(this);
  }

  @Test
  public void testListWhenNone() {
    Collection<ComponentEntity> components =
        componentManager.listComponents(VSP_ID, VERSION, USER);
    Assert.assertEquals(components.size(), 0);
  }

  @Test(expectedExceptions = CoreException.class,
      expectedExceptionsMessageRegExp = "Vendor Software Product Component with Id dummyComponentId " +
          "does not exist for Vendor Software Product with id dummyVsp and version 1.0")
  public void validateExceptionWhenTryingToRetriveNotExistingComponentEntity() {
    Version version = Mockito.mock(Version.class);
    doReturn("1.0").when(version).toString();
    doReturn(null).when(componentDaoMock).get(anyObject());
    componentManager.validateComponentExistence("dummyVsp", version, "dummyComponentId",
        "dummyUser");
  }

  @Test
  public void testList() {
    doReturn(Arrays.asList(
        createComponent(VSP_ID, VERSION, COMP1_ID),
        createComponent(VSP_ID, VERSION, COMP2_ID)))
        .when(componentDaoMock).list(anyObject());

    Collection<ComponentEntity> actual =
        componentManager.listComponents(VSP_ID, VERSION, USER);
    Assert.assertEquals(actual.size(), 2);
  }

  @Test
  public void testDeleteListOnUploadVsp_negative() {
    testDeleteList_negative(VSP_ID, VERSION, USER,
        VendorSoftwareProductErrorCodes.VSP_COMPOSITION_EDIT_NOT_ALLOWED);
  }

/*    @Test
    public void testCreate() {
        COMP1_ID = testCreate(VSP_ID);
    }

    private String testCreate(String VSP_ID) {
        ComponentEntity expected = new ComponentEntity(VSP_ID, null, null);
        ComponentData compData = new ComponentData();
        compData.setName("comp1 name");
        compData.setDescription("comp1 desc");
        expected.setComponentCompositionData(compData);

        ComponentEntity created = componentManager.createComponent(expected, USER);
        Assert.assertNotNull(created);
        expected.setId(created.getId());
        expected.setVersion(VERSION);

        ComponentEntity actual = componentDaoMock.getComponent(VSP_ID, VERSION, created.getId());

        Assert.assertEquals(actual, expected);
        return created.getId();
    }*/

/*    @Test
    public void testCreateWithExistingName_negative() {
        ComponentEntity component = new ComponentEntity(VSP_ID, null, null);
        ComponentData compData = new ComponentData();
        compData.setName("comp1 name");
        compData.setDescription("comp1 desc");
        component.setComponentCompositionData(compData);
        testCreate_negative(component, USER, UniqueValueUtil.UNIQUE_VALUE_VIOLATION);
    }*/

/*    @Test
    public void testCreateWithExistingNameUnderOtherVsp() {
        testCreate(vsp2Id);
    }*/

  @Test
  public void testCreateOnUploadVsp_negative() {
    testCreate_negative(new ComponentEntity(VSP_ID, VERSION, null), USER,
        VendorSoftwareProductErrorCodes.VSP_COMPOSITION_EDIT_NOT_ALLOWED);
  }

  @Test
  public void testUpdateNonExistingComponentId_negative() {
    String componentId = "non existing component id";
    doReturn(null).when(componentDaoMock).get(anyObject());

    testUpdate_negative(VSP_ID, VERSION, componentId, USER,
        VersioningErrorCodes.VERSIONABLE_SUB_ENTITY_NOT_FOUND);
  }

  @Test
  public void testUpdateOnUploadVsp() {
    doReturn(createComponent(VSP_ID, VERSION, COMP1_ID)).when(componentDaoMock)
        .get(anyObject());

    doReturn(new CompositionEntityValidationData(CompositionEntityType.component, COMP1_ID))
        .when(compositionEntityDataManagerMock)
        .validateEntity(anyObject(), anyObject(), anyObject());

    ComponentEntity component = new ComponentEntity(VSP_ID, VERSION, COMP1_ID);
    ComponentData compData = new ComponentData();
    compData.setName(COMP1_ID + " name");                // no change
    compData.setDisplayName(COMP1_ID + " display name"); // no change
    compData.setVfcCode(COMP1_ID + " display name"); // no change
    compData.setDescription(COMP1_ID + " desc updated"); // allowed change
    component.setComponentCompositionData(compData);


    CompositionEntityValidationData validationData =
        componentManager.updateComponent(component, USER);
    Assert.assertTrue(validationData == null || validationData.getErrors() == null);
    verify(componentDaoMock).update(component);
  }

  @Test
  public void testIllegalUpdateOnUploadVsp() {
    doReturn(createComponent(VSP_ID, VERSION, COMP1_ID))
        .when(componentDaoMock).get(anyObject());

    CompositionEntityValidationData toBeReturned =
        new CompositionEntityValidationData(CompositionEntityType.component, COMP1_ID);
    toBeReturned.setErrors(Arrays.asList("error1", "error2"));
    doReturn(toBeReturned)
        .when(compositionEntityDataManagerMock)
        .validateEntity(anyObject(), anyObject(), anyObject());

    ComponentEntity component = new ComponentEntity(VSP_ID, VERSION, COMP1_ID);
    ComponentData compData = new ComponentData();
    compData.setName("comp1 name updated");// not allowed: changed name + omitted display name
    component.setComponentCompositionData(compData);

    CompositionEntityValidationData validationData =
        componentManager.updateComponent(component, USER);
    Assert.assertNotNull(validationData);
    Assert.assertEquals(validationData.getErrors().size(), 2);

    verify(componentDaoMock, never()).update(component);
  }

  @Test
  public void testGetNonExistingComponentId_negative() {
    String componentId = "non existing component id";
    doReturn(null).when(componentDaoMock).get(anyObject());

    testGet_negative(VSP_ID, VERSION, componentId, USER,
        VersioningErrorCodes.VERSIONABLE_SUB_ENTITY_NOT_FOUND);
  }

  @Test
  public void testGet() {
    ComponentEntity expected = createComponent(VSP_ID, VERSION, COMP1_ID);
    doReturn(expected).when(componentDaoMock).get(anyObject());

    doReturn("schema string").when(componentManager).getComponentCompositionSchema(anyObject());

    testGet(VSP_ID, VERSION, COMP1_ID, USER, expected);
  }




/*
    @Test(dependsOnMethods = {"testUpdateOnUploadVsp", "testList"})
    public void testCreateWithERemovedName() {
        testCreate(VSP_ID);
    }

    @Test(dependsOnMethods = "testList")
    public void testDeleteNonExistingComponentId_negative() {
        testDelete_negative(VSP_ID, "non existing component id", USER, VersioningErrorCodes.VERSIONABLE_SUB_ENTITY_NOT_FOUND);
    }*/



/*
    @Test(dependsOnMethods = "testList")
    public void testDelete() {
        componentManager.deleteComponent(VSP_ID, COMP1_ID, USER);
        ComponentEntity actual = componentDaoMock.getComponent(VSP_ID, VERSION, COMP1_ID);
        Assert.assertNull(actual);
    }*/

  @Test
  public void testDeleteOnUploadVsp_negative() {
    testDelete_negative(VSP_ID, VERSION, COMP1_ID, USER,
        VendorSoftwareProductErrorCodes.VSP_COMPOSITION_EDIT_NOT_ALLOWED);
  }

  @Test(expectedExceptions = CoreException.class,
      expectedExceptionsMessageRegExp = COMP_NOT_EXIST_MSG)
  public void testGetNonExistingComponentQuestionnaire() throws Exception {
    componentManager.getQuestionnaire(VSP_ID, VERSION, COMP1_ID, USER);
  }

  @Test
  public void testComponentNullQuestionnaire() throws Exception {
    doReturn(new ComponentEntity(VSP_ID, VERSION, COMP1_ID)).when(componentDaoMock)
        .getQuestionnaireData(VSP_ID, VERSION, COMP1_ID);
    String schema = "schema string";
    doReturn(schema).when(componentManager).getComponentQuestionnaireSchema(anyObject());

    QuestionnaireResponse questionnaire =
        componentManager.getQuestionnaire(VSP_ID, VERSION, COMP1_ID, USER);
    Assert.assertNotNull(questionnaire);
    Assert.assertEquals(questionnaire.getData(), null);
    Assert.assertEquals(questionnaire.getSchema(), schema);
    Assert.assertNull(questionnaire.getErrorMessage());
  }


  @Test
  public void testGetQuestionnaire() throws Exception {
    ComponentEntity component = new ComponentEntity(VSP_ID, VERSION, COMP1_ID);
    component.setQuestionnaireData("{}");
    doReturn(component).when(componentDaoMock).getQuestionnaireData(VSP_ID, VERSION, COMP1_ID);

    NicEntity nicEntity1 = new NicEntity();
    Nic nic1 = new Nic();
    nic1.setName("nic1");
    nicEntity1.setNicCompositionData(nic1);

    NicEntity nicEntity2 = new NicEntity();
    Nic nic2 = new Nic();
    nic2.setName("nic2");
    nicEntity2.setNicCompositionData(nic2);

    doReturn(Arrays.asList(nicEntity1, nicEntity2))
        .when(nicManagerMock).listNics(VSP_ID, VERSION, COMP1_ID, USER);

    String schema = "schema string";
    doReturn(schema).when(componentManager).getComponentQuestionnaireSchema(anyObject());

    QuestionnaireResponse questionnaire =
        componentManager.getQuestionnaire(VSP_ID, VERSION, COMP1_ID, USER);
    Assert.assertNotNull(questionnaire);
    Assert.assertEquals(questionnaire.getData(), component.getQuestionnaireData());
    Assert.assertEquals(questionnaire.getSchema(), schema);
    Assert.assertNull(questionnaire.getErrorMessage());
  }

  @Test(expectedExceptions = CoreException.class,
      expectedExceptionsMessageRegExp = COMP_NOT_EXIST_MSG)
  public void testUpdateNonExistingComponentQuestionnaire() throws Exception {
    doReturn(null).when(componentDaoMock).get(anyObject());
    componentManager.updateQuestionnaire(VSP_ID, VERSION, COMP1_ID, "questionnaire data", USER);
  }

  @Test
  public void testUpdateQuestionnaire() throws Exception {
    ComponentEntity component = createComponent(VSP_ID, VERSION, COMP1_ID);
    doReturn(component).when(componentDaoMock).get(anyObject());

    componentManager.updateQuestionnaire(VSP_ID, VERSION, COMP1_ID, "questionnaire data", USER);

    verify(componentDaoMock)
        .updateQuestionnaireData(VSP_ID, VERSION, COMP1_ID, "questionnaire data");
  }

/*
    @Test(dependsOnMethods = "testDelete")
    public void testDeleteList() {
        ComponentEntity comp3 = new ComponentEntity(VSP_ID, null, null);
        comp3.setName("comp3 name");
        comp3.setDescription("comp3 desc");
        componentManager.createComponent(comp3, USER);

        componentManager.deleteComponents(VSP_ID, USER);

        Collection<ComponentEntity> actual = componentManager.listComponents(VSP_ID, null, USER);
        Assert.assertEquals(actual.size(), 0);
    }*/

  private void testGet(String vspId, Version version, String componentId, String user,
                       ComponentEntity expected) {

    CompositionEntityResponse<ComponentData>
        response = componentManager.getComponent(vspId, version, componentId, user);
    Assert.assertEquals(response.getId(), expected.getId());
    Assert.assertEquals(response.getData(), expected.getComponentCompositionData());
    Assert.assertNotNull(response.getSchema());
  }

  private void testCreate_negative(ComponentEntity component, String user,
                                   String expectedErrorCode) {
    try {
      componentManager.createComponent(component, user);
      Assert.fail();
    } catch (CoreException exception) {
      Assert.assertEquals(exception.code().id(), expectedErrorCode);
    }
  }

  private void testGet_negative(String vspId, Version version, String componentId, String user,
                                String expectedErrorCode) {
    try {
      componentManager.getComponent(vspId, version, componentId, user);
      Assert.fail();
    } catch (CoreException exception) {
      Assert.assertEquals(exception.code().id(), expectedErrorCode);
    }
  }

  private void testUpdate_negative(String vspId, Version version, String componentId, String user,
                                   String expectedErrorCode) {
    try {
      componentManager
          .updateComponent(new ComponentEntity(vspId, version, componentId), user);
      Assert.fail();
    } catch (CoreException exception) {
      Assert.assertEquals(exception.code().id(), expectedErrorCode);
    }
  }

  private void testList_negative(String vspId, Version version, String user,
                                 String expectedErrorCode) {
    try {
      componentManager.listComponents(vspId, version, user);
      Assert.fail();
    } catch (CoreException exception) {
      Assert.assertEquals(exception.code().id(), expectedErrorCode);
    }
  }

  private void testDeleteList_negative(String vspId, Version version, String user,
                                       String expectedErrorCode) {
    try {
      componentManager.deleteComponents(vspId, version, user);
      Assert.fail();
    } catch (CoreException exception) {
      Assert.assertEquals(exception.code().id(), expectedErrorCode);
    }
  }

  private void testDelete_negative(String vspId, Version version, String componentId, String user,
                                   String expectedErrorCode) {
    try {
      componentManager.deleteComponent(vspId, version, componentId, user);
      Assert.fail();
    } catch (CoreException exception) {
      Assert.assertEquals(exception.code().id(), expectedErrorCode);
    }
  }


  public static ComponentEntity createComponent(String vspId, Version version, String compId) {
    ComponentEntity componentEntity = new ComponentEntity(vspId, version, compId);
    ComponentData compData = new ComponentData();
    compData.setName(compId + " name");
    compData.setDisplayName(compId + " display name");
    compData.setVfcCode(compId + " display name");
    compData.setDescription(compId + " desc");
    componentEntity.setComponentCompositionData(compData);
    componentEntity.setQuestionnaireData("{}");
    return componentEntity;
  }
}