1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
|
/*-
* ============LICENSE_START=======================================================
* SDC
* ================================================================================
* Copyright (C) 2019 Fujitsu Limited. All rights reserved.
* ================================================================================
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
* ============LICENSE_END=========================================================
*/
package org.openecomp.sdc.be.components.property;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.Mockito.when;
import fj.data.Either;
import java.util.ArrayList;
import java.util.Collections;
import java.util.List;
import java.util.Objects;
import java.util.Optional;
import org.apache.commons.collections.CollectionUtils;
import org.junit.Assert;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.mockito.InjectMocks;
import org.mockito.Mock;
import org.mockito.junit.MockitoJUnitRunner;
import org.openecomp.sdc.be.components.impl.PropertyBusinessLogic;
import org.openecomp.sdc.be.components.utils.InputsBuilder;
import org.openecomp.sdc.be.components.utils.PropertyDataDefinitionBuilder;
import org.openecomp.sdc.be.components.utils.ServiceBuilder;
import org.openecomp.sdc.be.datatypes.elements.GetInputValueDataDefinition;
import org.openecomp.sdc.be.datatypes.elements.PropertyDataDefinition;
import org.openecomp.sdc.be.model.Component;
import org.openecomp.sdc.be.model.ComponentInstanceProperty;
import org.openecomp.sdc.be.model.InputDefinition;
import org.openecomp.sdc.be.model.PropertyDefinition;
import org.openecomp.sdc.be.model.Service;
import org.openecomp.sdc.be.model.jsonjanusgraph.operations.ToscaOperationFacade;
import org.openecomp.sdc.be.model.operations.api.StorageOperationStatus;
import org.openecomp.sdc.be.model.operations.impl.PropertyOperation;
@RunWith(MockitoJUnitRunner.class)
public class ComponentPropertyDeclaratorTest extends PropertyDeclaratorTestBase {
@InjectMocks
private ComponentPropertyDeclarator testInstance;
@Mock
private PropertyBusinessLogic propertyBusinessLogic;
@Mock
private PropertyOperation propertyOperation;
@Mock
private ToscaOperationFacade toscaOperationFacade;
private static final String PROPERTY_UID = "propertyUid";
private static final String SERVICE_UID = "serviceUid";
private Service service;
@Before
public void init() {
service = new ServiceBuilder().setUniqueId(SERVICE_UID).build();
}
@Test
public void unDeclarePropertiesAsListInputsTest_whenPropertyUsedByOperation() {
InputDefinition input = new InputDefinition();
input.setUniqueId(INPUT_ID);
input.setName(INPUT_ID);
input.setValue("value");
PropertyDefinition propertyDefinition = new PropertyDefinition(input);
when(propertyBusinessLogic.isPropertyUsedByOperation(eq(resource), eq(propertyDefinition))).thenReturn(true);
StorageOperationStatus status = testInstance.unDeclarePropertiesAsListInputs(resource, input);
Assert.assertEquals(status, StorageOperationStatus.DECLARED_INPUT_USED_BY_OPERATION);
}
@Test
public void unDeclarePropertiesAsListInputsTest_whenNotPresentPropertyToUpdateCandidate() {
InputDefinition input = new InputDefinition();
input.setUniqueId(INPUT_ID);
input.setName(INPUT_ID);
input.setValue("value");
PropertyDefinition propertyDefinition = new PropertyDefinition();
resource.setProperties(Collections.singletonList(propertyDefinition));
when(propertyBusinessLogic.isPropertyUsedByOperation(eq(resource), any(PropertyDefinition.class))).thenReturn(false);
StorageOperationStatus status = testInstance.unDeclarePropertiesAsListInputs(resource, input);
Assert.assertEquals(status, StorageOperationStatus.OK);
}
@Test
public void unDeclarePropertiesAsListInputsTest_whenPropertiesEmpty() {
InputDefinition input = new InputDefinition();
input.setUniqueId(INPUT_ID);
input.setName(INPUT_ID);
input.setValue("value");
resource.setProperties(new ArrayList<>());
when(propertyBusinessLogic.isPropertyUsedByOperation(eq(resource), any(PropertyDefinition.class))).thenReturn(false);
StorageOperationStatus status = testInstance.unDeclarePropertiesAsListInputs(resource, input);
Assert.assertEquals(status, StorageOperationStatus.OK);
}
@Test
public void unDeclarePropertiesAsListInputsTest_whenPropertiesToUpdateIsEmpty() {
InputDefinition input = new InputDefinition();
input.setUniqueId(INPUT_ID);
input.setName(INPUT_ID);
input.setValue("value");
PropertyDefinition propertyDefinition = new PropertyDefinition(input);
resource.setProperties(Collections.singletonList(propertyDefinition));
when(propertyBusinessLogic.isPropertyUsedByOperation(eq(resource), eq(propertyDefinition))).thenReturn(false);
StorageOperationStatus status = testInstance.unDeclarePropertiesAsListInputs(resource, input);
Assert.assertEquals(status, StorageOperationStatus.OK);
}
@Test
public void unDeclarePropertiesAsListInputsTest_singleProperty() {
InputDefinition input = new InputDefinition();
input.setUniqueId(INPUT_ID);
input.setName(INPUT_ID);
input.setValue("value");
input.setDefaultValue("default value");
PropertyDefinition propertyDefinition = new PropertyDefinition(input);
List<GetInputValueDataDefinition> getInputValueList = new ArrayList<>();
getInputValueList.add(buildGetInputValue(INPUT_ID));
getInputValueList.add(buildGetInputValue("otherInputId"));
propertyDefinition.setGetInputValues(getInputValueList);
propertyDefinition.setUniqueId("propertyId");
propertyDefinition.setDefaultValue("default value");
propertyDefinition.setValue(generateGetInputValueAsListInput(INPUT_ID, "innerPropName"));
resource.setProperties(Collections.singletonList(propertyDefinition));
when(propertyBusinessLogic.isPropertyUsedByOperation(eq(resource), any())).thenReturn(false);
when(propertyOperation.findDefaultValueFromSecondPosition(eq(Collections.emptyList()), eq(propertyDefinition.getUniqueId()), eq(propertyDefinition.getDefaultValue()))).thenReturn(Either.left(propertyDefinition.getDefaultValue()));
when(toscaOperationFacade.updatePropertyOfComponent(eq(resource), any())).thenReturn(Either.left(propertyDefinition));
StorageOperationStatus status = testInstance.unDeclarePropertiesAsListInputs(resource, input);
Assert.assertEquals(status, StorageOperationStatus.OK);
}
@Test
public void unDeclarePropertiesAsListInputsTest_UnDeclareInputFail() {
InputDefinition input = new InputDefinition();
input.setUniqueId(INPUT_ID);
input.setName(INPUT_ID);
input.setValue("value");
input.setDefaultValue("default value");
PropertyDefinition propertyDefinition = new PropertyDefinition(input);
List<GetInputValueDataDefinition> getInputValueList = new ArrayList<>();
getInputValueList.add(buildGetInputValue(INPUT_ID));
getInputValueList.add(buildGetInputValue("otherInputId"));
propertyDefinition.setGetInputValues(getInputValueList);
propertyDefinition.setUniqueId("propertyId");
propertyDefinition.setDefaultValue("default value");
propertyDefinition.setValue(generateGetInputValueAsListInput(INPUT_ID, "innerPropName"));
resource.setProperties(Collections.singletonList(propertyDefinition));
when(propertyBusinessLogic.isPropertyUsedByOperation(eq(resource), any())).thenReturn(false);
when(propertyOperation.findDefaultValueFromSecondPosition(eq(Collections.emptyList()), eq(propertyDefinition.getUniqueId()), eq(propertyDefinition.getDefaultValue()))).thenReturn(Either.left(propertyDefinition.getDefaultValue()));
when(toscaOperationFacade.updatePropertyOfComponent(eq(resource), any())).thenReturn(Either.right(StorageOperationStatus.NOT_FOUND));
StorageOperationStatus status = testInstance.unDeclarePropertiesAsListInputs(resource, input);
Assert.assertEquals(status, StorageOperationStatus.NOT_FOUND);
}
@Test
public void createDeclaredProperty_success() {
PropertyDataDefinition propertyDataDefinition = getPropertyForDeclaration();
PropertyDataDefinition declaredProperty = testInstance.createDeclaredProperty(propertyDataDefinition);
assertTrue(Objects.nonNull(declaredProperty));
assertEquals(propertyDataDefinition.getUniqueId(), declaredProperty.getUniqueId());
}
@Test
public void updatePropertiesValues_success() {
PropertyDataDefinition propertyForDeclaration = getPropertyForDeclaration();
when(toscaOperationFacade.updatePropertyOfComponent(any(Component.class), any(PropertyDefinition.class)))
.thenReturn(Either.left(new PropertyDefinition(propertyForDeclaration)));
Either<List<PropertyDataDefinition>, StorageOperationStatus> updateEither =
(Either<List<PropertyDataDefinition>, StorageOperationStatus>) testInstance
.updatePropertiesValues(service,
SERVICE_UID, Collections
.singletonList(
propertyForDeclaration));
assertTrue(updateEither.isLeft());
List<PropertyDataDefinition> properties = updateEither.left().value();
assertTrue(CollectionUtils.isNotEmpty(properties));
assertEquals(1, properties.size());
assertEquals(propertyForDeclaration, properties.get(0));
}
@Test
public void resolvePropertiesOwner_success() {
Optional<Component> ownerCandidate = testInstance.resolvePropertiesOwner(service, SERVICE_UID);
assertTrue(ownerCandidate.isPresent());
assertEquals(service, ownerCandidate.get());
}
@Test
public void addPropertiesListToInput_success() {
InputDefinition input = InputsBuilder.create().setPropertyId(PROPERTY_UID).build();
PropertyDataDefinition propertyForDeclaration = getPropertyForDeclaration();
testInstance.addPropertiesListToInput(propertyForDeclaration, input);
List<ComponentInstanceProperty> inputProperties = input.getProperties();
assertTrue(CollectionUtils.isNotEmpty(inputProperties));
assertEquals(1, inputProperties.size());
assertEquals(propertyForDeclaration.getUniqueId(), inputProperties.get(0).getUniqueId());
}
private PropertyDataDefinition getPropertyForDeclaration() {
return new PropertyDataDefinitionBuilder().setUniqueId(PROPERTY_UID).build();
}
private GetInputValueDataDefinition buildGetInputValue(String InputId) {
GetInputValueDataDefinition getInputValue = new GetInputValueDataDefinition();
getInputValue.setInputId(InputId);
getInputValue.setInputName(InputId);
return getInputValue;
}
}
|
