1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
|
/*-
* ============LICENSE_START=======================================================
* SDC
* ================================================================================
* Copyright (C) 2017 AT&T Intellectual Property. All rights reserved.
* ================================================================================
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
* ============LICENSE_END=========================================================
* Modifications copyright (c) 2019 Nokia
* ================================================================================
*/
package org.openecomp.sdc.be.components.impl.policy;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.mockito.ArgumentCaptor;
import org.mockito.Captor;
import org.mockito.Mock;
import org.mockito.junit.MockitoJUnitRunner;
import org.openecomp.sdc.be.components.impl.exceptions.ByActionStatusComponentException;
import org.openecomp.sdc.be.components.utils.PolicyDefinitionBuilder;
import org.openecomp.sdc.be.components.utils.ResourceBuilder;
import org.openecomp.sdc.be.dao.api.ActionStatus;
import org.openecomp.sdc.be.datatypes.elements.PolicyTargetType;
import org.openecomp.sdc.be.model.Component;
import org.openecomp.sdc.be.model.PolicyDefinition;
import org.openecomp.sdc.be.model.Resource;
import org.openecomp.sdc.be.model.jsonjanusgraph.operations.ToscaOperationFacade;
import org.openecomp.sdc.be.model.operations.api.StorageOperationStatus;
import java.util.List;
import java.util.stream.Stream;
import static org.assertj.core.api.Assertions.assertThat;
import static org.mockito.ArgumentMatchers.anyList;
import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.Mockito.verifyZeroInteractions;
import static org.mockito.Mockito.when;
import static org.openecomp.sdc.be.components.impl.utils.TestGenerationUtils.getComponentsUtils;
@RunWith(MockitoJUnitRunner.class)
//note that this class only tests group targets, the tests for instance targets are under PolicyTargetsUpdateOperationTest
public class PolicyTargetsUpdateHandlerTest {
private static final String CONTAINER_ID = "containerId";
private PolicyTargetsUpdateHandler testInstance;
@Mock
private ToscaOperationFacade toscaOperationFacade;
@Captor
private ArgumentCaptor<List<PolicyDefinition>> updatedPoliciesCaptor;
private PolicyDefinition policyWithGroupTarget1, policyWithGroupTarget2, policyWithGroupTarget3;
private Resource container;
@Before
public void setUp() throws Exception {
policyWithGroupTarget1 = createPolicyWithGroupsAsTargets("policy1", "group1", "group2");
policyWithGroupTarget2 = createPolicyWithGroupsAsTargets("policy2", "group1", "group2", "group3");
policyWithGroupTarget3 = createPolicyWithGroupsAsTargets("policy3", "group1", "group3");
container = new ResourceBuilder()
.addPolicy(policyWithGroupTarget1)
.addPolicy(policyWithGroupTarget2)
.addPolicy(policyWithGroupTarget3)
.setUniqueId(CONTAINER_ID)
.build();
testInstance = new PolicyTargetsUpdateHandler(toscaOperationFacade, getComponentsUtils(), new PolicyTargetsUpdater());
}
@Test
public void onDeleteInstance_whenNoPolicies_returnActionOk() {
Component container = new Resource();
testInstance.removePoliciesTargets(container, "groupToDel", PolicyTargetType.GROUPS);
verifyZeroInteractions(toscaOperationFacade);
}
@Test
public void onDeleteInstance_whenNoPoliciesWithGroupsAsTargets_returnOk() {
PolicyDefinition policy = PolicyDefinitionBuilder.create().addComponentInstanceTarget("someInst").build();
Component container = new ResourceBuilder().addPolicy(policy).build();
testInstance.removePoliciesTargets(container, "groupToDel", PolicyTargetType.GROUPS);
verifyZeroInteractions(toscaOperationFacade);
}
@Test
public void onDeleteInstance_whenNoPoliciesWithGivenGroupAsTarget_returnActionOk() {
testInstance.removePoliciesTargets(container, "groupToDel", PolicyTargetType.GROUPS);
verifyZeroInteractions(toscaOperationFacade);
}
@Test
public void onDeleteInstance_removeDeletedTargetFromPolicies() {
when(toscaOperationFacade.updatePoliciesOfComponent(eq(CONTAINER_ID), updatedPoliciesCaptor.capture())).thenReturn(StorageOperationStatus.OK);
testInstance.removePoliciesTargets(container, "group2", PolicyTargetType.GROUPS);
List<PolicyDefinition> updatedPolicies = updatedPoliciesCaptor.getValue();
verifyUpdatedPolicies(updatedPolicies, policyWithGroupTarget1, policyWithGroupTarget2);
verifyUpdatedPolicyTargets(policyWithGroupTarget1, "group1");
verifyUpdatedPolicyTargets(policyWithGroupTarget2, "group1", "group3");
}
@Test
public void onDeleteInstance_whenFailingToUpdatePolicies_throwException() {
when(toscaOperationFacade.updatePoliciesOfComponent(eq(CONTAINER_ID), anyList())).thenReturn(StorageOperationStatus.GENERAL_ERROR);
try {
testInstance.removePoliciesTargets(container, "group2", PolicyTargetType.GROUPS);
} catch (ByActionStatusComponentException e) {
assertThat(e.getActionStatus()).isEqualTo(ActionStatus.GENERAL_ERROR);
}
}
private void verifyUpdatedPolicyTargets(PolicyDefinition updatedPolicy, String ... expectedCmptInstanceTargetIds) {
assertThat(updatedPolicy.resolveGroupTargets())
.containsExactlyInAnyOrder(expectedCmptInstanceTargetIds);
}
private void verifyUpdatedPolicies(List<PolicyDefinition> updatedPolicies, PolicyDefinition ... expectedUpdatedPolicies) {
assertThat(updatedPolicies)
.usingElementComparatorOnFields("targets")
.containsExactlyInAnyOrder(expectedUpdatedPolicies);
}
private PolicyDefinition createPolicyWithGroupsAsTargets(String uniqueId, String ... groupId) {
PolicyDefinitionBuilder policyDefinitionBuilder = PolicyDefinitionBuilder.create();
Stream.of(groupId).forEach(policyDefinitionBuilder::addGroupTarget);
return policyDefinitionBuilder.setUniqueId(uniqueId).build();
}
}
|
