aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorManamohan Satapathy <MS00534989@techmahindra.com>2018-03-14 13:31:38 +0530
committerPamela Dragosh <pdragosh@research.att.com>2018-03-14 14:47:02 +0000
commitd1aa00c101648ecfea24f01b379d3c1cfaff7b4c (patch)
tree70b89860ca7962b184a6c7a40c65cdd0434ef4f7
parentfa1e3fb147d1bb0f2446eaf9923acfcf18f8384d (diff)
Policy:Blocker
Use try-with-resources to close this JarFile:L590 L617 Issue-ID: POLICY-688 Sonar link:https://sonar.onap.org/issues?myIssues=true&open=AWF91iXI8TZzbCgU6anv&resolved=false&severities=BLOCKER Location:BRMSGateway\src\main\java\org\onap\policy\brmsInterface\BRMSPush.java Change-Id: I11f07325e78d6c7a9760496db4685546d2910595 Signed-off-by: Manamohan Satapathy <MS00534989@techmahindra.com>
-rw-r--r--BRMSGateway/src/main/java/org/onap/policy/brmsInterface/BRMSPush.java20
1 files changed, 11 insertions, 9 deletions
diff --git a/BRMSGateway/src/main/java/org/onap/policy/brmsInterface/BRMSPush.java b/BRMSGateway/src/main/java/org/onap/policy/brmsInterface/BRMSPush.java
index a1113f53d..86cd066b8 100644
--- a/BRMSGateway/src/main/java/org/onap/policy/brmsInterface/BRMSPush.java
+++ b/BRMSGateway/src/main/java/org/onap/policy/brmsInterface/BRMSPush.java
@@ -586,8 +586,8 @@ public class BRMSPush {
}
}
- private void extractJar(String jarFileName, String artifactId) throws IOException {
- JarFile jar = new JarFile(jarFileName);
+private void extractJar(String jarFileName, String artifactId){
+ try (JarFile jar = new JarFile(jarFileName)) {
Enumeration<?> enumEntries = jar.entries();
while (enumEntries.hasMoreElements()) {
JarEntry file = (JarEntry) enumEntries.nextElement();
@@ -613,18 +613,20 @@ public class BRMSPush {
f = new File(path + File.separator + fileName);
}
if (f != null) {
- InputStream is = jar.getInputStream(file);
- FileOutputStream fos = new FileOutputStream(f);
+ try (InputStream is = jar.getInputStream(file); FileOutputStream fos = new FileOutputStream(f)) {
while (is.available() > 0) {
fos.write(is.read());
}
- fos.close();
- is.close();
LOGGER.info(fileName + " Created..");
+ } catch (IOException e) {
+ LOGGER.info("exception Occured" + e);
+ }
}
- }
- jar.close();
- }
+ }
+ } catch (IOException e) {
+ LOGGER.info("exception Occured" + e);
+ }
+ }
private NexusArtifact getLatestArtifactFromNexus(String selectedName) {
List<NexusArtifact> artifacts = getArtifactFromNexus(selectedName, null);