aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChris André <chris.andre@yoppworks.com>2020-06-22 11:15:43 -0400
committerChris André <chris.andre@yoppworks.com>2020-06-22 11:15:43 -0400
commit02f5d9e2c02c0b9fffdc494a9b7c87e0a4f7e000 (patch)
tree957a235369a65f87407f2dc59c78a2fdd10e8f41
parenta03865f2807e4aa0c80fbab1be812da2d8466d29 (diff)
MongoConfig - Removed Sonar warnings
- updated pom.xml files to get rid of warnings - used `try-with-resource` to automatically close variable `mongoC` Issue-ID: AAI-2954 Signed-off-by: Chris Andre <chris.andre@yoppworks.com> Change-Id: Ib26db5f100d700c2e18d7aa2e5376dbe17f7f846
-rw-r--r--pom.xml16
-rw-r--r--src/main/java/org/onap/aai/cacher/common/MongoConfig.java7
2 files changed, 6 insertions, 17 deletions
diff --git a/pom.xml b/pom.xml
index efbf33e..04eb0f6 100644
--- a/pom.xml
+++ b/pom.xml
@@ -279,11 +279,6 @@
<version>1.18</version>
</dependency>
<dependency>
- <groupId>org.apache.commons</groupId>
- <artifactId>commons-compress</artifactId>
- <version>1.18</version>
- </dependency>
- <dependency>
<groupId>org.mongodb</groupId>
<artifactId>mongodb-driver</artifactId>
<version>3.6.2</version>
@@ -364,10 +359,6 @@
<version>2.24</version>
</dependency>
<dependency>
- <groupId>org.json</groupId>
- <artifactId>json</artifactId>
- </dependency>
- <dependency>
<groupId>com.googlecode.json-simple</groupId>
<artifactId>json-simple</artifactId>
<version>1.1.1</version>
@@ -555,12 +546,9 @@
<artifactId>maven-dependency-plugin</artifactId>
</plugin>
<plugin>
- <groupId>org.springframework.boot</groupId>
- <artifactId>spring-boot-maven-plugin</artifactId>
- </plugin>
- <plugin>
<artifactId>exec-maven-plugin</artifactId>
<groupId>org.codehaus.mojo</groupId>
+ <version>3.0.0</version>
</plugin>
<plugin>
<groupId>org.springframework.boot</groupId>
@@ -603,10 +591,12 @@
<plugin>
<groupId>com.github.kongchen</groupId>
<artifactId>swagger-maven-plugin</artifactId>
+ <version>3.1.8</version>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
+ <version>3.2.0</version>
<configuration>
<additionalparam>-Xdoclint:none</additionalparam>
</configuration>
diff --git a/src/main/java/org/onap/aai/cacher/common/MongoConfig.java b/src/main/java/org/onap/aai/cacher/common/MongoConfig.java
index 5c1a541..ca063a7 100644
--- a/src/main/java/org/onap/aai/cacher/common/MongoConfig.java
+++ b/src/main/java/org/onap/aai/cacher/common/MongoConfig.java
@@ -48,7 +48,7 @@ import java.io.IOException;
@Configuration
public class MongoConfig {
- private final static EELFLogger EELF_LOGGER = EELFManager.getInstance().getLogger(MongoConfig.class);
+ private static final EELFLogger EELF_LOGGER = EELFManager.getInstance().getLogger(MongoConfig.class);
@Value("${mongodb.host}")
private String MONGO_DB_HOST;
@@ -61,9 +61,8 @@ public class MongoConfig {
@Bean
public MongoClient mongoClient(MongodProcess mongodProcess) {
- try {
- // To connect to mongodb server
- MongoClient mongoC = new MongoClient(MONGO_DB_HOST, MONGO_DB_PORT);
+ // To connect to mongodb server
+ try (MongoClient mongoC = new MongoClient(MONGO_DB_HOST, MONGO_DB_PORT)) {
// Now connect to your databases
EELF_LOGGER.info("Connect to database successfully");