From 628dd1bb98a25508f6fae41fe4ab249338abf53b Mon Sep 17 00:00:00 2001 From: Gokul Singaraju Date: Fri, 23 Mar 2018 02:19:09 -0400 Subject: Increase coverage fix sonar issues Issue-ID: VNFSDK-217 Change-Id: I74556357e52b534564476adf343f53a3453a96e5 Signed-Off-by: Gokul Singaraju --- .../java/evel_javalibrary/att/com/AgentMain.java | 6 ++++-- .../java/evel_javalibrary/att/com/EvelBatch.java | 2 +- .../evel_javalibrary/att/com/EvelMobileFlow.java | 4 ++++ .../att/com/EvelScalingMeasurement.java | 20 +++++++++----------- .../java/evel_javalibrary/att/com/RingBuffer.java | 14 +++++--------- 5 files changed, 23 insertions(+), 23 deletions(-) (limited to 'veslibrary/ves_javalibrary/evel_javalib2/src/main/java/evel_javalibrary/att/com') diff --git a/veslibrary/ves_javalibrary/evel_javalib2/src/main/java/evel_javalibrary/att/com/AgentMain.java b/veslibrary/ves_javalibrary/evel_javalib2/src/main/java/evel_javalibrary/att/com/AgentMain.java index 7380d90..23a1b4d 100644 --- a/veslibrary/ves_javalibrary/evel_javalib2/src/main/java/evel_javalibrary/att/com/AgentMain.java +++ b/veslibrary/ves_javalibrary/evel_javalib2/src/main/java/evel_javalibrary/att/com/AgentMain.java @@ -252,8 +252,10 @@ public enum EVEL_ERR_CODES { try { Thread.sleep(5); } catch (InterruptedException e) { - logger.trace("Interrupted on "+url); - e.printStackTrace(); + Thread.currentThread().interrupt(); + logger.trace("Interrupted on "+url); + System.out.println("Interrupted on "+url); + //e.printStackTrace(); } } }//end for diff --git a/veslibrary/ves_javalibrary/evel_javalib2/src/main/java/evel_javalibrary/att/com/EvelBatch.java b/veslibrary/ves_javalibrary/evel_javalib2/src/main/java/evel_javalibrary/att/com/EvelBatch.java index 6db25b5..9cc3d2b 100644 --- a/veslibrary/ves_javalibrary/evel_javalib2/src/main/java/evel_javalibrary/att/com/EvelBatch.java +++ b/veslibrary/ves_javalibrary/evel_javalib2/src/main/java/evel_javalibrary/att/com/EvelBatch.java @@ -43,7 +43,7 @@ public class EvelBatch { public EvelBatch(){ batch_events = new ArrayList(); - if( batch_events == null ) LOGGER.error("Unable to allocate new batch"); + LOGGER.trace("Allocated new batch"); } public boolean addEvent(EvelHeader element){ diff --git a/veslibrary/ves_javalibrary/evel_javalib2/src/main/java/evel_javalibrary/att/com/EvelMobileFlow.java b/veslibrary/ves_javalibrary/evel_javalib2/src/main/java/evel_javalibrary/att/com/EvelMobileFlow.java index 339cb90..7a01dae 100644 --- a/veslibrary/ves_javalibrary/evel_javalib2/src/main/java/evel_javalibrary/att/com/EvelMobileFlow.java +++ b/veslibrary/ves_javalibrary/evel_javalib2/src/main/java/evel_javalibrary/att/com/EvelMobileFlow.java @@ -449,6 +449,10 @@ public class EvelMobileFlow extends EvelHeader { /*****************************************************************************/ + public EvelMobileFlow(String evname, String evid) + { + super(evname,evid); + } /**************************************************************************//** * Create a new Mobile Flow event. * diff --git a/veslibrary/ves_javalibrary/evel_javalib2/src/main/java/evel_javalibrary/att/com/EvelScalingMeasurement.java b/veslibrary/ves_javalibrary/evel_javalib2/src/main/java/evel_javalibrary/att/com/EvelScalingMeasurement.java index 8645427..1312eed 100644 --- a/veslibrary/ves_javalibrary/evel_javalib2/src/main/java/evel_javalibrary/att/com/EvelScalingMeasurement.java +++ b/veslibrary/ves_javalibrary/evel_javalib2/src/main/java/evel_javalibrary/att/com/EvelScalingMeasurement.java @@ -643,7 +643,7 @@ public class EvelScalingMeasurement extends EvelHeader { if( cpu_usage == null ){ cpu_usage = new ArrayList(); - if( cpu_usage == null)LOGGER.error("Unable to allocate new cpu usage"); + LOGGER.debug("Allocate new cpu usage"); } cpu_usage.add(cpu_use); @@ -854,7 +854,7 @@ public class EvelScalingMeasurement extends EvelHeader { if( mem_usage == null ){ mem_usage = new ArrayList(); - if( mem_usage == null )LOGGER.error("Unable to allocate new memory usage"); + LOGGER.debug("Allocated new memory usage"); } @@ -1047,7 +1047,7 @@ public class EvelScalingMeasurement extends EvelHeader { if( disk_usage == null ){ disk_usage = new ArrayList(); - if( disk_usage == null ) LOGGER.error("Unable to allocate new disk usage"); + LOGGER.debug("Unable to allocate new disk usage"); } @@ -1862,7 +1862,7 @@ public class EvelScalingMeasurement extends EvelHeader { if( filesystem_usage == null ){ filesystem_usage = new ArrayList(); - if( filesystem_usage == null )LOGGER.error("Unable to allocate new file system usage"); + LOGGER.debug("Allocated new file system usage"); } filesystem_usage.add(fsys_use); @@ -1907,7 +1907,7 @@ public class EvelScalingMeasurement extends EvelHeader { if( feature_usage == null ){ feature_usage = new ArrayList(); - if( feature_usage == null )LOGGER.error("Unable to allocate new feature usage"); + LOGGER.debug("Allocate new feature usage"); } feature_usage.add(feature_use); @@ -1988,9 +1988,7 @@ public class EvelScalingMeasurement extends EvelHeader { if( additional_measurements == null){ LOGGER.debug("Creating new Measurement Group list"+group); additional_measurements = new ArrayList(); - if( additional_measurements == null ){ - LOGGER.error("Unable to allocate additional measurements "); - } + LOGGER.debug("Allocate additional measurements "); } additional_measurements.add(measurement_group); } @@ -2039,7 +2037,7 @@ public class EvelScalingMeasurement extends EvelHeader { if( codec_usage == null ){ codec_usage = new ArrayList(); - if( codec_usage == null )LOGGER.error("Unable to allocate new codec usage"); + LOGGER.debug("Allocated new codec usage"); } codec_usage.add(codec_use); @@ -2219,7 +2217,7 @@ public class EvelScalingMeasurement extends EvelHeader { if( latency_distribution == null ){ latency_distribution = new ArrayList(); - if( latency_distribution == null )LOGGER.error("Unable to allocate new file system usage"); + LOGGER.debug("Allocate new file system usage"); } latency_distribution.add(bucket); @@ -3146,7 +3144,7 @@ public class EvelScalingMeasurement extends EvelHeader { if( vnic_usage == null ){ vnic_usage = new ArrayList(); - if( vnic_usage == null )LOGGER.error("Unable to allocate new file system usage"); + LOGGER.debug("Allocate new file system usage"); } vnic_usage.add(vnic_performance); diff --git a/veslibrary/ves_javalibrary/evel_javalib2/src/main/java/evel_javalibrary/att/com/RingBuffer.java b/veslibrary/ves_javalibrary/evel_javalib2/src/main/java/evel_javalibrary/att/com/RingBuffer.java index 144fc24..460e84a 100644 --- a/veslibrary/ves_javalibrary/evel_javalib2/src/main/java/evel_javalibrary/att/com/RingBuffer.java +++ b/veslibrary/ves_javalibrary/evel_javalib2/src/main/java/evel_javalibrary/att/com/RingBuffer.java @@ -73,8 +73,7 @@ public class RingBuffer { spacesem.acquire(); lock.acquire(); } catch (InterruptedException e) { - // TODO Auto-generated catch block - e.printStackTrace(); + Thread.currentThread().interrupt(); } @@ -107,8 +106,7 @@ public class RingBuffer { spacesem.acquire(); lock.acquire(); } catch (InterruptedException e) { - // TODO Auto-generated catch block - e.printStackTrace(); + Thread.currentThread().interrupt(); } int readPos = 0; @@ -178,8 +176,7 @@ public class RingBuffer { countsem.acquire(); lock.acquire(); } catch (InterruptedException e) { - // TODO Auto-generated catch block - e.printStackTrace(); + Thread.currentThread().interrupt(); } if(available == 0){ @@ -201,7 +198,7 @@ public class RingBuffer { } - public int take(EvelObject[] into){ + public int take(EvelObject[] into) { return take(into, into.length); } @@ -214,8 +211,7 @@ public class RingBuffer { countsem.acquire(); lock.acquire(); } catch (InterruptedException e) { - // TODO Auto-generated catch block - e.printStackTrace(); + Thread.currentThread().interrupt(); } if(available <= writePos){ -- cgit 1.2.3-korg