From ca4c0d939cdb3bcabec2bef0636bee4aa403cee3 Mon Sep 17 00:00:00 2001 From: Adam Wudzinski Date: Fri, 18 Sep 2020 13:50:33 +0200 Subject: Add warnings field to oclip json response Add new field called "warnings" to oclip json response. All ignored errors are now reported as warnings. Signed-off-by: Adam Wudzinski Issue-ID: VNFSDK-596 Change-Id: Ifebfb09b54156f0566858e942d73a7a5ef34721f --- .../java/org/onap/cvc/csar/CsarValidatorTest.java | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) (limited to 'csarvalidation/src/test/java') diff --git a/csarvalidation/src/test/java/org/onap/cvc/csar/CsarValidatorTest.java b/csarvalidation/src/test/java/org/onap/cvc/csar/CsarValidatorTest.java index d742ca6..299aff2 100644 --- a/csarvalidation/src/test/java/org/onap/cvc/csar/CsarValidatorTest.java +++ b/csarvalidation/src/test/java/org/onap/cvc/csar/CsarValidatorTest.java @@ -29,6 +29,7 @@ import org.onap.cli.main.OnapCli; import java.net.URISyntaxException; import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertTrue; import static org.onap.cvc.csar.cc.sol004.IntegrationTestUtils.absoluteFilePath; @@ -37,6 +38,26 @@ public class CsarValidatorTest { private static final String NO_CERTIFICATE_RULE = "r130206"; private static final String OPERATION_STATUS_FAILED = "FAILED"; + @Test + public void shouldReportErrorAsWarningWhenErrorIsIgnored() throws URISyntaxException { + // given + OnapCliWrapper cli = new OnapCliWrapper(new String[]{ + "--product", "onap-dublin", + "csar-validate", + "--format", "json", + "--pnf", + "--csar", absoluteFilePath("pnf/r130206/csar-option1-warning-2.csar")}); + + // when + cli.handle(); + + // then + final OnapCommandResult onapCommandResult = cli.getCommandResult(); + assertTrue(onapCommandResult.getOutput().toString().contains( + "\"warnings\":[{\"vnfreqNo\":\"R130206\",\"code\":\"0x1006\",\"message\":\"Warning. Consider adding package " + + "integrity and authenticity assurance according to ETSI NFV-SOL 004 Security Option 1\",\"file\":\"\",\"lineNumber\":-1}]}")); + } + @Test public void shouldReportThanVnfValidationFailed() throws URISyntaxException { // given -- cgit 1.2.3-korg