From 497835a9faf9ec947af69a8e1c48f02ce7376fcd Mon Sep 17 00:00:00 2001
From: Michal Banka <michal.banka@nokia.com>
Date: Fri, 15 May 2020 14:45:42 +0200
Subject: Fix R972082 bug

Fixed bug that was showing errors during validation of CSAR,
when any other non_mano_artifact_set than onap_pnf_sw_information
was present in manifest file.

Change-Id: Iebf4f586c3069bc8c22796ec0f809fc95e561159
Signed-off-by: Michal Banka <michal.banka@nokia.com>
Issue-ID: VNFSDK-585
---
 .../cvc/csar/cc/sol004/VTPValidateCSARR972082.java | 31 +++++++++-------------
 1 file changed, 12 insertions(+), 19 deletions(-)

(limited to 'csarvalidation/src/main/java/org/onap/cvc/csar/cc/sol004')

diff --git a/csarvalidation/src/main/java/org/onap/cvc/csar/cc/sol004/VTPValidateCSARR972082.java b/csarvalidation/src/main/java/org/onap/cvc/csar/cc/sol004/VTPValidateCSARR972082.java
index 1061480..60bdd47 100644
--- a/csarvalidation/src/main/java/org/onap/cvc/csar/cc/sol004/VTPValidateCSARR972082.java
+++ b/csarvalidation/src/main/java/org/onap/cvc/csar/cc/sol004/VTPValidateCSARR972082.java
@@ -23,13 +23,15 @@ import java.io.IOException;
 import java.io.InputStream;
 import java.nio.file.Files;
 import java.util.ArrayList;
-import java.util.Arrays;
 import java.util.LinkedHashSet;
 import java.util.List;
 import java.util.Map;
 import java.util.Objects;
 import java.util.Optional;
 import java.util.Set;
+import java.util.stream.Collectors;
+import java.util.stream.Stream;
+
 import lombok.AccessLevel;
 import lombok.AllArgsConstructor;
 import lombok.EqualsAndHashCode;
@@ -115,13 +117,12 @@ public class VTPValidateCSARR972082 extends VTPValidateCSARBase {
 
     private static class ValidateNonManoSection {
 
+        private static final String ATTRIBUTE_NAME = "onap_pnf_sw_information";
+
         private final CSARArchive csar;
         private final String fileName;
         private final Map<String, Map<String, List<String>>> nonMano;
         private final List<CSARError> errors = new ArrayList<>();
-        private final List<String> attributeNames = Arrays.asList(
-            "onap_pnf_sw_information"
-        );
 
         private ValidateNonManoSection(final CSARArchive csar, final String fileName,
                                        final Map<String, Map<String, List<String>>> nonMano) {
@@ -141,28 +142,20 @@ public class VTPValidateCSARR972082 extends VTPValidateCSARBase {
         }
 
         private List<CSARError> validate() {
-            if (nonMano.keySet().stream().filter(Objects::nonNull).count() > 0) {
-                nonMano.keySet().stream().filter(Objects::nonNull).forEach(this::validateAttribute);
+            List<String> attributesNotNull = nonMano.keySet().stream()
+                    .filter(Objects::nonNull)
+                    .collect(Collectors.toList());
+            if (!attributesNotNull.isEmpty()) {
+                attributesNotNull.forEach(this::validateAttribute);
             } else {
-                errors.add(new PnfCSARErrorEntryMissing(
-                    attributeNames.toString(),
-                    fileName,
-                    UNKNOWN_LINE_NUMBER)
-                );
+                errors.add(new PnfCSARErrorEntryMissing(ATTRIBUTE_NAME, fileName, UNKNOWN_LINE_NUMBER));
             }
 
             return errors;
         }
 
         private void validateAttribute(final String nonManoAttributes) {
-
-            if (!attributeNames.contains(nonManoAttributes)) {
-                errors.add(new PnfCSARErrorEntryMissing(
-                    nonManoAttributes,
-                    fileName,
-                    UNKNOWN_LINE_NUMBER)
-                );
-            } else {
+            if (ATTRIBUTE_NAME.equals(nonManoAttributes)) {
                 validateSourceElementsUnderAttribute(nonManoAttributes);
             }
         }
-- 
cgit 1.2.3-korg