From 6750f9e73f44e7fc6854d570142e6d30f5d3cd24 Mon Sep 17 00:00:00 2001 From: SravanKumarGunda Date: Thu, 30 Jul 2020 21:30:09 +0530 Subject: Code Improvements-Vnfsdk-validation sonar issue fixes Signed-off-by: SravanKumarGunda Issue-ID: VNFSDK-608 Change-Id: Idba9f4876e41b699e2a2ac836eb2090f3694d0f1 --- .../main/java/org/onap/cvc/csar/cc/sol001/VTPValidateCSARR02454.java | 5 +++-- .../main/java/org/onap/cvc/csar/cc/sol001/VTPValidateCSARR35851.java | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) (limited to 'csarvalidation/src/main/java/org/onap/cvc/csar/cc/sol001') diff --git a/csarvalidation/src/main/java/org/onap/cvc/csar/cc/sol001/VTPValidateCSARR02454.java b/csarvalidation/src/main/java/org/onap/cvc/csar/cc/sol001/VTPValidateCSARR02454.java index 7d0489e..4270d87 100644 --- a/csarvalidation/src/main/java/org/onap/cvc/csar/cc/sol001/VTPValidateCSARR02454.java +++ b/csarvalidation/src/main/java/org/onap/cvc/csar/cc/sol001/VTPValidateCSARR02454.java @@ -60,10 +60,11 @@ public class VTPValidateCSARR02454 extends VTPValidateCSARBase { } } - if (!vlExist) - this.errors.add(new CSARErrorEntryMissingSwImage( + if (!vlExist) { + this.errors.add(new CSARErrorEntryMissingSwImage( csar.getDefinitionYamlFile().getName(), "Software Image")); + } } } } diff --git a/csarvalidation/src/main/java/org/onap/cvc/csar/cc/sol001/VTPValidateCSARR35851.java b/csarvalidation/src/main/java/org/onap/cvc/csar/cc/sol001/VTPValidateCSARR35851.java index 52582a6..78be3e6 100644 --- a/csarvalidation/src/main/java/org/onap/cvc/csar/cc/sol001/VTPValidateCSARR35851.java +++ b/csarvalidation/src/main/java/org/onap/cvc/csar/cc/sol001/VTPValidateCSARR35851.java @@ -59,7 +59,7 @@ public class VTPValidateCSARR35851 extends VTPValidateCSARBase { yaml = (Map) yaml.get("topology_template"); Map nodeTmpls = (Map) yaml.get("node_templates"); - boolean vlExist[] = new boolean[3]; + boolean[] vlExist = new boolean[3]; for (Object nodeO: nodeTmpls.values()) { Map node = (Map) nodeO; -- cgit 1.2.3-korg