From a4fd70a3a183a3ced4c46415a25d081ece8ac098 Mon Sep 17 00:00:00 2001
From: Ittay Stern <ittay.stern@att.com>
Date: Mon, 17 Feb 2020 09:48:20 +0200
Subject: Fix intermittent test inProgressJobMoreThan24HoursIsFailedInVidAudit

Bit more time was needed.

Issue-ID: VID-647

Change-Id: Ie7e101a2eb85e71a38d1cb2efd9f7327e4705fd3
Signed-off-by: Ittay Stern <ittay.stern@att.com>
---
 .../org/onap/vid/api/AsyncInstantiationBase.java   |  4 ++-
 .../src/main/java/org/onap/vid/api/TestUtils.java  | 34 +++++++++++++---------
 .../main/java/vid/automation/test/infra/Wait.java  | 15 +++++++---
 3 files changed, 35 insertions(+), 18 deletions(-)

(limited to 'vid-automation/src/main')

diff --git a/vid-automation/src/main/java/org/onap/vid/api/AsyncInstantiationBase.java b/vid-automation/src/main/java/org/onap/vid/api/AsyncInstantiationBase.java
index 4475c366b..ee3982c19 100644
--- a/vid-automation/src/main/java/org/onap/vid/api/AsyncInstantiationBase.java
+++ b/vid-automation/src/main/java/org/onap/vid/api/AsyncInstantiationBase.java
@@ -544,7 +544,7 @@ public class AsyncInstantiationBase extends BaseMsoApiTest {
                 .toString();
     }
 
-    protected void addBulkPendingWithCustomList(List<BasePreset> customPresets){
+    protected Map<Keys, String> addBulkPendingWithCustomList(List<BasePreset> customPresets){
         Map<Keys, String> names = generateNames();
         final int bulkSize = 2 + customPresets.size();
 
@@ -559,6 +559,8 @@ public class AsyncInstantiationBase extends BaseMsoApiTest {
 
         List<String> jobIds = createBulkOfMacroInstances(presets, false, bulkSize, names);
         Assert.assertEquals(jobIds.size(),bulkSize);
+
+        return names;
     }
 
     protected void verifyAuditStatuses(String jobId, List<String> statuses, JobAuditStatus.SourceStatus source) {
diff --git a/vid-automation/src/main/java/org/onap/vid/api/TestUtils.java b/vid-automation/src/main/java/org/onap/vid/api/TestUtils.java
index a2fe82e9d..cc292caa7 100644
--- a/vid-automation/src/main/java/org/onap/vid/api/TestUtils.java
+++ b/vid-automation/src/main/java/org/onap/vid/api/TestUtils.java
@@ -1,27 +1,29 @@
 package org.onap.vid.api;
 
+import static org.apache.commons.text.CharacterPredicates.DIGITS;
+import static org.apache.commons.text.CharacterPredicates.LETTERS;
+import static org.hamcrest.CoreMatchers.is;
+import static org.hamcrest.Matchers.hasEntry;
+import static org.hamcrest.Matchers.hasKey;
+import static org.hamcrest.Matchers.not;
+import static vid.automation.test.utils.RegExMatcher.matchesRegEx;
+
 import com.fasterxml.jackson.core.JsonParser;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.fasterxml.jackson.databind.SerializationFeature;
+import java.io.IOException;
+import java.io.InputStream;
+import java.util.Map;
+import java.util.Scanner;
+import javax.ws.rs.client.WebTarget;
+import javax.ws.rs.core.Response;
 import org.apache.commons.text.RandomStringGenerator;
 import org.hamcrest.Matcher;
 import org.springframework.core.io.Resource;
 import org.springframework.core.io.support.PathMatchingResourcePatternResolver;
 import org.springframework.core.io.support.ResourcePatternResolver;
 import org.springframework.http.HttpStatus;
-
-import javax.ws.rs.client.WebTarget;
-import javax.ws.rs.core.Response;
-import java.io.IOException;
-import java.io.InputStream;
-import java.util.Map;
-import java.util.Scanner;
-
-import static org.apache.commons.text.CharacterPredicates.DIGITS;
-import static org.apache.commons.text.CharacterPredicates.LETTERS;
-import static org.hamcrest.CoreMatchers.is;
-import static org.hamcrest.Matchers.*;
-import static vid.automation.test.utils.RegExMatcher.matchesRegEx;
+import org.testng.annotations.DataProvider;
 
 public class TestUtils {
 
@@ -96,4 +98,10 @@ public class TestUtils {
     public static String generateRandomAlphaNumeric(int length) {
         return generator.generate(length);
     }
+
+    @DataProvider
+    public static Object[][] trueAndFalse() {
+        return new Object[][]{{true}, {false}};
+    }
+
 }
diff --git a/vid-automation/src/main/java/vid/automation/test/infra/Wait.java b/vid-automation/src/main/java/vid/automation/test/infra/Wait.java
index cab3a2d5b..c392c2815 100644
--- a/vid-automation/src/main/java/vid/automation/test/infra/Wait.java
+++ b/vid-automation/src/main/java/vid/automation/test/infra/Wait.java
@@ -1,20 +1,21 @@
 package vid.automation.test.infra;
 
+import java.util.concurrent.TimeUnit;
+import java.util.function.Predicate;
 import org.apache.commons.collections.CollectionUtils;
+import org.apache.commons.lang3.exception.ExceptionUtils;
 import org.onap.sdc.ci.tests.utilities.GeneralUIUtils;
 import org.openqa.selenium.JavascriptExecutor;
 import org.openqa.selenium.NoSuchElementException;
 import vid.automation.test.Constants;
 
-import java.util.concurrent.TimeUnit;
-import java.util.function.Predicate;
-
 public class Wait {
     public static boolean byText(String text) {
         return GeneralUIUtils.findAndWaitByText(text, Constants.generalTimeout);
     }
 
     public static <T> boolean waitFor(Predicate<T> predicate, T input, int numOfRetries, int interval, TimeUnit intervalUnit) {
+        Throwable lastError = null;
         for (int i=0; i<numOfRetries; i++) {
             try {
                 if (predicate.test(input)) {
@@ -22,6 +23,7 @@ public class Wait {
                 }
             }
             catch (Throwable t) {
+                lastError = t;
                 System.out.println(String.format("a retry failed due to: %s %s", t, t.getMessage()));
             }
             try {
@@ -30,7 +32,12 @@ public class Wait {
                 e.printStackTrace();
             }
         }
-        return false;
+
+        if (lastError != null) {
+            throw ExceptionUtils.<RuntimeException>rethrow(lastError);
+        } else {
+            return false;
+        }
     }
 
     public static <T> boolean waitFor(Predicate<T> predicate, T input, int numOfRetries, int interval) {
-- 
cgit 1.2.3-korg