From f75ace38ec02707694f11e385a26c8fed32882ea Mon Sep 17 00:00:00 2001 From: Eylon Malin Date: Thu, 1 Aug 2019 11:05:37 +0300 Subject: Handling legacy region in vfModule creation Issue-ID: VID-482 Signed-off-by: Eylon Malin Change-Id: I2c55587d86a77eb0c6c2fa410b212efb074894e2 --- .../vf-module-homing-data-action.controller.js | 1 + .../main/webapp/app/vid/scripts/services/creationService.js | 10 +++++----- .../webapp/app/vid/scripts/services/deleteResumeService.js | 6 ------ 3 files changed, 6 insertions(+), 11 deletions(-) (limited to 'vid-app-common/src') diff --git a/vid-app-common/src/main/webapp/app/vid/scripts/modals/vf-module-homing-data-action/vf-module-homing-data-action.controller.js b/vid-app-common/src/main/webapp/app/vid/scripts/modals/vf-module-homing-data-action/vf-module-homing-data-action.controller.js index 87f0f301d..3b5384e14 100644 --- a/vid-app-common/src/main/webapp/app/vid/scripts/modals/vf-module-homing-data-action/vf-module-homing-data-action.controller.js +++ b/vid-app-common/src/main/webapp/app/vid/scripts/modals/vf-module-homing-data-action/vf-module-homing-data-action.controller.js @@ -47,6 +47,7 @@ var vfModuleActionModalController = function(COMPONENT, FIELD, $scope, $uibModal AaiService.getLcpCloudRegionTenantList(DataService .getGlobalCustomerId(), DataService.getServiceType(), function( response) { + DataService.setCloudRegionTenantList(response); $scope.lcpAndTenant = response; $scope.isFeatureFlagCloudOwner = featureFlags.isOn(COMPONENT.FEATURE_FLAGS.FLAG_1810_CR_ADD_CLOUD_OWNER_TO_MSO_REQUEST); $scope.lcpRegionList = _.uniqBy(response, 'cloudRegionId'); diff --git a/vid-app-common/src/main/webapp/app/vid/scripts/services/creationService.js b/vid-app-common/src/main/webapp/app/vid/scripts/services/creationService.js index 17adf77ce..1949f5aa2 100755 --- a/vid-app-common/src/main/webapp/app/vid/scripts/services/creationService.js +++ b/vid-app-common/src/main/webapp/app/vid/scripts/services/creationService.js @@ -626,8 +626,6 @@ var CreationService = function($log, AaiService, AsdcService, DataService,VIDCON var getMsoRequestDetails = function(parameterList) { console.log("getMsoRequestDetails invoked, parameterList="); console.log(JSON.stringify(parameterList,null,4)); - //console.log("getMsoRequestDetails invoked, DataService.getArbitraryParameters()="); - //console.log(JSON.stringify(DataService.getArbitraryParameters(),null,4)); //VoLTE logic goes here if(DataService.getE2EService() === true) { @@ -781,8 +779,8 @@ var CreationService = function($log, AaiService, AsdcService, DataService,VIDCON var cloudOwner; var lcpRegionOptionId = getValueFromList(FIELD.ID.LCP_REGION, parameterList); - - if (lcpRegionOptionId === FIELD.KEY.LCP_REGION_TEXT) { + var cloudOwnerAndLcpCloudRegion = getCloudOwnerAndLcpCloudRegionFromOptionId(lcpRegionOptionId); + if (cloudOwnerAndLcpCloudRegion.cloudRegionId === FIELD.KEY.LCP_REGION_TEXT) { lcpRegion = getValueFromList(FIELD.ID.LCP_REGION_TEXT, parameterList); cloudOwner = undefined; @@ -1258,7 +1256,9 @@ var CreationService = function($log, AaiService, AsdcService, DataService,VIDCON parameterListControl .updateList([ FIELD.PARAMETER.TENANT_DISABLED ]); } - if (list[0].value === FIELD.KEY.LCP_REGION_TEXT) { + + var cloudOwnerAndLcpCloudRegion = getCloudOwnerAndLcpCloudRegionFromOptionId(list[0].value); + if (cloudOwnerAndLcpCloudRegion.cloudRegionId === FIELD.KEY.LCP_REGION_TEXT) { parameterListControl .updateList([ FIELD.PARAMETER.LCP_REGION_TEXT_VISIBLE ]); } else { diff --git a/vid-app-common/src/main/webapp/app/vid/scripts/services/deleteResumeService.js b/vid-app-common/src/main/webapp/app/vid/scripts/services/deleteResumeService.js index 36e962b73..817bef670 100644 --- a/vid-app-common/src/main/webapp/app/vid/scripts/services/deleteResumeService.js +++ b/vid-app-common/src/main/webapp/app/vid/scripts/services/deleteResumeService.js @@ -45,12 +45,6 @@ var DeleteResumeService = function($log, AaiService, AsdcService, DataService, }; var getLcpCloudRegionTenantList = function() { - //console.log ( "global customer id: " ); - //console.log ( JSON.stringify (DataService.getGlobalCustomerId()) ); - - //console.log ( "service type: " ); - //console.log ( JSON.stringify (DataService.getServiceType()) ); - AaiService.getLcpCloudRegionTenantList(DataService .getGlobalCustomerId(), DataService.getServiceType(), function( response) { -- cgit 1.2.3-korg