From c65f0fc6b0d0be3fbeba4d57896fa04b42f5aae3 Mon Sep 17 00:00:00 2001
From: anushadasari <danush10@in.ibm.com>
Date: Wed, 21 Aug 2019 12:57:30 +0530
Subject: Unused Import

The imports part of a file should be handled by the Integrated Development Environment (IDE), not manually by the developer.
Unused and useless imports should not occur if that is the case.
Leaving them in reduces the code's readability, since their presence can be confusing.

Issue-ID: VID-582
Change-Id: Id79d2f2af4d69ded8e1c8da10fc67e4e7ea0f933
Signed-off-by: anushadasari <danush10@in.ibm.com>
---
 vid-app-common/src/main/java/org/onap/vid/services/AaiServiceImpl.java | 1 -
 1 file changed, 1 deletion(-)

(limited to 'vid-app-common/src')

diff --git a/vid-app-common/src/main/java/org/onap/vid/services/AaiServiceImpl.java b/vid-app-common/src/main/java/org/onap/vid/services/AaiServiceImpl.java
index 9b890478f..b50dcc3b5 100644
--- a/vid-app-common/src/main/java/org/onap/vid/services/AaiServiceImpl.java
+++ b/vid-app-common/src/main/java/org/onap/vid/services/AaiServiceImpl.java
@@ -42,7 +42,6 @@ import org.apache.http.HttpStatus;
 import org.onap.portalsdk.core.logging.logic.EELFLoggerDelegate;
 import org.onap.vid.aai.AaiClientInterface;
 import org.onap.vid.aai.AaiGetVnfResponse;
-import org.onap.vid.aai.AaiOverTLSClientInterface;
 import org.onap.vid.aai.AaiResponse;
 import org.onap.vid.aai.AaiResponseTranslator;
 import org.onap.vid.aai.ExceptionWithRequestInfo;
-- 
cgit 1.2.3-korg


From e77115762aec95c8693af35c3862669593cd2fc9 Mon Sep 17 00:00:00 2001
From: anushadasari <danush10@in.ibm.com>
Date: Wed, 21 Aug 2019 13:10:33 +0530
Subject: Add a semicolon at the end of this statement.

In JavaScript, the semicolon (;) is optional as a statement separator, but omitting semicolons can be confusing, and lead to unexpected results because a semicolon is implicitly inserted at the end of each line.

Issue-ID: VID-583
Change-Id: I73dbc757d62ef388d8935ef6aa25f08c3a82df8c
Signed-off-by: anushadasari <danush10@in.ibm.com>
---
 .../scripts/controller/InstantiationController.js    | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

(limited to 'vid-app-common/src')

diff --git a/vid-app-common/src/main/webapp/app/vid/scripts/controller/InstantiationController.js b/vid-app-common/src/main/webapp/app/vid/scripts/controller/InstantiationController.js
index 6eed08033..7fa312ed9 100755
--- a/vid-app-common/src/main/webapp/app/vid/scripts/controller/InstantiationController.js
+++ b/vid-app-common/src/main/webapp/app/vid/scripts/controller/InstantiationController.js
@@ -142,13 +142,13 @@
 
             }
             return null;
-        }
+        };
         $scope.hasVfModules = function (vnfInstance) {
             if ($scope.returnVfModules(vnfInstance) != null) {
                 return true;
             }
             return false;
-        }
+        };
         $scope.returnVolumeGroups = function (vnfInstance) {
 
             var svcModel = $scope.service.convertedModel;
@@ -183,13 +183,13 @@
 
             }
             return null;
-        }
+        };
         $scope.hasVolumeGroups = function (vnfInstance) {
             if ($scope.returnVolumeGroups(vnfInstance) != null) {
                 return true;
             }
             return false;
-        }
+        };
         $scope.deleteNetwork = function (serviceObject, network) {
 
             console.log("Removing Network " + network.name);
@@ -871,7 +871,7 @@
 
             //Display popup with additional VF-Module information
             DataService.setVfModuleInstanceId(vfModule[FIELD.ID.VF_MODULE_ID]);
-            DataService.setInventoryItem(vfModule)
+            DataService.setInventoryItem(vfModule);
 
             DataService.setSubscriberName(serviceObject[COMPONENT.SUBSCRIBER_NAME]);
             DataService.setServiceType(serviceObject[COMPONENT.SERVICE_TYPE]);
@@ -1323,7 +1323,7 @@
 
         var deleteCallbackFunction = function () {
             console.log('hi')
-        }
+        };
 
         $scope.resetProgress = function () {
             $scope.percentProgress = 0;
@@ -1364,13 +1364,13 @@
             else {
                 return true;
             }
-        }
+        };
         $scope.isMacro = function () {
             return $scope.service && AsdcService.isMacro($scope.service.model);
-        }
+        };
         $scope.reloadRoute = function () {
             $route.reload();
-        }
+        };
 
 
         /*
@@ -1539,7 +1539,7 @@ Private metthods
                     + FIELD.STATUS.IS_SUCCESSFUL + response.isSuccessful;
                 if (response.isSuccessful) {
                     color = FIELD.ID.COLOR_8F8;
-                    $location.path(COMPONENT.SERVICEMODELS_MODELS_SERVICES_PATH)
+                    $location.path(COMPONENT.SERVICEMODELS_MODELS_SERVICES_PATH);
                 } else {
                     color = FIELD.ID.COLOR_F88;
                 }
-- 
cgit 1.2.3-korg