From a7498b8b59c7872ae3de2237b681500384cbdc9b Mon Sep 17 00:00:00 2001 From: anushadasari Date: Thu, 7 Nov 2019 12:48:23 +0530 Subject: Merge this if statement with the nested one Merging collapsible if statements increases the code's readability. Issue-ID: VID-699 Change-Id: Icb52f1e1fcaec6ebfec3711c32c4cfcca9582af6 Signed-off-by: anushadasari --- .../main/webapp/app/vid/scripts/controller/InstantiationController.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'vid-app-common/src/main/webapp/app/vid/scripts/controller') diff --git a/vid-app-common/src/main/webapp/app/vid/scripts/controller/InstantiationController.js b/vid-app-common/src/main/webapp/app/vid/scripts/controller/InstantiationController.js index 6d8dde844..4b6b0f47a 100755 --- a/vid-app-common/src/main/webapp/app/vid/scripts/controller/InstantiationController.js +++ b/vid-app-common/src/main/webapp/app/vid/scripts/controller/InstantiationController.js @@ -1016,8 +1016,7 @@ var isVfc = false; _.map($scope.service.model.vnfs, function (value, key) { - if (value.uuid == vnf.uuid) { - if (!_.isEmpty(value.vfcInstanceGroups)) { + if (value.uuid == vnf.uuid && !_.isEmpty(value.vfcInstanceGroups)) { isVfc = true; var queryData = { serviceModelId: $scope.service.model.service.uuid, @@ -1033,7 +1032,6 @@ $scope.$broadcast(COMPONENT.IFRAME_DIALOG, queryData); return; } - } }); DataService.setSubscriberName($scope.service.instance.subscriberName); -- cgit 1.2.3-korg