From 8304a47a1fc59d6f6af0c957c96946e5cf099309 Mon Sep 17 00:00:00 2001 From: anushadasari Date: Tue, 20 Aug 2019 14:42:19 +0530 Subject: Move the variable to comply with JCC. According to the Java Code Conventions as defined by Oracle, the members of a class or interface declaration should appear in the following order in the source files: Class and instance variables Constructors Methods Issue-ID: VID-579 Change-Id: Ie87b550a30df06eb2498565b719bd52b11d0c3f9 Signed-off-by: anushadasari --- .../org/onap/vid/job/impl/JobSchedulerInitializer.java | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) (limited to 'vid-app-common/src/main/java') diff --git a/vid-app-common/src/main/java/org/onap/vid/job/impl/JobSchedulerInitializer.java b/vid-app-common/src/main/java/org/onap/vid/job/impl/JobSchedulerInitializer.java index b3ab75b23..b5c2dd74b 100644 --- a/vid-app-common/src/main/java/org/onap/vid/job/impl/JobSchedulerInitializer.java +++ b/vid-app-common/src/main/java/org/onap/vid/job/impl/JobSchedulerInitializer.java @@ -46,6 +46,14 @@ public class JobSchedulerInitializer { private FeatureManager featureManager; private JobCommandFactory jobCommandFactory; private EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(JobSchedulerInitializer.class); + public static final List WORKERS_TOPICS = ImmutableList.of( + Job.JobStatus.PENDING, + Job.JobStatus.CREATING, + Job.JobStatus.IN_PROGRESS, + Job.JobStatus.RESOURCE_IN_PROGRESS, + Job.JobStatus.PENDING_RESOURCE + ); + @Autowired public JobSchedulerInitializer( @@ -61,14 +69,6 @@ public class JobSchedulerInitializer { } - public static final List WORKERS_TOPICS = ImmutableList.of( - Job.JobStatus.PENDING, - Job.JobStatus.CREATING, - Job.JobStatus.IN_PROGRESS, - Job.JobStatus.RESOURCE_IN_PROGRESS, - Job.JobStatus.PENDING_RESOURCE - ); - @PostConstruct public void init() { WORKERS_TOPICS.forEach(topic->scheduleJobWorker(topic, 1)); -- cgit 1.2.3-korg From 6d53372256c01c3f0bf88cb95301322954e2471e Mon Sep 17 00:00:00 2001 From: anushadasari Date: Tue, 20 Aug 2019 15:00:49 +0530 Subject: unused import The imports part of a file should be handled by the Integrated Development Environment (IDE), not manually by the developer. Unused and useless imports should not occur if that is the case. Leaving them in reduces the code's readability, since their presence can be confusing. Issue-ID: VID-580 Change-Id: I3ea680af37477b564d02fcc9b58956b3958d184d Signed-off-by: anushadasari --- .../java/org/onap/vid/services/AsyncInstantiationBusinessLogicImpl.java | 1 - 1 file changed, 1 deletion(-) (limited to 'vid-app-common/src/main/java') diff --git a/vid-app-common/src/main/java/org/onap/vid/services/AsyncInstantiationBusinessLogicImpl.java b/vid-app-common/src/main/java/org/onap/vid/services/AsyncInstantiationBusinessLogicImpl.java index 7818837f1..d7b3ac602 100644 --- a/vid-app-common/src/main/java/org/onap/vid/services/AsyncInstantiationBusinessLogicImpl.java +++ b/vid-app-common/src/main/java/org/onap/vid/services/AsyncInstantiationBusinessLogicImpl.java @@ -39,7 +39,6 @@ import org.apache.commons.lang3.StringUtils; import org.hibernate.SessionFactory; import org.onap.portalsdk.core.logging.logic.EELFLoggerDelegate; import org.onap.vid.aai.AaiClientInterface; -import org.onap.vid.aai.ExceptionWithRequestInfo; import org.onap.vid.aai.model.ResourceType; import org.onap.vid.dal.AsyncInstantiationRepository; import org.onap.vid.exceptions.DbFailureUncheckedException; -- cgit 1.2.3-korg