From 455f47766ce554ed9354d707992353353753745e Mon Sep 17 00:00:00 2001 From: Ittay Stern Date: Sun, 8 Mar 2020 15:24:35 +0200 Subject: Don't use EELFLoggerDelegate.errorLogger in Async jobs The Logger.error(EELFLoggerDelegate.errorLogger, ...) idiom is flawed. Using direct invocation of LOGGER.error("msg..."). Issue-ID: VID-253 Issue-ID: PORTAL-835 Change-Id: Ibbc7da3a081675d2edbbb782732a14de9c865a3a Signed-off-by: Ittay Stern --- .../onap/vid/job/impl/JobSchedulerInitializer.java | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) (limited to 'vid-app-common/src/main/java/org/onap/vid/job/impl/JobSchedulerInitializer.java') diff --git a/vid-app-common/src/main/java/org/onap/vid/job/impl/JobSchedulerInitializer.java b/vid-app-common/src/main/java/org/onap/vid/job/impl/JobSchedulerInitializer.java index b5c2dd74b..bd82ffa7a 100644 --- a/vid-app-common/src/main/java/org/onap/vid/job/impl/JobSchedulerInitializer.java +++ b/vid-app-common/src/main/java/org/onap/vid/job/impl/JobSchedulerInitializer.java @@ -20,24 +20,29 @@ package org.onap.vid.job.impl; +import static org.quartz.SimpleScheduleBuilder.simpleSchedule; + import com.google.common.collect.ImmutableList; import com.google.common.collect.ImmutableMap; +import java.util.List; +import javax.annotation.PostConstruct; import org.onap.portalsdk.core.logging.logic.EELFLoggerDelegate; import org.onap.vid.exceptions.GenericUncheckedException; import org.onap.vid.job.Job; import org.onap.vid.job.JobsBrokerService; import org.onap.vid.job.command.JobCommandFactory; -import org.quartz.*; +import org.quartz.JobBuilder; +import org.quartz.JobDataMap; +import org.quartz.JobDetail; +import org.quartz.Scheduler; +import org.quartz.SchedulerException; +import org.quartz.Trigger; +import org.quartz.TriggerBuilder; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.scheduling.quartz.SchedulerFactoryBean; import org.springframework.stereotype.Component; import org.togglz.core.manager.FeatureManager; -import javax.annotation.PostConstruct; -import java.util.List; - -import static org.quartz.SimpleScheduleBuilder.simpleSchedule; - @Component public class JobSchedulerInitializer { @@ -94,7 +99,7 @@ public class JobSchedulerInitializer { try { scheduler.scheduleJob(jobDetail, asyncWorkerTrigger); } catch (SchedulerException e) { - logger.error(EELFLoggerDelegate.errorLogger, "Failed to schedule trigger for async worker jobs: {}", e.getMessage()); + logger.error("Failed to schedule trigger for async worker jobs: {}", e.getMessage()); throw new GenericUncheckedException(e); } } -- cgit 1.2.3-korg