From 862abccfdf8097e147ca743471066c4c236194b9 Mon Sep 17 00:00:00 2001 From: anushadasari Date: Tue, 1 Oct 2019 13:03:51 +0530 Subject: Replace "==" with "===". The == and != operators do type coercion before comparing values. This is bad because it can mask type errors. For example, it evaluates ' \t\r\n' == 0 as true. It is best to always use the side-effect-less === and !== operators instead. Issue-ID: VID-656 Change-Id: If93fe032fae618bb0bd7112c24a0e4d3acab6337 Signed-off-by: anushadasari --- .../main/webapp/app/vid/scripts/controller/InstantiationController.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vid-app-common/src/main/webapp/app/vid/scripts/controller/InstantiationController.js b/vid-app-common/src/main/webapp/app/vid/scripts/controller/InstantiationController.js index b3afcd864..6d8dde844 100755 --- a/vid-app-common/src/main/webapp/app/vid/scripts/controller/InstantiationController.js +++ b/vid-app-common/src/main/webapp/app/vid/scripts/controller/InstantiationController.js @@ -35,7 +35,7 @@ $scope.properties = UtilityService.getProperties(); $scope.resumeStatus = COMPONENT.RESUME_STATUS; //isPermitted - returned as string from url and converted into boolean - $scope.isPermitted = $location.search().isPermitted == "true"; + $scope.isPermitted = $location.search().isPermitted === "true"; $scope.STATUS_CONSTANTS = FIELD.STATUS; $scope.pnfs = [];// PNF data init; $scope.collectionResource = {}; -- cgit 1.2.3-korg From 4c8c2ac1d29e19d1cb935749af0d1c0063d5c0fd Mon Sep 17 00:00:00 2001 From: anushadasari Date: Thu, 26 Sep 2019 21:52:36 +0530 Subject: Add the "@Override" annotation. Using the @Override annotation is useful for two reasons : It elicits a warning from the compiler if the annotated method doesn't actually override anything, as in the case of a misspelling. It improves the readability of the source code by making it obvious that methods are overridden. Issue-ID: VID-612 Change-Id: I90f07b6da5934fcba0c6d4106a75684438d8bb4b Signed-off-by: anushadasari --- vid-app-common/src/main/java/org/onap/vid/model/VNFDao.java | 1 + 1 file changed, 1 insertion(+) diff --git a/vid-app-common/src/main/java/org/onap/vid/model/VNFDao.java b/vid-app-common/src/main/java/org/onap/vid/model/VNFDao.java index 8370f91e1..cb7a0fcc6 100644 --- a/vid-app-common/src/main/java/org/onap/vid/model/VNFDao.java +++ b/vid-app-common/src/main/java/org/onap/vid/model/VNFDao.java @@ -41,6 +41,7 @@ public class VNFDao extends DomainVo { @GeneratedValue(strategy = GenerationType.IDENTITY) @Column(name = "VNF_DB_ID") @JsonIgnore + @Override public Long getId() { return id; } -- cgit 1.2.3-korg