From 52adc0d940fef0dd96d5ca29dcf3430d8f1b2ee5 Mon Sep 17 00:00:00 2001 From: ThamlurRaju Date: Thu, 23 Aug 2018 16:51:21 +0530 Subject: Improve coverage of Svnfm RestfulConfigure 13 breaches need to cover to reach 65% Coverage Sonar Link: https://sonar.onap.org/project/issues?assignees=ThamlurRaju&id=org.onap.vfc.nfvo.driver.vnfm.svnfm.huawei%3Avfc-nfvo-driver-vnfm-svnfm-huawei&open=AV8WGS-K-08if2a6pID2&resolved=false&severities=MAJOR Location: src/main/java/org/onap/vfc/nfvo/vnfm/svnfm/vnfmadapter/common/restclient/RestfulConfigure.java Change-Id: Id2198807497133b13684bfed8c78a75c3e846885 Issue-ID: VFC-1062 Signed-off-by: ThamlurRaju --- .../common/restclient/RestfulConfigureTest.java | 93 ++++++++++++++++++++++ .../service/src/test/resources/Check2.txt | 12 +++ .../service/src/test/resources/Check3.txt | 12 +++ .../service/src/test/resources/Check4.txt | 12 +++ .../service/src/test/resources/Check5.txt | 0 .../service/src/test/resources/Check7.txt | 12 +++ 6 files changed, 141 insertions(+) create mode 100644 huawei/vnfmadapter/VnfmadapterService/service/src/test/java/org/onap/vfc/nfvo/vnfm/svnfm/vnfmadapter/common/restclient/RestfulConfigureTest.java create mode 100644 huawei/vnfmadapter/VnfmadapterService/service/src/test/resources/Check2.txt create mode 100644 huawei/vnfmadapter/VnfmadapterService/service/src/test/resources/Check3.txt create mode 100644 huawei/vnfmadapter/VnfmadapterService/service/src/test/resources/Check4.txt create mode 100644 huawei/vnfmadapter/VnfmadapterService/service/src/test/resources/Check5.txt create mode 100644 huawei/vnfmadapter/VnfmadapterService/service/src/test/resources/Check7.txt diff --git a/huawei/vnfmadapter/VnfmadapterService/service/src/test/java/org/onap/vfc/nfvo/vnfm/svnfm/vnfmadapter/common/restclient/RestfulConfigureTest.java b/huawei/vnfmadapter/VnfmadapterService/service/src/test/java/org/onap/vfc/nfvo/vnfm/svnfm/vnfmadapter/common/restclient/RestfulConfigureTest.java new file mode 100644 index 00000000..9a40cda3 --- /dev/null +++ b/huawei/vnfmadapter/VnfmadapterService/service/src/test/java/org/onap/vfc/nfvo/vnfm/svnfm/vnfmadapter/common/restclient/RestfulConfigureTest.java @@ -0,0 +1,93 @@ +/* + * Copyright 2016 Huawei Technologies Co., Ltd. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + + +package org.onap.vfc.nfvo.vnfm.svnfm.vnfmadapter.common.restclient; + +import static org.junit.Assert.*; + +import java.io.IOException; + +import org.junit.Test; + +import net.sf.json.JSONException; + +public class RestfulConfigureTest { + + @Test + public void testRestfulConfigure() { + RestfulConfigure rc = new RestfulConfigure(); + rc.toString(); + } + + @Test + public void testRestfulConfigureStringNoFilePath() { + RestfulConfigure rc = new RestfulConfigure(""); + RestfulOptions rp = rc.getOptions(); + assertTrue(true); + } + + @Test + public void testRestfulConfigureStringNoFileExist() { + RestfulConfigure rc = new RestfulConfigure("C:/Users/Public/Desktop"); + RestfulOptions rp = rc.getOptions(); + assertTrue(true); + } + + @Test + public void testRestfulConfigureString() { + RestfulConfigure rc = new RestfulConfigure("src/test/resources/Check7.txt"); + RestfulOptions rp = rc.getOptions(); + assertTrue(true); + } + + @Test + public void testRestfulConfigureStringNoFile() { + RestfulConfigure rc = new RestfulConfigure("src/test/resources/Check1.txt"); + RestfulOptions rp = rc.getOptions(); + assertTrue(true); + } + + @Test + public void testRestfulConfigureStringWrongFile() { + RestfulConfigure rc = new RestfulConfigure("src/test/resources/Check2.txt"); + RestfulOptions rp = rc.getOptions(); + assertTrue(true); + } + + @Test + public void testRestfulConfigureStringEmptyFile() { + RestfulConfigure rc = new RestfulConfigure("src/test/resources/Check3.txt"); + RestfulOptions rp = rc.getOptions(); + assertTrue(true); + } + @Test + public void testRestfulConfigureStringNoHostFile() { + RestfulConfigure rc = new RestfulConfigure("src/test/resources/Check4.txt"); + RestfulOptions rp = rc.getOptions(); + assertTrue(true); + } + @Test(expected=JSONException.class) + public void testRestfulConfigureStringZeroFile() throws IOException { + RestfulConfigure rc = new RestfulConfigure("src/test/resources/Check5.txt"); + rc.getOptions(); + } + /*@Test + public void testRestfulConfigureStringClose() { + RestfulConfigure rc = new RestfulConfigure("src/test/resources/Check6.txt"); + rc.getOptions(); + }*/ +} diff --git a/huawei/vnfmadapter/VnfmadapterService/service/src/test/resources/Check2.txt b/huawei/vnfmadapter/VnfmadapterService/service/src/test/resources/Check2.txt new file mode 100644 index 00000000..926dc205 --- /dev/null +++ b/huawei/vnfmadapter/VnfmadapterService/service/src/test/resources/Check2.txt @@ -0,0 +1,12 @@ +{ + "defaultServer": + { + "host":"", + "port":"80" + }, +"ConnectTimeout":"300000", +"thread":"10", +"idletimeout":"500000", +"timeout":"300000" +} + \ No newline at end of file diff --git a/huawei/vnfmadapter/VnfmadapterService/service/src/test/resources/Check3.txt b/huawei/vnfmadapter/VnfmadapterService/service/src/test/resources/Check3.txt new file mode 100644 index 00000000..08e37413 --- /dev/null +++ b/huawei/vnfmadapter/VnfmadapterService/service/src/test/resources/Check3.txt @@ -0,0 +1,12 @@ +{ + "": + { + "host":"", + "port":"" + }, +"":"", +"":"", +"":"", +"":"" +} + \ No newline at end of file diff --git a/huawei/vnfmadapter/VnfmadapterService/service/src/test/resources/Check4.txt b/huawei/vnfmadapter/VnfmadapterService/service/src/test/resources/Check4.txt new file mode 100644 index 00000000..7ccbf2b7 --- /dev/null +++ b/huawei/vnfmadapter/VnfmadapterService/service/src/test/resources/Check4.txt @@ -0,0 +1,12 @@ +{ + "defaultServer": + { + "":"127.0.0.1", + "port":"80" + }, +"ConnectTimeout":"300000", +"thread":"10", +"idletimeout":"500000", +"timeout":"300000" +} + \ No newline at end of file diff --git a/huawei/vnfmadapter/VnfmadapterService/service/src/test/resources/Check5.txt b/huawei/vnfmadapter/VnfmadapterService/service/src/test/resources/Check5.txt new file mode 100644 index 00000000..e69de29b diff --git a/huawei/vnfmadapter/VnfmadapterService/service/src/test/resources/Check7.txt b/huawei/vnfmadapter/VnfmadapterService/service/src/test/resources/Check7.txt new file mode 100644 index 00000000..47c4e08c --- /dev/null +++ b/huawei/vnfmadapter/VnfmadapterService/service/src/test/resources/Check7.txt @@ -0,0 +1,12 @@ +{ + "defaultServer": + { + "host":"127.0.0.1", + "port":"80" + }, +"ConnectTimeout":"300000", +"thread":"10", +"idletimeout":"500000", +"timeout":"300000" +} + \ No newline at end of file -- cgit 1.2.3-korg